From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70DF4C5320E for ; Mon, 19 Aug 2024 13:02:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D73CB6B0089; Mon, 19 Aug 2024 09:02:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D22FF6B008C; Mon, 19 Aug 2024 09:02:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9CC16B0092; Mon, 19 Aug 2024 09:02:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9F87A6B0089 for ; Mon, 19 Aug 2024 09:02:23 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 37D801A12AD for ; Mon, 19 Aug 2024 13:02:23 +0000 (UTC) X-FDA: 82469008566.03.249F49A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id B1E2B40003 for ; Mon, 19 Aug 2024 13:02:20 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dmGoipI8; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724072479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L354KTrWlkNo1VjLcWMmjkcbCq1FC6RNhOfHs0/qCLE=; b=zKNNPxO9PRxU6Lc132WeQwfSICAuTa7SJ0BKslhOw5rAMCdLm6urQfi3I39r9LP0M/jMfH IXrtF7bb8RFHe/ImgJ0FxHtVTVZonx8ENUOvuBYD5B5ZO4n5Y+7UGuDvlwaa/wNfJrbe6c f1eng72bj7I/Eso3ptsu1taszM1jm+I= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dmGoipI8; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724072479; a=rsa-sha256; cv=none; b=BGPtzpJu+lDVgDjvu+0xu21pJhUMnjGMv+DIuA0F5wqryirpxMerlOmsxONHnCLolqcZ/E WgLXfwsj8NsXmZKEPTn/jkQtGvJIdo1J1H2Ti5cbZlLkdJeKICAmxHHCi5vP32DVBpqXwS LzzWxaZTW8b0sS6kKTu9/vMprsjiz98= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724072540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L354KTrWlkNo1VjLcWMmjkcbCq1FC6RNhOfHs0/qCLE=; b=dmGoipI85BJNlqR+CYpnlkFnfdNk4cS8Dh1EHNHRzEf1gXBmoH0zuvKAd2U74ovzVpUfFB Dax1rXG+Tfu2Bv4O44MgrFlH0vdOJWsV2UFhsgfJNdk86Ih84swSst2ls6vT+dqEyZUyCH 54UIoapK+9sQRGHJLELnUxqe4GBUVK0= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-HfZ-WebaNBqkpO2txSoEsg-1; Mon, 19 Aug 2024 09:02:14 -0400 X-MC-Unique: HfZ-WebaNBqkpO2txSoEsg-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a7aa020cef5so264768466b.0 for ; Mon, 19 Aug 2024 06:02:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724072533; x=1724677333; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L354KTrWlkNo1VjLcWMmjkcbCq1FC6RNhOfHs0/qCLE=; b=S1dICugCIiPtswKGn98FQHuVOJiHXOvuqcKir7TaKjkQzl26L8Pw1k/jOMoS+F3Wbj WVR+TmWZGxKbQrDf2y6ukwyJVndZE27t+SlWRNrZXmeUQ6ZVPysWeLQspiZPXMa0ugV0 4cYueYOfat4AjMc/6ZgCh6yH86Cmscap1Pu0HehJQpvUtSoNbMS9IX7m98eqI8Mro8g0 C9F76VzeO8l5EaA7b1XZTUMccV3QTSOD40uGc7CneuIWgznS4oiDHVyiEVuqJktLe5Ma PCS6tBzB5fa7qbuihAcC5ke80J74AXfdG6ollOnWxwmEHY0xD6sFbYaKPtf2UVVyzLsG vpPg== X-Forwarded-Encrypted: i=1; AJvYcCUE9QBf6NY7vz2jn0RpEUYhR4EoXBOslxNQby4wHuT5Ri+3T8TiKXPmo7IdLkT5r1Ms1Taxzv8jAgoOQSRpzZ/i8RY= X-Gm-Message-State: AOJu0YxT5lOaJR74lbOBBOf6YBvxmsy5XjnSLgCxOQq9kR7f2KAHKoZ4 dedHDoLAVO6SL/SnnQjVP2ECW2tfq/sFpCa3Cn6uKRZZpf1IYUVJwBPShcEpqAxZLNxkE5P9XUT bPtyLqIyTPEBozEnFJxhuNFgUEHn/YK7mUU5TqcrZpYiK3YYn X-Received: by 2002:a17:907:efc8:b0:a77:b054:ba7d with SMTP id a640c23a62f3a-a8392a16e10mr708418466b.46.1724072532887; Mon, 19 Aug 2024 06:02:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHFsI/qcbeC1kjFjNC+nNC2bP7hj4GMAq8MQVyUzyGIecz8LTuHFghb/ciBsBvB7Wxq1q6tAQ== X-Received: by 2002:a17:907:efc8:b0:a77:b054:ba7d with SMTP id a640c23a62f3a-a8392a16e10mr708414066b.46.1724072532329; Mon, 19 Aug 2024 06:02:12 -0700 (PDT) Received: from [100.81.188.195] (ipb218f908.dynamic.kabel-deutschland.de. [178.24.249.8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a838394669esm641589566b.143.2024.08.19.06.02.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 06:02:11 -0700 (PDT) Message-ID: <7050deab-e99c-4c83-b7b9-b5dad42f4e95@redhat.com> Date: Mon, 19 Aug 2024 15:02:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] mm: clarify nofail memory allocation To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: 42.hyeyoo@gmail.com, cl@linux.com, hailong.liu@oppo.com, hch@infradead.org, iamjoonsoo.kim@lge.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, torvalds@linux-foundation.org, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev References: <20240817062449.21164-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240817062449.21164-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 19yd9nijzgxwiote8qfzgisykj1xd7f8 X-Rspam-User: X-Rspamd-Queue-Id: B1E2B40003 X-Rspamd-Server: rspam02 X-HE-Tag: 1724072540-645927 X-HE-Meta: U2FsdGVkX18XY3WJqC3i4pvRgHV90abYmuXkNZHJ27hGcZToUSO1if/k3BfbxTZCxuFfFz1fCIN/5CPGk6xfTLTOdE4lNgcJUP45BG6RiZ9QoOxag4ZpjcIiMJaCZhefEdewF5k0bT40X5U4NyPYIzwbqMk1dmbkTMyy6Q8q4M7LSWHL/NOh/LAqq596VXkH7rEqxHPaJrSdi6hCqER4Xo0YsYzAWeffkyVJ3PxQcy57zl9/8yM3aLdjoROUGIbMdACvNcxfyfYjmUutqdxs3XuaUsOQnHEqxW/NqolJj2+aql6GAcQr2jLnQ2P+D31nlbtV7elopc1BpTTiR3Ocldzx8m2IWP8MSL5lMMusoe7LaJe6fiUpPMkTBYNYU35/6X9WWDFdnKucE06sza0BACoC4lH+MGTOgbGCsvJSVDv6S/WVo1r2nFzkChxeQk5RkSecFJJeu/UiiPWkeUsUaeU2SXQmSEbCCZxyf4TRPpAaXz+3hAD3KLovovfSBNl6/DgjOVPbiFA39LAMy8JE2mFuoqrZFg5O9QkUIksrQY7GISQFrnJVcNCNFcnX1z6bn3cSNBt4Iz+I9ALUe9C05Yq8S3f9b0AIPQjnIFMfO50udv/AqUQPAfNc65DA17B3q7BjktkrpDHiZbNrkHdsNstOHaXTL2XULtzVvdHOJjjYIBqRzZR6VHtmDyR2iJq63yI/6rEW9vJqjBPOG02RWJGfZK+m7tbTvMchltsMB5o3+vq2BBQQErRAh8Mm7t2Yl59rKH29mOeBa8cm4tVxGjZlfrFUQmahpQZONdZ8hh/6fCrR6yb7RKE0rijGGXgHiH4zN7avKGbVKLulrBnXtXWlzFowkd1bedoHKkzKGHoM6JV0e8XjafmmtQTOl+kZ9PFVNJlVRlP0oIljVE/r0Jpq2wmIF8PmuWy2piExdT7wXQGwMGwFmYDbOAOCQdwMP+LWKQtekcPA2T4UVdq 1SAZeZ1g JbEYGCxVkE1ROtXhNxBEuPyPipsfwj9lWXVOaf4gXGoBBfeAoNxn4WpPnV6M0kYG1msEMVSvH3xrFqezFO8T3By4LF0P7IMyFYVdpaFdwEbXPH108y0XLuqt65/zU6D2gMcdPFtdeWLZlq+HuuMSulZGPdgNOU6b0KLenGxfdJpB7s+kb82XWFqcIiUhFKnaszNMb5x9c6UkVXaewnak8HG8CFmEpVxLkJlZiOfBtdmXQ31lHXMqDAOi1oGG8QA/rpl5jltW1tWC/c5d5yh7zsty+J/GPR5xp9crn5gtwmfdUxKViLrYKCF63jSatGjtz8GknpC/gmEKxvUICULwXaV6iRmLRI7VFQzJ4yIhc6cp7cS+IR2U2wr+BSsEtv+7aMFip7xgVG1HCa4zZfjtBN4e85/lKGH/Ahmk7nOrFJzx8Eu8E97J18VkzLn0GU/CLGSM3/B366Z+sdsYMD120d7U4n5koVJPvd1/7VPntAxabkAinK5w4XlEh4qE5Q2VEJi8yauYNqATftZ7VOz6Pe4B3Jpsh11qo4IfkkZJtBGB5beO3+1QMG1iSymkZ1eLNa9YfilV4fIXmNXx64Q8U+vANay3pf3ZaYcFWgKdMo0gfFNx5c8PoZ89yYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.08.24 08:24, Barry Song wrote: > From: Barry Song > > -v3: > * collect reviewed-by, acked-by etc. Michal, Christoph, Vlastimil, Davidlohr, > thanks! > * use Jason's patch[1] to fix vdpa and refine his changelog. > * refine changelogs > [1] https://lore.kernel.org/all/20240808054320.10017-1-jasowang@redhat.com/ > > -v2: > https://lore.kernel.org/linux-mm/20240731000155.109583-1-21cnbao@gmail.com/ > > * adjust vpda fix according to Jason and Michal's feedback, I would > expect Jason to test it, thanks! > * split BUG_ON of unavoidable failure and the case GFP_ATOMIC | > __GFP_NOFAIL into two patches according to Vlastimil and Michal. > * collect Michal's acked-by for patch 2 - the doc; > * remove the new GFP_NOFAIL from this series, that one would be a > separate enhancement patchset later on. > > -v1: > https://lore.kernel.org/linux-mm/20240724085544.299090-1-21cnbao@gmail.com/ > > __GFP_NOFAIL carries the semantics of never failing, so its callers > do not check the return value: > %__GFP_NOFAIL: The VM implementation _must_ retry infinitely: the caller > cannot handle allocation failures. The allocation could block > indefinitely but will never return with failure. Testing for > failure is pointless. > You should have called this series "mm: clarify nofail and BUG_ON on with invalid arguments with nofail" I was a bit surprised to find that many BUG_ON in this series ;) > However, __GFP_NOFAIL can sometimes fail if it exceeds size limits > or is used with GFP_ATOMIC/GFP_NOWAIT in a non-sleepable context. > This can expose security vulnerabilities due to potential NULL > dereferences. Which code is that that we are concerned about? Some OOT driver? Some untested in-tree driver? Just trying to understand what we are afraid about here. I'm afraid we cannot safe the world with some OOT drivers :( Are we aware of such security vulnerabilities (out of pure interest!)? Is the expectation that these code paths are never triggered during early testing where a WARN_ON_ONCE() would just highlight -- in addition to a likely crash -- that something is very wrong? > > Since __GFP_NOFAIL does not support non-blocking allocation, we introduce > GFP_NOFAIL with inclusive blocking semantics and encourage using GFP_NOFAIL > as a replacement for __GFP_NOFAIL in non-mm. I still wonder if specifying GFP_NOFAIL should not simply come with the semantics "implies direct reclaim. If called for non-blocking allocations, bad things will happen (no security bad things though)." ;) > > If we must still fail a nofail allocation, we should trigger a BUG rather > than exposing NULL dereferences to callers who do not check the return > value. I am not convinced that BUG_ON is the right tool here to save the world, but I see how we arrived here. -- Cheers, David / dhildenb