From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC32C83F1B for ; Thu, 17 Jul 2025 08:39:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24A6A8D0009; Thu, 17 Jul 2025 04:39:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2218E8D0001; Thu, 17 Jul 2025 04:39:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 110708D0009; Thu, 17 Jul 2025 04:39:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0173D8D0001 for ; Thu, 17 Jul 2025 04:39:45 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BB983BA9C0 for ; Thu, 17 Jul 2025 08:39:45 +0000 (UTC) X-FDA: 83673108330.12.510873B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 5D984C0002 for ; Thu, 17 Jul 2025 08:39:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="LdGwb/2R"; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752741583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lj6lTZwQRiYuMovgfeEEcoQjPhNrRremaT5OpC4sqYE=; b=5ROPLK5k82os2YrZM68ZPLGLbbY6s8foo8wmU2otpkIOEjOGmu6Jgb9y+z88plnSoFDMJB qQzA/woMvy8D//bdm4ajm0uMkAh9c4AWJTVDOntFQPRjx8HVdrSoZ/UXrngov3qCf/W/+A z7rzdYAF529OxOxmlg0t+iTf1Ao+K4s= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="LdGwb/2R"; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752741583; a=rsa-sha256; cv=none; b=FLWFbpV/CYPeMT3FUu+CFAeDmrzHjsaHS2Q0H4RC04N4lz3t5K86d+oPwwUvJImakBMEvn D+URNq/Pi6Gy/W3FBAv2PGH0GBsUhMjDzuevAcKtf5zZV4v0WWaLKXTH2RwOfxvZuUaqmY o2jhbGqdxg2z0occTajoAl2qTdfRCyM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752741582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Lj6lTZwQRiYuMovgfeEEcoQjPhNrRremaT5OpC4sqYE=; b=LdGwb/2RqiVWmCCeYjT4pypagODUdaWd9rZiv9Hoq5ph7o/ewaETgQK9TBdERJUnBACWHU I1+YsxMH9UCZ869zJTtU3tummRyqbBHv070BrneG3oNaeu5qH43t4z67mQ22cP5AMTHng/ wx90fOWGYZHGSrmIXo2tevyOOgwBJmU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-XAfaQrneMq2aZpjYL6hhbA-1; Thu, 17 Jul 2025 04:39:41 -0400 X-MC-Unique: XAfaQrneMq2aZpjYL6hhbA-1 X-Mimecast-MFC-AGG-ID: XAfaQrneMq2aZpjYL6hhbA_1752741580 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45626532e27so4363625e9.1 for ; Thu, 17 Jul 2025 01:39:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752741580; x=1753346380; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Lj6lTZwQRiYuMovgfeEEcoQjPhNrRremaT5OpC4sqYE=; b=AGxxC80s3oM4+RGpWdFYRXe4eniE9ZcQNkT+D/6qIhGsN3Qfyh8kbl7wjM6AYc81b8 92r8g5kdckqCU4uiNbSS73obwOOLgEFDEFjIjYoSeAY8fkvVNAswBnfUYc/c38X83oX3 jbT9NkFthS4R2JMkR2D3fUtQDoC/FhRaTKnIUL1ANG4ypla6ajgYRM6HHnzylQK5bUhc LDgujKkar5gaOQWyI/6BCbZ0H5FNEIHI3Kx+h9J2ES2uqdAwVYEydoUrCgr5arOHsH0O OBl0JzvbTt281hlOmqFLqnvdANeiKsPVr6R9ud4UlXdJiwNV9130F+ABMuKIFFd91mL7 meFA== X-Forwarded-Encrypted: i=1; AJvYcCWf4vWV86j7Q+aMpOE1OHzYb1nw8ZP7fBBy0eg6uaEUOlzb1hiOPBIKGMYO7OXbhsxTEgYqwi/E8A==@kvack.org X-Gm-Message-State: AOJu0Yzsqn3eD/EalP+JtTMl4+cSHJKwExpmsZk6tvj20zzVpfB4ohqH 7cpPteVizT9MXmtEAxDvVNXv5YS3V2ZL+9MHF5blulPCiHG6ih1ecmFrn4672CsZS75r4JFlCHc HeHcja8gHnqu8+IL1WvBWQeN5nx0Kvkz8QFBPpXnesSo+HdVJ6yPB X-Gm-Gg: ASbGncsfPIgr+K6zsPWg3Vwz8O/jjOTRuFDqexj7xSWs70PrOvcc5NlRbeWvVKAJf55 RLXrC+DpTZ1ACYZQVr4s+857F8qUkSaJ0o31qg1LGKWlmCJTb1VmsIc8R3xFfoxSM/a2C+Tu/EX ExUYdOS8gq4dE4JWHQfVe4shRJ5VEO0ek4XeWA6DBuAb4Of7BuICYQcna05mTdxh4PKHHTQ3hkI Z2s/sz068YORj4H7dmX+K/DSIPLd+nmZ9tK+ymKXk9x8Xv+TCl1SC5SlWwvT/bfPsAhuKikGMry 7QDSiF1+ZrdrWBjLEifpm6IjErsQDaYdbcGVVpIaP8S9MlX7NPJHhX4Xk1zBNCe+QKhVJif5wN6 jEQGCTn1az/Vp/khU3/6v5jc5bMrxEtOCUXJYqhLH4hAhL/C013wsnF5edo0M0Qp8 X-Received: by 2002:a05:600c:a08c:b0:44b:eb56:1d48 with SMTP id 5b1f17b1804b1-4562e0320ddmr54640075e9.4.1752741579812; Thu, 17 Jul 2025 01:39:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7/rwYshbHQ4mXCqXe0VfAWZwFMFiHguIbQQ20+5zBL9J/LJ0Z7d+RZpnAtH09KGdgkC3Klg== X-Received: by 2002:a05:600c:a08c:b0:44b:eb56:1d48 with SMTP id 5b1f17b1804b1-4562e0320ddmr54639715e9.4.1752741579349; Thu, 17 Jul 2025 01:39:39 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7? (p200300d82f1f36000dc826ee9aa9fdc7.dip0.t-ipconnect.de. [2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e89c313sm44617495e9.28.2025.07.17.01.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 01:39:38 -0700 (PDT) Message-ID: <705fa84f-7a4a-4f74-82bf-5dff51149d94@redhat.com> Date: Thu, 17 Jul 2025 10:39:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/9] fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio To: Alistair Popple Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Oscar Salvador , Lance Yang References: <20250715132350.2448901-1-david@redhat.com> <20250715132350.2448901-5-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oEqUThZlDe41Ax3u0wRJw9s5NzfdPiljpf8zeZt0J3E_1752741580 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 5D984C0002 X-Rspamd-Server: rspam06 X-Stat-Signature: y1iishmuweuowkt54qqzi4w1s6n3wwtm X-HE-Tag: 1752741583-973563 X-HE-Meta: U2FsdGVkX19RX/TWQ71tvHf5sIGOHQjBF6TyLMA/7HJrzwJp/0TU5IVXEFOnrPmwjVYtmh974F4PSYedwHYV0XMQN2UVymvvHFcAvLoz9yuHcmfb0rp9sVZkutezweHVmXlQk3u2QcU002wm+C9lcwjOgNNM+bj9dQxvsLeJ02eoI4lwD+llR9wKUPtr1jgdm1m6YDYZdn9ZvB1iQ234pmGYAYOiVKdptjdfl8bbwFSwOgGVzHFxzUe7tclSbss2CKrrAeON/XtYFjQAwv27IJqa5OqWJmSe0hqyLFTWIAkG8LWPMrEzjCTRtMremftyM55FjeX1OpBxUe3NDy2zJMrIQ4rYUj6LmdFxly/5vcQu32T758l1HJtTdDiYBENvBWfeCmndtXEc57haqvpGfYKmB3bcHD5rv2GImW9VkQcqdMd6Ogsx6x3kf7M7Ed/Lj4XwDCoMLosaXh+n8P0PCNur/jPiuJthRY2reMDoLDCF5yKT92mrcEQsOr5MajAp6roUQeWLq4BUYsKkes/8/vlJz/t+vDL4EVL2EUV++oabRMcBnkj8PQkrehIshxZmbdkYw787rPIzi5Ltu/md/tIqyBe8eFVcJ4ggjJg+2goy5cl9FxlUNsgpaxOtzHJcNihgMR1MbowtB6YT7ks74WHCfv2B4pgTmKsAbgSM3xbqb/fApdJg4FKERR6E/+vgzVnR+q3e1FsxnjdIKJyMAMaIZUTPxLSQ4EK1Hb/na5LCJioDT7umA4InRExJ57uJYs27rlRuuWBe1JeTvGo9T3pBmkYoRHW7RjWKjh+5w4vcrjGaMuRB48HwzSif2kqRWoAzlBwCTtFS9Z1Fom5SrkeT21SD1DByAYCkNjDXbvAqPSy1Efh07AREQatBP3wvunhVbnYGMw3BjMoN6JAQVXbQvhEt62mNiyfa6UFLH4YmJkxrya1lfpUf6srENmlS02ikuUwyQrtmtOApCU2 41+MENyn F2mbQ7GQPpVBIq/5KOdxRzy6jmWVCRIyqzTZW/Tm3s3/PjvOQPMHWwnM29trzgG+XE+fUvOTOVJXxFbhM7Xd7cqwqU1XV8h9YfvwjewXLTyROm13ep5XcjGIiU9KGL+vkCy9X0t7v4UzWMSlGjfUeG0Ml7eYQXM0kK//ny5ML4XaF3Kl0uwZF4PnOI+6BOkQXdpTQj5y4a79LHS63oouiyEg7vJsFemORjAgjxw2VxztZQUQ+xPuub8Q1JwlMyEVDloIB9ZzG7RWS/mie33lcfkjMbZskz1ZTkSbRWhkHH3BnEhlt5qV9B/KLMlz97cl+Xp6WElyCkPXSIBzBA1/doaf4s7ki247WCtPn9rDxyfVMHcT+uECmMhGfxnJ+O1U312GWkRzPhxkkzDJeMNyRbBVmSPsMr3tNq5VwpX88Kn+EVEdXlpQy6dl+jhDs4wCW+uar5uDBte80kLx9mDCdZrksSGTmDEdV0LSozUojBeCdWI/JfiQ8trKaWQPqk9eoAKJ4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.07.25 10:38, Alistair Popple wrote: > On Tue, Jul 15, 2025 at 03:23:45PM +0200, David Hildenbrand wrote: >> Let's convert to vmf_insert_folio_pmd(). >> >> There is a theoretical change in behavior: in the unlikely case there is >> already something mapped, we'll now still call trace_dax_pmd_load_hole() >> and return VM_FAULT_NOPAGE. >> >> Previously, we would have returned VM_FAULT_FALLBACK, and the caller >> would have zapped the PMD to try a PTE fault. >> >> However, that behavior was different to other PTE+PMD faults, when there >> would already be something mapped, and it's not even clear if it could >> be triggered. >> >> Assuming the huge zero folio is already mapped, all good, no need to >> fallback to PTEs. >> >> Assuming there is already a leaf page table ... the behavior would be >> just like when trying to insert a PMD mapping a folio through >> dax_fault_iter()->vmf_insert_folio_pmd(). >> >> Assuming there is already something else mapped as PMD? It sounds like >> a BUG, and the behavior would be just like when trying to insert a PMD >> mapping a folio through dax_fault_iter()->vmf_insert_folio_pmd(). >> >> So, it sounds reasonable to not handle huge zero folios differently >> to inserting PMDs mapping folios when there already is something mapped. > > Yeah, this all sounds reasonable and I was never able to hit this path with the > RFC version of this series anyway. So I suspect it really is impossible to hit > and therefore any change is theoretical. Thanks for the review and test, Alistair! -- Cheers, David / dhildenb