From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB21EC0015E for ; Wed, 19 Jul 2023 16:55:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB145280075; Wed, 19 Jul 2023 12:55:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D625428004C; Wed, 19 Jul 2023 12:55:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C02BF280075; Wed, 19 Jul 2023 12:55:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AE74228004C for ; Wed, 19 Jul 2023 12:55:37 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3A7D7120322 for ; Wed, 19 Jul 2023 16:55:37 +0000 (UTC) X-FDA: 81028962714.01.A4192E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 8876D40008 for ; Wed, 19 Jul 2023 16:55:33 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GywAJTHH; spf=pass (imf01.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689785735; a=rsa-sha256; cv=none; b=jhT0TqmCLN1fCsZ7LLtxjHPvkQGzTbzQxUcrB1Gt/VDCwgTT+XsZZf2jxW2R0ooGxVsl9+ qlEG22/zW1eP1oscCdnHWG4xy+eGrb+X5gU2mUJ0RUL41HjZiZyn3kRn29U9VMuxgoQncp 0wU6+WlsfRFRhd7JVeqhg2qjT8mzj48= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GywAJTHH; spf=pass (imf01.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689785735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ybZMnwXlmIEE0ADI9FsKUlcEynrHTdW2zV41y3cU4q8=; b=sk8z5DCwk92iacXFpALLNn4+In1Bzumyr1kXePlNKBzeaXz0/w9Y5TmCIZ7Hk+S4JJO8+E +1Nn/SvO96hUVvkcjl333WkpWxKgigPFq1V2yho1ZlId8r3HLfuzHXXsuxwcT1Vh22crw9 JG6Z0kajg2p29Z2XYYycT7/TSoLpA9g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689785732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ybZMnwXlmIEE0ADI9FsKUlcEynrHTdW2zV41y3cU4q8=; b=GywAJTHHLcxJVwUJVakntTMUsC9ImefzxWcs8ba2GGuU7mN0qPIBWmkS6OiMKea8ncFEmX GqmxHuyFFHDhYM5yhA6J+t4roOPPCnCIaXDkG4qsKtkkTzaNZ1kPGNB4hsHV+fZywytjKw m1nR9lV36gw3ZVAxhygmL3U5yVEGzxY= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-rZYY27tYNUSwLR_n84kPtw-1; Wed, 19 Jul 2023 12:55:30 -0400 X-MC-Unique: rZYY27tYNUSwLR_n84kPtw-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-521a38098faso1732827a12.2 for ; Wed, 19 Jul 2023 09:55:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689785729; x=1692377729; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ybZMnwXlmIEE0ADI9FsKUlcEynrHTdW2zV41y3cU4q8=; b=LUUovi+Zf9VCjg9s6m78oYeD5KjsH1xIIzoud+yTJJfL1ZNYlHB0qLPsXgittWJr9S x7iODRbiliFjyr2U/c/fPAna8dbmV51FFJUJUujmgh24TWkQ/QwDM4L8i5sXAxqe13vm UCFr/mm/M0zMvjyYv2C0U6kXt0qyAUdy+BPokLwc2kgZz+hKkP88HuNpRONOrpIVOiVn xDiO+j08mM6odlFFCcJI2aDMMz6Swgw8nRfl69AE0Us4A8kg8eh7bMeVhzrcU5IBZ+03 yVyaJc5utcfRVlGKGyqJrf7y5jLdf3muuNPI7nmJlIJUyz7MfT7ntJJ6CTDVIH3qhjN3 T4eA== X-Gm-Message-State: ABy/qLZS0EStbCG5m6HS2/F2SzkWxtb4k2a/PbgfAAWVXxQzzKGO0f5L kFvVDpPIPe8IWo9Oz+7gY/JIQ4GfOoXP9bCPo02Nf931rtm+gm0zIEQaYe21q8OlBxGx7yMvC8z /xZAVjU1c/2o= X-Received: by 2002:aa7:df12:0:b0:51e:28e6:3838 with SMTP id c18-20020aa7df12000000b0051e28e63838mr2675102edy.17.1689785729748; Wed, 19 Jul 2023 09:55:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlEE4qOGG9V7ZI8+WFW37awHpPD5aiip3zVhw1ks31Z/kpX3OD6eusNtSgp6OKt44xHjSBz/kg== X-Received: by 2002:aa7:df12:0:b0:51e:28e6:3838 with SMTP id c18-20020aa7df12000000b0051e28e63838mr2675066edy.17.1689785729461; Wed, 19 Jul 2023 09:55:29 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.googlemail.com with ESMTPSA id r18-20020aa7d592000000b0051df5eefa20sm2911736edq.76.2023.07.19.09.55.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 09:55:28 -0700 (PDT) Message-ID: <711f74d6-fe15-6bd4-a9b9-c4f178d95bf3@redhat.com> Date: Wed, 19 Jul 2023 18:55:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 01/29] KVM: Wrap kvm_gfn_range.pte in a per-action union To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-2-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20230718234512.1690985-2-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8876D40008 X-Stat-Signature: qhsw4ef5jghwr3wk68y9zcseyk47ens6 X-Rspam-User: X-HE-Tag: 1689785733-221022 X-HE-Meta: U2FsdGVkX1+Enl8gpjyrk7c2hK/TPwMMO0T3uQ+7ZZExVP4QJ2367j7P5ofGhMTchjEcHQH1Edao9CnO6ZZzRhTV0sl2j6OheXQI4aAcsPGf+TN+d3b+MMsQl+cnNW565a9c2vhDbp/Xx0U+/fyov2NyeTJ2htvslPkLSOqNHT3Abf7xJGTpjvL9MhKJQolneQ8Sx9QvTr9OY+NQoVnJ0++Sonxo8iz3hVaHAUMTRytFfWpK2dWnOYkJfqIBQVXMP98gUusVakjG8B5f7HUa5Jb3p8NBRuATVmK5O3/iLFnL/LTiacdY39WTDRCGQdhnc3rFXMvNmm8SYNeeOjsrSzIywp3nha/bWnCeMydDDtcEmpYSUXACFv2gLzRonKFrOK1hO2XkCcV7a0qy9FURtObjJGBjF07RzQJDhPGBewlzfV46PQs7py0gUoGAwq3EwWzwoj8ahqMSI1cuxwPy8f+M78QYoZxD1o/GBwv/pxi71sVb1z30HEVExCR2BpHJaMAkeFBrTbEuYrnLnVXsoEcgmVTJiOhOLHfN4JZKXTXRAvqdNn1l+ueskdC+Hf3qhAU5t/lAKQnsda5oj9WK69ITS3kDTBmcsAh4ZN+QdCBd72DHernFrjMzVx4QfCdDKUAATjdr410ZECN/zmjSXfoSoaMsEa+TGGbbnE6uk1D2zgSgfHLh9LyvPX3WFj7tGruyXJTkA7pzSw39gXUQj2nFgwuMm8NmXrz9zLuByAQ1U9g1CjmxUdL3QV2AjabDXXRkmIpV7GHQ4wDe/lBZhol5/u5DZ7vxytubcs1p8oXmP2v7y0x5rCss0xcpI+wjtBnT6PXWnzwDyGLPb5PVtHcNhIvvGW/nk/nAJn0GKm6Sm9MctGWGwdN6PwoeWBnRaoA3LMlNjMWVJJ/BH43kcx+KDWy777aeHBmkKjHHEwfegX6k5EKkQJkEHri/M8ZE146alJsdCZkElU9Scak eqDzSTJf gKnjujr59DtLelHX4mWp9gY4BOFWu0qypfBx0mWVTAQnSqMrDYuRALEnpUYAhnYueZ7lFLeeNtE+GK/MMHgd0zHDc1ipI2+Z0U6+crOmptTaRE7oQoYzBVmTYlqfWC/P9L5mXTk16OivvZTZTExKCOAUJSNO4JTUkoIVmP+QEUGPV6uuEAe8ZYNGqFB5OPehZ6F2+Tx+581S9sPQ8Z/mfmOxzERUabMivnY6F+ermdpjxkeZzUJ3qg7qgL3QdqLAFc/i0yFanObaeki7B+lDNF6pz68GxRC3IRY9K1an6jvde50anidbjDZ39ynP3AkwyrgGOJG4x9iFwqN8VfCP7jNCSiipDkuFvTq9/aC/U3hrgqLatiso1tmxx3yollyYNeUWBmQjTCymX51KCtzLtddn+79RpR5un47b8bUfC32adHHKiCCL5yMBiuh/KFcQQT3ChMELVtcLgqR2BpaPPuYhAiOzgYc5Y1P+uIUUyp+t80n0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/19/23 01:44, Sean Christopherson wrote: > + BUILD_BUG_ON(sizeof(gfn_range.arg) != sizeof(gfn_range.arg.raw)); > + BUILD_BUG_ON(sizeof(range->arg) != sizeof(range->arg.raw)); I think these should be static assertions near the definition of the structs. However another possibility is to remove 'raw' and just assign the whole union. Apart from this, Reviewed-by: Paolo Bonzini Paolo > + BUILD_BUG_ON(sizeof(gfn_range.arg) != sizeof(range->arg));