From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D46B3606A324 for ; Wed, 28 Oct 2026 08:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=izn1ZkeJ Received: by kanga.kvack.org (Postfix) id F33466B05B0; Wed, 28 Oct 2026 04:18:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE4236B05B3; Wed, 28 Oct 2026 04:18:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DACA76B05B4; Wed, 28 Oct 2026 04:18:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B5F196B05B0 for ; Wed, 28 Oct 2026 04:18:35 -0400 (EDT) Received: from smtpin14.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AB1A0A0C54 for ; Wed, 28 Oct 2026 08:18:34 +0000 (UTC) X-FDA: 85371333348.14.1EBA2CA Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf15.hostedemail.com (Postfix) with ESMTP id 060FEA0009 for ; Wed, 28 Oct 2026 08:18:32 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=izn1ZkeJ; spf=pass (imf15.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1793175513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rfg1cZlJEwCYeHTThqQx/kzAjyEawogFMalQMObgNNs=; b=heJo5vTXGMmyO7oWg6tzjUkzQU0Pugev/ate1Wbm904S763WQQHKThY402lXwVfAmUjIDp R6dMw/r91vOkcX+PaEk7NXLMR3QSBDgmVnq7Zqa8XmFIu9vrARbNqFKfIMeQDaB1OvLkZV 6e1vOKsIVDtrDmpwIxgJoQVO2vy9rAY= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1793175513; b=iQt6kyV4K51Y8JPk6AFPIhONPue9Sh6NOzKIuS8WPN9vAsgoQGKZxz+Ogzc2PXg/L6qqwy hCg5qq2qF26KLjogZ8h/KBbQRBJIGHq6cY05HOBgwdyBnm92YmeZG8rUWmfV5K2T+GOhx0 kyVnj+EUgjX0EI3Jr1KoHGVl08JLkIw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=izn1ZkeJ; spf=pass (imf15.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 7E80E600CB; Wed, 28 Oct 2026 08:18:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE98A1F01825; Wed, 28 Oct 2026 08:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793175512; bh=rfg1cZlJEwCYeHTThqQx/kzAjyEawogFMalQMObgNNs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=izn1ZkeJiAVyrZlZw/L12WrwvmU9O9TkhkIMYNeFuVV3QwF+dw6E6BnNte8AiawuX V4xa+DjVJZXhwb5An4LGNvsgrUubDnomzrscpG6wexo/M14K7qD7WbjYWr1SfVEaTd AMkXsm0mtFAhikKH3fvL5DsiOpBnOYXnOslQmQLqvPGzEO+Fzs5Jel7RNmnq/bYJFW wzwgIjUhuSDrcUKqPEirYiuau8fXKzIffDyoMU2KiJUhvgXXCjqI2ADqU4XbpQD0Tn pYDUfJZhkBy630Bqk8DYa2RyUOuVUbSxoXiHNg6m5Poej1wzj+GJCLIhuEFesgWzl1 NnCJrrGyNgccw== Message-ID: <7193e4ee-c5c7-456d-91f8-ef6f465f9803@kernel.org> Date: Wed, 28 Oct 2026 09:18:14 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 43/46] mm/vma: don't leak the charge for stack growth To: Harry Yoo Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kees Cook , Peter Zijlstra , Jann Horn , Pedro Falcato , Hugh Dickins , Pasha Tatashin , Pratyush Yadav , "Matthew Wilcox (Oracle)" , Jan Kara , Zi Yan , Lance Yang , Rik van Riel , Alistair Popple , Nico Pache , Ryan Roberts , Dev Jain , Usama Arif , Kiryl Shutsemau , Matthew Brost , John Hubbard , Peter Xu , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Oscar Salvador , Minchan Kim , Muchun Song , Xu Xin , Chengming Zhou , Chris Li , Kemeng Shi , Nhat Pham , Youngjun Park , Gregory Price , Joshua Hahn , Rakie Kim , Ying Huang , Jason Gunthorpe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, stable@vger.kernel.org, Josef Bacik References: <20261027-fixes_core-v1-0-6f74bec9a5bb@kernel.org> <20261027-fixes_core-v1-43-6f74bec9a5bb@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 060FEA0009 X-Stat-Signature: spfga6bnpcpdz98i13jub18fsym4gh73 X-Rspam-User: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=4.0.1 X-HE-Tag: 1793175512-591614 X-HE-Meta: U2FsdGVkX1+QomXstUNtYhatC8WYPGWCI0QqAhZCdIARX7iR234doe0Lrg4wsHIIypk1AzSfeumE7Mu/idlf/viMAHBTRsEK1uABEXd/NqwcqX7wcDPQL0M9stR1723nkVloKdxvWQKleuOEXn5k7xom532NoXeiuUIXOV+GsBW6ALL9xRqq3BLlbEHcvh01LG/vNpsOfaJ9l2bHS4T8PoCDArVFuPIRcIvNfy2RKewVp5SZMba/RZ6MZkt0kE1JtZ3kONQE9vw9vy9p6qM0Q4u1eGanJSr41zxpuYuZz+R/Bej2MjCB+H0IYvjjDN/zDN25qKmVz6C6wkOcQqwiMBxv1UHG+G9rWRH+E95XCtYhIzujy/648UqUvudO6pCSvdu01MlxfAstzGS5Svq8Wqj0glclxNTMVi0sq0OggrTZi+jhG2MB64NQLN9rrlinrYBH8B+PDKbEr4BWAM+D361102cYXEx/Xk9R8/b4pEPhKwd3PMz8RSXaT1GPZB62z4an7IRVIwGFvat12WCgN/tpR9YoE09ZczHLbivbVJduem05apvOGhLZhtT1GNDZUSK9niHxIiYLMlYhTrjoD/ezlFvAIthkJfEK1fmGVUiCd/XzW2jRFGIFE+rNdZ6kQSo17+Ptg4AVD++WXLF6003Ujsb5sN1Jfkeskm2l2pnKldY5C2lKePm7pL0JC5W3zy/OY4QIu7EcW2KY3E+GIRPShSnXFUIbKxbioEiOAt6E36vZq2yMIpxYDbyYBhk8dgjDaYMPjrfCUBXBF1GOzQmhPyGnLL2l3dyYYciw5TJLMnJcVzUKM9nKa7pRFE409AKtf/iRwl09hT7Pkjx4EQrYp8OnfLkqN5lflvhZlbNAQdCkIuYPKaeGqWBZP1uCTOvd33ajbcqpb/2Rdl9l91bmtYwYdejEzFtb7XmHZMBqHgSUpaKNBwktgF/BWFAcurwyc2oUi6FlkdGDCUZ gd0I/cOI 6CEnlEWZUyRDcIXV31vTatvjMSl66kzWurtLcJv7VEZ6J7Wcm1Bo0enztV2T1hunSqIkbmaXyACzwm1OHuYJhQR+56H37KJRT9Ir8b2cF8UponQSWhnmFekUxS4hRkzGAM9OjpNQ+BKluMGXvcl70MfHVUb6uYQkpC3RK09f+NziQ1CBOrAu4YbaOxuIZopN1iWmWPcLR8RWlTBeAmH7czGePiOL1KeIDuEKgI3U6oVUcZskiPcgwV/DROoO2mehOvAw5bC1dRBYSWQE023wSyu4KsTCeUE3JLP5/m4L8SG2LQYbgg2n62BNNXAOcgqNoT22eTDh8O9w3BGckbyhZzHMN8I+cK6m6Go6KMXP/0Znfn7gXSQ3yTfcIItoIjoC5hTEzX2N6SEMImOwiySiEVRSFfXhGB1hEOJHT Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 10/27/26 21:32, Harry Yoo wrote: > On Tue, Oct 27, 2026 at 12:18:03AM +0100, David Hildenbrand (Arm) wrote: >> acct_stack_growth() charges stack expansion even without VM_ACCOUNT. >> This can happen for read-only or MAP_NORESERVE mappings created with >> MAP_GROWSDOWN. Unmapping these VMAs does not release the charge, leaking >> Committed_AS. >> >> Only check and charge growth for VM_ACCOUNT VMAs, matching mremap(). >> Unaccounted growth skips the overcommit check while remaining subject >> to the other stack-growth limits. >> >> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") >> Cc: stable@vger.kernel.org >> Reported-by: Josef Bacik >> Reviewed-by: Lorenzo Stoakes (ARM) >> Signed-off-by: David Hildenbrand (Arm) >> --- > > Looks good to me, > Reviewed-by: Harry Yoo (Meta) > > Maybe worth having a warning when it's accounting w/o VMA_ACCOUNT_BIT > or let those helpers skip when there's no VMA_ACCOUNT_BIT set... You mean passing the VMA instead of the MM? -- Cheers, David