From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6045BC83F03 for ; Thu, 3 Jul 2025 13:27:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC5DF6B018E; Thu, 3 Jul 2025 09:27:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9D226B018F; Thu, 3 Jul 2025 09:27:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADA1E6B0190; Thu, 3 Jul 2025 09:27:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9CB8E6B018E for ; Thu, 3 Jul 2025 09:27:29 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 499DE1601C0 for ; Thu, 3 Jul 2025 13:27:29 +0000 (UTC) X-FDA: 83623030218.18.93B55C5 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf23.hostedemail.com (Postfix) with ESMTP id 96BB1140012 for ; Thu, 3 Jul 2025 13:27:27 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cCmmqMiS; spf=pass (imf23.hostedemail.com: domain of hawk@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=hawk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751549247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=07B9qWwSQA5aONigaBE70l88VIZkAET7cgpcbuCOnH4=; b=oN8OgxQO7wLLy2f74oJtrYFoYoIYnz9L15/RQ48H03E0U587DbUvLtOaHC/Pg9SmrHWM4x p2xMoJTl5U91FE2RSdY7+PKB6D1we6dPAOe06QrX/LCiJA+X+aLCWz9x0bI1rbeUfiumwZ SfFAm9KX5ZJCWU1XWnM4IKW27V5D5sQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751549247; a=rsa-sha256; cv=none; b=53H+h0mWfl57CHAmJhf/FnThk5TsVjENuzsiCC1/uCc9p+oGGu60rpaaWwopCE6QkAmNeM pbegwaZhb11BvbEvllMV1qR6hIqFxAHC+CKnBPy5DQqvk0hwtYAZ5Uu09KeWnELayqKClg 8Fhkmen3fTSFj/QB0u74QXYR0EFgvkA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cCmmqMiS; spf=pass (imf23.hostedemail.com: domain of hawk@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=hawk@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 825A561132; Thu, 3 Jul 2025 13:27:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D7ECC4CEE3; Thu, 3 Jul 2025 13:27:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751549246; bh=02Jt1Cymbs57OvvyqASB9yCoi82LcJgdykJmqeCnv8Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cCmmqMiSMdW95nEPe1HJViQllZgFpmCY4isMnJBc6miFP3aSlDhfQg5wjWCPHBjUO jHIeWhmx8m/x5oTMYwK0pov1zIDGKIMVDEnEtNxEXKtts1KZ2e+bU816zmaE07OmaY vsGJqNigVBrmny+x/6apIvX4eGvR6RjhALEZ6hvMDFB4gVoeUWGD3HDIDGVEkoDAC0 Fg1ZBJkg7bp+v9NK8JyV2aTfdU6REn1Ex58+/5nr3A6gL2RPe1L6saJxdppQTUV8LE qk0RP9lsJzodZ4eLLvskzTzyRiXaqlBfL/8EMYRLQDZ2cgzGfZLwYoSk4cD4S5ia8M dKDsCjqTRS9qQ== Message-ID: <720df841-8300-490a-af77-8d20f833c042@kernel.org> Date: Thu, 3 Jul 2025 15:27:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v8 5/5] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() To: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com References: <20250702053256.4594-1-byungchul@sk.com> <20250702053256.4594-6-byungchul@sk.com> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: <20250702053256.4594-6-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 96BB1140012 X-Stat-Signature: ft97k6jcz4b7yuok7gxdys5j8u1qakee X-Rspam-User: X-HE-Tag: 1751549247-208656 X-HE-Meta: U2FsdGVkX18+lm8FjSXQ6oQ8gimwiOhUd5zDv4i9gG4ghcBaINUMD4srfQSZ5uqhqPBFbGzLPbcf8vgZZMhVAF0fj2nC+5znrPzt+V75ZN7Zbx5npe31RJ0Zdn1t8cIvnEPPos+Dveq2a+8BykftHUQ/D2Bekb3EGfBHEkcQjCVRJJZyqvBlAk6qZAzIXztFjpJtXhQ7y25iWEWLK1rMl7fPMGKNZFhs9dCgt6I5G+Xlkz6885EckwV3zWzdEHxQe1rsYgWbtkvTNHt0eGB/CVSBRgyZXnMhYdzZLUGbnLdMdKpgaljqWeAnofE0UbE/xCk5Hc9CwILiszTLt8aj40W+okM0DRCSiZTuz/JPEekuBg25O3FlLSbTLRd8Ytc8OVS4g++EqXVffMibQGo1+oPGAyq9ScgcZl9B2axgtf1VCyOayniqAqDYdIpuEkuYyFk+pz9DTDH2ULXrJGm9qGSc6DeE91lAke4VQWSGZnCtNIU1eLHeY8dvxcF9V7Xyn1DM3ZFYq3vPAC4jj4COTC7fXbiCNIpi5ersnoh40TDf1j2dEjkfGdhPGqa3sH34OK4dHzsq1vNdyrBQAYJs4yPNZ8/1ye/UywgOrMnwLbgVIYR8slNN4j8QqXRbcuf518cECbaEb+s/Z9P760pzhGuzmraj3B5a1mfyvJGcfxz9cuMjTsXaZTVU8ibZwY8OFKDCjiR0GLE6Zq3HhInUkr6Kswq4wZjwrgtJTvER8GX7Khp7qub0C1yntFhkbB8/xEYmY3PdAWnwtiy3yZNfCzIMP/xKhcadvaerejjXjiQwxKxiqKZ1gNs/hYZ4P37XR0x/Pu2srB0LEoR+fdfdJXwaxpWj8Xso3FAplzhqujQoHDuHqwd2eU6pSE8ci3Ikdqog7nHpcC8ioAJWf46tfsSRhpQgigqVYJ1ogvvNmVs3ofmXwTZDIuUebA6J6DHO6GT2kE0Mch5Heix8YZH BLc2lp6T BMR98R/9nc+zApRC3tncnlqBIMkEOVRZf65LX0wBl0bHfZgXcBjIH8Qzd/skpVjucGAaZaJ+NDtSFyUAscjtUfkfFmkzoSL4bnqTODlofO2v6Bn3eVQPPfgvqYQ8vFDaAQt+FSVrSfKKYDdfNy6AtHV93DMRarko4q1dm/rf5E8mTAgl3Xg90QHxHGg3tm7hCvqhZrzCbs99TGCkktPkLZS3vq3J9lznZNA5rDh6L+bZ1/Ul+x9Y6seZqGIpBL5bcVaMfP8Gr67d+5X2MF0FZuZw0gwZNMwyP9UBrVgyP5+9SWgTgfEmX6y/c+X3CaN5GuAjEbAZoK0LRdKoS8qpWZ/QDWPhqUWPlVlyHt4z0azPdnH1A5Yiuvfr8dkY0y77Y8ZPmn+als3YaohO+KJRlpG9nHFCA/y5ojy1q3KCtDSRngU/PsDNTYptOvD0T7XCFGxO/CBBzOgTVeUOB6l/i6mMCGjJ73zNDz13BGw5FcC9iGVqs9aNBvKUe+3eusS/JNdbtTQjUZMRfp6td6INDr6L0f6Remp7GaLZA4uYZjuKxpG0s36YmGd78jWi+r8WMN4G2eEfVYticFv7jOq8k+NxivF+PLekoBbDY6zzuhDCYIRw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/07/2025 07.32, Byungchul Park wrote: > The page pool members in struct page cannot be removed unless it's not > allowed to access any of them via struct page. > > Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but > just wrap page_pool_get_dma_addr_netmem() safely. > > Signed-off-by: Byungchul Park > Reviewed-by: Mina Almasry > Reviewed-by: Ilias Apalodimas > Reviewed-by: Toke Høiland-Jørgensen > Reviewed-by: Pavel Begunkov > --- > include/net/page_pool/helpers.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h > index 773fc65780b5..db180626be06 100644 > --- a/include/net/page_pool/helpers.h > +++ b/include/net/page_pool/helpers.h > @@ -444,12 +444,7 @@ static inline dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem) > */ > static inline dma_addr_t page_pool_get_dma_addr(const struct page *page) > { > - dma_addr_t ret = page->dma_addr; > - > - if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA) > - ret <<= PAGE_SHIFT; > - > - return ret; > + return page_pool_get_dma_addr_netmem(page_to_netmem(page)); Wow - the amount of type casting shenanigans going on here make the code hard to follow. This code changes adds an extra "AND" operation, but we don't have a micro-benchmark that tests the performance of a DMA enabled page_pool, so I cannot tell if this add any overhead. My experience tells me that this extra AND-operation will not be measurable. I see a lot of reviewed-by from people I trust, so you also get my page_pool maintainer ack. Acked-by: Jesper Dangaard Brouer --Jesper