From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17942CD1284 for ; Tue, 9 Apr 2024 06:27:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 899D16B0098; Tue, 9 Apr 2024 02:27:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8495E6B0099; Tue, 9 Apr 2024 02:27:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C2D46B009A; Tue, 9 Apr 2024 02:27:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4D87F6B0098 for ; Tue, 9 Apr 2024 02:27:25 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5F29C016C for ; Tue, 9 Apr 2024 06:27:24 +0000 (UTC) X-FDA: 81989011608.30.C94037E Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf14.hostedemail.com (Postfix) with ESMTP id 68DB0100005 for ; Tue, 9 Apr 2024 06:27:21 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=i7QEtUo4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=DBxgy5Js; spf=pass (imf14.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712644041; a=rsa-sha256; cv=pass; b=u3qUreik22nkT2/vXaQtD9T5012AOPJEj80fHOXB2g+9kH1GPIt6UXoWI/zGsz2CAgGDbS Ti0COJmLA2UovsG9835zkyFQ8jLLO3abJnBupzLYjh/9CWCdRGyJuhKYtmNuxc5R+oiaiZ Tb5/Md7r+a9yZek8176CqaSOO1zVGnE= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=i7QEtUo4; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=DBxgy5Js; spf=pass (imf14.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712644041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+8DVjWF/swhOyykKnQpNJaZmjWt3V9mvSZuA70uAKs0=; b=gdoPKQqBHECTAHKZaECm50Ho0SwlQv7cXY/7tW/X8bsSFbL6/VdIz2li2JMfWJzYFjMGEJ Lf8DegW2iM4ze5KaZ0ZPE7JsossZ21qYAz60ml1EHYn+eUybjTBOKydphxh5KEdtWqZbL7 axVR+ovZSGPUlwPnSGEBnStzs+0IFFo= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 438Ln0rO013130; Tue, 9 Apr 2024 06:27:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=+8DVjWF/swhOyykKnQpNJaZmjWt3V9mvSZuA70uAKs0=; b=i7QEtUo4HuwQLhvGuro/KRcl3wW833j8uuQruzFyUseLy9bptU0vpfzNMXxJdNKzslKk oVCih+tJEWWKd5uruw38d81DmUahpUQ2BvbLSJlM7on25sgQCoqer1tj2k/N+8wKqxeR FABG25x3I4WG5e2licxXFuFPKJYRew2yyQqu/8UuS9+iYAYvMsizNGwgamw8iZ0n3+fM OohTRqxsMGFuxRlB4/CysuHxUb3Ra/4oRvwzRJ5EU+zxviVThI6bioOHOHG0THg7TNc8 xVHG1I/K/G8Rb1oJgCscqAHZFr+QVgWJ41wd67+C9htoBPoXNj+ObN6rpdYFXpoqSbHJ cg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xavtf4ag2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 09 Apr 2024 06:27:07 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 4396N6t3017938; Tue, 9 Apr 2024 06:27:06 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xavuce2jd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 09 Apr 2024 06:27:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fqyr/h5i1d1tBlKaslno5OnrZG9Ez/fB4BV9R5OKUh26qVIaldLNnXCAgResXyyCItqwap2IJTmPLsfOJx8X0/Pme+FXx+lVZrH6hTU/oVt2jRx3QFlBISsS4xFPCrkmAhLdFJCQseG0Gw6YvAXsDg1X4eVgh/UezUhYz4V1A3IFvD0Gkw9sTfhicd/DdKh/S4J9B5Rahn0Y58fNuv4WCw7DSx6BFJ7xFnUZ6PkpVDbWHjotCZO6RZD7vcda10z+INFMmZpZhSQKPQvK1o7iZ+Wjb7LawuOuC3AUUxJYAqsYVEdPxEuJL6zD9mDvwXYVRSDe5N/kdyFcTL9BAET4pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+8DVjWF/swhOyykKnQpNJaZmjWt3V9mvSZuA70uAKs0=; b=OxcCmzLjO0tcWsaM/EGjlp1ogSn0gPgAGh/P7B3nWX7MWCgpyd4CEYnS85Fs8c387TVK651dr/XyBaOOERweg9upC1KC0hn2wi5x9fXKu1Qwv4V2+pk+Hmxz7NJ8t6iOOcQhw0v+4MOg5H+rndk5RS46UqbCeSj5lDbBmITHRoA5i45s64leb6rzqyHQkyXHnfB9e0OzXx7fmoqmHJg9YshkaNV9KKdaOluBZdwTp6LrReGkBgG5y/geMUSMsBum4pNevWenwzZI6egEIsA6nVBUBXXQDDQDjOB3djmf3pK+VT1Zd4QLhi28gTJ4UBiUIysR1ZAWpt8luNIAdCgRCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+8DVjWF/swhOyykKnQpNJaZmjWt3V9mvSZuA70uAKs0=; b=DBxgy5JsE/RxgHOKW8+52TIxkTCKBMp/TpDkZwjwJGTUFP7VPu9N2dyskwbp2Qe0YK5COCiCRm/rrB4OQf1AdP6wL5r1TQYuiZmpGFrwurUaWapBkQvjKMI9ULFEM6FmLMdJcaUmDPYxbX21wmPVsCqgOpHkzm/6QKo7mfPJyBs= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by SA1PR10MB7856.namprd10.prod.outlook.com (2603:10b6:806:3a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.48; Tue, 9 Apr 2024 06:27:04 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::f5b:648d:5d73:dd03%7]) with mapi id 15.20.7409.042; Tue, 9 Apr 2024 06:27:04 +0000 Message-ID: <721459db-1a7d-4b39-aa42-723624e718a8@oracle.com> Date: Mon, 8 Apr 2024 23:27:02 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/11] mm/memory-failure: Pass the folio to collect_procs_ksm() To: "Matthew Wilcox (Oracle)" , Miaohe Lin Cc: linux-mm@kvack.org References: <20240408194232.118537-1-willy@infradead.org> <20240408194232.118537-12-willy@infradead.org> Content-Language: en-US From: Jane Chu In-Reply-To: <20240408194232.118537-12-willy@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR05CA0048.namprd05.prod.outlook.com (2603:10b6:a03:33f::23) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|SA1PR10MB7856:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LnebZTusSSj8NhWAcBQ/i5npzfzHkak2sJi6NZ3yjOpnurSXBJCKNEzGD5F9Q/cGxNNo//aJ4gvb7UyMD351YA+bwp9XEDQF9nF/RTTTm6J0q9zmuLJGfvWICgwvcmfHMby621dHD+l1hNSlgv/gESBbIXoiVkXR8Y9PIdrHTBou9n87po0lipJn6EKOQd/E1C0zDfP9AxTMwIveiBJVUeg9QzV6k5dYp6Pl0u9J3XnVmd6wnx70X+w6+nwvoQn9W8skvQpEvM7SFkOo6hVy0XqNIP7HEQQ9ZpMycivGmBsJggqLcfaDf5gGxRTrSryecgz8szZZlRpL8Vw1pJmFa85xPiK6/8r0krkvAZEahX2tLEiDVIpPACImPV2VxHF/kcXix2heFQSnXVrnbxD/q+Q4VZ8nVSHLENASRZNbBeZxPNy3fZZmru83zDmUxPQDGCGXuSqy6MRqBe0c8fsmKi8bx3JEbg1Dn+p6+Pyb+dDJcRhz3X+kOyyNvQu5awb9gGMtkU66IHbFJzjs+SRBgBbufSZDVr2DxlrLACyPbrA6LB9Sc017ypHQRvmtr4UKh9/ckkAXIBlJZ7thfLs8pF8n7csx7OVTRT6TTrX/K7pLehAvHEEfuYVibE/r7cHbVtmcy75NV58K8YRH8EcOQtBavYQJsa87fzOlK+kZnTM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M29DWmVySmZEWjg1bVVnbmFmL1lSMy9nY2hjM1prRUdpV2dNUlBXU2xkei9E?= =?utf-8?B?OWVsNG5ZL24yb0xCL2RMVGZIRzBYM1p4c2NGcTY3a0lyYVZNM3NzdUMxZG85?= =?utf-8?B?Zk9hRnczeHdKWUYxWGw5MG5ndTMyR1hPMGwyUk1aWUV5Q0RhN2IweU5Zb1J0?= =?utf-8?B?cXlteUppLzdrWEFZWW1jQWF5WTFoVlc2YzA2SVRpL0pETGhQZURvTC93WXB1?= =?utf-8?B?YzdPZlNZbVp6UTQ1YW5PODRpSGdaMmJ4Yk1wSHJOdkI2WVJrcGhoYklNS2Ns?= =?utf-8?B?Q1V6M0NkZ3JvVHdVMzhLR3c4bDEwUXE0elRIQXZOSWMwakQxbWJURmlLSHFE?= =?utf-8?B?enFoblNQaS9QSU1mRmNoTmRXNzJhNTBYbkRVOXd1OFJGcDV6QlFGZXdnQ3hr?= =?utf-8?B?Yy9MMzFaSkd0R2h4VzQrbW8rclRHdDZkR015bThzbUNvYk1qVUpRUkQwcm02?= =?utf-8?B?QkVhQnBFNElRY2hvMXhmcmc2c2RaMURBcnpRS3BFbDdPcXEwRklGMWFaY1hO?= =?utf-8?B?dmVwQlY4TkIyZkFYOEJ1Qnh2YmZubVBUUzNSZ1ZjWFBQUFZtWXBOZnZmMXBU?= =?utf-8?B?OUFvWldnMFFSL0ZyMmx4RDIxZThyOW9BSlp3T1NKWllwOVc2MFZjazdOMUpi?= =?utf-8?B?azlRYnJueW5VVm0xblZkbVd0Q0dWM0NYTHkybnkwNXVoaUd6VmFCWnk4R1Bl?= =?utf-8?B?eHplNlhGbGUwZFdHV2dTd1VXZjNTRlVRQTZsQzFIWUo4SW4ycDBHUm96dDgw?= =?utf-8?B?WVFua243VUU1L2RxbGh4eitQWVdqZlVOYkFUemIvOXM5SVM0R0ZoelRxUHhk?= =?utf-8?B?OHJQeVlmWjQrT24yTmxNZHVJQVdZMHkvRmtZQjF2b2l6aVR4aEQzeTZ5YVVU?= =?utf-8?B?dk9KM1JESjdtN043b25NVHZoWWlleUtpam9kNUhDN1lmMGY3Ym45OHhZcFpj?= =?utf-8?B?MWZucXJMWFF4WnBhV1F5RDl1QUtVK3dYNzE1dTlxbEh5Ky93U0FmckEweGdK?= =?utf-8?B?TUpXTm5HNEo4S0VjUVl2SXRsMmlXMkRGVUkyU1ovWVRob1p5WnF1MGV6aFor?= =?utf-8?B?M1k2ZjJ6M2R4ZkhUUUEvcXd4N3VzUmpWMFYrN2VYMXQvQ3FHWDVUellKT3k4?= =?utf-8?B?YWcvV0pvUHNqNFhCeW5wRlpLUWk1b3J5N05xKzQxWkpzcmcyM1I5eElpbHRO?= =?utf-8?B?ZUNsZXhxM1FIa1NqVUZWbDR5dFhhM3NWMTlpUTI3S3daQTZwdGY0anlvK0dP?= =?utf-8?B?dCtqYlE1cXdKSVZpNzdCcWIwYWVRUlNEc3VaYklrVVJMbHhnNzJYWmZCcjc4?= =?utf-8?B?NmVXbmliT0NTTlh1SGNwUVVrOGNXSFFsVk80VDZhU1VnK0w4bWttRkZBU3N6?= =?utf-8?B?TVRMUm40dlg2RnkybVIwUTN2ZkJNY1NScjR1SGgySmlIREFYUzJjZTBlZjV4?= =?utf-8?B?NUlCUmJ1b0cxOGZmQVlBMy9TV1NBVmtSaWNNWW5wRG9ibDJ1RGhQZmVQY0ox?= =?utf-8?B?SDU4MEdpSWZOZzFiZTlwZnlkaHFHbURhVUVaanE5a3FGempHUDB0L3ZDZVFO?= =?utf-8?B?dUIyclFjRXliZWFMUnVvOXRJSnF1N0t4V1o0RlpxM3psd3pxSmpYNVgvL01B?= =?utf-8?B?bjZWV0pEeU1hVU0yM2R1OUFFV0hzMUVIZERONHR3Q29YSHRkSWhJYWNITVVW?= =?utf-8?B?VUNoL3dPaUpsK01mN1dJWE96ZEFCWDBDVG1xdTROaVdjZUFUczZGUDZialN6?= =?utf-8?B?TEw2MThteS83eFVMYVplSkgwVVZLRXI0WGkyQ05IQ0RLaUFUVGF2UG00TE96?= =?utf-8?B?cVFlMjR4UzJpYkxmdHhpZGhJZm5ORWxDc0VVZHM4OW55dHlIZVlmbldVMExn?= =?utf-8?B?L012RkxieXVDK2NtNm5ZQ3I0aFpxLzZITWx5bmVMVXFtOFR2TWtNc016T2lU?= =?utf-8?B?ci95SFgxZU5Kb3JuTkxzdnAvdnZJbUJuOU9CTDhvdWZhOXFQd055SklETzJP?= =?utf-8?B?alR6L016OGJzU0pNSXY1Tms1WVpUbnRsRjY5aHVmd2l2aTNpcUp6ekp1dkZE?= =?utf-8?B?dWduRTZ4L3lxWHl0M0JTcStyUEdTVDZVVlRtT2RFY1JvaHpwa2pxNWM2RGRy?= =?utf-8?Q?6uvewWnS9OPL0eRIbpRSgGu36?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Wom36hTFG4KoBdqpNcTFq7KBZolX2/xKEYqSUhbEqLdkwpw2C6JZrYNda5Qiijnvtn9VLPzjvTyyZW4EXpjvtYMOJFARzUc/pBlIwhRBXPvYTRPidzcRTlIvoGdNJXeCsund7+vBE4lnJMeK9T070zFW3p38lsyMS5bjN8xCSFKUCqfXyc4XDJIB9U8Wa2ptZjmSTrb+ag2eChj4KloDkkjhaflW9RZ5iFcR5sdqbKzmfkoNOT40XrBR5+1de7hcecSA/TYEjqv1Q6uBPN86cOMztsFWrvozy71s0FLKH8Dn8AFODeXZNn5eYNH9+kVSl3gWj/BFHrfIrWRvRNhQ52FoYxVvw6fJeNhVDE9c55LH4ZcUO4DhylUfpn1+Bnesfj7bCHEZVyymtrjx9KznucU4CD0vLs6NmdXhDgyIwyQLEjsMg8aP+40M9+l0n2jx5QdvEWroqjPOD1fEdW3ytOH9kLUwbLkNK/8iivyaGJGmwW/Lb89oj7AawEbZl/gU36ESk0w8RT9mt9TuhXX5v+g2b1WaPL85KBW1+gguyc5w3NMqfLRqi2UPxSzWIUl1PhdHr7RsflQiDKPKoyFonKm3X5glypbhjJHyR+qAj84= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 109a5eec-4e4b-4e37-b6e6-08dc585e126d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 06:27:04.0253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 686+CqGlMhEulrbb2eSfhY1ouE1fWNbEnGWo1nMoR0BmHL+0DdY8SW9a30ocoQ5BnVjs9zf6VGQAF2DUHWek0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7856 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-09_03,2024-04-05_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0 suspectscore=0 adultscore=0 phishscore=0 mlxlogscore=890 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404090038 X-Proofpoint-GUID: VlRXqCsdpUUzUA-tauZgqvgD3JyTtwgX X-Proofpoint-ORIG-GUID: VlRXqCsdpUUzUA-tauZgqvgD3JyTtwgX X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 68DB0100005 X-Stat-Signature: xsjw44dsd7jkdcf9j6xcowc63uag483k X-Rspam-User: X-HE-Tag: 1712644041-643257 X-HE-Meta: U2FsdGVkX1+VREEw3W557QZdV4jJ4GQa241t4ugTT6Xv62Iv45zLVPkom6OLxEIRSfOfDzIMcPNOz+Q4jNgNUPcmgepgqOtIkhfhiuzbcI8+75bNb9Hj1eTyvjdnriLqMQwkojhD36EiLHbDfxL4XfgzJKFLatC485aGo64YFJxJcT5YjOH0SbvBTH2sSW+P850lUpufWpsTvj0LWoaUHmCJXYHsORrAK6BRoZrEDSoB16pt8lgYXoLRMrtEh2S7A0tYFRcOQGowwj9ZW8MT/j6cA5mI5H0g39eJAru6O44ZJQZImCjgyWkAcIL5mxc9aXrt/ZuCGfFa4YsQKO67f1/S/OK8HYefja9RDAbQAlpfpYgtDb7jTUpbWdZNqIhZcEnaxDb1Vj7FamfV5+snToySmlkUkPqF0+Vob6SlGi2YI6nj1OE2AfsjDXw+5wlAy60mEK6IXKafNYu4Y8/TV9XfvzHL13lt9SXQNKR8hHc/r1MXQpSxMf87Z32kuv5NOUzc0UQ4QQF6bbfJGGRZurTLRc4z6QwVJw4en0hQQFGM4CS0mnoGIpOk2OeyQ7Gh8mNywZWu9jpfayBhdYBAA5jZ5VGVWn05qoANiJbgym0b3pHKEmgHswlGcoVBjCI3LjgI6baDq7EpHnDWBC79eWCQM+eerqm5+M6Pq4onNUnMin056NA9fMKK1aeZeQdOsDiOQBVYlHcK97NPtXuNKIy+7PB7gDlqoWxlz7+QUaTkEb2+1n6RynOUZmQGk4qWj8m9TFeamwD/Kn2szmC5P2sE8u99qJnlL/azzL3DC2trrAGnLghFXr7EBbUQtui8GEAk8sWcoRCTgxEECwL80R++F/hp4IqcXxAIcj+bqH0rRJeLFxJ+urE+aK6UgslYDOgYtfvaIip/miVbcXNIDNy6eql/qN+6qGS20URzJLzA8Wa0qib18A6WnPUWxAsXFgQy2t4oFSL67SguOgG WCbJ25dF RTHJLSMfVs83wggc5w84/T18BKKXCIvw2px3Sj6/Z4M8TPbRJJcQQFhtXQ9vdRQUmomttaj/kBPokSe/8kTEgfUKCqcXOhM5AhOUSQmAEG/dlc6d+HoU4gNvimPqQbTeih00Yn70QuQpmcFIGEceJeEZ/CrsaquOWVsW8zCoVWGqpQijC5z8D3u3y7t+0QB36LfgJs4OVTFvVoJkLnXrCSt4du1aYCBAzVFJgLDH6PawCaL6EAWg1vbORU6eYKxrsw/C/a+ujJ6AZwlg09IsuJdH7gAyk5yJoJWsDsnqohuitMUDyborWH7H6RUfEkMGOH41L7MmKqbw34Z3IwZ7l5ZHMkC7ukr1utWFCI5sqVrzsvEhaO6lTz18P/GhxkPR3QWwezdAe//TKIqcjs9L014Z7DhEk03UVGeYusKlILYcXxIVNm7wqLqF9t4G7cgBY+zTbVG4LMsZS3FMHUsNtDLj5dDgHrqICaVvK9h8V5XELfU54NaWfqXEnXDDf1wjcEZ9lYyN4gJWmWdugz2POeGNGB5kt5rqjfPo6T8c6tB1BlzwmTplrQs89g8a53ejwhE25fs4cyd1yGLU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/8/2024 12:42 PM, Matthew Wilcox (Oracle) wrote: > We've already calculated it, so pass it in instead of recalculating it > in collect_procs_ksm(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/ksm.h | 14 +++----------- > mm/ksm.c | 5 ++--- > mm/memory-failure.c | 2 +- > 3 files changed, 6 insertions(+), 15 deletions(-) > > diff --git a/include/linux/ksm.h b/include/linux/ksm.h > index 358803cfd4d5..52c63a9c5a9c 100644 > --- a/include/linux/ksm.h > +++ b/include/linux/ksm.h > @@ -81,15 +81,9 @@ struct folio *ksm_might_need_to_copy(struct folio *folio, > > void rmap_walk_ksm(struct folio *folio, struct rmap_walk_control *rwc); > void folio_migrate_ksm(struct folio *newfolio, struct folio *folio); > - > -#ifdef CONFIG_MEMORY_FAILURE > -void collect_procs_ksm(struct page *page, struct list_head *to_kill, > - int force_early); > -#endif > - > -#ifdef CONFIG_PROC_FS > +void collect_procs_ksm(struct folio *folio, struct page *page, > + struct list_head *to_kill, int force_early); > long ksm_process_profit(struct mm_struct *); > -#endif /* CONFIG_PROC_FS */ Why is the #ifdef-#endif CONFIG_PROC_FS removed?  In ksm.c, ksm_process_profit() is defined within the config switch. > > #else /* !CONFIG_KSM */ > > @@ -120,12 +114,10 @@ static inline void ksm_might_unmap_zero_page(struct mm_struct *mm, pte_t pte) > { > } > > -#ifdef CONFIG_MEMORY_FAILURE > -static inline void collect_procs_ksm(struct page *page, > +static inline void collect_procs_ksm(struct folio *folio, struct page *page, > struct list_head *to_kill, int force_early) > { > } > -#endif > > #ifdef CONFIG_MMU > static inline int ksm_madvise(struct vm_area_struct *vma, unsigned long start, > diff --git a/mm/ksm.c b/mm/ksm.c > index 8c001819cf10..7d032b52002f 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -3172,12 +3172,11 @@ void rmap_walk_ksm(struct folio *folio, struct rmap_walk_control *rwc) > /* > * Collect processes when the error hit an ksm page. > */ > -void collect_procs_ksm(struct page *page, struct list_head *to_kill, > - int force_early) > +void collect_procs_ksm(struct folio *folio, struct page *page, > + struct list_head *to_kill, int force_early) > { > struct ksm_stable_node *stable_node; > struct ksm_rmap_item *rmap_item; > - struct folio *folio = page_folio(page); > struct vm_area_struct *vma; > struct task_struct *tsk; > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 1c3cf1fe4964..0630e34b583b 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -713,7 +713,7 @@ static void collect_procs(struct folio *folio, struct page *page, > if (!folio->mapping) > return; > if (unlikely(folio_test_ksm(folio))) > - collect_procs_ksm(page, tokill, force_early); > + collect_procs_ksm(folio, page, tokill, force_early); > else if (folio_test_anon(folio)) > collect_procs_anon(folio, page, tokill, force_early); > else thanks, -jane