From: David Hildenbrand <david@redhat.com>
To: Stefan Roesch <shr@devkernel.io>, kernel-team@fb.com
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 2/4] mm/ksm: add sysfs knobs for advisor
Date: Mon, 20 Nov 2023 11:32:55 +0100 [thread overview]
Message-ID: <724f61a5-4d02-4232-ae8f-71f55e73186a@redhat.com> (raw)
In-Reply-To: <20231028000945.2428830-3-shr@devkernel.io>
On 28.10.23 02:09, Stefan Roesch wrote:
> This adds four new knobs for the KSM advisor to influence its behaviour.
>
> The knobs are:
> - advisor_mode:
> 0: no advisor (default)
> 1: scan time advisor
> - advisor_min_cpu: 15 (default, cpu usage percent)
> - advisor_max_cpu: 70 (default, cpu usage percent)
> - advisor_min_pages: 500 (default)
> - advisor_max_pages: 30000 (default)
> - advisor_target_scan_time: 200 (default in seconds)
Is there a way we can avoid exposing advisor_min_pages/advisor_max_pages
and just have this internal e.g., as defines?
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-11-20 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 0:09 [PATCH v2 0/4] mm/ksm: Add ksm advisor Stefan Roesch
2023-10-28 0:09 ` [PATCH v2 1/4] mm/ksm: add " Stefan Roesch
2023-10-28 7:33 ` kernel test robot
2023-11-20 10:51 ` David Hildenbrand
2023-11-22 17:20 ` Stefan Roesch
2023-11-24 15:37 ` David Hildenbrand
2023-11-24 15:39 ` David Hildenbrand
2023-10-28 0:09 ` [PATCH v2 2/4] mm/ksm: add sysfs knobs for advisor Stefan Roesch
2023-11-20 10:32 ` David Hildenbrand [this message]
2023-11-22 17:42 ` Stefan Roesch
2023-11-22 17:43 ` Stefan Roesch
2023-11-20 10:53 ` David Hildenbrand
2023-11-22 17:41 ` Stefan Roesch
2023-10-28 0:09 ` [PATCH v2 3/4] mm/ksm: add tracepoint for ksm advisor Stefan Roesch
2023-10-28 0:09 ` [PATCH v2 4/4] mm/ksm: document ksm advisor and its sysfs knobs Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=724f61a5-4d02-4232-ae8f-71f55e73186a@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@surriel.com \
--cc=shr@devkernel.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).