From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDC6C3ABA9 for ; Fri, 2 May 2025 07:18:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B15976B008A; Fri, 2 May 2025 03:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC33B6B0092; Fri, 2 May 2025 03:18:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 948F26B008A; Fri, 2 May 2025 03:18:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7622E6B008A for ; Fri, 2 May 2025 03:18:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CB77C5E9C7 for ; Fri, 2 May 2025 07:18:50 +0000 (UTC) X-FDA: 83397115620.28.B9BD926 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 3FE2BA0009 for ; Fri, 2 May 2025 07:18:48 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="A6036c/E"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746170328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WvVwxa/l0Dpro0/sAgCe/uKQ25ooLoIul7E/bG/CZSA=; b=e/5mU0odlsyD5LBdWvw0UD6qNWFYOpVXS8s3PNkCQijEMvU3yPbTlbIT1Qocjr86gpKu8h CVFBlk6pXZwnyaYhahnRWrQgNk6mCwf+Z/h2kj5aa/GgX4jnbbrm3HWvtMbOO+JwfNCAjR FW7aS5gznWnOKW1n61rcWyl1dQ2zTXI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="A6036c/E"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746170328; a=rsa-sha256; cv=none; b=kReX5QklTyBBCOsqbuCEfTv4l/BP87PBWwFMUSJ3+NMabmlpH2Kqi0hfNHhpxL4yTHIP4O 5I5kgBZSBQeZsvslWyIwMKY9PGOvzFVWEc5E8RsojhObt77SzdhetA4F5jmGb1KZD2H5dl IYMndVJMkIyuhNSrMK/YfDATIV7ytg0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746170327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WvVwxa/l0Dpro0/sAgCe/uKQ25ooLoIul7E/bG/CZSA=; b=A6036c/EL2tvNQSFHrzIZjII5ZdMyWpxOwmkIUHob9+4B1UmgpBjB0eyV5TMg5dcLQfRgY kvBQrx5BNaRLNKEXHisGQeqP3YbRVz5uKp3gTFuTln/U8dYqFUUaay//K8EAhNjCxL4zFq y477OeORKlrItx/FCsF7IsgLU5t3RdE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-UJn4p8GNPOqqiZEKe9nj0Q-1; Fri, 02 May 2025 03:18:44 -0400 X-MC-Unique: UJn4p8GNPOqqiZEKe9nj0Q-1 X-Mimecast-MFC-AGG-ID: UJn4p8GNPOqqiZEKe9nj0Q_1746170323 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-39143311936so478524f8f.0 for ; Fri, 02 May 2025 00:18:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746170323; x=1746775123; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WvVwxa/l0Dpro0/sAgCe/uKQ25ooLoIul7E/bG/CZSA=; b=RG1HjyM38xkheXGztDeViaWSE1WVni+YIJ9T5JurnF096mKTVjxLE1MPHACuGiVoxK t8SkH51w+yHy/FaqvJj8EVVjR715CIrN/YPZNAvOAix4mDXZ3dL4fyPM+1XzcGGAjj58 Ebs+BAy+UcE1JhzXwicZYEpR/rTzNAPP5aQG98GtH2+imeylFofwP4pYdizWeFXZdQrz MYlGT8l5/Mf07H8nArc+PhTWqs2ZDumYLERG7j3VvH5Ok8QEA4nAWEABIsK1MMDK1FRW h1k4RjKyb4wjW9T72Aj1BDAlDH6iFuIKrqWVLpKjIlSqn0QHh9PnIWKyvZhfCAnSTnqW nwrQ== X-Forwarded-Encrypted: i=1; AJvYcCWXmREv89cruaBOI10zdIqsKkNOnMvy8OzZeZGNWLR5pMOohGSjJqzYGO0hsuqcgsZ1qoIVzgmeeQ==@kvack.org X-Gm-Message-State: AOJu0YxmhOMbjs8SQG/ZMf0S8RBXrd0sik8oaj+RCKzynAecGWsy7uU0 9zMpzugr0EDXpHA55/G/oCPd/c+ZPyl0dFvZsFK9RfiNF2t7CMkF6+82j7Hi+qwkX3AwglXO5B1 5jD0yQRmEf5QMPX7rLmU8GVYLpe0Zdt4Id9bi/Xq+QuE58J/c X-Gm-Gg: ASbGncvGQ3l0Syi+t/ovzJGYI3Yug3CNGCYG74yIKSgjvaZsTwyATyqll4xvz8k7OfL YQs3sJH74OJdgxK8yL8/qFrzaqiPXu699Ayw5dKSeFBpnlm9Bpxil9ECIB/jzSSn0PW0wxfeDlg 5EpXiLZDeBdWKp4vVuaXcjBT21iINjD4O10BGPVRRoXRrJB0mVlwoGz9g5DTIc5dW3CIVnlzbqG 0y1zazUaxWS6I9n9JrVSA8A7PoR/BCnSjVLeBKYiB5PEld8Cvc98ccxM9Fg6mwgQZGd28Fmnyog zXMN7t0/IlwChBPJO304B4JaplDBKK9txgI5KRYTgIbT3ah/iWS6M85xBcBSUaKWLQN3snh0ilZ xPsp+ICWDsLm9x55RUhwVUorxpsbjirM3NooikqU= X-Received: by 2002:a05:6000:420f:b0:3a0:7139:d178 with SMTP id ffacd0b85a97d-3a099aef9c0mr971151f8f.51.1746170323345; Fri, 02 May 2025 00:18:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyRMNgoo6YPSxUQFUuMJW5ewbRCwkZNmCBDuHOusZvSz6tTMPNpdjOI6X6GDT8vuzy7+l7EA== X-Received: by 2002:a05:6000:420f:b0:3a0:7139:d178 with SMTP id ffacd0b85a97d-3a099aef9c0mr971132f8f.51.1746170322963; Fri, 02 May 2025 00:18:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:d600:afc5:4312:176f:3fb0? (p200300cbc713d600afc54312176f3fb0.dip0.t-ipconnect.de. [2003:cb:c713:d600:afc5:4312:176f:3fb0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099ae338bsm1299223f8f.27.2025.05.02.00.18.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 May 2025 00:18:42 -0700 (PDT) Message-ID: <72978e3a-ee67-47d4-b06d-e911bc5d57ff@redhat.com> Date: Fri, 2 May 2025 09:18:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [REGRESSION] Re: [PATCH v3 3/6] mm: shmem: add large folio support for tmpfs To: Baolin Wang , Daniel Gomez , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, wangkefeng.wang@huawei.com, 21cnbao@gmail.com, ryan.roberts@arm.com, ioworker0@gmail.com, da.gomez@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev, intel-gfx@lists.freedesktop.org, Eero Tamminen References: <035bf55fbdebeff65f5cb2cdb9907b7d632c3228.1732779148.git.baolin.wang@linux.alibaba.com> <57dc4929-268b-4f3f-a0f8-43d6ec85974f@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <57dc4929-268b-4f3f-a0f8-43d6ec85974f@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CW_pyISCiL8Nv5T3f8lRARokoc2hzqReYUwSyUbEIfU_1746170323 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: wwb6u5k1zto3e8saux4zfcacxj8t34t9 X-Rspamd-Queue-Id: 3FE2BA0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746170328-997182 X-HE-Meta: U2FsdGVkX19lt0n+XWwJTmqAg0uD+2S8qKPOxf53XR9hPjiNOrARMI6ow9X+bdqEhJYYfxjpurIp/zFbQOwbzysz3KPxI4o/A9miVBSNjdabny+JV1mG2f8MsuWKTao5/AX+rs25SAWpLOUXrUNP9dqxrspO5KLajV0avUpp2G6tyHHj28T+MRhcmEKeEqI5fT+X/0AkdCY+vD7HmGI7bEwVXIbTFQiLKhwJZxwdOApVM2kOFgddp7U+o5oKAwqW9z1AnKh0cu/ubb4gbXE3LmcQ/TjkDCeB/JuEWmB3mmS3CDveGo1MBz+cR2Fv+514JH3l2nyRetEZHeRSOxgwvCxahqrcNlu12kRZFo6ZlfkeOLYW4Px6lBVeeC/JeWm66PsnUkg1K0o3r+gOjWQkX0PWsseneoCwxYHk7ZioW8ppsoxgUbW6VCYfTSmYs1gHXG2u26qAhtPZQ6mtRW3RpuiAnUyw2BjjQQDnwk3jHIk4ziqI7lg8Dx3W49ktCgFTpY+Zmnd/FHvNXJgvU4gjXz2EXMc5moocx7N2MY1JYndWFHS1q7j12E+Q02quq2CKTK0MQ7BSd+4I9HBOjz8CZPSuNPQzdf0adb5bH4yUbtmIFF+i/A4U+odADpXNqTWfEozTS37q2lZE98aMqxkIgO9p6F43V5d9zdGAm/XwLbKKvAbCqk39sELmaniEo4z1ce+hyLgvaUORqkB/XTnrR934HMMaUAkbrYkv3hizd9rLqvstxyLnoQCyX30Fsj7bFBIz7/X+tTnIitWV/q3RmKhDvmvMbDGb0ENPE5CodJQ2eNig/85PeKA5xohgWbezmJeLmbekzQnNlnEHd2WMYoBvLwL3WQX3FSeikd90l39Laz6t5H14W1bWue6d4N3GpNYyxojR1YQ35UJpm6O3SX9fpbZEW7V4/fk2REz1Av2zRsn/gDkahL0NPYf9RsFKMxJ6rzt9/qxa2qc4s7j VG9BMX2J 7XvXqa7UT/fz5hjQ9nrYTsvvchA9eKxax/e0209ZpdIbKE/tnhI3ZMDAchP9QKoR1KrhQLnJQvV9V+pJMJk5NaYK86SzVmS3e3k7J9hVOaxdrDOIzTk1AheGaGUyq3IwbL8LnSlIeTX1Ba7OYcu8afD1dZFkuo9iDbLlBcFkuFeXUnim8Tcyrv0jQ6iZJ5EXqXzPCaoM2kk/cisTm6BioZUIL9tv26xQLKPiSfxIT049T+UeKWgiA0q89HcX2ntp5hTnKjQODCguk31ZadxAW3xi6vZK4i02/qidjRyTg5Dek1YPtGzjWslvwxMzSfhw6gL4hr2PZVvGCRJWkH7XurMdkBXBoqvh0cwVDB/nRCPRIZzvJd/IyFKZOl3sadAhYqejLqHvpnIGkIBBgjlTgWWoHnDy8Wp3lPXZrjAaGlEEz4ls= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.05.25 03:02, Baolin Wang wrote: > > > On 2025/4/30 21:24, Daniel Gomez wrote: >> On Wed, Apr 30, 2025 at 02:20:02PM +0100, Ville Syrjälä wrote: >>> On Wed, Apr 30, 2025 at 02:32:39PM +0800, Baolin Wang wrote: >>>> On 2025/4/30 01:44, Ville Syrjälä wrote: >>>>> On Thu, Nov 28, 2024 at 03:40:41PM +0800, Baolin Wang wrote: >>>>> Hi, >>>>> >>>>> This causes a huge regression in Intel iGPU texturing performance. >>>> >>>> Unfortunately, I don't have such platform to test it. >>>> >>>>> >>>>> I haven't had time to look at this in detail, but presumably the >>>>> problem is that we're no longer getting huge pages from our >>>>> private tmpfs mount (done in i915_gemfs_init()). >>>> >>>> IIUC, the i915 driver still limits the maximum write size to PAGE_SIZE >>>> in the shmem_pwrite(), >>> >>> pwrite is just one random way to write to objects, and probably >>> not something that's even used by current Mesa. >>> >>>> which prevents tmpfs from allocating large >>>> folios. As mentioned in the comments below, tmpfs like other file >>>> systems that support large folios, will allow getting a highest order >>>> hint based on the size of the write and fallocate paths, and then will >>>> attempt each allowable huge order. >>>> >>>> Therefore, I think the shmem_pwrite() function should be changed to >>>> remove the limitation that the write size cannot exceed PAGE_SIZE. >> >> To enable mTHP on tmpfs, the necessary knobs must first be enabled in sysfs >> as they are not enabled by default IIRC (only THP, PMD level). Ville, I >> see i915_gemfs the huge=within_size mount option is passed. Can you confirm >> if /sys/kernel/mm/transparent_hugepage/hugepages-*/enabled are also marked as >> 'always' when the regression is found? > > The tmpfs mount will not be controlled by > '/sys/kernel/mm/transparent_hugepage/hugepages-*Kb/enabled' (except for > the debugging options 'deny' and 'force'). Right, IIRC as requested by Willy, it should behave like other FSes where there is no control over the folio size to be used. -- Cheers, David / dhildenb