Re: netmem series needs some love and Acks from MM folks

[Pavel Begunkov <asml.silence@gmail.com>]

On 6/18/25 01:08, Byungchul Park wrote:
> On Tue, Jun 17, 2025 at 06:09:36PM +0200, David Hildenbrand wrote:
...>> 1) have a dedicated data-structure we will allocate alter dynamically.
>>
>> 2) Make it overlay "struct page" for now in a way that doesn't break things
>>
>> 3) Convert all users of "struct page" to the new data-structure
>>
>> Later, the memdesc data-structure will then actually come be allocated
>> dynamically, so "struct page" content will not apply anymore, and we can
>> shrink "struct page".
>>
>>
>> What I see in this patch is exactly 1) and 2).
>>
>> I am not 100% sure about existing "struct net_iov" and how that
>> interacts with "struct page" overlay. I suspects it's just a dynamically
>> allocated structure?
>>
>> Because this patch changes the layout of "struct net_iov", which is a
>> bit confusing at first sight?
> 
> The changes of the layout was asked by network folks, that was to split
> the struct net_iov fields to two, netmem_desc and net_iov specific ones.

That's right, and the moved fields should never be touched without
checking that it's a net_iov first. All of it will eventually converge
to netmem_desc without net_iov sticking out where it shouldn't, but my
personal preference would be to get this merged, as it's a good enough
base, and do the rest on top.

> How to organize struct net_iov further is up to the network folks, but
> I believe the current layout should be the first step.
-- 
Pavel Begunkov