From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71332C71157 for ; Wed, 18 Jun 2025 07:50:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C58426B0088; Wed, 18 Jun 2025 03:50:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C08AC6B0089; Wed, 18 Jun 2025 03:50:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF8216B008A; Wed, 18 Jun 2025 03:50:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9AA656B0088 for ; Wed, 18 Jun 2025 03:50:20 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6912D1D37D9 for ; Wed, 18 Jun 2025 07:50:20 +0000 (UTC) X-FDA: 83567748600.29.6973E5D Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf12.hostedemail.com (Postfix) with ESMTP id 64E3E40002 for ; Wed, 18 Jun 2025 07:50:18 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=J3LoleNR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750233018; a=rsa-sha256; cv=none; b=7Axpxxn1Dnx44GoCaMFa5vuwhooBwzSPHo9PMKDns+Q1pMibksY2ng6TUhdDCOWLuNE4fF PrGUBW2qVcigq9mCc+tthtN1NLKD66koYvjbMiLbzZKU6FGgSN7SnhVTMd6AjWciDHoqIW IdaqMQFlOc4VLzw5wwSoiRYMT1pYWNU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=J3LoleNR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750233018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ECKn4hQ4bwsuqfN+mIcN9gog+ud6vUM+tBu4MrCxvDU=; b=JrliwStfkm7hffx/b1jVxr5MVxo9OFNjsYqlAmmBzsIsNBPlBTgsiS6JFcEDDNBBUDLsPG Hq7MRq7v6QPm43+gkyWRv4F80uINXIzZsa4TXAeitEBU94eyDU5alAU6p8+RdqY4plj1t3 JQ1Pcto8Vzp7ZK3wXWS2jJPTlF6c5D4= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ad883afdf0cso1293694866b.0 for ; Wed, 18 Jun 2025 00:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750233017; x=1750837817; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ECKn4hQ4bwsuqfN+mIcN9gog+ud6vUM+tBu4MrCxvDU=; b=J3LoleNRZOMZgJpxXqxTyQbjXJVCkCRmLHGmbhkbWsjL3Wji/CsV+5/KdOEG5x1jo3 8KGNWdZ8uWBrzLwfllbQO7Bt4uExWoNHzIkf8BF0/3NGKacjhOW0IB8Y11NEbyiYog83 tpepqzvZ+ZawF1Frn3E18NdlJQUvfR0aVKCfV/S0t3H06DzzN9bVw9tx9I2rG+lisNk5 p2x9KHmKKxHVVQg0+0uMslnGPWcfLro8yk8G7YeGjEm3vf5VV1OwNJKfqncrZ84iULWN K+fdh6vKhbSi4g0NMlyZPQYuVdkyqlrDqcjekAgupXs18DC7Vwvj/fYajylIHi2O2UVx 344A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750233017; x=1750837817; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ECKn4hQ4bwsuqfN+mIcN9gog+ud6vUM+tBu4MrCxvDU=; b=YlA61YvXqRQqN6XL5jbMQZj6fOkUrSHsAj99lPJTi3Ff6Pjbr4MNUJ7F+cl5OKuqn+ 2OXueRFhPWGty5zD0k7dKbhQjmGscvcjZYxRg8uLeO8D2Hqe0UL/ZYoEo5h7Kg66paHd OjqsqIC9tsLUhFp8o02tRkZsSFR5ZOVSCe6HP+sJSLbEfwynm33T06hZ7dRj3MTHdaR0 j5ZNTh7tg09klGQ4rrY1oiaYXrTGdome+DlBf3fdzSZrEzcK4UW0t/v6qgCmB9QdDcEC ITQjnDOKWu2NXs4cS4t2BbGm7Lz+FgeV4hiLqSJTok236k9i9q1qzWYnvtE/9E3wQYHG gLmw== X-Forwarded-Encrypted: i=1; AJvYcCVLruGzVh4OjRfiJf/xJGsSL1xdQDflrfKkSDRTu/7b1la23KnnIfsJbVcL+4j3WgOei7jTohTg/A==@kvack.org X-Gm-Message-State: AOJu0Yxg+sM8vMcTNHEOdVBIRnqvr2Kgwt0mtK9eOBFodluovgjI7oUU PJgwRP7Xb10aOZ7ZXW81pn/mhREQlWw7ea9EgTIM3bU1lpNiHqKeGrnd X-Gm-Gg: ASbGnctgC8+dz+0hCA3m+QNPenh4vO+UMrdeYM6B4dUTLkrqOiiSrIO7+dCml2lnHNt H/9utwtaL7SFzUQE+HhRSjOOQJz8vGtW5Q8UxoFMJn+mdbES1MvIKSNTIrksHu4fwJnIDlLf5/8 kGhqnO9X3RyvfauOdmts5N/F4jtJW6x58u7zOJxNKu5A8dgWZDBpaQfR9wixvkVusY17QQOrNIM 1pHkXrvj3GGbh/lLPiBjYFd7E1cL05yggeNoKLiSCq60bWifSLIda/MmjeuNhHJ70VYoh5BZwuN /ZrVMDEb89Dfsbx2jIXvTSXmSHnJTpwj0cWvqYnx5lCxwFQGTTyhLeNdmWWjw3JxHkDUjk9do+4 = X-Google-Smtp-Source: AGHT+IGU4+U2g1i+YBxoe05CktY6r7Lz+Sv5ZqQdL+2ljUCgejgb3V2iXZawdXMuMofP/og+uhKFKw== X-Received: by 2002:a17:907:dab:b0:ad8:9428:6a3c with SMTP id a640c23a62f3a-adfad31ccc4mr1575311066b.11.1750233016473; Wed, 18 Jun 2025 00:50:16 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::2ef? ([2620:10d:c092:600::1:ae0d]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adec88ff1a1sm987202266b.89.2025.06.18.00.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 00:50:15 -0700 (PDT) Message-ID: <72e9f23c-58ca-49c3-baee-f76b91d093ff@gmail.com> Date: Wed, 18 Jun 2025 08:51:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: netmem series needs some love and Acks from MM folks To: Byungchul Park , David Hildenbrand Cc: Harry Yoo , Mina Almasry , willy@infradead.org, Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, ilias.apalodimas@linaro.org, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250609043225.77229-1-byungchul@sk.com> <20250609043225.77229-2-byungchul@sk.com> <20250609123255.18f14000@kernel.org> <20250610013001.GA65598@system.software.com> <20250611185542.118230c1@kernel.org> <20250613011305.GA18998@system.software.com> <129fe808-4285-48fe-95b6-00ea19bd87af@redhat.com> <20250618000840.GA23579@system.software.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250618000840.GA23579@system.software.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 64E3E40002 X-Stat-Signature: p8dd6eox6tsk14sh9xntkrgrhzbt9746 X-Rspam-User: X-HE-Tag: 1750233018-89119 X-HE-Meta: U2FsdGVkX19OSeBTmT0PNHgKK1GLHjB71UTcgRM7vs1Q4l56wyGzhB1g+9P/JTkaZ7p2Nr+XC2DHaFg2QBt2Zsj3tLoSO4N9xwU8nUPPEmjo/nwjipZLEcN98vSkEdvKl/5SPu1/wGJmif7zRk58YbxYqp4m/yjq4AWKUzsbMit86YCkU4sGkGSBDIjRJ6vVTtGgnV0Yje62HvoYuk2RtZjzTfyqW//PrKiozFbpDjRlqlJMewbDbHsxHrFkYC9gljXLpdQC7zJDzww+82sxrJ3tbRb2ZnvKYWED4laSZqS1fXi6Pq6QSVGOIfu3aKOKOCrM3NxKmFDfEQ5qApvtZE+t9pZMdoM/8/+7XjTf27YWQrlZqdWgHK5Oh+9a6nGvcdQt9LlREoTiOJVQ7Jt7EwHOqZvbrQBNm+65/vVImFSr4O1/5aLZE+3cpWVEsuPuDDI64nK6IdnnfvLivb/Fev7NXdTwdtGiN8bVhm2E4fZramfeb19NMLP/w/jKkEgpbp8oM96GdxCF644TbbEHBdHAD2UkrTRTG40pf24M3mVEn/lVnoF4VzvG3klDXgnqPjGomqrShlE9j/C28Tm20z+dGW/C+iGqoMw67CngozVZ6sOqgyUXkz8GdEDHx2O4KWnSn9X1jVwS/oNlmY4QCL739vUE9DidaNV8VHfyepnXeHaxLCY3sJISgF/bXykSaC7gmxxCs60K10ZHorfTm2Ng1bd2FfLoYma5RFmpQmKkACsoNPD50AmAr9GEVDCOI8OroyRt8FDDyfoKT/NW8uYm0WPQQ73YP91v6SACo/V4MCBqPwMHNWsTKyetdgQqjviVyro+eL76bKgCbc7BLlkc4ZW60nroF+oUyXUwNNZyGCsm5It8J2YCMEPnvVnPaxGcA86djj+A7PS75Ja65xKo09PThOtmAI9hdytLq9gpN5U/auDCSia6IS/iiq0yISIaPbl/kLQBoZclaD9 +EGXJm6N GoJJQyan2GFowbSRxlPQXbzQMK3BcMRg0SfRcNfdXqXTX7Fk4y2KqBEbO7rROtjZoAS+UdiIk1z2PEDkDm7MtgShVskwXhaKLUqNd2nd0niEQ3ndeFAlecr46GC/wgqT6naqeqBeu0OCmMTAvjECr9FFeimiyM2JBFR3wbW8mRCR02Z7eiZCS8qSWLoc0+FEL1WUPBqufIykYl1lCQouIA0izUiu4h1xcwuTN21DYj9xGM2gbrL7x9ZLWfX2JEuAPoaVCkL4Dhcy8dI/tsvBjk7ZwoXCdpoPgUwpmVS/K1e2D8yZtqZWZlcWOffQu+ezzLHC1VWuLd2lhOP+o3BQxHqwMjlCqXcGKz++9brugqzroIRej2+954fFEFCjzWywCKfYZJQRVnaq0cwB9wpYzRw4MnZQAbrm08j+IZh2bWLGtiRLPPm3dXqLfm3KoBv1SMIhI1Tx0/OHtX57pvGRLdPGdTSr/gJf/5sO9VikeKD20XMkXSLSm/oUiNs7BFdtm5vO3SMXz0LzdWxpfsR3daTPIXCv1OoGvh56F8+GSUXrm1scV9IPVk353VA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/18/25 01:08, Byungchul Park wrote: > On Tue, Jun 17, 2025 at 06:09:36PM +0200, David Hildenbrand wrote: ...>> 1) have a dedicated data-structure we will allocate alter dynamically. >> >> 2) Make it overlay "struct page" for now in a way that doesn't break things >> >> 3) Convert all users of "struct page" to the new data-structure >> >> Later, the memdesc data-structure will then actually come be allocated >> dynamically, so "struct page" content will not apply anymore, and we can >> shrink "struct page". >> >> >> What I see in this patch is exactly 1) and 2). >> >> I am not 100% sure about existing "struct net_iov" and how that >> interacts with "struct page" overlay. I suspects it's just a dynamically >> allocated structure? >> >> Because this patch changes the layout of "struct net_iov", which is a >> bit confusing at first sight? > > The changes of the layout was asked by network folks, that was to split > the struct net_iov fields to two, netmem_desc and net_iov specific ones. That's right, and the moved fields should never be touched without checking that it's a net_iov first. All of it will eventually converge to netmem_desc without net_iov sticking out where it shouldn't, but my personal preference would be to get this merged, as it's a good enough base, and do the rest on top. > How to organize struct net_iov further is up to the network folks, but > I believe the current layout should be the first step. -- Pavel Begunkov