From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 373C7EB64D9 for ; Tue, 27 Jun 2023 16:49:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CEA48D0002; Tue, 27 Jun 2023 12:49:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57EC88D0001; Tue, 27 Jun 2023 12:49:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41F4E8D0002; Tue, 27 Jun 2023 12:49:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 30E938D0001 for ; Tue, 27 Jun 2023 12:49:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F3346801D5 for ; Tue, 27 Jun 2023 16:49:31 +0000 (UTC) X-FDA: 80949113742.21.9A71654 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf24.hostedemail.com (Postfix) with ESMTP id DC478180021 for ; Tue, 27 Jun 2023 16:49:29 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="cGOUc/1T"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687884570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KIF14ZRhhNhvP7s/dCFS3UgnLk5r7liSptBE93jJiP0=; b=1aLwNI8sBiy7oCHns6f58Hvprdo/a4IEhIpZC4jpg5uFrUiZFQD9aHGt5JI/nlv9Hws5wR qAC4GD+q2ECXHGXyfg7cXhfSeGHaksxA7EiAB8FU/ddDZOLLt0HIJOC/iB6QWN0CEYvrcs U1YQeO2BtDVhi9OzJa7kxKAhYRxR+hY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="cGOUc/1T"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687884570; a=rsa-sha256; cv=none; b=7fjDa6wyZQvEkW++iNn2YDxflKDxgbx+Dd1k/cr9JWbUwksznHcZ3QKDR2aqCDO5o78tYu KiCnQ1bQ7cUqoGCqeZ+zYt2IujhVfe+MfL4kues+ZuCGENy0TJ7qqC8+fvzB7ARtyo5L7Q ID5RgPS/qojnV6hgApWBBQtf9XyT6Ww= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-986d8332f50so601209466b.0 for ; Tue, 27 Jun 2023 09:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687884568; x=1690476568; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KIF14ZRhhNhvP7s/dCFS3UgnLk5r7liSptBE93jJiP0=; b=cGOUc/1TLhs56qcwE8WN7OTKbFjZfn6zPmdhM3EoLJkyaH3Ec0Ix8CnjESLMLXoDmB F3S1It9z7AcZIsJ3zMuUkojpZWjtzvtVGAeGuaXk8j/t5Lq4et9sj8oYUrFLrjKO0TMe nT/HhBjuV2PgMvPFVrddicOE7kbubj9lkP6otJoSuKnexHCDSrb1ubjQadXLjN87kgl7 scPhMGhS+sIswFPlRDUzftwTwETjkql2qJLI1HTgAjVTQm2hyWxAgL1+/eo/O26NTpn0 Urt2Nnuiz6p1jTLsxQB8sAII7VPEqyj6Zxxz5xC8jnUY/6Rv49Q8ninI8WcJGE4o+AFk Xaaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687884568; x=1690476568; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KIF14ZRhhNhvP7s/dCFS3UgnLk5r7liSptBE93jJiP0=; b=jYpwZHy04h6W09vi0TQqp8OXFyaZzO++NdZErfhB0J0DJhDJCV3NTs5WOEdq0n3wCv PE/TDMlkaX1KFNcWYAonbxyw/XCnyQ4rSFU5amBjdLVAgngTh3JAiu8mx00HJlqY3G0E gMuPgD85U76nWRWGJHn0pK3/9EKd7+voCVKy/o6xgds/Kyzcoi8S/PCxxRhraJJfWR8v D164ysHD18T5gP5rHAnj6ZygtJ5M7jettaAy9aHssnv7g6DpiJvWSF9gJt+/ZatKTj1D WLWvuazTbzKWIlMhX307W5V25ZwU5PSYeG0qFzvspkzs8CrSyXpGe+06ZD2A2+iJoVxV Zd0w== X-Gm-Message-State: AC+VfDzB8yJAy3Ca3FaDZPic+hR7CCo53RBH3LBAjNCFSdj/3JzKOx1/ 7gy5ozl6Rqed9LsRhr5160U= X-Google-Smtp-Source: ACHHUZ7FfnMKUnb75ZuZJnHVFM+fgisgQVLRYsjvmlbWG4AbNckpTrSwdsrlHBKUg/BItw73XkN+ZQ== X-Received: by 2002:a17:907:c0a:b0:96f:d345:d0f7 with SMTP id ga10-20020a1709070c0a00b0096fd345d0f7mr28695988ejc.62.1687884568091; Tue, 27 Jun 2023 09:49:28 -0700 (PDT) Received: from [192.168.0.107] ([77.126.161.239]) by smtp.gmail.com with ESMTPSA id i26-20020a1709063c5a00b00991d54db2acsm2303686ejg.44.2023.06.27.09.49.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 09:49:27 -0700 (PDT) Message-ID: <7337a904-231d-201d-397a-7bbe7cae929f@gmail.com> Date: Tue, 27 Jun 2023 19:49:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() Content-Language: en-US To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> <776549.1687167344@warthog.procyon.org.uk> From: Tariq Toukan In-Reply-To: <776549.1687167344@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: DC478180021 X-Stat-Signature: wyu4a1io6rkajc9f5deu84d4t9cy4u4z X-Rspam-User: X-HE-Tag: 1687884569-526035 X-HE-Meta: U2FsdGVkX18wuvYlDvo9LFaOwHBFqZG7Nm/fInX5pMH3smB3JyK6JbTCSMwSnAAXhvTHyH51Hfwv989krUnuPtTfcCvSLO/yFToKLzlGafQ7DNlXguftnROqtsahrmwEroWJkSEfnAqFD/jqOsyRioZgo1iskvVGfWA7FXTXgCq+cB5IAVIHHWmIxU5lP9oGSmR7FI8g7DsJRjSvUrQ0VpELEXvs12/56humuZtRXCK1pyZ8hLdNZHDxyFDzPVTVTurqvEwYAklSecvw3r98AKPeIpmN4YBBlk8e22rACpQeyTJNrskqJZmXk4l27HvuyW0Ca0Ks2bvbl801xzFePGqlJ0ySFlXdjTrmFxeC5VZyMeGn+uRKdDHYC6QOKTxNfTSnoBd1AMS/oxSz+1BArq+v1A9sWPRTWn8v7jEQRGsFCmRsnfNhc/H06WP7cG3t6a3lEi/Jqky/R8jnNhQrDaQC+szKvCcdl8/CZOZ81dRMx7leaS1cy4hg2LyW5MFfaVb17foLz7M0gzDN1tTsL4FVegqP0mHNB7tsixRF9pYMTcxTpHTQWCfR2h6s3VSSgpil7I0LG5IavgYJgrF2H1t1YlsGGmLwwg94ik4prPT6s406yy+K7C4HmADJbA78jJChspiW86YbpJ6m+O0l8JP+MVbnq6EV0cC+N+Cw6r+ehWw/STUy2LCWBSphL+I0MBenJoVnDJtbV5PKLBvez4+R1HYDKYElkM7nwPO8T1q6bRpyz9RrGoellalnjjSgyx0mgLLPkjmgolX6LAQPjN0yF7RG/lxFLkuspSb26S+x2S01Uj5ZYFnssT5QeR9jPIIFpFWjw0cSwH8u17ETJRkaAyttoo9N0w+h1rQkZbEa4A63PcU/K3vh5F11De7aFhB64c+ARXFY58OY/aNPpyBkqnChU16wlhW4e5/2jdnCM0PDYZadxq6Av6Oaiuilv7TS4GJ/1vs6o6APaWe BBBsh2sW EEC31H1szcQ4jQAjjqjMFzwMD3umZFM4MXtZZC+cVHq8HVkkx25pKhS9p+0KRmiizs5Jn6oJIx6EZkQxw01cs09kZCYG5N8z0q+wG2JkjWz+Xm/5jTg8VVLx/tvZB/CP7TDTbH91j3UID7o6FW7f3BSaF/Lgt8kSDWZAD1vWXdGCVphaihUbpIFMIXLNaYf4iDS+K6Q2o/tv4MvEj7MRqUV0sL9BWjmRBkq7+piMjLsIueSVVc+ej1SNZByrPFEnFyBl+oQ/ig7Xgg3NbilEn/f5QGxgq1MVFuOfLGwWncrKeVdMsOVFjheEK4hOgNLuqpiAE6CyabR+zUOvMK5pjaf9HHUnp5x92AokxTy2vOCJQCF2kYw7epDCSLm2bj6KKba9+6oNZy5MNVqKR5Pum3fScFGSP1Xq6UgaNCP62NXtzs2cFHcC0Ec7N4GZdLCX6kiJ+tzb1i1ukK5SFdZ/RI76lR+yo14l+ucDQ9kxwklvHVwAJLw1vY+uPehEtd8zOf6VZkEC82BhcYfLxRLgdUoPWjJ4b//I951TN4a6SSf53bj2OP/zHyByt2jNr2b0Ug3aQZUZFh6KPzGvObZONTmwWwZk+juxBa4EArEQ3WWIuGby61IQwAu/qtfjWr1U2f63rZBg3aKfYAvptI9yB/iBN2wqysD/daXZ4GVxsnNxkloYLEa8Xphq7U09QzltA3l8DGM+/AYtO/CcJskOL/awlxj5HFH2wJ/O7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19/06/2023 12:35, David Howells wrote: > Tariq Toukan wrote: > >> Any other debug information that we can provide to progress with the analysis? > > Can you see if the problem still happens on this branch of my tree? > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=sendpage-3-frag > > It eases the restriction that the WARN_ON is warning about by (in patch 1[*]) > copying slab objects into page fragments. > > David > > [*] "net: Copy slab data for sendmsg(MSG_SPLICE_PAGES)" > Hi David, Unfortunately, it still happens: ------------[ cut here ]------------ WARNING: CPU: 2 PID: 93427 at net/core/skbuff.c:7013 skb_splice_from_iter+0x299/0x550 Modules linked in: bonding nf_tables vfio_pci ip_gre geneve ib_umad rdma_ucm ipip tunnel4 ip6_gre gre ip6_tunnel tunnel6 ib_ipoib mlx5_vfio_pci vfio_pci_core mlx5_ib ib_uverbs mlx5_core sch_mqprio sch_mqprio_lib sch_netem iptable_raw vfio_iommu_type1 vfio openvswitch nsh rpcrdma ib_iser libiscsi scsi_transport_iscsi rdma_cm iw_cm ib_cm ib_core xt_conntrack xt_MASQUERADE nf_conntrack_netlink nfnetlink xt_addrtype iptable_nat nf_nat br_netfilter rpcsec_gss_krb5 auth_rpcgss oid_registry overlay zram zsmalloc fuse [last unloaded: nf_tables] CPU: 2 PID: 93427 Comm: nginx_openssl_3 Tainted: G W 6.4.0-rc6_net_next_mlx5_9b6e6b6 #1 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014 RIP: 0010:skb_splice_from_iter+0x299/0x550 Code: 49 8b 57 08 f6 c2 01 0f 85 89 01 00 00 8b 0d 22 b3 4a 01 4c 89 fa 85 c9 0f 8f 81 01 00 00 48 8b 12 80 e6 02 0f 84 a3 00 00 00 <0f> 0b 48 c7 c1 fb ff ff ff 44 01 6b 70 44 01 6b 74 44 01 ab d0 00 RSP: 0018:ffff8882a16d3a80 EFLAGS: 00010246 RAX: 0000000000000000 RBX: ffff88821a89ee00 RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffffea0004c2cfc0 RDI: ffff88821a89ee00 RBP: 0000000000000f34 R08: 0000000000000011 R09: 0000000000000f34 R10: 0000000000000000 R11: 000000000000000d R12: 0000000000000004 R13: 0000000000002d0f R14: 0000000000000f34 R15: ffffea0004c2d000 FS: 00007f5c383eb740(0000) GS:ffff88885f880000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000002ea5000 CR3: 0000000264ffe006 CR4: 0000000000370ea0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: ? __warn+0x79/0x120 ? skb_splice_from_iter+0x299/0x550 ? report_bug+0x17c/0x190 ? handle_bug+0x3c/0x60 ? exc_invalid_op+0x14/0x70 ? asm_exc_invalid_op+0x16/0x20 ? skb_splice_from_iter+0x299/0x550 tcp_sendmsg_locked+0x375/0xd00 tls_push_sg+0xdd/0x230 tls_push_data+0x6de/0xb00 tls_device_sendmsg+0x7a/0xd0 sock_sendmsg+0x38/0x60 sock_write_iter+0x97/0x100 vfs_write+0x2df/0x380 ksys_write+0xa7/0xe0 do_syscall_64+0x3d/0x90 entry_SYSCALL_64_after_hwframe+0x46/0xb0 RIP: 0033:0x7f5c381018b7 Code: 0f 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 RSP: 002b:00007ffee9750848 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 0000000000004000 RCX: 00007f5c381018b7 RDX: 0000000000004000 RSI: 0000000002ea2dc0 RDI: 00000000000000d1 RBP: 0000000001d1bbe0 R08: 00007ffee974ffe0 R09: 0000000000000001 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000002ea2dc0 R13: 0000000001d2a7e0 R14: 0000000000004000 R15: 0000000000004000 ---[ end trace 0000000000000000 ]---