From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30D2EC52D7B for ; Fri, 9 Aug 2024 01:57:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F3F66B0095; Thu, 8 Aug 2024 21:57:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A4636B0098; Thu, 8 Aug 2024 21:57:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86C946B009A; Thu, 8 Aug 2024 21:57:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 680696B0095 for ; Thu, 8 Aug 2024 21:57:54 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2C5B4405A4 for ; Fri, 9 Aug 2024 01:57:54 +0000 (UTC) X-FDA: 82431046068.15.64E5C68 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf13.hostedemail.com (Postfix) with ESMTP id 35E572000B for ; Fri, 9 Aug 2024 01:57:52 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kj9aZAPe; spf=pass (imf13.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723168639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e3hWooo6TlTCb+z5/eTYrLth+2Cm0fnj2Bq11rJlINA=; b=LuHGcq333db2GGuzmS7JxvmCZKLAYrH5ZZ7HHUl/lI7dZMK2pfFDkKWWr/7kIlvHUTRFFl 2THcUMo4+a+l0aEwZjSJoSmtYzS00/hHHIlXMphTo01t9PVaBZesjn4i5A5maZAk9K9os7 LLvZSRLSoR+EH3TUzx5GyvUVNwOlXOE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kj9aZAPe; spf=pass (imf13.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723168639; a=rsa-sha256; cv=none; b=7B29Gs+5nQ+QQdPbjN/jcMjTmKxxxvlzSlcz1qvkj80d4JofS7+GJBaMNcgTLP46E2IK8/ fB+Bx8mrCVIZGjRXPoDCRvCdgriZGfIXl7c8aHm8XkTwTbLT0w7stqks3ri5tjNovTUzTR bDu/k/GkIsjdujSYBruZ+ZFdEHaWU+A= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1fc5549788eso15494405ad.1 for ; Thu, 08 Aug 2024 18:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723168671; x=1723773471; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e3hWooo6TlTCb+z5/eTYrLth+2Cm0fnj2Bq11rJlINA=; b=kj9aZAPe8PI2ENrK7VwWxqgHwqsql+/MG2MUF7G+hUSBFcoIzAYPC3nPEg5AUMuhqq EYfKzbVbi3nDaBDiFTVFnVXbYaKMKZn/lX933IVj3cNUdenAmQmu3FpFZvjcRZ0xHWBb IBhd43+H4L96XSfz5dHXSUvDxwuQFgKRyzyK0rtLmfBZL60Mj7lkrrgiXErp6boNQDeD ZwNb/ZN0rNUomzX3AO+2DMq+mybwMKlbQ2dOdTEWli+T8WMOfqmd8FY+5wuUpv7+JuFN OQbZvD3VldEHjtAdNULLtgKJAh9w5WYA0/SAVn6eApTZAWEZFFDf3XS7/Q1YoS/jswbo MEaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723168671; x=1723773471; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e3hWooo6TlTCb+z5/eTYrLth+2Cm0fnj2Bq11rJlINA=; b=OFDbZhjk+DArqFNcN7I/289y0BEVMnjzSZ9zggP1faiddraoyFIFLNHyxkgXQrqwzF xQPng/Ip1OHKWMldlG72FTiTpKkO8xLqA6/5SgCHE1za1nrClxI2lHfSEqXqzpp/4aBH NEpAeVGc5C+Cgrkx32OQOKu3eR2j84UDAVu5T63YzXhuHKsMYLfiKLz43RFt5AUthZ0q /7EmSdw/onXYYqnfep2WJGmy4Ssn8WUfugCh1NoHuNkDG7ama16+3BZobP6nQo8VSMe3 0GojeXmsPHpG4RXIWgyf5UUfKOlID609OguJnB0r3/cpe6tpH64hXWCUicGm4vwaHcHO Xp9w== X-Forwarded-Encrypted: i=1; AJvYcCUGxSZ//WlaFQC66nOMYBOmwiM6IULIfEdsIHNd2aADlP3mHjkXbMKaBrw14flQaPFz6xd4yr76pAQP6vLqSgl9/QA= X-Gm-Message-State: AOJu0YyU3qylk3PauOJ0R4Q6T9dc0YneHea1cUfpOR6HB7MsC8YKsb2Q b7PEMIWi6rR3DMRptu+WZ+Id5UjCN5DTMzkjRoSJrFnQ6m4Yszsr X-Google-Smtp-Source: AGHT+IEHZcxbJyvEDWpe9FMJ03OibGbtIVlG0Rvh/bzNg467SQswLOfXy+AVc6vJX5wHlo0fkYgx0A== X-Received: by 2002:a17:902:ea09:b0:1fd:6c5b:afd4 with SMTP id d9443c01a7336-2009535c4c9mr51846265ad.64.1723168670804; Thu, 08 Aug 2024 18:57:50 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2007728d837sm59945385ad.84.2024.08.08.18.57.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Aug 2024 18:57:50 -0700 (PDT) Message-ID: <73d3e43c-cdf0-4ed1-9df9-fc0b8069db39@gmail.com> Date: Fri, 9 Aug 2024 09:57:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/22] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool To: Vishal Moola Cc: alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com References: <20240729112534.3416707-1-alexs@kernel.org> <20240729112534.3416707-2-alexs@kernel.org> <66ad2ad7.170a0220.3a8e93.6a32@mx.google.com> <66b50cbf.170a0220.295f9d.891b@mx.google.com> Content-Language: en-US From: Alex Shi In-Reply-To: <66b50cbf.170a0220.295f9d.891b@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 35E572000B X-Stat-Signature: mrto8dpkebk9uw6anqcc39n19nygwmp4 X-HE-Tag: 1723168672-151964 X-HE-Meta: U2FsdGVkX1/koZIcSqxfk0ZNUFkOvjoNJ/4fFKACzgqfsH0nuCLa178Aag9AOr9LbRzr+E8d/bFtolvWgYkCWHqtTf2eJ9UPhFYSgg3a/yV4IjcaY8BlZ8MkluUMN5OWj4mHcRoiSCpbwbgCt3Y3vqSrFTaGlV2LHx1E3q7OpOKZAlnn/sYDOcDR71vgfTV99XfvvS6R1Tnqee3jZA6x/jcLXeZad3VFi74LK6ssh8VRwD4qazd1GdaOL1FvNsKrnkMycu5gxXfUMtbtUuIKohmP6rm8gtTVtd54KvSCh08uS556wViVfoiwTJsswxwkYkx21xwSJFXpUedRdXrPdm3YPe+eBIDsjrqk59s9SbQh4cPAuCL8FL8so4m/XOWxAR+hN+pmW4Jw4vaLtgiNqJSUxcdRDMs3602kdQiI5qhRWOgg7sFXkVwd7cevYSgdhG8+Bf5OhSfKV5mPmWLhHQ2zQ5g9zrYtucefbYEPrsWMtSwcCxEN/O/MC4eNIb0RoouKtKYm5z8Hziq+46cVQbNm2nFX3/GcCcZvRFecBtxncs9ETYZdefIjVHjnpm24zEuwNBN3SxqtpCzff2DjIQWpqRlfQuTOdB2VrskI65sspK8XU/MRktJJUfKZ+gx39RcV4D2lZs5HU0J1GWzpc8KyWSwR3Dsm0KLVgexes9qztQcPPdOS+1cduDa3mt4fuMPR5UkHntrUWChpuOSEq8k184IdwlBbHmY5oVsPVPJtXOk24d+iDYKRp2woWMqDhfTvk2PbnjhuvIKDuQf9JYtGrYNF1pSVMFXyZEitbJj44c3PrB5LXfj/JUtenFtzDkSw4V7ylzOm+Jdl4n1sH1YnYqXhBCQ5DzdV7Teb3m3dULv0kxyNFF5L7Rx2jnIaul8944do8MMaoEGEvSeyQcGneK/8gTs0XSBHSsoPL6S8Z5l7F3Gei4a9XB+peJOn/O2wKeLwd0gfDxK7thM r5lYlatP 14V8Pmh9F2HAwYPRpyrzz51A41GYyIMNuj7MwEL7suj2Ar+mLIuQFe+X6SSUVWqefKe1NLhBjjI5GqFT39ZSV6FfpFE/P4UN9fWX7QeuA3zjJOckpwTFQBH2EuLK9qvXy+a5gTiWpW/qNNcNJfWeWdMJKGgOwq7gxFjLUprFftAA82X7nSFEIrpDp2NOp8x1U0VyH6VoCGonrn/HtkZXREUUosCgAcudE2geMLYtoRD3E5q9ffnQM+pWbW2aci2sWLYL8XFZk4zB+rw2bgut0uuteVJDHCbPS3j4A9W72kR99tHTXfhHzujiPiGykJXw6roj924T/zR/BYrRLLz2wZZu3UPiVUqkgjrK3r023TuxhmJxFgCx1kOcyjNyi4THMknNBEX1U9bW291bRJZEVF9IMDTe7wfPBS6QpTxNe7fnI5eyvkZPPElQg47/1dRbiBZtR X-Bogosity: Ham, tests=bogofilter, spamicity=0.001696, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/9/24 2:21 AM, Vishal Moola wrote: >> So I wrapped them carefully in zpdesc series functions in zpdesc.h file. >> They should be easy replaced when we use memdescs in the future. Could we keep them >> a while, or ? > IMO, Its alright to keep both pages and folios due to the size reduction. > However if we do keep both, it should be clearer that we Want zpdescs to > be order-0 pages, and the only reason we have folios is that > compound_head() size reduction (and nothing more). I think a comment by > the zpdesc_folio() macro will suffice. Right, will add some comments for this. Thanks!