From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69F58C76196 for ; Mon, 3 Apr 2023 07:56:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0574E6B0072; Mon, 3 Apr 2023 03:56:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F23B56B0074; Mon, 3 Apr 2023 03:56:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9CC16B0075; Mon, 3 Apr 2023 03:56:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C81A66B0072 for ; Mon, 3 Apr 2023 03:56:58 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9D56B1C5C61 for ; Mon, 3 Apr 2023 07:56:58 +0000 (UTC) X-FDA: 80639323716.18.9885E73 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 753D318000A for ; Mon, 3 Apr 2023 07:56:56 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=inPXZadI; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680508616; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NzHpZ5WAiQYV9j8cFvgWd2yh5/Eu+1K2MnoYxqZ9t0M=; b=hD/buhk57Fk4bWWmm/LH/54t1dWWRqSZZKQDYDlTVkd30uniYMQvAae0DZMW430uWuhBhg IAyRrrBlsp6s3HZ8ihsnq2xcMYZbK6Vv/NKCNjA1MeF6LhWcc1heqVVcWcOylNWOdBAQ5t vganW4R6ey9PPWcGGkIzQ/BjSe+4ypI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=inPXZadI; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680508616; a=rsa-sha256; cv=none; b=xcMZPoLmkga/nruCkpNsyIk+OtIrEdmqpnsCBnfaEDMh1tOggfEpiVOjZCqN4MJEmYBT7M Emt5cX8hSS84HUparAuGwWGdc82J4gJlKFRyBttBnsfxS3yV65mk+XSchB6CKfXstZM442 JfJDgqjNVbLpbFyRoQqt6h5BbHkyrOA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680508615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NzHpZ5WAiQYV9j8cFvgWd2yh5/Eu+1K2MnoYxqZ9t0M=; b=inPXZadILE8ZIhWhM+KSDakQ8NSjVf9PUNsQ5cLxeE+kXkJU3Wb4r9uuRrHwv437dW6nGs JrR0VxO4Ljd/y4CfI5Nai+QhuTd602SUIXbEY7j5rIvUUb+wo2CqZWt0VoS+b6Ary7UjOn dwmSZfa5KjH5xgQj4zXM5Am1Wvgc2RU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-JtmppJGUOtSf2Oy-khHuXw-1; Mon, 03 Apr 2023 03:56:54 -0400 X-MC-Unique: JtmppJGUOtSf2Oy-khHuXw-1 Received: by mail-wm1-f71.google.com with SMTP id k25-20020a05600c1c9900b003ef79f2c207so8592103wms.5 for ; Mon, 03 Apr 2023 00:56:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680508613; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NzHpZ5WAiQYV9j8cFvgWd2yh5/Eu+1K2MnoYxqZ9t0M=; b=gQ06Wyv9mBMbTpU31SAtuQNzGhsds5wkJfabG/yil2pzyfEjltM1cE694KodfZ2nWX XgdSTcAM0I1M4WDY3PVVQiNgtbZtTZeU1qS7GahEecirdSb9J+Z4yv/hOuKWlPjmTWd+ ko2bizMuH1D1/qM9AKcmWB9O/BpM8Kjw08WP5GycR7crSTGBX+Yr+RIH5ZBw+1Bj5Hbt ukA9WH88h5+7JVW4Ap2SgVmDrMLyw54SwsbU1b3I9+pikB4YrrsXuZQh/vdjtqa+n98x jPiMpr7nbYGAVHcSNpOeR0kKfog4rwX70lNYI8rmLGzQAJpLXkJiHpS0XaUCjXEtkLcP 7S4A== X-Gm-Message-State: AAQBX9dQVuTum5khmSM6nQnLlbSTqXUcNfuujASKTryxbWEbCKN9PNWm zT0X4WxmKOJr55EUoTTTLcGd0BHq5YHBlVQTn5S07BiJsjnqLXLw5Pd8md5hQetqciM5KFRpQM3 wBpPbl8SPk2g= X-Received: by 2002:a5d:5742:0:b0:2d0:c37a:5ebd with SMTP id q2-20020a5d5742000000b002d0c37a5ebdmr25774647wrw.64.1680508613640; Mon, 03 Apr 2023 00:56:53 -0700 (PDT) X-Google-Smtp-Source: AKy350byxxRpdTK6BbJbot7lH5iAmTTcmMRSXk6dbIlT+FfyplV1kxbX23F9ngOslpl1pXo/s5CKkQ== X-Received: by 2002:a5d:5742:0:b0:2d0:c37a:5ebd with SMTP id q2-20020a5d5742000000b002d0c37a5ebdmr25774630wrw.64.1680508613362; Mon, 03 Apr 2023 00:56:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:5e00:8e78:71f3:6243:77f0? (p200300cbc7025e008e7871f3624377f0.dip0.t-ipconnect.de. [2003:cb:c702:5e00:8e78:71f3:6243:77f0]) by smtp.gmail.com with ESMTPSA id t17-20020adff611000000b002c5a790e959sm9044849wrp.19.2023.04.03.00.56.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 00:56:53 -0700 (PDT) Message-ID: <73e9d113-0418-8a69-83eb-935be531e9e0@redhat.com> Date: Mon, 3 Apr 2023 09:56:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 11/29] selftests/mm: Drop test_uffdio_zeropage_eexist To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , Andrea Arcangeli , Axel Rasmussen , Mike Kravetz , Leonardo Bras Soares Passos , Mike Rapoport , Nadav Amit References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160717.3107010-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230330160717.3107010-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 753D318000A X-Stat-Signature: phw9x94m9nxg1gyan4jow1ebfauebwc3 X-HE-Tag: 1680508616-273441 X-HE-Meta: U2FsdGVkX19tAKC0yE+rF14k665gbPiSx1UWGt9hjy3oUwSAnJ0GKeEP5ZjpP/QXB8w4k1IoDcak2Ejn6JcH3onUXTqEdaro6PsBXpAcKGXPRakSJPLOStLAULBB8OHPKFn9dN3Hzmv9Y44Rj5iYbQ63+Hk02CAUfAWouEJtB3UJAoLPUMyve4EmNBkIdpoe9XsiYfROvM0Db3FrZsIck+dxUFCHBW2ez1CliL89A4zoiDfpwTIhhlwKDru4+IWbHfks/TPF8w9pJAE/2RoYD6nsCSUBi3Lt+ztRPVQDec0LoA2qpRgVKYd/8A8S4ZACGUCCKqaMHhvWpFyzDdO4QFmD1AQW9f/WNiIIX1wF1LJIAOwRy7lyYkjae5Ee3edF3Hh+arEv+UCbRNu/+cpNonuIo2mBOBaBvH1CRTJ+OdR0inX7Qky84f2Ljdq+nwd3l7pKXo44Fu4yktv4iVhddtmX8n0THRZdW18DtZN1BZEVqvx1IFawnTaY6NE1JvRFY7XSzNfbVqTvoOh9tA5V249vDbMdFXV3/1efyuF8LdJACF+Q8hojcwvu+KkAmbm8tc4wetbToYFgUCqLjpXY7g/sHqJyt4gQ2jc+zzatqACDhk+yGwajP5okDdq2SYGykjVVZMC8kbKfQbndT7qDWzvhj+/Bg4svzlue4nvEd7/2IdcGDa1oIz0DheegrDufzd85Yn1Yv1CgoHyJ/Wh0Zu2fpB/SPioN1kdohk9YIwP2DnlANRM5J5UCjdcz2JP1inAgbGb3dpR8PqKNJuP5onMhnWMv4zwE3j2SyG9Xf5mN7mcLYJP66p04AzAt/Guqw3ZMPAdj3LCVhRrZ5D9I0FqIiwj3i529ZcF46iT9jKz90KzI0abJIxS3BMplcCFXi+kjBmgOGA3ITwl/4UAxAMKvu9Uhqhy/A++747kjdXwlmb3TT4bS+192TMF5MKA1Otm+1RU4VVYkn+uExHC Z+yFXJFj e6+c2B7h7cMTUEekn95N+cRyUkxauQx7f8dzBYY6MRRy7eOHISrNluhmVWqGNAZjDytrEgMsohF+6sm4JThqabTNkfFVNv+lmVG7KDbXTfIZlrtN0kx3h4rgxJbVWqHrQPgGUqOKXyt5ypKiNRUPIQnkhFNGlOfDyptAjh8q0LbGMrAW3sK/Pto6L5PYZ5LCDqVae9G0DG6AYPbApzL7dK4jbAC+EIdPWoy0hpUo4cWGZKGu866XkK2Ddh5+7Zy5ukF0qY13YjHa5RhkMCoHNxNMORmTLrqQUT9Ci3MtoD3fqk0FrXONYgaPdODSi0XELJrJgp/KzAoXAtIQhx4WImq4vaGOuwgA5maDJXz+oAmhuWKiCy5d7Eg8+LULvssR66TC/nmMmmTZQmyg6MO/ShCI4Eu7FVIJGnbPMaWZd2NljQ/Mpf3ucVCQ8NG6zIRm4t9mDOFysurVNoMW/o59JX2rm0oyq2KyZq88QMyarj++tQKV6UCZ8ryj3URsthUv/bblpJ5B3a+//JtQCVUqfyQFdrHtU4caeK7ZZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.03.23 18:07, Peter Xu wrote: > The idea was trying to flip this var in the alarm handler from time to time > to test -EEXIST of UFFDIO_ZEROPAGE, but firstly it's only used in the > zeropage test so probably only used once, meanwhile we passed > "retry==false" so it'll never got tested anyway. > > Drop both sides so we always test UFFDIO_ZEROPAGE retries if has_zeropage > is set (!hugetlb). > > One more thing to do is doing UFFDIO_REGISTER for the alias buffer too, > because otherwise the test won't even pass! We were just lucky that this > test never really got ran at all. > > Signed-off-by: Peter Xu > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb