From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918B9C47DB3 for ; Wed, 31 Jan 2024 14:29:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 049016B00A3; Wed, 31 Jan 2024 09:29:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F13F36B00A4; Wed, 31 Jan 2024 09:29:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D40546B00A5; Wed, 31 Jan 2024 09:29:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD8C26B00A3 for ; Wed, 31 Jan 2024 09:29:54 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 89380140CBB for ; Wed, 31 Jan 2024 14:29:54 +0000 (UTC) X-FDA: 81739840308.30.C6D2288 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 4A78FA0008 for ; Wed, 31 Jan 2024 14:29:52 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MO4S90h8; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706711392; a=rsa-sha256; cv=none; b=I3CZQ0eQ0z+2e7c3ry9UlbWM/hVQkZ9azcmwvuajIW0a9JbOjI3qGRPLlTTWHWHieDZQpK SOBKSQFMgTqFJeYbYhIMzReEUoODsD/yJ6P/8arRx6s+oY+qIUxbheDlxLDYIX7qUzJTtL ciB1AmCEb7HlATnI6u+EuSUlHU3zwGU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MO4S90h8; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706711392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZZ8b65xFaoLyifj6soTcCK4V3mFrLiPMpU7F9cu2+Zw=; b=wtXxH57JRoitoXvE6faWEEKPyAKR/EgURsWL9zx2Revu1RlJTfyQ0n7yCN22O2dVaaELnX eqsGydIdTOzIfJkE420VFU+vQDV1l4+SID5LMp7kznjl43AA3q7ycmsnb2otkDGPPuE1KR BqukvUVf8F4lFHKpzENUMTfIw4ZVxA4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706711391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZZ8b65xFaoLyifj6soTcCK4V3mFrLiPMpU7F9cu2+Zw=; b=MO4S90h8v/5n1JdOQ22szy4MYjo0Y7z+wsOiSBG60+LlR/BIm7H2VsrcqFXStZAlFdsTjj VQDsNY0VHzy/lxTTu3wTN/0I1CHQrbPiM4xd0lr/33sFPoURac1CqEa7dyl/LVUW2X0ZhX HmApiAynI0W8NlmA9767Ul+1FJZtEFg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-kK3vIUS0NWOH-M2R7ED-NQ-1; Wed, 31 Jan 2024 09:29:50 -0500 X-MC-Unique: kK3vIUS0NWOH-M2R7ED-NQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-33b0c264adbso92123f8f.0 for ; Wed, 31 Jan 2024 06:29:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706711389; x=1707316189; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZZ8b65xFaoLyifj6soTcCK4V3mFrLiPMpU7F9cu2+Zw=; b=gfVULqC4dNEvYgQbAfZLgVBLLU3dp50AIK0eEUA1dIz3HzISqIJDqKJ+IKVgw9Uz+L EvW8h9fxIIxNngcvbX6NSewUbuk+YC7Em4umDBBH7JBg0dz9Y1SYhYJJ/N+eDOb5uTxe PXl0JC1ogwbMBqnE2CXH4rD4JcXd7PpqPj3kdK9dDZKplcFu1F9/RftL1Ob4g9Z2B1rD D9CZ1MnfLIspko8NNQ1ormp28PCARmqztFYCbZOO8X4kvoUlVDouStGjxEpgnFd+hmNy wE1Pemmus9VxlXcYh7+I3AxnmMrnPBWSAp2lvxnRLUZQ8++Y9d0QWCy1HZUgJtSuQvv5 RRcA== X-Gm-Message-State: AOJu0YwaX9vILP51oWihU8q4G5dAVlU/L27ycp2zru2IWmgVPqbljn8z K6NTNlx17yzGDA0LLlz7VIBHAIFVeR5noGvcTP+oblMd5tzta6fC0ol8bQXveDp5DzYZyXP0hrU DcSfrvd0LJWMOONjbuZTh774zIPJMAIo9B6LFiRuumbbPuUzf X-Received: by 2002:a5d:598b:0:b0:33a:ff6f:608e with SMTP id n11-20020a5d598b000000b0033aff6f608emr1538706wri.39.1706711388913; Wed, 31 Jan 2024 06:29:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFPGskpVirI8XyVxfxlAH1i9dBAoHA8YDWcFOsNNMi2vRqQHUZE1EbK6vou26NNGCX4WuJG6g== X-Received: by 2002:a5d:598b:0:b0:33a:ff6f:608e with SMTP id n11-20020a5d598b000000b0033aff6f608emr1538682wri.39.1706711388493; Wed, 31 Jan 2024 06:29:48 -0800 (PST) Received: from [10.32.64.237] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id 18-20020a05600c025200b0040d4e1393dcsm1765374wmj.20.2024.01.31.06.29.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jan 2024 06:29:48 -0800 (PST) Message-ID: <74333154-a99b-4bad-81f4-bee02ba05e91@redhat.com> Date: Wed, 31 Jan 2024 15:29:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 00/15] mm/memory: optimize fork() with PTE-mapped THP To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org References: <20240129124649.189745-1-david@redhat.com> <57eb82c7-4816-42a2-b5ab-cc221e289b21@arm.com> <714d0930-2202-48b6-9728-d248f820325e@arm.com> <30718fc8-15cf-41e4-922c-5cdbf00a0840@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4A78FA0008 X-Stat-Signature: depzh5mfkqmbyxiaonfecq6tjrtbxrcm X-Rspam-User: X-HE-Tag: 1706711392-9827 X-HE-Meta: U2FsdGVkX196lafOyFCUKRCL8Wdb2L7K7UHpakftpF99HSVk7vvOiM7Osnm/VurjWJyWepRBr1S1N1ejruy0/rizth44rJSJ+50Bz/cvrmO3ybyJ9zwZShNhUHHaxdv9Oi5YufV9S5+K6k03PgLm0DfVR1+AD15CysJ3A2UOjAYG31SncBvsRFW3iylNEHGFr8UHSmu+InC/V4B/MlYOcWkZzbs70RmZrb8bb4RsljAvYnJHH+yaLdR80wy/IXYvB/CZVy1W5g96bjsrVNKcm1kGMWAaR/VveWJARGjbyewv4DqsBHrFsxerRTWsVjos0bb2MqNSt9u3KvJExL/iU1j0Itmze4/w+xinaRnOMw1Z5EVIpT8RQO2IMXyjHsFBY7BKCEtB8TW7bbAoK8v2/yh3rHIDUO/ZGPoHHDzLKW/el3CU3huqOFf6dv5L8xIpZH7JlL66d5+v0iQM7VNVcYvJyfNvOAaSbKDILneDDFDLHWddVm78sWyUKWhGDvWkMut206wUhV3nNjdxn50xoxE7W09H+ZESNEmK8GXsvEBJ/XQ7D8sn4RO5XqQgSTybxjgX13ofeor+r/PEhcynoA7lMlriu5X/8k39t57NgnYNtxIRKTEGKSLjMCNisfZ5gNR/PnmekD3xux+PmHjmRXZuv41ctaZSZhCm6FZvad7I6tzkpzsplIxC7jRSYKfyLLaJgHNcmy/oZ9IMMQK+vL7PjvKFbav69HmmKnW6lyWgsv61CXKubrP3X77OhPpucU6yfmknYz9Ro/DhaiD9PjJ7/pCZQl+m72d27wicZ1rCah+NP1kIiaYoOD4SdlcAlNbvhFkJ3PJ8CM1CCgMcmBZ+8MJzhGC2sGkjze1fyQ2CEXw6LKgRg4vau2e5q0XLz4Q2j+B/BKTV+j2n8uHH82irsbA14aFSCE5X/D62Lsb6Cr/C9TZNd8MkwlqEmEcIN9JpFUlQuD1VGri1KEA hBK0OpK8 2nKmWxdJ33gCpldGTr4d4LGCijshuwd+AQCQQghAWDWhTwqFy56qjLKZUGc4ihlk1zg9EfANltKHNpuiKo05jobpQAfLlRJKYP8MZyaKS4JuqPrTKalQ3rhsR1nZ2ADKhGNPqaboNHtp2fDq730A9cp2TSvKsSOUjU8N8JUysRbAe75JuN9n4OvZf/McPJwn2pL3yYvNy53DPEUPUNXwb6Bblh5w/xGAwFJptHG8KdiNZ4fJnXsXVYEUyNRHBOQmRrtrK6U0B//D/OTjndFAcm2V8apFjbFx0+xxEY3pGAzGWEyfDg2WAW4ZZTteR4MXhITjanuDrzDhNi47CbkRCP+8qn+Fl3+MiBIgWWhcj4XTCtFWoh9ylAKGkmmdU/3Fzl4malTa0YSVBn3J5jT47N1XaOVTRXV49xoC+rei0zZHkj+FQqQ4lcecOjGXQvi17Bfo2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> Note that regarding NUMA effects, I mean when some memory access within the same >> socket is faster/slower even with only a single node. On AMD EPYC that's >> possible, depending on which core you are running and on which memory controller >> the memory you want to access is located. If both are in different quadrants >> IIUC, the access latency will be different. > > I've configured the NUMA to only bring the RAM and CPUs for a single socket > online, so I shouldn't be seeing any of these effects. Anyway, I've been using > the Altra as a secondary because its so much slower than the M2. Let me move > over to it and see if everything looks more straightforward there. Better use a system where people will actually run Linux production workloads on, even if it is slower :) [...] >>> >>> I'll continue to mess around with it until the end of the day. But I'm not >>> making any headway, then I'll change tack; I'll just measure the performance of >>> my contpte changes using your fork/zap stuff as the baseline and post based on >>> that. >> >> You should likely not focus on M2 results. Just pick a representative bare metal >> machine where you get consistent, explainable results. >> >> Nothing in the code is fine-tuned for a particular architecture so far, only >> order-0 handling is kept separate. >> >> BTW: I see the exact same speedups for dontneed that I see for munmap. For >> example, for order-9, it goes from 0.023412s -> 0.009785, so -58%. So I'm >> curious why you see a speedup for munmap but not for dontneed. > > Ugh... ok, coming up. Hopefully you were just staring at the wrong numbers (e.g., only with fork patches). Because both (munmap/pte-dontneed) are using the exact same code path. -- Cheers, David / dhildenb