From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC3CC54E69 for ; Tue, 19 Mar 2024 04:26:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAEB76B007B; Tue, 19 Mar 2024 00:26:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E41226B0082; Tue, 19 Mar 2024 00:26:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB0486B0083; Tue, 19 Mar 2024 00:26:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B60C76B007B for ; Tue, 19 Mar 2024 00:26:29 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3489EA0618 for ; Tue, 19 Mar 2024 04:26:29 +0000 (UTC) X-FDA: 81912502098.29.8D5896C Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf16.hostedemail.com (Postfix) with ESMTP id 552F6180003 for ; Tue, 19 Mar 2024 04:26:27 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZTAFK3kI; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710822387; a=rsa-sha256; cv=none; b=54CbLu/oN+Wn96Q3Zb4dK+jGjSfDY7tOiHc4dHo2Fdj1Jo+rBlhaaiLMWxRU5mht5UQkn8 v3lp6jkrCR0i39lH+3mWyZItlvQCVnI8XyOXs2HAALhSXDk5tlQzYTNVgGBYRorSAPMcOj 0CLQ5/oTuvLxxd1AN/uMPtAXmk5x9cU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZTAFK3kI; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710822387; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kgOYrA8AEdh1woTHtD2vW3ca3PCtrZkdcZD77qbWikM=; b=VOkivzU+WbZIic/1WbVaE+VyXb1fQW0iHY2GBwnXt/MueuWLqHcTnZFzUby3dtNjFKxhui YecZSFxydckKfvaVvDxcKvsTvulfdF//AAKlDW5P0J96Dk/GZRi4wZXtRdhzB4hzCDeXGl M6K69E433evZM6a9IqTAjX3L0sHWRSk= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710822380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kgOYrA8AEdh1woTHtD2vW3ca3PCtrZkdcZD77qbWikM=; b=ZTAFK3kIV8AKtSNFLFj4r5t0E2RLRk79ahMgFgMUh3jepMgCaS/mVJWw+RNCCrBHBN52gG NXM8ti3nDdYB1W5KBlYW6GIieZZXNfTfpKEBYqCv/yKV1dd9Ool2dQxzcp3DvEWHCDX49h rpX1jczrZg5j7IQxr3uyYzwVPdmEh3E= Mime-Version: 1.0 Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240318200404.448346-6-peterx@redhat.com> Date: Tue, 19 Mar 2024 12:25:39 +0800 Cc: LKML , Linux-MM , Andrew Morton , x86@kernel.org, Mike Rapoport , Matthew Wilcox , sparclinux@vger.kernel.org, Jason Gunthorpe , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , linux-arm-kernel@lists.infradead.org, "David S . Miller" , Andreas Larsson Content-Transfer-Encoding: quoted-printable Message-Id: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev> References: <20240318200404.448346-1-peterx@redhat.com> <20240318200404.448346-6-peterx@redhat.com> To: Peter Xu X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 552F6180003 X-Stat-Signature: o9ygj5wthuc41okgpyb96mr3wgsw66x9 X-HE-Tag: 1710822387-347501 X-HE-Meta: U2FsdGVkX1/tUmCPqYJrGa0kUPs6UHMl+ejX7H2b2UgGMyD5+opLONcYwVtN1ehgBJxfWdaMhNcCxDOH/hxO9i85oK5U8UZl4pvgA7JCovL+sCu7z7Ov34COqI4PenajrurHgfZQALE/r1eZG0FqICumJMki00go+pwvAsr9Y34Oo6HfYatNGTOGgyMoM8hUMhRgilWZ+8FAVnJ/9KaWCSFEH5DDhOg4tEEVAUqpNfaHJ+kfQxURXlsrI0ldC7fBXcEe6XVspIWHXrtx2h3KNFXFNuiR+hwEsb2IDQ2qRV6uhcUPUbVtDbt1rQ9sbTMYIncWlre65iCXRJCd5nBfZd5aQeNRDyZQiFGA4AzMWySi5iw7QyOd2CS0q8r31usR8cfOFczsFzvkoQWfnTBdwTB4DSscKzxAYjgrXzynVh5a0xBcCBTP+ILEyMvnoIchnJ9ItklTu4xnZJ2K/d9Q/a7c6HIlwCVrD2XWpmc6Hj+DTTA7HayYjPefFn9Auw5xkuVNaeddNEE4aIwVnIzTh/5v516e9OXjBW0KLVD57reouCQ/Ub3+PSVf+dOlVMo2DGm2bLmtX9LMazHQhFoS7UFvfz3gmTBppIGNL/tg9QqmfuCPhvvTqYtqIaiCVF1w1Dw5DrbZJw5Ra/+CKnSrzFohCBiKooqoFZQ35jok0SKjlyQbVec9t7VPiVkcmh4FQgVhHj+sEGSoh75gF50c6Cr0lHr5ntm+X0MljOzHL3BJU2VlgQONzUgROPFRi8W+wiRIYHE529EbshjyVD+1zCGeB3dhc1ringW4MZoaA3ZoRXgm30VI/SVazlGa4euR8OEli7rSYqB1NzfTB9GVqq9yYFHv3txvI1GaIxQnAIcaGw5u+Iaoqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Mar 19, 2024, at 04:03, peterx@redhat.com wrote: >=20 > From: Peter Xu >=20 > Please refer to the previous patch on the reasoning for x86. Now = sparc is > the only architecture that will allow swap entries to be reported as > pXd_huge(). After this patch, all architectures should forbid swap = entries > in pXd_huge(). >=20 > Cc: David S. Miller > Cc: Andreas Larsson > Cc: sparclinux@vger.kernel.org > Signed-off-by: Peter Xu > --- > arch/sparc/mm/hugetlbpage.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c > index b432500c13a5..d31c2cec35c9 100644 > --- a/arch/sparc/mm/hugetlbpage.c > +++ b/arch/sparc/mm/hugetlbpage.c > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct = *mm, unsigned long addr, >=20 > int pmd_huge(pmd_t pmd) > { > - return !pmd_none(pmd) && > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) !=3D _PAGE_VALID; > + return pmd_leaf(pmd);; There is a redundant semicolon in the end. Thanks. > } >=20 > int pud_huge(pud_t pud) > { > - return !pud_none(pud) && > - (pud_val(pud) & (_PAGE_VALID|_PAGE_PUD_HUGE)) !=3D _PAGE_VALID; > + return pud_leaf(pud); > } >=20 > static void hugetlb_free_pte_range(struct mmu_gather *tlb, pmd_t *pmd, > --=20 > 2.44.0 >=20