From: Usama Arif <usama.arif@linux.dev>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
david@kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org,
tj@kernel.org, mkoutny@suse.com, roman.gushchin@linux.dev,
liam@infradead.org, linux-kernel@vger.kernel.org, ljs@kernel.org,
mhocko@suse.com, rppt@kernel.org, surenb@google.com,
vbabka@kernel.org, kernel-team@meta.com
Subject: Re: [PATCH 0/2] mm/vmpressure: reduce CPU, memory and code overhead on cgroup v2
Date: Mon, 8 Jun 2026 22:19:36 +0100 [thread overview]
Message-ID: <744aae62-ad99-4534-906e-92ddad978ee1@linux.dev> (raw)
In-Reply-To: <aicdqucZVqAUfh7N@linux.dev>
On 08/06/2026 20:56, Shakeel Butt wrote:
> On Mon, Jun 08, 2026 at 07:49:45PM +0100, Usama Arif wrote:
>>
>>
>>>
>>> For this, I am wondering if we should just go ahead and work towards making
>>> vmpressure memcg-v1 only unless we foresee a lot of or complex work is needed
>>> for that and only then patch 2 makes sense.
>>>
>>
>> I think there might be a transition needed? Because vmpressure and PSI
>> do not work out to be the same and people might notice a regression with
>> increased memory usage or a hit in networking performance and might want to
>> opt out? A solution might be to switch socket pressure to PSI while
>> keeping vmpressure around gated by a defconfig. And then in a few releases
>> remove it completely for cgroup v2 if no one complaints. If we go down that
>> path, we would need patch 2 for the medium term.
>
> Yeah the reasoning that PSI is not an exact replacement for vmpressure makes
> sense and it will take couple of iterations to transition v2 (networking) away
> from vmpressure. Can you please update your commit message with this and about
> the midterm or transition plan.
>
> I assume eventually we will just have vmpressure-v1.c file which will be behind
> MEMCG_V1 flag, correct?
Yes.
How about something like below in the commit message? :
This split is the first step toward eventually making vmpressure
CONFIG_MEMCG_V1 only. The v2 in-kernel socket pressure path
(tree=false) cannot be removed today immediately: PSI is not an
exact replacement for vmpressure, and switching networking socket-buffer
back-off to PSI may regress networking performance or increase memory pressure
in workloads that today rely on vmpressure's hysteresis. The medium-term plan is
to introduce a PSI-based socket-pressure path, keep vmpressure available for
v2 behind a defconfig as an opt-out for several releases, and only then
drop the tree=false path entirely, at which point everything that
remains in mm/vmpressure-v1.c is the whole subsystem.
next prev parent reply other threads:[~2026-06-08 21:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-06 11:41 [PATCH 0/2] mm/vmpressure: reduce CPU, memory and code overhead on cgroup v2 Usama Arif
2026-06-06 11:41 ` [PATCH 1/2] mm/vmpressure: skip tree=true accounting " Usama Arif
2026-06-08 17:06 ` Shakeel Butt
2026-06-06 11:41 ` [PATCH 2/2] mm/vmpressure: split v1 userspace eventfd code into vmpressure-v1.c Usama Arif
2026-06-08 17:05 ` [PATCH 0/2] mm/vmpressure: reduce CPU, memory and code overhead on cgroup v2 Shakeel Butt
2026-06-08 18:49 ` Usama Arif
2026-06-08 19:56 ` Shakeel Butt
2026-06-08 21:19 ` Usama Arif [this message]
2026-06-08 22:26 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744aae62-ad99-4534-906e-92ddad978ee1@linux.dev \
--to=usama.arif@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=mkoutny@suse.com \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox