From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F65C001DE for ; Tue, 15 Aug 2023 07:48:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D886E900027; Tue, 15 Aug 2023 03:48:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D388F90000B; Tue, 15 Aug 2023 03:48:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C27FA900027; Tue, 15 Aug 2023 03:48:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B12F990000B for ; Tue, 15 Aug 2023 03:48:40 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8BA201A0CF8 for ; Tue, 15 Aug 2023 07:48:40 +0000 (UTC) X-FDA: 81125562000.19.BD19801 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 51E0516001F for ; Tue, 15 Aug 2023 07:48:38 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cBZ3cHfa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692085718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0LmXbT2cqrnfIcuqb+LxCY3oi+h86qKI0tWvN/rblOE=; b=uz8xt/AOd8tSXcJCR8oLG2PW9uYFv3xn5RiA5c7jicWNAbchFbXzLXJO2N+Ws3LC3P/V6S LohL6RJOY5fLCdGW/1/vFbFymFfoAxU7vbzQi7bVXlMDvF8fmRd66nwYOOj+EAEaD5A2nY /uVeF3/wqNGZ0Wdm4p2ZNSOXMoBogBU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cBZ3cHfa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692085718; a=rsa-sha256; cv=none; b=lbe96OwwpSR4y2Zxsy1Yz/m51tfBF+UxRv2kDYggDmlUSD5HfweWczM7jDEQcUW4l7FOuV ZQrzrc7gXhPAkCAh5sBGvjhASjMTPAZF1/Ez59mzq1rqupZuoniyPfaWQlUpXUsMLtEJ86 vMOTyoQAmo8HMelA9hbIHo63zTImYjc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692085717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0LmXbT2cqrnfIcuqb+LxCY3oi+h86qKI0tWvN/rblOE=; b=cBZ3cHfawljRiY0ukhfwoyaazSlfcdyuzNLm4AGZhcb/PcSczQtGkr/LiGhcmUeUB6t6ed GeGLoOJJflAOT8RRJdcN4Cstdysag2iSqHxJV/vIN6Ix5Pe7e4aVGhi0wfI/uzgYwbT+NJ 6p8zM+ZlU0IKfwceQs1jsly1LedL2Bc= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-47R0h-IPMy-F9Eat5hH8Wg-1; Tue, 15 Aug 2023 03:48:36 -0400 X-MC-Unique: 47R0h-IPMy-F9Eat5hH8Wg-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2b9bb2d0b47so49534901fa.2 for ; Tue, 15 Aug 2023 00:48:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692085715; x=1692690515; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0LmXbT2cqrnfIcuqb+LxCY3oi+h86qKI0tWvN/rblOE=; b=C8NRF516yh+u7WPThraBVYkGhvxt+jiW9CNWC8eGQXIaaHYnxC4Vc3kmBZO7hb3L3r jrP328OEa6rkqzWlkXw+hu1SO5GQM4tBnqjR6o7ZOcun5qmcOXXEeupPrE+JnBEu2a8j sLByg7TLmjyTbBC0DyavdtnHOU8FKgHEBPU6wp1t968dKjcKqJkNQUongiOEp6gxVWTg e9Qy3H1CILTcJZ201cx1SGFd36OHq9TPh9R19wYD/aH3fHoXoXqBYsm9jxmc5WMoZKpU bNPkYEvaf31FdlqhFiENvyUzYB2QLtGeWipl50LupPNVy8SSU1wkm/lvpcPLF1/i1kHa vulg== X-Gm-Message-State: AOJu0Yy3GMXuXC2YmNEDhI8GySAu1vLEzCIQwHJUwEloUJCd2cDH2C1e RK/527WOQ2x0nAm8jRckWpmNXYm1ZjMPzL/b46aZ6hJdh+bPojZk6axpj2PZMH5/z4Lf14zOby9 PfZxk2LDgfdc= X-Received: by 2002:a2e:9587:0:b0:2b6:a6e7:5afa with SMTP id w7-20020a2e9587000000b002b6a6e75afamr8667212ljh.12.1692085714763; Tue, 15 Aug 2023 00:48:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHRCIxNPh3Oi+B/3AlBm3t1XObf57+A1RZie/0ec/LObbjijnLgVRsKEG3QcV+RHqrtCtUV7g== X-Received: by 2002:a2e:9587:0:b0:2b6:a6e7:5afa with SMTP id w7-20020a2e9587000000b002b6a6e75afamr8667203ljh.12.1692085714459; Tue, 15 Aug 2023 00:48:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:3100:c642:ba83:8c37:b0e? (p200300cbc7013100c642ba838c370b0e.dip0.t-ipconnect.de. [2003:cb:c701:3100:c642:ba83:8c37:b0e]) by smtp.gmail.com with ESMTPSA id b13-20020a05600c11cd00b003fe1a96845bsm19750883wmi.2.2023.08.15.00.48.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 00:48:34 -0700 (PDT) Message-ID: <74eec38b-12a9-7932-0670-10b34960a8c5@redhat.com> Date: Tue, 15 Aug 2023 09:48:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 5/9] mm: Remove free_compound_page() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: Jens Axboe , io-uring@vger.kernel.org, linux-mm@kvack.org References: <20230815032645.1393700-1-willy@infradead.org> <20230815032645.1393700-6-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230815032645.1393700-6-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 51E0516001F X-Stat-Signature: t47sp6j86noyyt47g5iqtsaoib48u3sc X-Rspam-User: X-HE-Tag: 1692085718-176716 X-HE-Meta: U2FsdGVkX18Dhcv7YjNmlcDUP+D6i56xNBE+1S635gOFOgyWZLklxNIPpnY3wRm2qcJmn1J+4fc5ZZo2un/4VPNtF87Govqw2KQlmtRAXysMcweXJy9ODlLqioJRy0ASi+sYijeaGbH16P06/Fb7SSDe6o5Jt/bUsh3BA3xcQw4xMgdr17VsF09bl6Rk+p1Dhyd01T2RuVIqK3Dhp327jIigbzyAmbAqy9Ri4g/Uof6A6Rdf6AVLufoxNKmPBJPQItreCdlKf9XvPRXEg4ZgtTzDcCKmkf5S1bp/MMsVuRhYyO3udtFjgLdF7d/r2bWK/QyhhSi6ZX+g4sYUwx63x6tAGPnQ+lY5+4fFHTYSUWi4vb0H0uElroj3BShfJeD1uR+ll5gHRnPaDQ3cEVFECX6FxQG4CRmFv3TIZ+EY46ToyRZjxG4XF17XhJk+SQswdi4PO4YOMC6R5+HNmL7mGO3VMTRgKvHYdbK5ejoLZ0gyX/AiAwSyw1qvkaDFjbUwZ3IhTnmB6iHCpuc+Xo9H2LbYPze0h0jU5C2PPmZaM62Mlu3pjPJZ2xka3hUuJRHrGuNq2is4Ayf7HzhN5K5edc4Z9mMY9Mk72sZroQ76JfPpal8ko9d8VReVk3WyYR6Gt7O+S/B5p2sw66iqa7qLD+UH3Vd2+iYg8GpbxzpHmn2W5EmBc35eHZ4QGaE+VM/jWzcNBQKIMBY715Z1m88Q8xDooUEEa/hyr3mU42OvGOjBieghS6AjLU41R5WPzRTlQeYOhWKfT1iV8r/qIkfQ4vRSgES7jPE2WGhgQy+IFpR/m8elN1ZWjpegMrP8pwF/9sZlvKknRlYb5Nr9AkY3nKBRg2T425nefIxKPy7XrjXEsm8zBOQk8EYncInzsXKgOilLVJI2cyHThK5CyJMWkPKmj2P9xW//XZNx829hmkjsd/TmCciltEhwrW2rTEF//ckN4Zsqmv8BfqgpF4/ Ur8YDS3m qJqIhqGD65sHLAdGYvEEgm13MvWJW9KBlHe5rWBS5+ao2ILqL+6RLPhTb7SoTYRwG5DbR08WlySkl5tRLHhoQl5dKJlpXGbRRenc3vLCN0WZJGZFSViOqueHUNXJTCCGyEMpMPCCLlR4p9HYDQwgV3a3NZjKcC+WgDnBqYJKvfbwjdy6hXuSHx2WGsgzR5MaUQaCGpuWgXLBRrHh+vATWVEckzvC7csPUUcJfXsK2eAfvhN8v3XnNwazS/wYldcVldIs9ojZLDMRJUkdzWOFULlZyH7I6MdADQWQxittDXXg1fjao8w5KSSP5jW2P1bNdJO+SpQPOl8CrF5X/gjfNgXsBzlCsPm8o8Dtgu7XaUZJZTQolRNJntS2ehhsqzAdp65VeBDi9K41QZPz+97UHNgrUpkLCouCZFE1nffmV775xmuyeIbQ/GYCsvP7NiblxdFeJhSGtaySsA1GlC+1+uucD0MnsAB21DGdIMexCounueXW9uzWALRriOgsW1x+u/SCU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.08.23 05:26, Matthew Wilcox (Oracle) wrote: > Inline it into its one caller. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/page_alloc.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 804982faba4e..21af71aea6eb 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -589,12 +589,6 @@ static inline void free_the_page(struct page *page, unsigned int order) > * This usage means that zero-order pages may not be compound. > */ > > -static void free_compound_page(struct folio *folio) > -{ > - mem_cgroup_uncharge(folio); > - free_the_page(&folio->page, folio_order(folio)); > -} > - > void prep_compound_page(struct page *page, unsigned int order) > { > int i; > @@ -618,7 +612,8 @@ void destroy_large_folio(struct folio *folio) > > if (folio_test_transhuge(folio) && dtor == TRANSHUGE_PAGE_DTOR) > free_transhuge_folio(folio); > - free_compound_page(folio); > + mem_cgroup_uncharge(folio); > + free_the_page(&folio->page, folio_order(folio)); > } > > static inline void set_buddy_order(struct page *page, unsigned int order) I'd squash that into the previous commit Acked-by: David Hildenbrand -- Cheers, David / dhildenb