From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D325C54EE9 for ; Tue, 13 Sep 2022 09:08:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8FA38D0001; Tue, 13 Sep 2022 05:08:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C18276B0073; Tue, 13 Sep 2022 05:08:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A92F58D0001; Tue, 13 Sep 2022 05:08:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9491D6B0072 for ; Tue, 13 Sep 2022 05:08:37 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6005B80FFD for ; Tue, 13 Sep 2022 09:08:37 +0000 (UTC) X-FDA: 79906486674.14.485EFB6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id BBD15A00BD for ; Tue, 13 Sep 2022 09:08:36 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 86A311063; Tue, 13 Sep 2022 02:08:42 -0700 (PDT) Received: from [10.162.42.9] (unknown [10.162.42.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F09AD3F73B; Tue, 13 Sep 2022 02:08:33 -0700 (PDT) Message-ID: <75318c8e-11fb-7d2a-1296-db1b06351aea@arm.com> Date: Tue, 13 Sep 2022 14:38:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 14/16] mm/page_alloc: use costly_order in WARN_ON_ONCE_GFP() Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org Cc: david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-15-linmiaohe@huawei.com> From: Anshuman Khandual In-Reply-To: <20220909092451.24883-15-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663060116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6pu2ZhZBFMD4XkPZyOHyH2BXPi6qI9shCTfgqhX/juU=; b=4QUDtGyh+k3wkjfr7ijDKJJqFJceN701jadQs4X1eMwjaBoNje/tGjPONgTr1NUcr4O0TN 2OvTGDz8i/3lQ3dXxqj0UJel3cCa8oLv7+BSZR5qaAhYprj1WQ2M3TuzyYexRy0PMJKdwD 3pFDltN6ltmJACBNe+PbDh9M9wbsB/M= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663060116; a=rsa-sha256; cv=none; b=X3YUCs6y9CUXt4Oi0nViRTJ6E/3uN+hu3TNrza0jYG0tFyZJhgZoftz9okUEeRvf8wfPWS mkFDScBWbc7IkkJ/FHElDu2iBGUcLRTkTRfThLqUAilC2PBY2aBNKrFsDSsLfdMkgYgntA IwGmN7YKQS8GRmQLG9g8gMjA2bjWfXQ= X-Rspam-User: X-Stat-Signature: 4u4r4ky53ayz3q5ddf5rtqodcb65akf3 X-Rspamd-Queue-Id: BBD15A00BD Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspamd-Server: rspam08 X-HE-Tag: 1663060116-472608 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/9/22 14:54, Miaohe Lin wrote: > There's no need to check whether order > PAGE_ALLOC_COSTLY_ORDER again. > Minor readability improvement. > > Signed-off-by: Miaohe Lin Reviewed-by: Anshuman Khandual > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 63ad25e86010..262e8972e019 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5272,7 +5272,7 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > * so that we can identify them and convert them to something > * else. > */ > - WARN_ON_ONCE_GFP(order > PAGE_ALLOC_COSTLY_ORDER, gfp_mask); > + WARN_ON_ONCE_GFP(costly_order, gfp_mask); > > /* > * Help non-failing allocations by giving them access to memory