From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B319EC05027 for ; Tue, 14 Feb 2023 12:07:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EF9F6B0073; Tue, 14 Feb 2023 07:07:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49FA86B0074; Tue, 14 Feb 2023 07:07:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 341F86B0075; Tue, 14 Feb 2023 07:07:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 236046B0073 for ; Tue, 14 Feb 2023 07:07:52 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EA5541603D8 for ; Tue, 14 Feb 2023 12:07:51 +0000 (UTC) X-FDA: 80465773542.25.E6A45D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id A6EC98000E for ; Tue, 14 Feb 2023 12:07:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VCr3UrBE; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676376468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SnnGhci8G9bgg/cHSUev+SUa0D8kZiVN6LjQKlMVnJQ=; b=2wn3LXh41trlTGhEx5KVKSOSGFecTwvnw9D+NoJyO3kQv8m4is+e9rfMObupSV0FpPgCUR EmWnWA018PDnfimlT54dpU7MMJ7aUeSZp8lM7yvrpKI2EeKT8dEVbZXSZUl+mbNv2V+n84 VzNnpONjiHO6HJ34Amc4fhnNsqHRqFU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VCr3UrBE; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676376468; a=rsa-sha256; cv=none; b=ioah+0bq1y6wMfykBbmsOCfzf9baaH9W8zm6um1Wp9z6CCzDmdU5tU9NDSRBock992dOCj yprkxYOAQBdwNYwFtHh+Ctj227OWVWgsWjy47GYo+KdAwmHAEc4X3TNBu5PZYYa8QO/Xw1 0AfbS88heJFkmHhxyt5AqLzAs/Fh5YI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676376468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnnGhci8G9bgg/cHSUev+SUa0D8kZiVN6LjQKlMVnJQ=; b=VCr3UrBE0TZmV0juKmh3jA9uJ/aQfWUx5BZMzTGUH4YvFrkIBpu4S5hRU0oAGYuRdnpZG3 hiwCTXHky+Rqa/TP23/FTEH1/difKJ6pKqodYLcIjxO/0lq2zPHBRjrT2jFPwWa+G+tedS iNdICGlJ5rovVgPi6txZUvwx/6wvra0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-388-gt8zXATdOZmnn5iT6KE-eg-1; Tue, 14 Feb 2023 07:07:43 -0500 X-MC-Unique: gt8zXATdOZmnn5iT6KE-eg-1 Received: by mail-wm1-f72.google.com with SMTP id o2-20020a05600c510200b003dc51c95c6aso455520wms.0 for ; Tue, 14 Feb 2023 04:07:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SnnGhci8G9bgg/cHSUev+SUa0D8kZiVN6LjQKlMVnJQ=; b=blLpn3WmKXuf2Y6iqXEN4nc1pBZVS+A+WvKlUVxNIDopWFmYT5CjgbK0nMEY1WFCYZ z11xPTRpdRzisv947XlTNGLgvL0cP3Vw+mvMiSN6lWkshBkmBU5fmFJJEVZD7cHNHxXv 8SEkMsvqJzdQ6U7kD68880kDdQux3JKq7WrLp2Tf38l7CN0DIc36OeqW8pd7XtPmPIg+ VqeKYSFA2BfW8VUdYSaYRHwuYfRUm2hueWTHyg3psiCjJfr2czltIlQaCEIt/HzFBFpY psoEazhjPJ2D9p2C/cFYE4WgHo2BcwfxRy2cM9lHMztg+CDuVX629oqpt6amgKt/GO3q A8xA== X-Gm-Message-State: AO0yUKW8UeHwVlc+ZqEt33mXSAJTttg9vbxTnGPEtgCRo3dXWrPtT2fD YPGBdJAAmDc4gqSCjw0iUoo3Me7m3yOtf/dzh+zWYA6QxZu+ZS1/fOaCK40INyNp26YqH7TnARj aAMfcdSbD6zI= X-Received: by 2002:adf:e909:0:b0:2c4:71d:244c with SMTP id f9-20020adfe909000000b002c4071d244cmr1857463wrm.25.1676376461738; Tue, 14 Feb 2023 04:07:41 -0800 (PST) X-Google-Smtp-Source: AK7set9JVRyPcksBjwU0iydRKtoaY2OusW9u5eIsJUAzolbLk6gP3ogyJcalxK/ei33Tej8x/threg== X-Received: by 2002:adf:e909:0:b0:2c4:71d:244c with SMTP id f9-20020adfe909000000b002c4071d244cmr1857443wrm.25.1676376461512; Tue, 14 Feb 2023 04:07:41 -0800 (PST) Received: from ?IPV6:2003:cb:c709:1700:969:8e2b:e8bb:46be? (p200300cbc709170009698e2be8bb46be.dip0.t-ipconnect.de. [2003:cb:c709:1700:969:8e2b:e8bb:46be]) by smtp.gmail.com with ESMTPSA id h18-20020a5d4312000000b002c54d970fd8sm8754308wrq.36.2023.02.14.04.07.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Feb 2023 04:07:41 -0800 (PST) Message-ID: <7533a41d-4e43-cdcf-e5fd-ba10f53c9b3b@redhat.com> Date: Tue, 14 Feb 2023 13:07:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] [RFC] maple_tree: reduce stack usage with gcc-9 and earlier To: Arnd Bergmann , "Liam R. Howlett" Cc: Arnd Bergmann , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, Andrew Morton , Vernon Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230214103030.1051950-1-arnd@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230214103030.1051950-1-arnd@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A6EC98000E X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: i3mnpbbjbdtf6s4jsnopgt3rdwtni673 X-HE-Tag: 1676376468-180056 X-HE-Meta: U2FsdGVkX1+x7yV3Mgy3nwFbIGbcSNB9P+rE3Lo4j7Af0gyIuPJei5um/frdHfG0caBPs1dkVGSwurm84GbLQiSFE9JxRG+pssedtQNz7hDsAKIZ2wfVrhua1EBSonheb++1Ak8jNvykBX+PEXdwGdbrmUjBdX/f0aXkFc1i1bwhzWbCYwXw1bzvRwFmgByz4xkia9NNNzOYa5ZZ/S3qldpM0sv1tGczPWXEXrV22eUtkmgmL042ViQd8Sl7t10qGrmrDMR61zg4gFcQnKcXlHeTR/iLk/+8KflqxYsqwPU5bekzDktphkYR1VGjtG+if3J6auoxQ9U2ySaQcCyB+CYVeaJ2QcZbpXdHAk5bnFUZgynoRI3GWdyzu0ZaJ4OVjTqkDXQ0WOr8bDYOW70Qltl185a5tFnmtx1doFNua4GBnvzatGNWNwgts45wyUY8To56zipcv8aXKLjcpTqFXOYIbq3nSRgTjYavudvjzpzIUoPb5v6AMYe8CVCE9hlP6Hb7mnKsBxvp0TyB/kpY/cPLucRMwnKBcCUytOKYonxNBKeX7SuH66pTN1KhGCynwA/S3jCqH3s9nbyriy5tx+PolTA2mNTHicKfisImG5kXiOjz2BitntR8KOuIoXxSdHtyM5wC+hQhuH9HMiBf5qu0wlgEEx3TuUpwhpxIK/W5Q44aA7BCQE+CSu2eR2cJhwzRKgaliPdH0NUn2qIJg23A+W1y3Ko1Yi6fOFYLJYOxEnYxCyAJecy8LsyPq/B8rMHJ9akrIdtyuM3XqjEjbZrmBMMh4cxAGdpdyJHG5SNipvKgVbl1ShWE67rwlIrgY//Fci0hsTgtGNID5CQ5wXoVW6n90ALg6CC3QUWdoby5CgwdKRp2lNBgOM5Hy8V7xxeeCbGZbnLUMumfHewBbYraY80YYoWLHvsB5Woc6Ykl0UCHp/+S8rcRQlpzbdh7J6CfNJ4SFvFRGTt/duT gW9hZN/y SKQLbMoFAit5lWhsP/g70xC08QXIMmvvsV9ZlYNgathCtU/bUE6YsB9T6EjAMRdvYAV8LW3nPcyeB7OyOPgGg6ZZntG5oO/ynRNO+R/4YMAmFqO6yJZD4lROtmVhlxyyILn/aCyLc/yA7B9/PsPOQ+I93no48/wp7MKGnC2lo5Aa6C3Elwd4q2UWoQTTUhJY5nEJD9OeYVPnIWOfCaPqCHIdOOKREo+MFxsytm0rx8wUYkEZiq/oQOPwoZO5rgnuX2ZL1+/z/EgwKnJycacAix6z4ARl2mS5BVBjFBlrfyaMjVDMPGgwWT5F8HEOn+2RtfqcXeAcr8lxvfVOfBaU0Sr9FNiy4PdLmYrbpxF3OOKBFTVifjYmbvSKeY3GpyUdWLHx5j2S/U0LZLWLyoABZt4U/XflcrR/2HN8ZoWezwTEkDbriMkBnGYDWZMnCRTP8z9ygpONW135JlpLWWrbwxOlLa109nwTvCpMNauqsbU7ps7N9NKEp9rxE2Js59n9ooal1vXzbFQwgY1aAyfMb7UOpJiFdl1iOWju9lKgyJituw9r477hSDwcUXs1Z2QXY+zBdlhb6vasKyKQ+Cc3q8OfiVI7tLIk9XaUh5EfKBbfSYnF2BoI7Kh4qM4IHZP0Aq3UpJDeRyslPeeVbHFOELYvX8hBGM1ptW758npZ5Hr1Kz/kEA0Eddy8I2zdn7LTvLE1VzX3AWFqzB8Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.02.23 11:30, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-10 changed the way inlining works to be less aggressive, but > older versions run into an oversized stack frame warning whenever > CONFIG_KASAN_STACK is enabled, as that forces variables from > inlined callees to be non-overlapping: > > lib/maple_tree.c: In function 'mas_wr_bnode': > lib/maple_tree.c:4320:1: error: the frame size of 1424 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] > > Change the annotations on mas_store_b_node() and mas_commit_b_node() > to explicitly forbid inlining in this configuration, which is > the same behavior that newer versions already have. > > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Andrey Konovalov > Cc: Dmitry Vyukov > Cc: Vincenzo Frascino > Cc: kasan-dev@googlegroups.com > Signed-off-by: Arnd Bergmann > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb