From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED033606A33F for ; Mon, 16 Nov 2026 16:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Z/hSCkGI Received: by kanga.kvack.org (Postfix) id E3A8F6B05B5; Mon, 16 Nov 2026 11:10:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E11696B05B6; Mon, 16 Nov 2026 11:10:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD9BE6B05B7; Mon, 16 Nov 2026 11:10:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 97DFC6B05B5 for ; Mon, 16 Nov 2026 11:10:45 -0500 (EST) Received: from smtpin15.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 12900801A4 for ; Mon, 16 Nov 2026 16:10:45 +0000 (UTC) X-FDA: 85441470450.15.6D008AE Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf13.hostedemail.com (Postfix) with ESMTP id 2E07B2000E for ; Mon, 16 Nov 2026 16:10:43 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="Z/hSCkGI"; spf=pass (imf13.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1794845443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tn1OgnHLvY8pB7bssQ17l15coGdAwQFCYSQKrIsgJ7c=; b=1pMLXRzEL+WFyZ1qoTxK5C2y3trQ685fZZy/V+iHjJUO/MgCpsLshNdG1oUhl3p8DrsZcW w/CuCcvHia+hjz4jwReUoITspminamLvD+dUl2JNPjhoaCv7qMDaWAcYZujb1XS7cREwjj Y1qdyUi4b2psB6jztK7fmf+9+lwWY8o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b="Z/hSCkGI"; spf=pass (imf13.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1794845443; b=O5pEK3I90EsgXQ1DSWvO54/XRob9fpDE1eV+/ZzfSMsMNqk82t1R0gK12WsIWJewzDPum3 KiFVHhxknK1um2eSb2kiJZP9CM/L5DZXgTjcQnLG6zjyMPZ4tkJmFx8koUt+4RAdmtHGPO CxTm4HN3ZLtr0tt8Bnz61hEUBTbLK4A= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 77AA644F43; Mon, 16 Nov 2026 16:10:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2480B1F000C9; Mon, 16 Nov 2026 16:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794845442; bh=Tn1OgnHLvY8pB7bssQ17l15coGdAwQFCYSQKrIsgJ7c=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Z/hSCkGIBdKjXcFnFifRHR1/s0kmY4LGWQkh2wIyddubLz3E9S++w31sU0xIEGvEj sdVfgd70xVYtY3xbzeD6uP2xU8utBg6CPwMzf0ViCi+UhH7WC53J+Gy3j26hlLlyLb Slen8p26azocIdX0wyqkh6C4t6FEepzLw7Mb7188J/GU1+sBye81CTl1wFMYHk/5pI xh9UN0djjiGcYJrahn7JZqZyQv/NV0BgDv2btFbP5MI5X4RSV7iRDtyY077WxaqrnR yv0sMr0DS0H6UIL3ovg534U3UHePyM/6sqvgKtgwRyk+errg6ljzVXJlvrt4/GhbRB e9/hbMXMgC7Fw== Message-ID: <7544e13b-e926-4350-a48a-cd76df456bd2@kernel.org> Date: Mon, 16 Nov 2026 17:10:28 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/15] mm/hugetlb: fix reservation leak on min_size= mounts To: "Gregory Price (Meta)" Cc: Muchun Song , Oscar Salvador , Naoya Horiguchi , Andrew Morton , Mel Gorman , Andy Whitcroft , Miaohe Lin , Michal Hocko , Rik van Riel , Hugh Dickins , Baolin Wang , Vivek Kasireddy , Dave Airlie , Jason Gunthorpe , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Jonathan Corbet , Shuah Khan , Randy Dunlap , Peter Xu , Breno Leitao , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gerd Hoffmann , linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Chris Mason , stable@vger.kernel.org References: <20261028-fixes_hugetlb-v1-0-a0a033db180f@kernel.org> <20261028-fixes_hugetlb-v1-13-a0a033db180f@kernel.org> <179467919954.482102.5381456550239958011.b4-reply@b4> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <179467919954.482102.5381456550239958011.b4-reply@b4> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2E07B2000E X-Rspam-User: X-Stat-Signature: wns56pqqd7n976t87m67co184ebyrh4j X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-HE-Tag: 1794845443-907444 X-HE-Meta: U2FsdGVkX19btv8/YGCx773r0YzZut8+VUeYEiU1mNBKJDqrabZ3e4Sf16QUumyf8miMuJuvxOYqCczqN8AiCl0q0464OAJR5sPKSHJPBiZqxj2r6Ogw+mN/wkRTcGNriLaizbL9xJhouhSuYgsCSsg4hDjdecWBZqWKR3Hb0Stt58GhdGzYBFn1WXo/HSvEPGneb3bXWsVf8mlpXQXO+KOsP9kMhBzst2iPazp9dI30zNKZxGBJ7rt216GU3l8qoLv/mrcwBLNrK6r0CBNgSq5as4czcot6LlOyvEf02RPfsSKB3z6dC2SqalafzMgTx2bXHu9OUT3zzTFSNOMBmLZExHj2C8cbqDVkEXBuj6VFmG6hCfyp8SXXssIMZhoNGMFQnchJTNzteuQQAoquIYEyKb0FxeCoq9kWjuemaecqolRPZoR6x2B5+FInMjpA24OdNl3xrqbGWi/oGhFn+VCQ1KMnh8hLGwqYO62ZJKQO7MZ8uA35wQZLpnm88xIw6HKW5EshcnyMFGaFCzwtwPVlnSzk2EvDxhEPU4+7rF8nj0yQQX0SAFc2QhUY1ZLc7qAWxmU7FZRvzpSpOC1Z+fGDY7ChcGvknFtuHgnfuyh+AYiifbIk87KMgz7CoHySSBeKmzn/ePpIBKv8TAlHSYptjKY9My+HDE+OzGW3WnaPIQZuyvnMWxSrOyZAiQWYH5SHUlpddd/lcXCEoudZZwdBUJWe5Xa7yqCkzTBe7xBbqvlaMghuXV+XrtT+26bx6SjHNhTu8bt9HctdZkvXXsfEOPOdkGg7cdR53IHDkfLG9Fdoh7n5gvQp0yNhZyR94TpA8GpykD+yApVT+tCbUOnjBaAfhCdSPIBuvmnitVt4w8YoyDTreP0MyzQtlmbilJcBOs1/rsVNsc0c8EsIqQDuzp4VTOqUETkwVnEgkNl52HLbR7UWbLS28g0wI7paFRstclsj15JejPacaik /kFniDfS ZG9Gi09DbyIVG2SpHpiq1KLW0Ju0Bmemqim9T8V3szXSfg16oEXOuejKaWvQq0A5QJJzdwGP6yU/sqXBZG0H5GKwEf25hF8OiGAuYUWXvq9A9kW0uZVgvpB8A5thSGmOmw0dXhddLXxId8RW5VmbXJln7UVJ5BL2wcoo1QIxoq0LgYPHGetY5vfo+NIAGyxTqlP29VsuxMcLew9BW5fFesE/aqLcpDimVZ5QVF/AsnuBdpJ5mdSgQfCzAvr8K3qCWC4BudcYpmzOao0zdgNOr2VfDrxAuMkVkTiRgAHYSGSKQEbkPv7PNlDCV4tlDALySWmZ938DVODnNli8lT1lunnFghGkDei7Cf+c06kAyNxQbs01QHvd2usvipYOTQZ40bBNwpgkPLRf5vYfZSL+gb6c4kBCXav9FLS6+3BKFwyALoYBwlP4lfNN7+XHfgWEoz1hecdPrAe5CjMtgG/nIJUJojg== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/14/26 18:59, Gregory Price (Meta) wrote: > On 2026-10-28 21:13 +0100, David Hildenbrand (Arm) wrote: >> From: Chris Mason >> >> Failed allocations for CoW mappings can leak reservations on hugetlbfs >> mounts with min_size= and no size=. The leaked reservations survive >> unmount. >> >> HPG_restore_reserve makes free_huge_folio() restore the global >> reservation without returning it to the subpool. This assumes the >> reserve map holds the reservation. However, a CoW mapping may have no >> reserve map, or the map may already account for another folio at the >> same index. >> >> Commit 58db7c5fbe7d ("mm/hugetlb: fix avoid_reserve to allow taking >> folio from subpool") allowed owner CoW allocations to consume subpool >> reservations. Commit 51e1de00acdb ("mm/hugetlb: simplify >> vma_has_reserves()") later extended this to CoW mappings without a >> reserve map. >> >> For example, with a subpool minimum of one page and a >> MAP_PRIVATE|MAP_NORESERVE mapping: >> >> subpool global >> rsv_hpages resv_huge_pages >> 1. Mount 1 1 >> 2. Allocate using subpool reserve 0 0 >> 3. Free on error with flag set 0 1 >> 4. Allocate without a reservation 0 1 >> 5. Free and return to subpool 1 2 >> >> Call folio_clear_hugetlb_restore_reserve() for CoW mappings when >> map_chg != MAP_CHG_REUSE, meaning no reserve-map reservation was consumed. >> This lets free_huge_folio() return subpool reservations to the subpool >> on error. >> >> Do not set the flag again if region-cache allocation fails during >> rollback: that would undo the flag clearing and skip returning the >> reservation to the subpool. This also fixes the older case where setting >> the flag invents a reservation for an unreserved allocation for a CoW >> mapping. >> >> The doc still mentions PagePrivate at various places: future work should >> clean that up. >> >> Fix generated by an LLM and sent by Chris Mason in private. >> >> Fixes: 846be08578ed ("mm/hugetlb: expand restore_reserve_on_error functionality") >> Fixes: 58db7c5fbe7d ("mm/hugetlb: fix avoid_reserve to allow taking folio from subpool") >> Cc: stable@vger.kernel.org >> Signed-off-by: Chris Mason >> [ david: simplify comments and improve description; updated Fixes ] >> Signed-off-by: David Hildenbrand (Arm) > > Commit message is still hard to read :| (or maybe HugeTLB is just awful > and no amount of massaging the message will ever help this). It's just absolutely horrible stuff. > > Maybe note - this is an accounting error only, the pages do not leak. Ack, I will add this. > > Was able to reproduce the issue with a UFFDIO_COPY the provides an invalid > invalid source address (src=0). > > 1. Create the pool and mapping (hugetlbfs w/ pagesize=2M,min_size=2M) > 2. invalid UFFDIO_COPY (kernel allocates, fails the, rolls back) > 3. Close uffd, cause a normal fault > 4. Unmap and truncate the file > 5. Remove the file and unmount > > Base Patch > step 2: total=2 free=2 rsvd=1 total=2 free=2 rsvd=1 > step 3: total=2 free=2 rsvd=2 total=2 free=2 rsvd=1* > step 5: total=2 free=2 rsvd=1 total=2 free=2 rsvd=0* > > Result looks correct to me. > The code hurts my brain but looks reasonable. > > Tested-by: Gregory Price (Meta) > Reviewed-by: Gregory Price (Meta) Thanks! -- Cheers, David