From: David Hildenbrand <david@redhat.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
Mike Rapoport <rppt@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Jianxiong Gao <jxgao@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/8] mm: Fix endless reclaim on machines with unaccepted memory
Date: Tue, 6 Aug 2024 14:00:07 +0200 [thread overview]
Message-ID: <7564cf76-115b-4d5b-bfbd-fd3b1e55a5c1@redhat.com> (raw)
In-Reply-To: <20240805145940.2911011-2-kirill.shutemov@linux.intel.com>
On 05.08.24 16:59, Kirill A. Shutemov wrote:
> Unaccepted memory is considered unusable free memory, which is not
> counted as free on the zone watermark check. This causes
> get_page_from_freelist() to accept more memory to hit the high
> watermark, but it creates problems in the reclaim path.
>
> The reclaim path encounters a failed zone watermark check and attempts
> to reclaim memory. This is usually successful, but if there is little or
> no reclaimable memory, it can result in endless reclaim with little to
> no progress. This can occur early in the boot process, just after start
> of the init process when the only reclaimable memory is the page cache
> of the init executable and its libraries.
>
> Make unaccepted memory free from watermark check point of view. This way
> unaccepted memory will never be the trigger of memory reclaim.
> Accept more memory in the get_page_from_freelist() if needed.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reported-by: Jianxiong Gao <jxgao@google.com>
> Fixes: dcdfdd40fa82 ("mm: Add support for unaccepted memory")
> Cc: stable@vger.kernel.org # v6.5+
> ---
Nothing jumped at me, sounds reasonable
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-08-06 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240805145940.2911011-1-kirill.shutemov@linux.intel.com>
[not found] ` <20240805145940.2911011-8-kirill.shutemov@linux.intel.com>
2024-08-05 17:04 ` [PATCH 7/8] mm: Introduce promo_wmark_pages() Johannes Weiner
2024-08-06 7:19 ` Kirill A. Shutemov
[not found] ` <20240805145940.2911011-3-kirill.shutemov@linux.intel.com>
2024-08-06 7:52 ` [PATCH 2/8] mm: Accept memory in __alloc_pages_bulk() Mike Rapoport
2024-08-06 12:02 ` David Hildenbrand
[not found] ` <20240805145940.2911011-2-kirill.shutemov@linux.intel.com>
2024-08-06 12:00 ` David Hildenbrand [this message]
[not found] ` <20240805145940.2911011-4-kirill.shutemov@linux.intel.com>
2024-08-06 12:06 ` [PATCH 3/8] mm: Introduce PageUnaccepted() page type David Hildenbrand
2024-08-09 8:28 ` Kirill A. Shutemov
[not found] ` <20240805145940.2911011-5-kirill.shutemov@linux.intel.com>
2024-08-06 12:18 ` [PATCH 4/8] mm: Rename accept_page() to accept_page_memory() David Hildenbrand
[not found] ` <20240805145940.2911011-6-kirill.shutemov@linux.intel.com>
2024-08-06 12:20 ` [PATCH 5/8] mm: Add a helper to accept page David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7564cf76-115b-4d5b-bfbd-fd3b1e55a5c1@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=hannes@cmpxchg.org \
--cc=jxgao@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).