From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AB0AC3DA64 for ; Tue, 6 Aug 2024 12:00:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3C1D6B007B; Tue, 6 Aug 2024 08:00:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEC136B0082; Tue, 6 Aug 2024 08:00:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93E516B0083; Tue, 6 Aug 2024 08:00:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 782FE6B007B for ; Tue, 6 Aug 2024 08:00:16 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 249411A1F90 for ; Tue, 6 Aug 2024 12:00:16 +0000 (UTC) X-FDA: 82421677632.15.F7E6F27 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id A70B64003D for ; Tue, 6 Aug 2024 12:00:13 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IpMOyxId; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722945530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jOJGHm4Br6LaHArjPowVXyqQXUfsOQYsBdbCDZ6CFQA=; b=FtwX8PizFb+c4ONZITCmbyndZR1H4f2o0A0EnSw/qMoaFek0C0kN0u8BoCxvYX2C7fn45p O56wLd0qUlQWIiahELaONY67jCMnLM+Y++Jku84UQCu5/jnwqSQZSSBjzc3C0V1ig6mgaC +VjAsGW9CF+rEBWuHW/h0uGq5XOhLpw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IpMOyxId; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722945530; a=rsa-sha256; cv=none; b=h97IliIRh/8Nqyg/826MSpgKAnessqEr7FUVY/lCW2JOOMmQITNH4zWfGn1dtD43TxYWGd R46RIwR+x0g8yFPnyJ/VAREP9kd1fUzh2QG+5cCvUEjZdWxIfe5UbgvClUlkVImCd1B+6n dvsv0sLN7btHZpsb/iAP3LyYkETw6P8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722945612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jOJGHm4Br6LaHArjPowVXyqQXUfsOQYsBdbCDZ6CFQA=; b=IpMOyxIdiZHkihURojq0Oht/R8uG4go0rMf0gHLuGgbA0s1N3yl0UzCHXwMF/acN8ZPe6O shQM23TGZuKfxd+o2C9MqmVMATPQpvbOEzNCOof1lpjwDMlA9okkUvyxL1ip28qTs9e+tX ADrBGtj0eJxzv0KO/GImoZXWJ6RXXwQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-392-tS0VxxZIOCawKKZ0Bu2fOw-1; Tue, 06 Aug 2024 08:00:11 -0400 X-MC-Unique: tS0VxxZIOCawKKZ0Bu2fOw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4280d8e685eso4811175e9.1 for ; Tue, 06 Aug 2024 05:00:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722945610; x=1723550410; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jOJGHm4Br6LaHArjPowVXyqQXUfsOQYsBdbCDZ6CFQA=; b=qKqLkDNWvklh2+Q4Z5N8IYSTDWyk3iPVIMxFPT+aZ+WCBwwqbQEnl4hOVwrymyqLqq ifAbBVfECUMDv0ZW5/lEKXFAwLN9JL33/t0rl2m0GPFDcD1lZHyGsYkDHiTbks7OJ02c S4jDx0JPwRa68kibv7W4tDe7O3IgXQyVPb9zr/BOPDcJs+9i77hBjymirIB3i1yOT7fU IjSgoFfDG4xu1MK8vu/46GEhPUt6J/EqXMSgF50kUiUdrjTI2P6q7F51v4w+ieZo5DeA Ga7Rqo+jMeSwNs7Jmp3S28Pj1QkOEr5VF1Y2lWKWUrif9bzz7ZGhyMeAptwk6ILj+LDi Tdcw== X-Forwarded-Encrypted: i=1; AJvYcCV7DQEKhBrNc/vlR+qPJAx7tKPbPBtPLuylveHiruTg6/HUARpVX3KBUAu9Vj3oe+4pA4t9Znz4N8YrKs/EEbhGPYA= X-Gm-Message-State: AOJu0YzGdwtuYjezsvKw1Q+OE5izRPI4QkUIasoHKvryAikPMxLz6XKq dKlDzSmQj7eTscHC7vEkMIHRkJJoa0tjhNzeRESmH7GhqUieUG3PbgYDbnr+4BifgB0Yf/aFFJR Dfh73TB/KXAIhl7gob1TEO+IvfEUv9cV+pKc6StVt4II8ThdN X-Received: by 2002:a05:600c:468c:b0:427:abed:3608 with SMTP id 5b1f17b1804b1-428e6af2fb9mr85689015e9.5.1722945610150; Tue, 06 Aug 2024 05:00:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2QasHYqkusBhWQLHdc8qVQblinwhGWx2cAkm/gc5JdYPrFP55UaOZZ1yyKwduUpTbjy595g== X-Received: by 2002:a05:600c:468c:b0:427:abed:3608 with SMTP id 5b1f17b1804b1-428e6af2fb9mr85688825e9.5.1722945609620; Tue, 06 Aug 2024 05:00:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c73f:8500:f83c:3602:5300:88af? (p200300cbc73f8500f83c3602530088af.dip0.t-ipconnect.de. [2003:cb:c73f:8500:f83c:3602:5300:88af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428e727084dsm177397315e9.36.2024.08.06.05.00.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 05:00:09 -0700 (PDT) Message-ID: <7564cf76-115b-4d5b-bfbd-fd3b1e55a5c1@redhat.com> Date: Tue, 6 Aug 2024 14:00:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] mm: Fix endless reclaim on machines with unaccepted memory To: "Kirill A. Shutemov" , Andrew Morton , "Borislav Petkov (AMD)" , Mel Gorman , Vlastimil Babka Cc: Tom Lendacky , Mike Rapoport , "Matthew Wilcox (Oracle)" , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jianxiong Gao , stable@vger.kernel.org References: <20240805145940.2911011-1-kirill.shutemov@linux.intel.com> <20240805145940.2911011-2-kirill.shutemov@linux.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240805145940.2911011-2-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A70B64003D X-Stat-Signature: 1whonubkj3uh14c3815uz13kwij69k85 X-Rspam-User: X-HE-Tag: 1722945613-700973 X-HE-Meta: U2FsdGVkX19WvA6PN15ny7F/OXPXydi43uCRYA1xDJOtCX9rJoLUL4S99oQyq9kh1nEhctJYhOlB76i8IOtmOfQJCEMyWvCUQUBp2F8uZpniOOZCr3lEBbY/+vODxRjZzosE37FnWNZCGk6fUMsL9n+YbYPOQcFs+da8+pHUndeIV+YUqBGSBXC37uNiRnHin6ehYdncNMSp0mZWFIfvigrShmo/QaEguhgJRRSLu+Eu/wkGdm83BCvup2mRtmtMbOvYJz906DK0tyPsQNatJkGJ85QDFXCV7jLJYWKsLALlAn6t2EalqiWhwMwRejp17Bfqxhcmd+ZkFaGPdItruWKqydhvnyZCW4QlvSMvlvDnOJGvE6bPMgB8Gnvkp9RTVugvr5ield5StsC+R2ywfqMgtLz2aMc0njNygRGwFWtvFKTpP0YwN6jjC8iWX+Th9NQZG+KfVOtu1EZU+Po43RJW26hmys8lJ/NbX9dg0f353uBWJ4edRjUE9DT6BZNn7DL2TqRQSXHPK9iTBu6+Vzk1AqIxx1uRvUTds7wnvl8f3qnMGldPlEOiCT/b1n3N3CQggrIXdkNIqtJCYYhHjSs70ZjZsIZCXEs6svEfaHrmZLe16SLBxtfTjMMUiUaXIakx7pyTmxBpKNOnp8OmGNzmpJxOt+izgr+Q0uNEiQcFkm7sd7f+F78Nh5cpcOqYmS/yo8kXJMbWfUJbGd4xP6qzv8NDlZ5OZFXMLODQfZVzLI+ABqLxt3EnobT1j26pOuTGJhczfUtaP/hOw366A1/l/mZFAZi8MkzLn68ReX+zY0CLNLgE9uBt+Ffohj0HOx5z//xYWwEQtk6c9P5TezYQgBpN0EwsFLHEZo51qFNUF0USrSMMvhKCUSAeVshuZfrce8NMlpA+sjuwLyL4KBnWNAWMo3IuwFxAVfpQ3Ni0tzFNW/wzUi/Ax0wen6rq8Jxznrdn8/foeiR16F7 0iZ+pJod 8CECmXTW9/UaTKv689ju/2qZToXf04Mh/HoDjj82Kge9FY+zWXxjF7UxWx7bohbq2D1WBhu5K0ETTxPUGGN3tYeGTT7jiDsmlH9fjMOFJ4f4nviuD5+QM2GDQbgGURmuZmjtpoS7EiNJGtXtpCW0B2+f8KqPHz3k2ABdvmaEQGsbsGgdybLtWcfKWpB8HvlM38B6xZypAZYp4JuvzopYweToKMMwUkLJ77lZXbr+jlT7MRU3Fkm7YJTJIlgkIfposwXS1rltjgpu+MoxKaTiAqme88BWW7H5RxYUApn7G2wwpwi3N5reCJVDGJfm6dVvBlz/V3mdS/UFDEtKIIBpqA7wRGsgXnObudDuk9CTDDFzX6x0G1H6WNcNrqokuKACzg2dLiIsXM2eLOFZOG0OGGSiA6PsR+GKhC6DzeucY5KPQInWUtesUtM/5/qPvyjcsGAu2NPQuoaqJZkri777fO2m4yOufjOsOpwuVj9zeOdW7cLJYN5dAFXr8kA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.08.24 16:59, Kirill A. Shutemov wrote: > Unaccepted memory is considered unusable free memory, which is not > counted as free on the zone watermark check. This causes > get_page_from_freelist() to accept more memory to hit the high > watermark, but it creates problems in the reclaim path. > > The reclaim path encounters a failed zone watermark check and attempts > to reclaim memory. This is usually successful, but if there is little or > no reclaimable memory, it can result in endless reclaim with little to > no progress. This can occur early in the boot process, just after start > of the init process when the only reclaimable memory is the page cache > of the init executable and its libraries. > > Make unaccepted memory free from watermark check point of view. This way > unaccepted memory will never be the trigger of memory reclaim. > Accept more memory in the get_page_from_freelist() if needed. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Jianxiong Gao > Fixes: dcdfdd40fa82 ("mm: Add support for unaccepted memory") > Cc: stable@vger.kernel.org # v6.5+ > --- Nothing jumped at me, sounds reasonable Acked-by: David Hildenbrand -- Cheers, David / dhildenb