From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C75EB64DC for ; Fri, 21 Jul 2023 15:14:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C5B98D0002; Fri, 21 Jul 2023 11:14:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 275DE8D0001; Fri, 21 Jul 2023 11:14:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C8DE8D0002; Fri, 21 Jul 2023 11:14:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EEED48D0001 for ; Fri, 21 Jul 2023 11:14:42 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B9FCF4033C for ; Fri, 21 Jul 2023 15:14:42 +0000 (UTC) X-FDA: 81035966004.27.5064FD0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 90C10A0008 for ; Fri, 21 Jul 2023 15:14:40 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FTerqROH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689952480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BrJmJjnrV3+4TK5GKS3+EEIdaYEFXLT6GE196jD6rfg=; b=dioaadmOSubPO2Cj6mfgOM8xyhyd14rhRmvQmvZ67EDCL/c45sxkhvka+vWnXnLsgGQqHX N6Wq04IjPpJK5YsGh93LUju+uVXq6i2B3RRfhZbOIJBRjauJ55j0ctqbQU0iIClWm3lUPG /3XdemYrW4e07R9te0Ltl5uxkgiu0pU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FTerqROH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689952480; a=rsa-sha256; cv=none; b=VXjJGw10Z07sQVJnTPCn9i9o80abpr9ZkvX/IFfnu35dHbqB7hrkklvJjHOgUIIp82WMes QME+2BcgHRhslDMVZhKbL1T3gaDA5Uf3gFytgRheUufC0WmkoEXSML9Cbj0x8tddTDgVDk bY1GdamsMRpH8VIZp7EwuyAl63g7aw8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689952479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BrJmJjnrV3+4TK5GKS3+EEIdaYEFXLT6GE196jD6rfg=; b=FTerqROHSr49FG3IuuTeRzk+ckFCPi2WY2dTAu8BnwSXNn295IHo2p3YHI+yytyl4fP7kx YkpcOn9Oe9vIVsHBUovkSU2q8zwNBp5YJ5bp2YHTA33eq9hsiEcOqxEXCFq6IQ3tmqyovQ oUaCsV88IgyKp0XeM2Y2RUA37S0SPiA= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-wulh3jNBNJ-wBsR5sooI9A-1; Fri, 21 Jul 2023 11:14:38 -0400 X-MC-Unique: wulh3jNBNJ-wBsR5sooI9A-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4f84a8b00e3so2097598e87.0 for ; Fri, 21 Jul 2023 08:14:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689952475; x=1690557275; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BrJmJjnrV3+4TK5GKS3+EEIdaYEFXLT6GE196jD6rfg=; b=C6uAZNx42P8H8W/Ibr5R3W+y3wbu/GOqSMlEo3iSKkzkGhqx8n/RxDJSsV0qv0VgVy TW+845EcBjptarPFaO1YH535l+vdHJSY+7tQNC/hDr5v1phiK6fyfgldWcZBcx18Rl1I WUmH/b4yCmmGFEsY5Bs6FvVCqr3Y50yUs7ZlNYojG6wyjbV6hQa7ewKsyeMim0MtUAMF PkTARWxTBO4hDhbHVvZmCSvTBJzlt7VsH8M+u9QkZefBbFKU4eV/3Jh58fsmNXWLBqPC sRG8gfN/8s7Zsaknw4AmW/q3UKLESznnH96zrU/S1HV6jNhl0qXdoHmNLGjaxwO/Fg+/ 4jSg== X-Gm-Message-State: ABy/qLZj3xhXEjVK+DxDhO3GqRSN3UPZZhNZbxSN9blWDwx8Cyg1W1wN 2ZYmkEWdHtfZoJkmJFbBtu4M1mU3PtjUKmHUzCGHmb64zfFTpI91uTUSuw7/W8yI6ejK5K8uymG DZ7MVLKGtRX8= X-Received: by 2002:a05:6512:1150:b0:4f8:661f:60a4 with SMTP id m16-20020a056512115000b004f8661f60a4mr1702784lfg.41.1689952475230; Fri, 21 Jul 2023 08:14:35 -0700 (PDT) X-Google-Smtp-Source: APBJJlEY792MHWkKnplUr0Vx4lx09FEkAsdfsZuVIi7WtMfQ0gFs1YquUiOv8dJt4JtZPtFNMSuP/g== X-Received: by 2002:a05:6512:1150:b0:4f8:661f:60a4 with SMTP id m16-20020a056512115000b004f8661f60a4mr1702736lfg.41.1689952474795; Fri, 21 Jul 2023 08:14:34 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id l23-20020a056402345700b00521d2cf5f3bsm2224721edc.96.2023.07.21.08.14.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 08:14:34 -0700 (PDT) Message-ID: <75f13a8a-132f-99ee-d3c6-24a12f2f23d5@redhat.com> Date: Fri, 21 Jul 2023 17:14:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 18/29] KVM: selftests: Drop unused kvm_userspace_memory_region_find() helper To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-19-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20230718234512.1690985-19-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 90C10A0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: z9afti6ce81c3hgra137wbugutejs4u3 X-HE-Tag: 1689952480-647886 X-HE-Meta: U2FsdGVkX19WJMfvESJIwyVztYDvHBdzITm5Q7yX0dmzYd1MbOnGkQxaN4DWzIAEqlvDhaaP/pMaQdHFKNnuowuaknjmfEIiQr5DqSWLC5Q5/D1cDXUfkUV2+F/iD4hNyomde8lUxwNYUYJGYkNyU/guKz1btlJinKw2G3buRPyQLvntL+unGwpruNTMawv/oa28WqwtnqKlo2g370iFAy4hcGJTFOMlFk+bZTaebuJ7TVul7uBLzqWRdwOp8PiukaMEOdbJp7ct/KRTb8+Oi0HK4a7wwyfcq7FOj4H6DK2FloK6CxsHwRzVSxiR5u/4Wqzx+bCR5hosiw4zjg5G4CTUEdSPQpDmz8d5X+5KsxLKclpulA4Z6D3iQnW+n8w5q61s9RF06gUSH0viiwYmFdmN1zwVIdgCeDoViHXOmJpCrZ/c9K9a58+xfbN5u/zavqNPHZnZ3SGE5q2yvgb2bRPMohJlPCRR3njZ1y12HgVR+wk50J1kLe7srA6SuNZTF+omp0i20EYdwzekiImqftni0QHss46mhgvRsmiAGcxllCXuyz/ihAmi388YpuQ31J9We8dw3LVvxp5mbwUSbebQnbCRPBzlrWasUmh0Rw+oLzR9MXxoYLTEPa0uxg8eJMApGCiLMuZGcWZUv3nveJs40v10wvOXsHsq2q4g0oC6l/vQoS5a5gjkyKk3hD19vRgo6PexQeeQ1U2b3a02zYkC2pyQBE7X4kM0HFnwZNxHEnzs78oExI+GLPD27x3X6vo7djsBYZEYeyGODRSDdAoDcnrMN0f+t7QKT83eBAJ/w6p635y5vq4x2sJtfrmDffuJ7Rn37xAKHUG3SJeaMGQPvvc82USV+WfILDPQw8cddNuEi1lI6pnS/hd667b/dgu/fh8DTiJmfeg/dUHX6uk49+xHBzVErM+9SFnWphP0dIwQhB5IE1Te5WkLBzAjqW1TGr/AAMFk/ClGa7q R1ujdL9q ahMG9iF8LrEue1SvaRCqw2Om2FXEBbhbSDwnepcNKJKPZOUggXdiUyYcTafR8b1qdcX82mtbpwLHgNQBMuD8c5mbJLiuJ5KQsOdx3s8XYO44+VB6hTQ+RIpYiGak1eq5F4RUkbCVZMdBJJC2kKkvjXmbhMusxnWMRBlTxKxgmvpjk0OrZh9Loi7+v10zz6UqndDYFPjGFilmwpdpJxbM0TUVnY3j/1VOKo3CLxM/HgN/5Lcjn3xUwL9jEkH+reGFWL6JRcMvpH65e372zPsHYqvAjuVw7UMR99Agb3CLFNjftvasw2UyloX+53yISnJWgewc4D4naCztGU36fJoHFpAKNdTQul/9Z7ypLkEswkC9zflH+4NeKZEZpMF8RYKBz+eZXCfU6rhRWuBMQo5SGWO55s3Pk7EC7u8I/ET+76X+H/GoQ1yY1jZsIX/2XcFz6YTaFItiSoaHNHDhcft3kCT7nLPvZQ7xULSdgV53SK3htVXg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/19/23 01:45, Sean Christopherson wrote: > Drop kvm_userspace_memory_region_find(), it's unused and a terrible API > (probably why it's unused). If anything outside of kvm_util.c needs to > get at the memslot, userspace_mem_region_find() can be exposed to give > others full access to all memory region/slot information. > > Signed-off-by: Sean Christopherson > --- > .../selftests/kvm/include/kvm_util_base.h | 4 --- > tools/testing/selftests/kvm/lib/kvm_util.c | 29 ------------------- > 2 files changed, 33 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/testing/selftests/kvm/include/kvm_util_base.h > index 07732a157ccd..6aeb008dd668 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util_base.h > +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h > @@ -753,10 +753,6 @@ vm_adjust_num_guest_pages(enum vm_guest_mode mode, unsigned int num_guest_pages) > return n; > } > > -struct kvm_userspace_memory_region * > -kvm_userspace_memory_region_find(struct kvm_vm *vm, uint64_t start, > - uint64_t end); > - > #define sync_global_to_guest(vm, g) ({ \ > typeof(g) *_p = addr_gva2hva(vm, (vm_vaddr_t)&(g)); \ > memcpy(_p, &(g), sizeof(g)); \ > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 9741a7ff6380..45d21e052db0 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -586,35 +586,6 @@ userspace_mem_region_find(struct kvm_vm *vm, uint64_t start, uint64_t end) > return NULL; > } > > -/* > - * KVM Userspace Memory Region Find > - * > - * Input Args: > - * vm - Virtual Machine > - * start - Starting VM physical address > - * end - Ending VM physical address, inclusive. > - * > - * Output Args: None > - * > - * Return: > - * Pointer to overlapping region, NULL if no such region. > - * > - * Public interface to userspace_mem_region_find. Allows tests to look up > - * the memslot datastructure for a given range of guest physical memory. > - */ > -struct kvm_userspace_memory_region * > -kvm_userspace_memory_region_find(struct kvm_vm *vm, uint64_t start, > - uint64_t end) > -{ > - struct userspace_mem_region *region; > - > - region = userspace_mem_region_find(vm, start, end); > - if (!region) > - return NULL; > - > - return ®ion->region; > -} > - > __weak void vcpu_arch_free(struct kvm_vcpu *vcpu) > { > Will queue this. Paolo