From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15437E77188 for ; Fri, 20 Dec 2024 10:58:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BF646B0085; Fri, 20 Dec 2024 05:58:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86EA06B0088; Fri, 20 Dec 2024 05:58:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737F96B0089; Fri, 20 Dec 2024 05:58:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 54CFD6B0085 for ; Fri, 20 Dec 2024 05:58:22 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 02ABCA0A41 for ; Fri, 20 Dec 2024 10:58:21 +0000 (UTC) X-FDA: 82915037436.12.BC07BE8 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 5EBB74000D for ; Fri, 20 Dec 2024 10:58:05 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734692262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KO9VGuWdvuRdvvp8WfCovPvsMnVANf+aoBczuD6TfMY=; b=bpPl1ZaNfgGN84mjo3isSvh8sCekbQccNwOayrwbIMzHAYcn/LenQHHOs9aQetD+2MKB8B O44COg+JYPkhMCVkTHOQmdlnm8HMSH8KbMg8RvBFEQosuzHHYIG4cpSZi+Tas4R0qqVs6a LzZSuhFyYe2hpYGIe7JCq5SfPdY810s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734692262; a=rsa-sha256; cv=none; b=63iZw/SNIBMxKnLlJUdzAHup76eV1ip113C6mfEWR1LOogDmLw99Y/iNUdpZYGE34aiqZ0 6Hltfqz/ieg7PKwcNBjevn4oc7GCw3wnRfiSo54MidEB/aiQUgNv0DzXftv7glfb/c7xYH TjBVlsyGJ7Wa3/LbvlBPukKd3NUOH68= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf12.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4DDC71480; Fri, 20 Dec 2024 02:58:47 -0800 (PST) Received: from [10.57.72.191] (unknown [10.57.72.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0C613F58B; Fri, 20 Dec 2024 02:58:10 -0800 (PST) Message-ID: <765aec36-55a4-4161-bb30-4ff838bc2d98@arm.com> Date: Fri, 20 Dec 2024 11:58:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] Account page tables at all levels To: Dave Hansen , linux-mm@kvack.org Cc: Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , Peter Zijlstra , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org References: <20241219164425.2277022-1-kevin.brodsky@arm.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5EBB74000D X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 7xwob4gmh73ju7tbyq3nfg19nkgwmory X-HE-Tag: 1734692285-816207 X-HE-Meta: U2FsdGVkX1+iXH++Jbs/DWXQfJh+kXHRo7+y3EPkjOBIjJIE07Gw13WWCg5a2xZCP2O1FqyW1bURIw3Vv6Wo6FJKsaudpURD4jya33eWPU6I3Lfur0ubeIwr1R2y7GOlmn87LenSmpIjExvePL3M9wNhekA7uvSzZrg3TYIwXivYQgbKtCJ1LolAv35AEIYakQhTgvVdGlGq1Y2ksQWNjiSqziyxR0ryIjG3ZmjqdBzk1BK7aUa8oET/G4jtWMqbPQV4j9RfWOHL2C9jpfZPGf9IKmYMH9rAfm/oQgNKuVL+oXlpHPtZ5qzM1mvimJhMnTi7EcEdqVR7VDihTT4aRo5vNCsIva2Vzn3XFAPVXng2toGtFV7GAofw1vcgNIyntsxa7Sh6Kl3byT3R9LcmL27DBQ68k2Fan0i0lFfPhTZSAChljeHQOzjiCXYSLvJ4HLvs96+JTCk6HXbSYkfB7BtXw8AHgfLYqhJjtjXwDyIAYCoxkg3PPcfbQVd5qWbMN+1a7LNY4oRGlr2pyIb/3p3yD6tlsP4HiTuBjnQM/vXlksXL55iC4uOUH42CkUVHroukEGgrB+RFXGt1lk3z5AsBbyF7a7nLQaC90MFUJe2tFSZR8tVpwlBhIxvwbw2FcGjRioPhc4WNmw6W3Jp9HTK3erLxgc0d1QmNj8WzO6YgkBkJpmNVuVlJsbtxQ/+HNPYuU5/hl82P795XieZAU/41xEj0LGkiA3GLMV4WUGLuLySncEoJz5Ov2gLZOnYZCOS0Ng4JdvnU508ilKwY3PfdrKvx8f2apVXPGiNBbzGx4gvpjjDlrkpDTrcYkGvxC9Ejpe4lTa0kovqQXEaQBEs6PGvwAoWran0TUGFFxrSNnByr30TZIWAu9Mx3WEWhbOZxaI0YdNhDcLgwer0BtymIpBzmkUw4Ha+peY3fqg/mS/5PSXiiNgqOhVRVmpJsXa3PNZhdm0qZpqTh+QA DSjDY0BC ceaeGNYhWIvL1820EWBPWSciGSncmzn/D0poSwsh423in7wji60a1esf/kbuDZQbAbalUhq/M3OCdzzNQUvcS4gZeBQpmf4u0+XtIW3MkAtnU9apL11MpqrJs++PMYaTHzSN5SHk+uapopdNHkMWuQ/PEFp002K1v+F5lXftvjQlMwUrbfextWXKQwIdfZy+unvbXJxbXQy70p90bEiVclDPCP26UX0y0CUNaAVNZZKQYOIZjy6BgCqFLTUabNwo5Xu/L X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19/12/2024 18:13, Dave Hansen wrote: > On 12/19/24 08:44, Kevin Brodsky wrote: >> +---------------+-------------------------+-----------------------+--------------+------------------------------------+ >> | x86 | Y | Y | Y/N | kmem_cache at pgd level if PAE | >> +---------------+-------------------------+-----------------------+--------------+------------------------------------+ > This is a really rare series that adds functionality _and_ removes code > overall. It looks really good to me. The x86 implementation seems to be > captured just fine in the generic one: Thank you for the review, very appreciated! > Acked-by: Dave Hansen Just to double-check, are your ack'ing the x86 changes specifically? If so I'll add your Acked-by on patch 6, 7 and 9. > One super tiny nit is that the PAE pgd _can_ be allocated using > __get_free_pages(). It was originally there for Xen, but I think it's > being used for PTI only at this point and the comments are wrong-ish. > > I kinda think we should just get rid of the 32-bit kmem_cache entirely. That would certainly simplify things on the x86 side! I'm not at all familiar with that code though, would you be happy with providing a patch? I could add it to this series if that's convenient. - Kevin