From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 213F5C54791 for ; Wed, 13 Mar 2024 14:43:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A9CB80030; Wed, 13 Mar 2024 10:43:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 758B9940010; Wed, 13 Mar 2024 10:43:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FAD480030; Wed, 13 Mar 2024 10:43:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4FAE5940010 for ; Wed, 13 Mar 2024 10:43:35 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CAE19160757 for ; Wed, 13 Mar 2024 14:43:34 +0000 (UTC) X-FDA: 81892284348.14.058A9BC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf17.hostedemail.com (Postfix) with ESMTP id EB1B540006 for ; Wed, 13 Mar 2024 14:43:31 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Nmf6Xm61; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=K5ptLFKk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Nmf6Xm61; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=K5ptLFKk; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710341012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O3ouuLw+tQrb8/EbRY+xlkqcLCuq786lUp+bYp4r2zU=; b=MTnvjGeKNVkPm18d7mGsBH9ZOVO4BrnYZ8i9kJTNB0XTFMqHtrXK3zq6YIdJ3w5u3KCi3W mA9bd2x8XYPGxWXvwI5Cue9+f7fVy29+rXKFXAK2tVxtkW7dYUKW3d5x2jt25jQvTyX/sY lIAr4eotMmKbx6y9UM6YH8EUNX2Pdqk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710341012; a=rsa-sha256; cv=none; b=tjx7ehn0WxSKV8rCjpEkPg5cw5bAsl25YRyrkd4SLSk7j0rnm4EDFeZ+GB7yJrBpI/trGJ AY6XkLADdL3Lh2iS12opOVfqqiX1PmUe7l3VQlx3sz2FQJIK7XTHrhK9082yuyhZ2XvxSk tT+z3pOlmsCMLvoxjhEv4t8MJJz059s= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Nmf6Xm61; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=K5ptLFKk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Nmf6Xm61; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=K5ptLFKk; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C35421F7D4; Wed, 13 Mar 2024 14:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710341008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3ouuLw+tQrb8/EbRY+xlkqcLCuq786lUp+bYp4r2zU=; b=Nmf6Xm61+zxcWS+I5r9U+P3gPHU2vCbG7ufrhgetyuVBRCFoAAp+EoXhy5xUB5Tmutzepl 7YmX4PfY5TaUAkjwOQpz9y+4LHQEPr3MY6QlMMsIFpMnXXofcmRb61UVwIlpEK3LPlPdr8 EojUYmzwXu4oWcfNFWwBYddlMSbm8uY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710341008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3ouuLw+tQrb8/EbRY+xlkqcLCuq786lUp+bYp4r2zU=; b=K5ptLFKkA01m4S7ajiM2r/a218s+QmeM+PIHTAAq79pyoH1Wrn2NfXTQLwjdD9JNIp1I+B vI5NUhUMygRO1rDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710341008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3ouuLw+tQrb8/EbRY+xlkqcLCuq786lUp+bYp4r2zU=; b=Nmf6Xm61+zxcWS+I5r9U+P3gPHU2vCbG7ufrhgetyuVBRCFoAAp+EoXhy5xUB5Tmutzepl 7YmX4PfY5TaUAkjwOQpz9y+4LHQEPr3MY6QlMMsIFpMnXXofcmRb61UVwIlpEK3LPlPdr8 EojUYmzwXu4oWcfNFWwBYddlMSbm8uY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710341008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3ouuLw+tQrb8/EbRY+xlkqcLCuq786lUp+bYp4r2zU=; b=K5ptLFKkA01m4S7ajiM2r/a218s+QmeM+PIHTAAq79pyoH1Wrn2NfXTQLwjdD9JNIp1I+B vI5NUhUMygRO1rDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 73FB413977; Wed, 13 Mar 2024 14:43:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id IMkYHJC78WXjZgAAD6G6ig (envelope-from ); Wed, 13 Mar 2024 14:43:28 +0000 Message-ID: <76c84f17-8b99-4f68-a6ac-a0db22f5ace3@suse.cz> Date: Wed, 13 Mar 2024 15:44:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 20/37] mm: fix non-compound multi-order memory accounting in __free_pages Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240306182440.2003814-1-surenb@google.com> <20240306182440.2003814-21-surenb@google.com> From: Vlastimil Babka In-Reply-To: <20240306182440.2003814-21-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: + X-Stat-Signature: ize17th6iuimi7nxusnpndmjbq5az98d X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EB1B540006 X-Rspam-User: X-HE-Tag: 1710341011-178766 X-HE-Meta: U2FsdGVkX19963MUWJ5irGGK03e6pbYDY2okDy2k7SdN2Q/3oo72u0BvPi+CelU403svcDCHD8aPxkq2kH/0YicIPuSEdcRPnIOhAZhqE28jx8EchmFTVX6Uvu4aaQ/fdH8Boe5vXlydyP10d1rTrEiVwxDV47iIxk62pe2p78ddw1nDyM6T3QnZY4MIRPuehC1EiSX7lFyhBhKrW3dd/ZJMad0Po5gFBfWsZh9u2XTP/Enhq06DRZVp4tt6OWfI4hnB79g2p2ZCCvGR49RWPaRGty6/oqc0IBXs6G+GNPK4wtmglzM27E28KoyNmTW0S+CI2amfORCG4QWZb/mja7eMSH8i6c6OybQBZrmTSPFUOgFkvATX9kcXYP0Avei5EXCqGJXubrfQ0y1TGkOX8RpAVpya+FMDZlJ3MIQsN9Z6hbtw+3kcLsOorqi9RI4UOTDx1NB4KYP0qtNeNxwQCJXKdXYla+CDdE8MBvfkQn8Z8iIhV3MMqIFs8tDz0MmisIVPMKgFZHckjZABknKXNm52G1pa6YePlxKfSUuH2A8I62B8eVxNy9FL3lW3q45zK5vMh1QAbirYnxf6WsXIzBMdj+T1DMFf+rpSjAjI70Za0gbeuM/8EmevZxxGXMW6SsuZF9yBtXb7vzO1FertjUc7HjcjjHF/ccS0KOXwHZqpgY9ihZQUQ8tvX9TKqeywWyIYEt++L3BORijGB7qauGjBD5mYrk1MtFG7ppmsik9hXBxNwBX/J7yT1ZkkEj9kSwDvaYLX85VR3TNPycMVyaL2cCLJR2NaLmM5xRMMPH4vgc99ARtoXEiTNhdZ3a3a5rq3ZvYOMXSBgzhm7GAsCzGSP69MApRkRcIoPibwHnF25bVaQfzVFko/wIrsgtfkgTUsUdNE96v1HS14Jvyi9guRBx3p58Npf4K+lN3MvtMFT4j7yd29lxMpNxnAN3fT2NeqLj63hjj5jqyxyso EClIb87G Y9cvfR3R7E83jNbN6pz6grCVCUzyaV1IA5QJjv5WJaoMuVrji2wrO540chQRQvi+x4BsxebOob5SVGR2tQ3oQ1dtdXsBnKcJzQhcn3yavLSVBUgXqP97rtogp9vaaCEjzFP6O/XD5WDYePqPfC5PKoYS2MvkoXY99HRL47BRYxmd1b/F8480uDdPJBuSgbc9IY6OmWisOx5tU3B0hyYpL7wWKQxY2cqMeMAgVfOtdtUodEW7raGl4eLsVN7yYx5q9f1ccg/T62utTElJ/VixeaQo4B3R4W9Id2tPIdEw95CtUkBb1N8nLHngfjTlMrF+M3aKs133zuY2M4X71eBCQLALqKOtuhL8WYq6WJNepKFjggnfl1PhozoXAZcpJqA955RwgxM/ksUB7xL9EqFM6DKHxhg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/6/24 19:24, Suren Baghdasaryan wrote: > When a non-compound multi-order page is freed, it is possible that a > speculative reference keeps the page pinned. In this case we free all > pages except for the first page, which will be freed later by the last > put_page(). However put_page() ignores the order of the page being freed, > treating it as a 0-order page. This creates a memory accounting imbalance > because the pages freed in __free_pages() do not have their own alloc_tag > and their memory was accounted to the first page. To fix this the first > page should adjust its allocation size counter when "tail" pages are freed. > > Reported-by: Vlastimil Babka > Signed-off-by: Suren Baghdasaryan Reviewed-by: Vlastimil Babka