From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9119C83F22 for ; Wed, 16 Jul 2025 18:16:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71AB56B009E; Wed, 16 Jul 2025 14:16:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F2316B00A3; Wed, 16 Jul 2025 14:16:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 607C86B00A6; Wed, 16 Jul 2025 14:16:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 513CB6B009E for ; Wed, 16 Jul 2025 14:16:05 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F29531A042F for ; Wed, 16 Jul 2025 18:16:04 +0000 (UTC) X-FDA: 83670931848.28.5BDC0BF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 71E10140006 for ; Wed, 16 Jul 2025 18:16:02 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GgWewUXJ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752689762; a=rsa-sha256; cv=none; b=Jd6s48ZL/mY5TO+ES8fbgGY35UncKUo9UKqn+CT05YH6fM3V06MQh+Dojzn555BG1feanE AxEnAsM9FEIadSQCyA4YCNEJYNScYaSw1ARvW7Eq5FlkIaNAo5D88OApbE3I6ylQWTCqgo zxAnLWFeOqq5rfBk1EG0oqkz5WYX0Qc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GgWewUXJ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752689762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YJlXYqPs7Pq3VOCFDHYdUl1qPeHQCNweMrgKcwXRJ1g=; b=kDLKcoUrTJi27+Co5fBauPma5cfQo39931w2Oms7/uR8UX2+wy6PTIpbJPO4sJPjOYHiiW nt5pH4MxjWKlnNOp+prALioiz+3Re7CrAJZuVKyjDvXz0JvsFgY9bf58n/FGcb97PIApKu 1IIQf/3SXdZbg2AGXMUX4E2Q1tB9ueA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752689761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YJlXYqPs7Pq3VOCFDHYdUl1qPeHQCNweMrgKcwXRJ1g=; b=GgWewUXJq7VfCqrc+xHFQHXPF0ZUgAHvvbtwNEnmf+Z9V66ZOruXs0sgwQZspRXm9wQVIu YRTBys11wWeQq5zEGTMSvvUPX9tWFwgUFeBfr9G7QCKc14haj1ME2CdlkdHji12pDaXjmW +oTC3YkbW0x3Wytf0rur6x/57Ck7bZM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-QHtu_lMaNEakYiIxdlA2dg-1; Wed, 16 Jul 2025 14:14:27 -0400 X-MC-Unique: QHtu_lMaNEakYiIxdlA2dg-1 X-Mimecast-MFC-AGG-ID: QHtu_lMaNEakYiIxdlA2dg_1752689666 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4f7ebfd00so50177f8f.2 for ; Wed, 16 Jul 2025 11:14:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752689666; x=1753294466; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YJlXYqPs7Pq3VOCFDHYdUl1qPeHQCNweMrgKcwXRJ1g=; b=ay8RYYzZ+UUPjYJm3xGR8/t2pGgy91xfOYLv1LbmAdXq3WzUtHg0A39Tyf2NllzuT7 KYCPD3xzPXWxsRKOAHKWG3WBTBWnRia18zzkuFPJHd/FtLxoAmraIZ9bnFZZzN0dG2ae wYCb7Gr88xBsGTPLpn0SlW5S4ATI2hOJta4L/D8uYRsoij0cHNqqq748Y+FrdwJSwtrv c9xfqQOZKw/Qw2cdlXdHHAVQFU8FJpRyEM4se6vn5qs2XU1dDjL0znLwG5mwMKaU9QzM PIhuEgLjWDOor2IV3HjXnTlSSaj2mO/lUu0416UfZuNxmnWyk2bUAboMhK/Vbd3IEZoX sw4w== X-Forwarded-Encrypted: i=1; AJvYcCXJSyW7LE1a0vihABYP2+46mmMBBg6XEHZIvSO6ZgnrSiONnCZoZJTAHkt3dq2W9hXZO9TQD9VT4A==@kvack.org X-Gm-Message-State: AOJu0YyJ7PPkMm8TO13qNZx9Z1Zknawv0mUFmOW6YyBKOp79oeab/Qyk GQW1zQFEpidisz2g2ZmKRbSWN6smO+h7OJYRI3JvH8ILAU4Ylg1lKPQLIKy6YPhhSIvd0QDYyNO i5aVOv1Bqxnp/qmqBKPOba2RPlWq3zVuOuTph8HAzus2CrRQJMVB6 X-Gm-Gg: ASbGncvZh3XozDrhFinVzlyoi2YDVNaDlE+5NJtnNHcsUOUU1dnicvkBmJKztikFTKD GVE1CGTOvO8imab99jzWYWCL5GktZnR5//dvl54Xx/pkzQIaJ1s5CDCz7vXG85OZyRUB16ZjH/s QgElCZ5QRYXJ7ONgBLjsq2ukQNtQ2u7BTIkkLCxEad2TeuuoC/OyW3YjkEr0mOANvdECACC3Koc JaZeepeB66XNJ7vTt83+lBM//jkTVv7xIbr2fjhNnSP1dou7CajJN8hoRlFIgrEf0Qf8bK3BW4g BfaNPw9GBuJ5n0r4ZrvtT1OMxheP9Iw8/ESCBhcRZ3EmgyBIIgkdDANmJRpgcMk05hABxmk8715 t8uDw+lfvnrNXRg+d/t1SxmOuP/vHDYadNA1dzJUuHocPIemsE+oA8xsEwj9AkYYMUiU= X-Received: by 2002:a05:6000:1449:b0:3b3:9cc4:6830 with SMTP id ffacd0b85a97d-3b613ea3ce3mr59772f8f.48.1752689666242; Wed, 16 Jul 2025 11:14:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGs53CY8fblnEWr7zu7Fa4O92Dr33AAcDtGHdHy2XlF5+DFKJIkWdqEP/4mlPgF6zQ41dQPzg== X-Received: by 2002:a05:6000:1449:b0:3b3:9cc4:6830 with SMTP id ffacd0b85a97d-3b613ea3ce3mr59751f8f.48.1752689665812; Wed, 16 Jul 2025 11:14:25 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc9268sm18434096f8f.41.2025.07.16.11.14.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 11:14:25 -0700 (PDT) Message-ID: <76d80492-e85a-4948-8c25-3885be23ca7f@redhat.com> Date: Wed, 16 Jul 2025 20:14:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/huge_memory: refactor after-split (page) cache code. To: Zi Yan , Lorenzo Stoakes , Dan Carpenter , Antonio Quartulli , linux-mm@kvack.org Cc: Andrew Morton , Hugh Dickins , Kirill Shutemov , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , linux-kernel@vger.kernel.org References: <20250716171112.3666150-1-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250716171112.3666150-1-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KH_2gatFsChlWegPcOsei4gRg5V3uZdaNvEdXWXuhb0_1752689666 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 71E10140006 X-Stat-Signature: o4pcrqoiy5ryjf696m1na4r5w1sxs46q X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752689762-70267 X-HE-Meta: U2FsdGVkX1+6eVpqzIygkL6rgJf32cAu70t0ndUGAmyMCrIrT8OyBVqrSOfomzQONilQ+ZnsCflfTJWxCpZWGfIJeGun0yWSz0aoTMBg+z++7hsRwOd/T4bPntdW2wR2X2NaeZarkfrE7y6HvpPqgAA2g2M6tw1IEZBZGwJatRvStbaKMQHxk4eSj4iiuxSCDFFaEbCYSFv1/5yS0/VDXnJW5/PDxXDbfkPFI6a4IveaOc+Wk2vpY0hI7g1QpfGE8WxQXrfNxJZfP61v8PFRtqy89P+ddxhE614i+b976Dk+UmtnANosyXBr+22wua02I78mO80CTqTvB0K4L/Y/VCO4XEi2yXxTbuYh5T8ZYh3bGWGfzbVkuEhaq9UpUrWCH7J0/VwGisq6QV0dZ80D/BPyed4fd0q2dkJCoBi7q5G5DrDjDNxn22cd9Us6RnW2OFSfF2/nwPppgBp7AkvFPOOQGhDrZlwAyHNHRdxDtc+oO9DhnVCrhmvdlwL3iqzVMCBlHkZTkdENZN3p3MrnPXU+yrk4tjG1ZDQjCogPlK9ynSZaZg6qTKFLIFtDeFKXxpOG/iSyL78SxvGYRqz667BivxVTjK89WoJ80TmlzixQIg6yTYUHH3Qh2WwAUuRviGr+yeO/9w8+ukhB82zUDeL4nxiNJkpBKRvPIyxQ4A5Xq81o9Y9diKmrLsaS79KrFLdmKl/mpAJ+GyJowGp8rJdO94gvr/sgoH53SFfo9hlMVWG4EwirRK1kClnujdEqXiNajdIk63rAKQzzop9X1fjRf2sNpbDqt/M2KgbU+3KUJLkl2SDnXxXIoY0EUe6hHSTBwRJQB/7Fnew/A9rqvfrdRsUdh0FMbXjlCkqMUibjXC7rea9JgwB1mr6UkRCTP6UcB5l+nyrdmwUeIN2Mz4vXY6Kb7Ih8AQcyrSgAJCJRTCwLE+yQz0oQ2vvL2luuiB3HLDYbORlVOylFEkv mD0i6cT9 SfBkxcbpR/cDOTfqQBQx26APLYJw1bnZDDmKYxlXxUyv1h4AQj7OVvXtAMwDRSLw1gmiDEWwDB5j48mm1S8DoZ6bM77701U2+eaeT5ScR4q3K0w8zVwM6Yo1Z1rcPFKeY1FwXpPp+fY/szjLWEtPNNPvbpNah+IUnbo/k0h9B0JbMCuCCmoeyQkTTYSMq64E/QBgSsLoofglhkdSXrqNz/LQsEzhei4ScxVXJWgoeKwm3C8OEALGkz7s3OsMYr/dIle5rsVSy7yBqTimvq5TiVntWkNwk3D3oTyW7dGkSXO1bpcut/phx6HVnm1YCINbOKOMT3hJMiD2RUqJBb1+IcHKuURvcLEapUeweccOea6G4kC1S2q3vNvcLQM3za7diXZN7kDg3j+e9WzqMPtxQfVF98udBPkij3t+tImj6RphtWUIySy7HW0e6Dr1yjDtdHALtVmXVpcA25tlWXssqfjXcvh+m15be3N68goGvUkd4QaxsLxa5gCs+Z0yay75CQGgGG0ZSo/oBxDRahF7tjavvHnrw28XtqrYVi7YaQjuzdu8tOfD90T3RPiuA1ucczKP+I6kPUCPH/xrCZo0IFBhz+OiQSXhtSdKM59mkvIh1VK+aSAwWDpAEIWW0atzcIKMrMwgiz1Ll7u4VRm8WTDAroz6h2AuNQFa805JNdDTpTRA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.07.25 19:11, Zi Yan wrote: > Smatch/coverity checkers report NULL mapping referencing issues[1][2][3] > every time the code is modified, because they do not understand that > mapping cannot be NULL when a folio is in page cache in the code. > Refactor the code to make it explicit. > > No functional change is intended. > > [1]https://lore.kernel.org/linux-mm/2afe3d59-aca5-40f7-82a3-a6d976fb0f4f@stanley.mountain/ > [2]https://lore.kernel.org/oe-kbuild/64b54034-f311-4e7d-b935-c16775dbb642@suswa.mountain/ > [3]https://lore.kernel.org/linux-mm/20250716145804.4836-1-antonio@mandelbit.com/ > > Suggested-by: David Hildenbrand > Signed-off-by: Zi Yan > --- Thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb