From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B13C4332F for ; Mon, 30 Oct 2023 17:11:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 103A26B0253; Mon, 30 Oct 2023 13:11:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DB7E6B0254; Mon, 30 Oct 2023 13:11:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBD6C6B0255; Mon, 30 Oct 2023 13:11:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD5FD6B0253 for ; Mon, 30 Oct 2023 13:11:58 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B0D58A067D for ; Mon, 30 Oct 2023 17:11:58 +0000 (UTC) X-FDA: 81402770316.29.289E825 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 4FAC8C0005 for ; Mon, 30 Oct 2023 17:11:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cpLDJt2+; spf=pass (imf28.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698685916; a=rsa-sha256; cv=none; b=oF1ZWHr/GlOqVprrAy/o9ewi7rBD2gn5RcJ1RTtx+kWyeYCpJM5KcXAoG90haShnAcObCj 0EocHpPLQ+vNZDM+CarrTwx8Wz/gd0NJ43nt1yhEr4opWNctGhgMo7jdP2Vhbp/c7AFe0O JxoK7NHsKIaHMJabEgQu3IINN2nWns4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cpLDJt2+; spf=pass (imf28.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698685916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lo4ysHz5pmHfFsXnk84EoayTJ3hTlIhc3rVOfp1rxtc=; b=8It66j8mMwF70GPkclmj7A/nUz2wvnc4L7qgkOAqroLdFo3db8fbOoNgzgOZ1508WpnUhh VmTeRGqc+Z27zPKbXDRxBJ6tW+McyHQc9Nnw6It8eBTLzW/Y0XHmRiuAXIAUqD8HKX1rGV lD2lxRgISSRAW9Zd9nGTmCuMkihTLBg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698685915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lo4ysHz5pmHfFsXnk84EoayTJ3hTlIhc3rVOfp1rxtc=; b=cpLDJt2+6yxkZbmC7dAvXetuv6zb+Okf2WZrlidRuXr59dd4Ieo0D95vLh1pG3XpMitwSH FIYEosZk7PEEkIiKFempJUazAQzvBf4NHCnThG1GmfPYeV/D6LBQVQBFS6toBJtoXUnkfc xAd4JF24ptyQSHh5Q3SK3zFHgkxwjko= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-J5svvpwqPHW8EESytnuw0g-1; Mon, 30 Oct 2023 13:11:54 -0400 X-MC-Unique: J5svvpwqPHW8EESytnuw0g-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4083717431eso34573295e9.1 for ; Mon, 30 Oct 2023 10:11:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698685913; x=1699290713; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lo4ysHz5pmHfFsXnk84EoayTJ3hTlIhc3rVOfp1rxtc=; b=ZLPq087R885NnfACsjpVYUwy+1gD02xIENMa14omaBuSBWIS7BRKtnXwtAR1Ja40rK Q8Qx/uHmMYLa2xMm7l1Mwrc20tUd8OIASB+0HORN2/mvtq+OKKG4k3ukyOYc43yDAwRh 6schQBzCXjV+CRoMb6dVQPUcRsPapRu7xO5PIFBJTieDx1mAY+yzFzKLMbA9OyINkXEt FMbe1Z/nRN950JhtObSNNOqlY56FW4NIACWsRrdmCLALriVxKbxHTWfVBkW+oRnKtD2x 5SeF5GYyLeuditQ5/1Tlm/AvXBM/fDuo15ru5yu/IVMxdvWLcncns8dm3ZA2wlWSybb7 3Y1Q== X-Gm-Message-State: AOJu0YztXXUQc5tgU1qYXUqJbUhixsjeN1UBRaHtq/aBXrx3RoYS9qwd HQOZbZ6DDro2d/UKb5niiMcTqKzzAP4RWXIxsY1yiSlhmFSUCdnrMpIz27ogrCCl0isNhsRnI47 tiu2CC0R1qT4= X-Received: by 2002:a05:600c:1c9a:b0:401:d803:6243 with SMTP id k26-20020a05600c1c9a00b00401d8036243mr8797102wms.32.1698685912895; Mon, 30 Oct 2023 10:11:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEE3mzsAlLnekLWdY8A4rueILcmfn/0LGvZfOgJVm2OXLCsoyw1l1K7DLfNbIxoxk9UoBDhkg== X-Received: by 2002:a05:600c:1c9a:b0:401:d803:6243 with SMTP id k26-20020a05600c1c9a00b00401d8036243mr8797063wms.32.1698685912474; Mon, 30 Oct 2023 10:11:52 -0700 (PDT) Received: from [192.168.1.174] ([151.81.68.207]) by smtp.googlemail.com with ESMTPSA id w16-20020adfcd10000000b0032da75af3easm8617198wrm.80.2023.10.30.10.11.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 10:11:51 -0700 (PDT) Message-ID: <773328b3-0ef0-4e93-afb9-6fba3302b8a7@redhat.com> Date: Mon, 30 Oct 2023 18:11:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 10/35] KVM: Add a dedicated mmu_notifier flag for reclaiming freed memory To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-11-seanjc@google.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20231027182217.3615211-11-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4FAC8C0005 X-Stat-Signature: 6899tfihxrkgobq3izf4og11npannr6z X-Rspam-User: X-HE-Tag: 1698685916-238649 X-HE-Meta: U2FsdGVkX1/ClUasUo7WgbLQgn5szy4UPMp2Yc7SaKNFgACOgbGuv/3DQrbA+IwL8y+pfQnqGM+J3SpZnrZmdgVYDnW3TQSPxjbmHvlnembTiIxiUBHygLUJxQzWs4/mP5+pDwM/YqCsnQfmzk3U0fwK822Thgg0BdnaxD/zgqwmCfbWwsGWxvwwTgrCrPD8N3NeAMGZsbBuFimOC23hFoBQ5GPa3pYBmNQ0dP8G3neZjedNLU1eitf3l1MeuARvWyRsFAx4uJnPC9q2IFuBHRfVTKrMiC37zWLnBP/dwxiVSxEmtbzNLShMYmL1bncq1IpddIUN8mWXK5ZRob6+qAHak4CnUreFhHHZ9GLM9HPIFHGcWUVmzti9/Uvlirv6qSRJPiByEdphPQ5ddFlmukA8xvwTSEk1MdUeo3ysciVLoPzsHpK7+Z7KNmcTZ/Gsx1u98XZaPD+NqBoXHxBUsSk92wLOxJvczP4s2Se9uLi5pFmNuUmxFJHbYX2Oc3x4F5qqSxeaS6mIAStLl0VlVbGqNq0GtXaZdhRcC7J6nJhOqfaEPR66l7JjLx8J/UjUBozcXMUt31s7ezXlSwbIlLp8bweCfO9NxCzX9TdI2fQ89QcTfWdqThV1USNrgcKhQzEWZ0JrX5Pzd/HhKkSlHPRBWVx7jND8jav7mCD3OwduvyHnjruviHIqfGrGnvUySYcAADx9nvg11lr+5p30PXH7GuCle1R4Tzv/4ZFfkQYig7N8TU7TUduvnliN4rC+AhpKUzMW4DIGQuwpyiLxEM2H8soXu9adGk2d3G2K7Ei9i/xrPGYzk41nhigOTZqPcQUJBFtU8YpdJMbXw/DRMYv+0JDpcbB/er9WkIH+ZtCbzrm+8CaVCg6XcXhXQeyO7W0hE3/j3Uv0kVRSvU8dxDQMsTEJmAatxlt/WXQaZ7ZzUBTL7ae8sOcrjO5ovXJPcfSNGXXCrHbRdh+ra+t 6iYU0lTz a5U0+4tdhKAowFhVpBVk7J20O5XaHr0hstbl15n4kOxAffBGGnoCUe0xLImDsj0NZgAeJtg09aFl0UkrBi80lVo7G1iR+juEPM7bnkhgN/FIynGc3lm2Nc/B7cXta8XUKe0eb/wfhk3GyI9N/g20k6Ob/y2JMWCjVcuy7pcTmrFZbCPgWGXXaI6uIdH7m9sh8beQ6uBhYu9bHkmyuk8Nhg9uHyjMSnsFw5pTsqtuXsXkFbVicSrsGFTX5lw988cEfgFidip4qwcaSiIaHvKKIbHzieu0LdOQ1+wP9TDLup6n0BeUUfdJd49L0EDi3HjFrHs0itu+V89DhaUasu7cOMLqmplbMX9Li25ZFSbMw2x1WGMR7pWIGTtkLau5hOJOSFrcql9OVhUStFxgZ9AEbQA0TO5StK7iotqqk9Mt1EwSzjL0byUlBZo0aRbaTyZ0qrH+Uwh4DMNbs9sglbPkb8ORb+hT3YzuTmy3Cca7dcuhUyNAeXRy4WhR2F8rFAO+IjubcDBm1nL27n8rJKJsMgAcz16MPZZfU3Y3u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/27/23 20:21, Sean Christopherson wrote: > Handle AMD SEV's kvm_arch_guest_memory_reclaimed() hook by having > __kvm_handle_hva_range() return whether or not an overlapping memslot > was found, i.e. mmu_lock was acquired. Using the .on_unlock() hook > works, but kvm_arch_guest_memory_reclaimed() needs to run after dropping > mmu_lock, which makes .on_lock() and .on_unlock() asymmetrical. > > Use a small struct to return the tuple of the notifier-specific return, > plus whether or not overlap was found. Because the iteration helpers are > __always_inlined, practically speaking, the struct will never actually be > returned from a function call (not to mention the size of the struct will > be two bytes in practice). Could have been split in two patches, but it's fine anyway. Reviewed-by: Paolo Bonzini Paolo