From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Yeoreum Yun <yeoreum.yun@arm.com>, Zi Yan <ziy@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <liam@infradead.org>,
Nico Pache <nico.pache@linux.dev>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Usama Arif <usama.arif@linux.dev>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
Kevin Brodsky <kevin.brodsky@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] kselftest: mm: prevent random failure of huge page split for khugepaged
Date: Fri, 21 Aug 2026 11:35:40 +0200 [thread overview]
Message-ID: <774ee653-5f01-4a06-965f-fd3517743c08@kernel.org> (raw)
In-Reply-To: <aoeT20fPw57DtpGe@e129823.arm.com>
On 8/21/26 01:55, Yeoreum Yun wrote:
> On Thu, Aug 20, 2026 at 07:37:29PM -0400, Zi Yan wrote:
>> On Thu Aug 20, 2026 at 5:23 PM EDT, Yeoreum Yun wrote:
>>>
>>> Well, this also works with hugepage_save_settings() and write the
>>> khugepaged/scan_sleep_millisecs with the maximum integer.
>>>
>>> I don't have a strong opinion but since it seems more hackish way to
>>> change scan_sllep_millisecs, I use madvise() with MADV_NOHUGEPATE.
>>>
>>> Would it be better to change using APIs in hugepage_setting,h?
>>
>> No. I did not realize there is no way of stopping khugepaged completely.
>>
>> BTW, I am curious about your khugepaged config causing this issue.
>> IIRC, khugepaged scan interval is about minutes and
>> the time between madvise(MADV_HUGEPAGE) and the second
>> is_backed_by_folio() should not be that long.
>
> Yes. it's relly timing sensitive and I've failed to reproduce in the
> real hardware. but in the emulation environment it often failed with
> the scan_sllep_millisecs as 10 seconds while the test running.
>
>>
>> For your patch, maybe you want to check the return value of madvise() to
>> make sure it succeeds.
>
> Yeap. but it seems enough just worning message for the madvise() with
> MADV_NOHUGEPAGE.
Yeah, I assume we can assume that we are running on a recent enough kernel that
supports MADV_NOHUGEPAGE.
--
Cheers,
David
next prev parent reply other threads:[~2026-08-21 9:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 19:40 [PATCH 0/2] kselftest: mm: fix some failure of split_huge_page_test Yeoreum Yun
2026-08-20 19:40 ` [PATCH 1/2] kselftest: mm: prevent random failure of huge page split for khugepaged Yeoreum Yun
2026-08-20 19:51 ` Zi Yan
2026-08-20 21:23 ` Yeoreum Yun
2026-08-20 23:37 ` Zi Yan
2026-08-20 23:55 ` Yeoreum Yun
2026-08-21 9:35 ` David Hildenbrand (Arm) [this message]
2026-08-21 14:07 ` Zi Yan
2026-08-20 19:40 ` [PATCH 2/2] kselftest: mm: replace usage of /proc/self/smaps for check_huge_xxx() helper Yeoreum Yun
2026-08-20 19:55 ` Zi Yan
2026-08-20 21:26 ` Yeoreum Yun
2026-08-21 0:09 ` Zi Yan
2026-08-21 0:26 ` Yeoreum Yun
2026-08-21 1:19 ` Baolin Wang
2026-08-21 1:40 ` Zi Yan
2026-08-20 23:49 ` Yeoreum Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=774ee653-5f01-4a06-965f-fd3517743c08@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=kevin.brodsky@arm.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=nico.pache@linux.dev \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=yeoreum.yun@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).