From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D64F0C54EBD for ; Tue, 10 Jan 2023 01:22:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 489D7940007; Mon, 9 Jan 2023 20:22:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 412E18E0001; Mon, 9 Jan 2023 20:22:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B387940007; Mon, 9 Jan 2023 20:22:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1807D8E0001 for ; Mon, 9 Jan 2023 20:22:14 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D942181C62 for ; Tue, 10 Jan 2023 01:22:13 +0000 (UTC) X-FDA: 80337138546.25.9313616 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf21.hostedemail.com (Postfix) with ESMTP id D03C41C0004 for ; Tue, 10 Jan 2023 01:22:11 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LEh+C3S3; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673313732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pVZ6f7tMngliVnudtq58n/e3njfIMDQN+Yul9m16g6U=; b=sGSxSTGXX9v+Rgs6DOoqdi1Y5MpAW/XvNDSrEHkd4mYblE+opjCtzfs1l2AmQEBhlJTUfu MPa/UvWUF6TJWSKg5Vc7GVVhdOb+/J+elMw1ST/HNrWWc+d2oUVBPRChip2d+J2Be3O7Ds 8CgDWzxIRumSrGkIiUEvcldbQ2eyMJc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LEh+C3S3; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673313732; a=rsa-sha256; cv=none; b=U00MNTVahh91VsdeHMtuMLh15l2fiFTFEhBVOyBVyjvS+yNwufbH7CvJj18aHHcFBXSMoR LUAF1eg07LVGh+zYEcK8s5aWwdhISOviZhvqxe2iAIgTarYcN7mCMcxSbCNPHSCZ4nkNr4 fporz55KyTiO3DRjLKeDMc7FJg228/Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673313731; x=1704849731; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=4lDBthtxkF9BK72Tb/F4AAov7TFWGXDqWmGMUa8+rYs=; b=LEh+C3S37KQlGIwXl6xeDak6Hsnm+gMJLcFXjml31Kk+i+F8MEam6BId yI2x56OchFnuU31SnW5/V5fDirKm25qrXc2Iw+XfUubDGl04uCnhMa9ik s+zrpp+gBFXfYrFqN3PXjXTuoYHI0Dfur3pIpOrB/sChP74zem19YuEi6 Q9Kk93tG4rammy0K5NYk22X3uYA2TaOz3ZxB+L6PAcrtWz3n/93IfoWVm 0ZIOoJCctUn3RFkRFyIPvAOfT29itzdeVjo8LjqwPBk0gtdkjl7ZX7zQf RNmc17jRq2LVEvrosvRif9REmZDA+64jPQPfFZir5fXHQDPbJQhHZQWjk Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="303391984" X-IronPort-AV: E=Sophos;i="5.96,313,1665471600"; d="scan'208";a="303391984" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 17:22:10 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="902198111" X-IronPort-AV: E=Sophos;i="5.96,313,1665471600"; d="scan'208";a="902198111" Received: from swapnadi-mobl2.amr.corp.intel.com (HELO [10.209.29.117]) ([10.209.29.117]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 17:22:08 -0800 Message-ID: <778a6c80-a955-620d-a82a-c2ca82f26363@intel.com> Date: Mon, 9 Jan 2023 17:22:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v8 11/16] x86/virt/tdx: Designate reserved areas for all TDMRs Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <27dcd2781a450b3f77a2aec833de6a3669bc0fb8.1670566861.git.kai.huang@intel.com> <2d7d2824-7aa7-5f96-d79b-b44ff7fe2ef9@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D03C41C0004 X-Rspam-User: X-Stat-Signature: mx65kkochcxu3ffda7utsn7y1trnnigd X-HE-Tag: 1673313731-158407 X-HE-Meta: U2FsdGVkX1/jm4TWU6vd17b59DsyDX0O4VEiDK9ArrCyHZKIelKDfP1Zl1K7veeBX1o0t2/KLDdA3PcuIpNzKM5X0fvPgTJ7NW2zXFBWrmTUTDyatF6DQv0gkxY1VVjBOuPoxvtXw7yxvUlQ9uRx0/yjU/IyW2I1SWlp7Qu0dYqSkJyQbaPu/PHQzTCqG3OAWQ3XYHhaA7IP+79oEqbvZFyRDwU/kPI0/o2Xh4ybOQmQ9kMLoduNqDRcerVEPYSrkodAXNMfJIPgaMbVozRYAGaaZ4FBH0spaVLacKI+/dAxM2BNIk2OGv+rKa2VuPxGant58Nkm4XkX9zZ9+qJypRF+bjZtQl4UTS0xR5eVHxz3qn7tyY8JpDICAVi+AI2NHK9LXZCIPuMbI/ELMivANVmPikpXYeEMdVDdlLGp3RTPGvKuyS0ln5lE9yBCRDatqA2CrVvkAkffthymRAcNV2HCdws9/nFnqokxHOaKYdoVirGgf8cd1aiBO8Pvx97CdfwDYgmm62UqNd6VmORUZs5Yqa/ho6fO6jVk3HLta49FJu+YcH3Boesbd7Q+6XBwqQX3gozqp2ZHQxMr/d8auMxdWh1Krfbtx5SMkae70Cdak2uEauOPeHeCx3MESrX8w0ivpj/j7TUS9KsOiAdlyJovPwXmxJATD2kv+ruVXL9aPM0u9YDeKovPjvY/IHj1pkoGrpMmm5qnmTG8zEjLQL9COg7/8HVUGUk904AvC2VogaE0EC3Zyzg5ae3kHL64LmXPrRPdPKVv2sgNeY31/o3wnk4oPiZt9+bmtcWM13AX3IppXIOKvJUEngMdgkbxo3bwDLch1tRetkTqRZeEihu1rINlWmW5/Bd4A4nE90olXg/Y4mJte7omy08Km7VY0W74WTR80r+/RLwxiwbC2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.017815, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/9/23 17:19, Huang, Kai wrote: >> It's probably also worth noting *somewhere* that there's a balance to be >> had between TDMRs and reserved areas. A system that is running out of >> reserved areas in a TDMR could split a TDMR to get more reserved areas. >> A system that has run out of TDMRs could relatively easily coalesce two >> adjacent TDMRs (before the PAMTs are allocated) and use a reserved area >> if there was a gap between them. > We can add above to the changelog of this patch, or the patch 09 ("x86/virt/tdx: > Fill out TDMRs to cover all TDX memory regions"). The latter perhaps is better > since that patch is the first place where the balance of TDMRs and reserved > areas is related. > > What is your suggestion? Just put it close to the code that actually hits the problem so the potential solution is close at hand to whoever hits the problem.