From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92588C83F1B for ; Wed, 16 Jul 2025 10:25:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 025748D0002; Wed, 16 Jul 2025 06:25:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3F7E8D0001; Wed, 16 Jul 2025 06:25:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2EE28D0002; Wed, 16 Jul 2025 06:25:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D225C8D0001 for ; Wed, 16 Jul 2025 06:25:14 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9C35B1D9C3D for ; Wed, 16 Jul 2025 10:25:14 +0000 (UTC) X-FDA: 83669745348.25.91C80E0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 101CF140002 for ; Wed, 16 Jul 2025 10:25:11 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TAE/TH9/"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752661512; a=rsa-sha256; cv=none; b=paDDyjzvpZFt6iyjVveYhhqgcs4DjnYTXmE9LiNpvlwMPJuQJzWThqVwyxxb+tYSq/YgE4 QY/SjILK7jXw+JiUC1j2utxf+yv5GsoK5UV3OgCsIoYwd4Z3RdC6bl2fPfImHoi98Dct7K J3cRJdNW4Q1TXPQM7jiU1jvQDiZ50Fc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TAE/TH9/"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752661512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ojPiTGB0uO1S92U6FwE1qmBlbBFxe92SbIqLgPjYfxw=; b=SZ1RXEUlnlQdOW/Msz6a1UdhotiNunNigXoOGS7v5gDsfwUUUpjP2MPGTwEVmM2bcn64nM pvdxQVONSrgU2qKD+gl3eas47dmhjme3B2AN4jvoFUFhrEGRIjRL9Gq9K2Q66r01+rAxUa 2HFrnG4WZ4NcxLMz9N6O8QgtdLJTtX4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752661511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ojPiTGB0uO1S92U6FwE1qmBlbBFxe92SbIqLgPjYfxw=; b=TAE/TH9/pHUenigWgjUXrZm5GRwDNhyLR77NrPnHM1rSzAQiD7Tz2tDT4Q5CWDzWGVR86J bZ4znWKoEiZi73iRyG+PgmSxjRPkCaDigzEqSQb8qfjcJe0nftjauUJADKaOMUSt7v327P e1Ew/QvFbqD3vw7Zm0YL5o7JvAaGVZk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-iEJELfJmMCKMbQ9XG7-0cw-1; Wed, 16 Jul 2025 06:25:10 -0400 X-MC-Unique: iEJELfJmMCKMbQ9XG7-0cw-1 X-Mimecast-MFC-AGG-ID: iEJELfJmMCKMbQ9XG7-0cw_1752661509 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-455f79a2a16so40889945e9.2 for ; Wed, 16 Jul 2025 03:25:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752661509; x=1753266309; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ojPiTGB0uO1S92U6FwE1qmBlbBFxe92SbIqLgPjYfxw=; b=jrSyVeeGZrgQYLPye1FTKAUEHM0CV0BKITrekkVHKmcbEZAuBHjoCRvGBv8iYsXDvS sJRUxDtNamsPdUL/LpoEa+ZdmqtMGAz8YoykZZc0oZvy3q43ksUfzXFUlVBbxvDp+XGq GQWcxb9s91PlDMrf0wR9kO9lVeUgBENC4/7DZB2zdX4lHKQcj7ePIaoGklvhGXLJ/BS9 m1DCISsw6dKBd1lNa2oyIqOGL44cg0ffLoROLn+evqy4DY2h3dfF4YOiflXQjzIr0llf wd+CoKt+G7zOm5MTKvSJfmftrnAwoFFv91EvhJk2wCqAvZtmp/LIzRngNalvawgQ76am 3A3A== X-Forwarded-Encrypted: i=1; AJvYcCVaULLj4YrA65ZM8l9jFFKLsJtW5L+sUtQ+4hQX5qfjcHCyI56dcvMwJitKYDZbbnc+p+G2TMH0ng==@kvack.org X-Gm-Message-State: AOJu0Yw5WdBxeNVexGR21z4NhQXCiLZbX8+VjB6INRu5qRrGVwN4FKb6 BAVVx9Obzx6hw9t7+zYnPytbNTUDRM3OBXxrFbkuE/AK+PNWjH8LTahhY7E1ah1NH3SwVpvmDSn cbvXLoyJwbIYEgXcg25yDDMiPf7jIGPEzamASU0flbBOqQnsFkbJT X-Gm-Gg: ASbGncvcJaJzPCd+GvdsSaClRevIQKV064wppGxHXUb7yZBllaxOX1HNXtiqhKT6f95 GsbuovO7FpG3OwQWhlqmBqxPYIMLi5abklNZcduwSq9DUL8jwrsGKqyNYkDi3tHIYwHaicN2dGU 7CxpA5uDH3/tfTnppKeVOEps7JqCS5OMXwH7szcfR68SFGnRQCnPUC+XSqxhzUe0/fI2YM2kONX J4Mr5rx+Zzj7vuzgCYBGpb8iijbu1qs0zIhyyB1CMIuIw6rr4EqBfmq4bG3pX5N4FwJrr5DCv7j P8CxLbz61gou3NcFfDHM4VE31lmv2/7jCRZ4IwfthM/BbGeumxMhMsRjrE4hrOKqiIjHWhIxx9W 79idzBMqfoUQB2b8r62ppLVa6C0LrIM4yWn2VNrV7B2Q/w9qkPh5xw29tQBZHd1oZiOg= X-Received: by 2002:a05:600c:c042:b0:43d:745a:5a50 with SMTP id 5b1f17b1804b1-4562e5893f7mr13757485e9.19.1752661508755; Wed, 16 Jul 2025 03:25:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcxKB+PIip+FbZHyjFofyMfWBEFGOv/h9k5JBC6DcPQY+RjH+NEnKUQ+3Rz4fuDqwtShJzsQ== X-Received: by 2002:a05:600c:c042:b0:43d:745a:5a50 with SMTP id 5b1f17b1804b1-4562e5893f7mr13756875e9.19.1752661508192; Wed, 16 Jul 2025 03:25:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e7f363asm16820645e9.7.2025.07.16.03.25.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 03:25:07 -0700 (PDT) Message-ID: <778ca011-1b2f-4818-80c6-ac597809ec77@redhat.com> Date: Wed, 16 Jul 2025 12:25:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 02/21] KVM: Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to CONFIG_KVM_GENERIC_GMEM_POPULATE To: Xiaoyao Li , Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250715093350.2584932-1-tabba@google.com> <20250715093350.2584932-3-tabba@google.com> <418ddbbd-c25e-4047-9317-c05735e02807@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <418ddbbd-c25e-4047-9317-c05735e02807@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -xuyXXhQbdhKjnEP8GvXQZniBGKXosxIfgWXHjSwhus_1752661509 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 101CF140002 X-Stat-Signature: cricr7qo3aya7m6htk4azgp5ps9tdqja X-Rspam-User: X-HE-Tag: 1752661511-445107 X-HE-Meta: U2FsdGVkX1/ZHIj1IgGVe6H6NS6rFZTt+gQUvu/ss7C/i1GF15q+tZz/T8W67eAhXgAP0tLVJK9A1R8dVp8pK5ldURmUrpIBDNgQdkknz0L3775hSAiPjMHe3efc+EwxYQFzKQETvCmqFoqkV8D+PWVx2xO6J1PmpnAZzwxMJtcKdZUY4kLjoH0ZdyvoYkT6rGlFM7b2zdypFzQVYxWArx+VttkPGxHIek0eK069KdEEel5/DBSkIDfPVaBdbu745dffnwe5rEV3axkANvEj0b4VNixFVGRVhCr1VsTgJKIjb1G7Jfopseaimzmpi2ajAzjceJJPLe4YHvt80+IHrGnxwyZpiiZaeX7FBtHFkIOCLCamEboUX8GcuQk9I33cIQxD3vn/VltMI/kvobKIAeXFN0cmRkMG136LZ9od1hin6ONL3S/IPLhcu//djMY8yOXm4KKfFUoegwv8x4U7jzlb+a5ilA/lgqtMiLlizhdiH96kxpxao5UlLzkBwvW9AwavBdxMh3si8HCty3Z/Kg62D8z4pfx1Ft3jYbDeLcQ5UDo5b6eHRaHJU5Ub33n9+0DX7TXUVWM+3zbN0p3DYVHNCSwJKvvIP5dlbjtmbgOpHcZSkkTTSb4EwQxMqD7Ti4h6MUeWPmWkCw+uf2n5dSj/0mS5GAXbLnd6LG1zjzx3L/JHN+tolu0JyZ7HOjzHN7ArmNfCeubVOTCLTCLGvjwlCAMMksbL4wQ6KZtEKfqeIpMCMH4YBld66tDbe9MAX++RnOth3LuWCrmI2tzVoXPFteJXw+GQPVbB/RYVG9wCpYKb+skpRFY8Po6rk8dI7Z8s8R4IOOenT7/lgtdDqmD/5DqkKbM6/J/CTSop8RSBO163nRfgEZT802sBGNXNMQh9TH7K+vJagHyOP0xx15e8pj2svzXazvWD4yLTZE2/Z0+psOs107q8BGdFzw4hSu/Pq/TpnvcuZk5Qrvb w4kyVc2z X0U/fymMAkgZvCgfU1MNWtP8up3XuftPkuUwUqc2ggUP+mCuR70LsKcPUj7zeG+QvxkpEK00XeAy2oSYmvkMT5D9qIkTlMgX9N383RhHkzRJjdN7r8s3LlIDhkQNqCleZRITFE5WRGK3+iXpyqCOYztJ3ss5cs0rCQm98BaoFYCxClT/HEhqeBc1X3xYLWJnnW76/h/PvKPhhg0b9nxwdN6ArzjK8dPwwbwJbMJ0+T6Aq/8ofOHCERa3Qwkw053T/sAgUU5gqo1XBpsyNwJcuQwaku+MQO4c2vseEcbMLjkYhu10BZ9EbwIuH6GxROcWRYO9fS//jjObfIfXPpGCfeBlxhxbASRgJRaeZLXpJ0qHFLzD0IFPB3xmvYYVB+UgXt/QTirAuKdudEPwCtooDQP+Eu68Yyz9Oom9EAag33fcodCKJ4QfOJoCEwt1jWhppMzBXNci4x2K9olXFmrspp+vXdqn4yIbYsLYINOER6ZOLIrobVCS+EHWDp5tOBgb8yglyf2bOvzssvvHdKI1PZDeX/nQLUAyVyJF1X3rqMu3HryRsVdW7oMmAPwwOxPTL3y0o4OOhOgkiqZNNTKmfFQRW52zovgEHuanE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.07.25 10:31, Xiaoyao Li wrote: > On 7/16/2025 4:11 PM, Fuad Tabba wrote: >> On Wed, 16 Jul 2025 at 05:09, Xiaoyao Li wrote: >>> On 7/15/2025 5:33 PM, Fuad Tabba wrote: >>>> The original name was vague regarding its functionality. This Kconfig >>>> option specifically enables and gates the kvm_gmem_populate() function, >>>> which is responsible for populating a GPA range with guest data. >>> Well, I disagree. >>> >>> The config KVM_GENERIC_PRIVATE_MEM was introduced by commit 89ea60c2c7b5 >>> ("KVM: x86: Add support for "protected VMs" that can utilize private >>> memory"), which is a convenient config for vm types that requires >>> private memory support, e.g., SNP, TDX, and KVM_X86_SW_PROTECTED_VM. >>> >>> It was commit e4ee54479273 ("KVM: guest_memfd: let kvm_gmem_populate() >>> operate only on private gfns") that started to use >>> CONFIG_KVM_GENERIC_PRIVATE_MEM gates kvm_gmem_populate() function. But >>> CONFIG_KVM_GENERIC_PRIVATE_MEM is not for kvm_gmem_populate() only. >>> >>> If using CONFIG_KVM_GENERIC_PRIVATE_MEM to gate kvm_gmem_populate() is >>> vague and confusing, we can introduce KVM_GENERIC_GMEM_POPULATE to gate >>> kvm_gmem_populate() and select KVM_GENERIC_GMEM_POPULATE under >>> CONFIG_KVM_GENERIC_PRIVATE_MEM. >>> >>> Directly replace CONFIG_KVM_GENERIC_PRIVATE_MEM with >>> KVM_GENERIC_GMEM_POPULATE doesn't look correct to me. >> I'll quote David's reply to an earlier version of this patch [*]: > > It's not related to my concern. > > My point is that CONFIG_KVM_GENERIC_PRIVATE_MEM is used for selecting > the private memory support. Rename it to KVM_GENERIC_GMEM_POPULATE is > not correct. It protects a function that is called kvm_gmem_populate(). Can we stop the nitpicking? -- Cheers, David / dhildenb