From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 644DEC64ED8 for ; Mon, 20 Feb 2023 11:19:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D66B46B0071; Mon, 20 Feb 2023 06:19:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D164F6B0072; Mon, 20 Feb 2023 06:19:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB69D6B0073; Mon, 20 Feb 2023 06:19:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AB4E36B0071 for ; Mon, 20 Feb 2023 06:19:52 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 768631C6827 for ; Mon, 20 Feb 2023 11:19:52 +0000 (UTC) X-FDA: 80487425424.24.20A89B6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 47E4A40012 for ; Mon, 20 Feb 2023 11:19:50 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="FPw99/XY"; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676891990; a=rsa-sha256; cv=none; b=Ev7142qziho9XSPGMTO4QH7KW+FQMiWPKr/V2+tjUXuewEBQsIeoQs16zxgb2aPVfBOYWt K665jCVAeYyIA7E4DlPqkiy+HxWceDePVInRckN0y1H0dwAIrJQD5InLGF3qC2mAwZCccq p1aZ/XBy0pPoER8Qy9Lz26sO2gudc38= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="FPw99/XY"; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676891990; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Y0d/vI0Qp2mhR9IQ+0FEQIh8Qkf0r9E2FFAh9KN8Lg=; b=aYgjrVpz1WYDL8yJKXMmHTZ/FLNa9BT32Xpb1jLXwWb2+AgjuZGzaMcNLRtzz0bynDsDHy QDBPn9upu27WOZbSP97YzjcHwr+L1PaY+3kVsvtLKQH0F8030PmYuEWH0+Z7CVDy/km0HX IJ6QHGlwxwrj1Q19dSRXBZP2oQQ6g2w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676891989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Y0d/vI0Qp2mhR9IQ+0FEQIh8Qkf0r9E2FFAh9KN8Lg=; b=FPw99/XYfI9dw0GAndEKb/PzBONw4VcW8WwH3a15hqlI5RQ9zE+fZNTys4MFEJGSNk8oCh L2dO6sty/H+scfmI8o7vV0hnrzN5iMRss4pdjnEVTy6hoqAni7Sy8kwPkbd443LghbLoJc Srl1rvGqC8+VDgmhwPyRDg6V+neQgvA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-416-jJq74SQYMrC4zlLITyeBVA-1; Mon, 20 Feb 2023 06:19:46 -0500 X-MC-Unique: jJq74SQYMrC4zlLITyeBVA-1 Received: by mail-wm1-f71.google.com with SMTP id ay41-20020a05600c1e2900b003dfecb98d38so338500wmb.0 for ; Mon, 20 Feb 2023 03:19:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4Y0d/vI0Qp2mhR9IQ+0FEQIh8Qkf0r9E2FFAh9KN8Lg=; b=F0v+ihM8wFH99dSSGG98xYcAPz+PenLcSMJpH0JNIhvom056VsiKMdqN+D7HqQo7c4 ojxaFpRQCVU7vAnIbrfzKa7c0NiNQBPewYJZl23tmsIhqtQSfvRHvZDrihps+ocbcCiP KNB2JYeki9GGoT1BTCGKTu6Q2H0hZiJkuAlTJe3pbaYe0OpO4rC0wCIzt5IoJcwOMYdi K27iCExhG+K4yRM8VUZh/rMX+fjatR5JzKJhHR/Z0kO2fCRjs9DGk6TSQ1ZFFg2xmvuD kjser9L3vos3y7Aca/mbPuGUW3dHWQ3pPAJxH0xSXXhKkl9OWXVFLxwWwwF7s+tFq6SL Erlg== X-Gm-Message-State: AO0yUKXCCVuGKPDuSTnV49+AOATOlWfhifIrDSs0gvI+EFOnmopPBEPu lhJn3aCEqNzvnh+MY9//zsjW1u5znttuhZYw4ir03oPrJdI6DpxJcITtJYebi3NplEkw6n8jwPf ql7d9lfvjc68= X-Received: by 2002:a05:600c:13c3:b0:3e0:39:ec9d with SMTP id e3-20020a05600c13c300b003e00039ec9dmr667661wmg.23.1676891985217; Mon, 20 Feb 2023 03:19:45 -0800 (PST) X-Google-Smtp-Source: AK7set8gwoTHdOCWEVucXLZ1cWaezJA5lkFoQjhOhQbs8nj/fdafmDMVp3INR4+sjGhG9kWSgEqR2w== X-Received: by 2002:a05:600c:13c3:b0:3e0:39:ec9d with SMTP id e3-20020a05600c13c300b003e00039ec9dmr667628wmg.23.1676891984832; Mon, 20 Feb 2023 03:19:44 -0800 (PST) Received: from ?IPV6:2003:cb:c705:8300:e519:4218:a8b5:5bec? (p200300cbc7058300e5194218a8b55bec.dip0.t-ipconnect.de. [2003:cb:c705:8300:e519:4218:a8b5:5bec]) by smtp.gmail.com with ESMTPSA id z5-20020a5d6405000000b002c5534db60bsm713917wru.71.2023.02.20.03.19.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 03:19:44 -0800 (PST) Message-ID: <77f5e061-080b-f9f0-25f7-bbbe721b5e2e@redhat.com> Date: Mon, 20 Feb 2023 12:19:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v6 11/41] mm: Introduce pte_mkwrite_kernel() To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, xen-devel@lists.xenproject.org References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-12-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230218211433.26859-12-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 47E4A40012 X-Rspamd-Server: rspam01 X-Stat-Signature: quw81umeadtx4ya7jxh1p43y9h3oxw9n X-HE-Tag: 1676891990-604945 X-HE-Meta: U2FsdGVkX19BbWJzQRknWacoy/QL0l/HEh2+yOnUU9QINJv9k1ldSuPhkDCzMCG86pb6KR7otC/QDJph3rnRcWaq0rwhkmpHOtThq2VKmlsL3iBSYsAG99Wpwr7ojIxxHwpJY3B4Ghw/QjhexokKKcumeewu/Z5dc2f5MQE6xEuAwOJ2Q3qO4rW/aClJ/HVtUE+aQi1iUzPGnbXZsjXG2CIZtkgKzXWKCR+EqCAgfQi5tjuUQZDiPK6107kA8iM58zTlPIijIChMzU7KXLp49buvJZiQnjq3okJqI5QFDtY/vXOGyvA6V6gayy5PXKdWf9Z8d+LLEsnEF9X4ZSzgvrfTehHviZTpSNLAmSM0fToXk96GrPDrnXJemQg/FCS3/eww1IMbrB0Hfa5Ra5OtXmCk31us/OzTwwWppgx2jU14K6QpqzKdhj5jmJHOroJwrvSW8Jmw3c1PaPVsjEA6iS0Aw4VxC+WHPzEMMehMfIDDiu9+17oWm0UHSsnf7J/rQTK4p663dUYbW6jPM3NHstiNxqnxX14+H/yxz6dkyvtge46ysmidtGtVhG2AoG8U7hnNryJg2Dtc3Ug9u7GnDQ8W75dokix+AjG3wK+jV9wy8A5wxf5SwcDWYNx30sOlaHNFQrNdp+oZSkzhipMTzHZeb22LFYgAMlcAyncHthNkZ4Ln5cscMTCfYBxX+2r0Wrz7whih5FN3OjUnnrCWr+PHJUPcCHrCeqFnPo7+FLR/QzwEi4icL76FViqbWT6vuUSWPKW3cPLGCch2ynM+H9VqCbl5htpK+6eVGGQFJKNnWdR6imBrDv4HOTrnVr7z/BCzGoLrDmtfo2owWzCA1phR6uM+YO9/qH/ZvmA97EisPfm+naXsZkpKs7Yx5TLJYzZQNAAQdzOOlQwA2uduDigxHyxvmu9zbQiUnmUteEn0mlUjrQWO7rl6Peh3HdnXsFfuxk2d+BoSUuudgRi e18lSTNW vlEsUzBsynBkyEpINOkfGFUSBs6FzVh2ySVAsJYasTjKrm3ysH+e8OHSrXY3F8nO5R/bV3uYUzrtq21Btjrho9i4wKL7DmNZua8l2uF3sOiAfcBWUe2B0VucFrHK5aQj6TDeLaSKCgl8ZrnTN0IBjtj3DNnX6Hd9PfhOu+lbS5qmqNs+FxgJL6Em6KJFsG8vKYoURuQ/XOO+uVGMUlams5JsF9TDQ2KkUR+CFBJUQRpnQS1Ql1ISuHm8nX03JpjePfJtRhSvw+lbMzxKUM5UJ+m82E/V7LhcVUZ2TEKxtRD2+xj6Oz7ibWfYUGL8KkwRiJ+7ulEsWXBpkZ2+Royziy5ri8obJrVcsRN8fuxkzO8ptuFbNN7QKv/svtt3AvAKbW4nL9ijMIDt1aRH0J9OuSWRcMIsORWaWWnsWo3Lj7DIlDZTBrG/uOkoE1iOJ8ohIWpdQbILI/+egoBtImktr/YDeC674NZ82NFuMuCEYopVtfw6q8kSjakaLYRnndArYIXLesb6f2HlKpCPu72Julqi23Nm5OwxSahutC40fZJqwF1XXDRquDTRGbm0CalNl0D+Alv0oPxA090kNOvKHG4WqJ6W6ymVcbaSegCU2qIqCNlepYoi3nEkAA7rQratViBSqHSSjBWYw3OBafRHV55naAOEvdE46YBOdVz/vm/9a5LDIJvMXuGrlNMl2H+OmtuENNGY87fFunOMNHvauJ8KC74V+n5U6RutXZ+pbxB3TNeRthkWui4fSK7H0bHxQ+pZSqCOmwCiiRMKQDesmuuMFdORKGIsQdcn3fynN8+D4Gzk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.02.23 22:14, Rick Edgecombe wrote: > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > One of these changes is to allow for pte_mkwrite() to create different > types of writable memory (the existing conventionally writable type and > also the new shadow stack type). Future patches will convert pte_mkwrite() > to take a VMA in order to facilitate this, however there are places in the > kernel where pte_mkwrite() is called outside of the context of a VMA. > These are for kernel memory. So create a new variant called > pte_mkwrite_kernel() and switch the kernel users over to it. Have > pte_mkwrite() and pte_mkwrite_kernel() be the same for now. Future patches > will introduce changes to make pte_mkwrite() take a VMA. > > Only do this for architectures that need it because they call pte_mkwrite() > in arch code without an associated VMA. Since it will only currently be > used in arch code, so do not include it in arch_pgtable_helpers.rst. > > Cc: linux-doc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: xen-devel@lists.xenproject.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Tested-by: Pengfei Xu > Suggested-by: David Hildenbrand > Signed-off-by: Rick Edgecombe > Acked-by: David Hildenbrand Do we also have to care about pmd_mkwrite() ? -- Thanks, David / dhildenb