From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4308BECAAD3 for ; Fri, 9 Sep 2022 11:32:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA0278D0007; Fri, 9 Sep 2022 07:32:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D50148D0002; Fri, 9 Sep 2022 07:32:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF0FD8D0007; Fri, 9 Sep 2022 07:32:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AC8768D0002 for ; Fri, 9 Sep 2022 07:32:16 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 90A141A1363 for ; Fri, 9 Sep 2022 11:32:16 +0000 (UTC) X-FDA: 79892333472.06.C417A24 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 32C76A0081 for ; Fri, 9 Sep 2022 11:32:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662723135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d50SkkWrkIdpdMIVL6ztnsBoBH02DSFy2w4b8A0IjEs=; b=LAmhWZGHlVGy3ZcUMjxC25n1PmoM1KCyXRzDAJpJHqlvu+v/tN7QuvqXIaXZlwgQyVKjYG K4c5ZBq1N8uBXSojXxtv7XwiV4dVnxwhzm+V5XlwNSjzyoFb0anneeSR02e42WmDLbWWVP 9akFF8QBsPfqkZNlcAjDX4OKDroYtPU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-446-4qQOFxNXNSWD_oVm1NpmPQ-1; Fri, 09 Sep 2022 07:32:14 -0400 X-MC-Unique: 4qQOFxNXNSWD_oVm1NpmPQ-1 Received: by mail-wm1-f70.google.com with SMTP id ay21-20020a05600c1e1500b003b45fd14b53so345681wmb.1 for ; Fri, 09 Sep 2022 04:32:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=d50SkkWrkIdpdMIVL6ztnsBoBH02DSFy2w4b8A0IjEs=; b=MUEsmZgV7s7fFB6ZZeeerqbUepEngbcyzbzwwiUvItBeoFcg8SnunX1uMYxwCFvAhX sgeu40b7orV9NJI8p3D2eR2lD5V/u7eFSmP9DuJZdJR6DMEUMfG/Ytl5/ItYQLlOGUCe BFSGuE8wb9WTx2u39WY5tZG3+N5anprbwVBfV3MgLTjtp2Dnzp+bbrur6/GHxPTkrSOp uAx5VyLfuyPQaaqmfXXS6KDn2hs9Ez9bD9E8ehbWlI3y2c3qFRA++tJv9gfr6fomK2y3 KZAYjAhcYVk45RdXeLiUrQJbmoHBTJPzRskaTdASS8GXM/wqI2QPrfH+F2oOzcVwrLu4 Gs7Q== X-Gm-Message-State: ACgBeo3dsUdxwHxLwh59fii7mkPpYc91lriEt5Di/8pX4CQm1MCbSB9K FVJQjXKjv8n4iF/romv2PxK9Q5KiofmFVdIcQJXI5v7GBdmNCUBsKtvfIWtHvkcn4mbg6jNTtrI b2UNoowPlsws= X-Received: by 2002:a05:600c:3d93:b0:3a5:eb9b:b495 with SMTP id bi19-20020a05600c3d9300b003a5eb9bb495mr5084857wmb.91.1662723133528; Fri, 09 Sep 2022 04:32:13 -0700 (PDT) X-Google-Smtp-Source: AA6agR4N73zmdsLJhBg5eCUJMbXWc2aViXaT3qqh7XFt/DT8yrkWPVay0ZcuKruKG0m9vD8U6YWpoA== X-Received: by 2002:a05:600c:3d93:b0:3a5:eb9b:b495 with SMTP id bi19-20020a05600c3d9300b003a5eb9bb495mr5084845wmb.91.1662723133258; Fri, 09 Sep 2022 04:32:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:6300:1fe0:42e1:62c5:91b6? (p200300cbc70463001fe042e162c591b6.dip0.t-ipconnect.de. [2003:cb:c704:6300:1fe0:42e1:62c5:91b6]) by smtp.gmail.com with ESMTPSA id l20-20020a05600c4f1400b003a607e395ebsm663249wmq.9.2022.09.09.04.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:32:12 -0700 (PDT) Message-ID: <780938ad-9e14-7241-a139-573c967ce73f@redhat.com> Date: Fri, 9 Sep 2022 13:32:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 10/16] mm, memory_hotplug: remove obsolete generic_free_nodedata() To: Miaohe Lin , akpm@linux-foundation.org Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-11-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220909092451.24883-11-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662723136; a=rsa-sha256; cv=none; b=8dmSFrB3bB7enkNZYUuLbH6griEDQe78MTrLFDgf0gWBuMK3hzTFSx5BhMD3Exb3pcdIOy Cb3B27Clq489ZngQa11i1eks67izl9tFt0Xey1xBHTJLiy8w8R07FnPJZzbHQZPrbLb48p mR5ss/NI/t5Ee4yXHgjotyGBb10vRPs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LAmhWZGH; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662723136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d50SkkWrkIdpdMIVL6ztnsBoBH02DSFy2w4b8A0IjEs=; b=wzIoeNQt57sgBK0LGBOStlBqold8aws2K625vlbTrsRKpAMggkPCAMRU2Kb1mohLheltpx Jk/lYmdADncdWWOeVPR60KR4f6yp7Ka2nPd7k3+2nNvml3JVmRa7HTOwGZh6kbJOjzR429 rL3UUi8ySXybmCPWWRUm0OKdumScvcw= X-Rspamd-Queue-Id: 32C76A0081 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LAmhWZGH; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: wk7yt37hq1wamhandt8ty3n1hm5zk9gg X-HE-Tag: 1662723136-196978 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.09.22 11:24, Miaohe Lin wrote: > Commit 390511e1476e ("mm, memory_hotplug: drop arch_free_nodedata") > drops the last caller of generic_free_nodedata(). Remove it too. > > Signed-off-by: Miaohe Lin > --- > include/linux/memory_hotplug.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index 51052969dbfe..9fcbf5706595 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -43,11 +43,6 @@ extern void arch_refresh_nodedata(int nid, pg_data_t *pgdat); > ({ \ > memblock_alloc(sizeof(*pgdat), SMP_CACHE_BYTES); \ > }) > -/* > - * This definition is just for error path in node hotadd. > - * For node hotremove, we have to replace this. > - */ > -#define generic_free_nodedata(pgdat) kfree(pgdat) > > extern pg_data_t *node_data[]; > static inline void arch_refresh_nodedata(int nid, pg_data_t *pgdat) > @@ -63,9 +58,6 @@ static inline pg_data_t *generic_alloc_nodedata(int nid) > BUG(); > return NULL; > } > -static inline void generic_free_nodedata(pg_data_t *pgdat) > -{ > -} > static inline void arch_refresh_nodedata(int nid, pg_data_t *pgdat) > { > } Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb