From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C485C4363C for ; Fri, 2 Oct 2020 16:18:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B37412085B for ; Fri, 2 Oct 2020 16:18:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="tKvgYWbC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B37412085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C6C3D6B005C; Fri, 2 Oct 2020 12:18:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1C9A6B005D; Fri, 2 Oct 2020 12:18:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0C836B0062; Fri, 2 Oct 2020 12:18:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 811726B005C for ; Fri, 2 Oct 2020 12:18:19 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0A10A8249980 for ; Fri, 2 Oct 2020 16:18:19 +0000 (UTC) X-FDA: 77327492718.25.cart05_61073e0271a5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id D247B1804E3A1 for ; Fri, 2 Oct 2020 16:18:18 +0000 (UTC) X-HE-Tag: cart05_61073e0271a5 X-Filterd-Recvd-Size: 3544 Received: from z5.mailgun.us (z5.mailgun.us [104.130.96.5]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 16:18:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601655498; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=whNc0k6iZS9jVhUtXaRh3qR5AHdDHKShvRvwUbV8CQI=; b=tKvgYWbCBYvSvOVIt1KWvULroUIS10GXrPXJSFwY2Dp9f5rUjEGS4E6ijr41hGmNc/vt1C4q AOvdbspiKVkAY7vD7tHI+egzQV6WUV+406J47oxMFLcZOlHDx7Dek31lJwQxcpENQLATnm/M l8WNFfppHUbPm1JdLp/LTiSdxQc= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyIwY2Q3OCIsICJsaW51eC1tbUBrdmFjay5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 5f7752c4a03b63d67355f9c3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 02 Oct 2020 16:18:12 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id F1A3FC43382; Fri, 2 Oct 2020 16:18:11 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: pintu) by smtp.codeaurora.org (Postfix) with ESMTPSA id 72C0FC433CA; Fri, 2 Oct 2020 16:18:11 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 02 Oct 2020 21:48:11 +0530 From: pintu@codeaurora.org To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, pintu.ping@gmail.com Subject: Re: [PATCH] mm/util.c: Add error logs for commitment overflow In-Reply-To: <20201002121137.GY20115@casper.infradead.org> References: <1601639861-32171-1-git-send-email-pintu@codeaurora.org> <20201002121137.GY20115@casper.infradead.org> Message-ID: <783f85abc401aa9dbe7623819f9683fb@codeaurora.org> X-Sender: pintu@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-10-02 17:41, Matthew Wilcox wrote: > > I don't think the __func__ is particularly useful information. I would > also expect the name of the process to be more interesting than the > PID. > And why is the ppid useful? > Dear Matthew, First, thank you so much for your review and comments. I totally agree with you. Yes, initially I included process-name but later removed it to shrink some lines. I thought just pid should be enough to figure out the culprit process from dumps. Okay, I agree __func__ can also be removed. ppid, I thought might be useful, so I included it. Okay I will remove that too. > Wouldn't this message be more useful? > > fork: Would overcommit system (pid:162 name:./consume-and-fork.out) > Okay, yes I think this should be sufficient. But I think printing pages also should be good to indicate the users to lack information about this commitment. > ie put it in dup_mmap() and use current->comm Sorry, this part about dup_mmap(), I could not understand. Thanks, Pintu