From: David Hildenbrand <david@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
virtualization@lists.linux-foundation.org,
Jason Wang <jasowang@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Tyler Sanderson <tysand@google.com>,
Wei Wang <wei.w.wang@intel.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
David Rientjes <rientjes@google.com>,
Nadav Amit <namit@vmware.com>, Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM
Date: Tue, 10 Mar 2020 12:12:50 +0100 [thread overview]
Message-ID: <78427916-fc17-b081-6b1e-cbcb00d51752@redhat.com> (raw)
In-Reply-To: <20200310070413-mutt-send-email-mst@kernel.org>
>> static void virtio_balloon_unregister_shrinker(struct virtio_balloon *vb)
>> @@ -971,7 +950,22 @@ static int virtballoon_probe(struct virtio_device *vdev)
>> VIRTIO_BALLOON_CMD_ID_STOP);
>> spin_lock_init(&vb->free_page_list_lock);
>> INIT_LIST_HEAD(&vb->free_page_list);
>> + /*
>> + * We're allowed to reuse any free pages, even if they are
>> + * still to be processed by the host.
>> + */
>> + err = virtio_balloon_register_shrinker(vb);
>> + if (err)
>> + goto out_del_balloon_wq;
>> }
>> + if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_DEFLATE_ON_OOM)) {
>> + vb->oom_nb.notifier_call = virtio_balloon_oom_notify;
>> + vb->oom_nb.priority = VIRTIO_BALLOON_OOM_NOTIFY_PRIORITY;
>> + err = register_oom_notifier(&vb->oom_nb);
>> + if (err < 0)
>> + goto out_unregister_shrinker;
>> + }
>> +
>
>
> Let's decide whether we want an empty line after }, or not, and stick to
> it. I prefer an empty line but no biggie as long as we are consistent.
Can add one.
>
>> if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) {
>> /* Start with poison val of 0 representing general init */
>> __u32 poison_val = 0;
>> @@ -986,15 +980,6 @@ static int virtballoon_probe(struct virtio_device *vdev)
>> virtio_cwrite(vb->vdev, struct virtio_balloon_config,
>> poison_val, &poison_val);
>> }
>> - /*
>> - * We continue to use VIRTIO_BALLOON_F_DEFLATE_ON_OOM to decide if a
>> - * shrinker needs to be registered to relieve memory pressure.
>> - */
>> - if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_DEFLATE_ON_OOM)) {
>> - err = virtio_balloon_register_shrinker(vb);
>> - if (err)
>> - goto out_del_balloon_wq;
>> - }
>>
>> vb->pr_dev_info.report = virtballoon_free_page_report;
>> if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_REPORTING)) {
>> @@ -1003,12 +988,12 @@ static int virtballoon_probe(struct virtio_device *vdev)
>> capacity = virtqueue_get_vring_size(vb->reporting_vq);
>> if (capacity < PAGE_REPORTING_CAPACITY) {
>> err = -ENOSPC;
>> - goto out_unregister_shrinker;
>> + goto out_unregister_oom;
>> }
>>
>> err = page_reporting_register(&vb->pr_dev_info);
>> if (err)
>> - goto out_unregister_shrinker;
>> + goto out_unregister_oom;
>> }
>>
>> virtio_device_ready(vdev);
>> @@ -1017,8 +1002,11 @@ static int virtballoon_probe(struct virtio_device *vdev)
>> virtballoon_changed(vdev);
>> return 0;
>>
>> +out_unregister_oom:
>> + if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_DEFLATE_ON_OOM))
>> + unregister_oom_notifier(&vb->oom_nb);
>> out_unregister_shrinker:
>> - if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_DEFLATE_ON_OOM))
>> + if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT))
>> virtio_balloon_unregister_shrinker(vb);
>
>
> What's with vdev versus vb->vdev here?
> I suggest we keep using vb->vdev to make the patch minimal if we can.
> Same elsewhere.
As we touch this line either way, does it really make a difference? No
strong opinion. Can just do a vb->vdev and clean this up globally later.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-03-10 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 10:39 [PATCH v2] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM David Hildenbrand
2020-03-10 11:09 ` Michael S. Tsirkin
2020-03-10 11:12 ` David Hildenbrand [this message]
2020-03-10 11:19 ` Michael S. Tsirkin
2020-03-10 11:20 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78427916-fc17-b081-6b1e-cbcb00d51752@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=namit@vmware.com \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=tysand@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).