From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 769BFC5AE59 for ; Thu, 5 Jun 2025 10:38:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F85A6B058B; Thu, 5 Jun 2025 06:38:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D12C6B058D; Thu, 5 Jun 2025 06:38:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 010846B058F; Thu, 5 Jun 2025 06:38:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D65496B058B for ; Thu, 5 Jun 2025 06:38:22 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8D8F358F62 for ; Thu, 5 Jun 2025 10:38:22 +0000 (UTC) X-FDA: 83520997644.08.7D4F4A6 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf11.hostedemail.com (Postfix) with ESMTP id 8790540007 for ; Thu, 5 Jun 2025 10:38:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="d5X/8unq"; spf=pass (imf11.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749119900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g1mQV2GX4SFqvH9eeb9tY7RL+iprLrEQ6gUJTtclCgA=; b=NxadlIhE4o1AlbgCyNoch2KJtD1AerDDwLZAlpGgmi0+OGzc800BkHDNI2NQsiiWv037BT s/fPPXXNb0JzrAwhapLQZ3fNzRSl/YUVOHrELo1JVzvIfwOidEe/To6qUJoBYGgklan5V1 k0vOdlicjh7ficb9wcQmHR54e9Nklkc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="d5X/8unq"; spf=pass (imf11.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749119900; a=rsa-sha256; cv=none; b=V4OEvq3VNgUO/kaZnNM2o7iBtXOnkZoSwwNf1DKeMfA4SK2rM3Vwc/Zz2t6a1AlYX6wPiJ ebM1Y6hozMIE0dFrl5Asi/hbEbWhgSrM1RpUqvn1ENqzoPEpzLRt4I4IT3OjJzZoy8yUdW 67c31tVd1066u/zgRJCOBILjnqxifyo= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ad574992fcaso134724666b.1 for ; Thu, 05 Jun 2025 03:38:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749119899; x=1749724699; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=g1mQV2GX4SFqvH9eeb9tY7RL+iprLrEQ6gUJTtclCgA=; b=d5X/8unqygtElLE9+CBz/225dyfzNB+jkKp8XiFybp83OfPd6X1CqtZxvPGqiWTcvq pVRUkE8NQkkb++vCrDXLpvY6kYb0ZS8yQg6YQSmZ5T/Jwp+VtbsS/2DhEa/w3c1Uf/rD jV2o/UqCSucB2AIEmRZF3RTd3kqs7/dW3x8GXU0pmS5dm6QTsS5D6DOjugjM2AitlMHY oO3inTLxOVBNYQQHKxuyLprVMsP64pREiI8sy4e1OtVUBZ+YE/iMGcbUz5jGAkelC1Vx cJ6pNksr5f9leXIiQqWW1vWAY/8ChNqqu/lV22oZR8o12fqeiZnpiDoRT7vhOLLTsz+6 CWRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749119899; x=1749724699; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g1mQV2GX4SFqvH9eeb9tY7RL+iprLrEQ6gUJTtclCgA=; b=KkPzdV+xlJf5dfk7h+MPIBvRO66fzzf7zX5TrPMHMsJgTtqxqdjKkz4hUUl065UU9/ PpNJ6zvIKI4LNhgkk3iRt/8oIIZ5kqCtg6nFskTYiS9EkykKXnmJcutfTSXKzMPfPk+e qBt7MPvbAWcH5mc+r1+UEsK0K2Er53mV8/cccs13pFQDxiOOo2M4coL5htCixch9btK8 WCxcCnrvRTTxxnT1rGO8dgTfB0jLiu+jbYtH7RENpHbGMDyBm9R//KfHQ8tmftjXCrfc GzuBPEMTWiUJ0m7u3ilN+ltU2XOSdigxSFbCaZ5JvjdR11JcAEAb0sap/GLKKTzr1ex+ y5XA== X-Forwarded-Encrypted: i=1; AJvYcCWW+4nbdOFl9pzt4BN/xBD6kIuhmbTnXHt8Wu25hVi2yit627/Efo0Jz4Jbo8vxadZ1FvItAZXgGA==@kvack.org X-Gm-Message-State: AOJu0YxuE9tQd0oR43fiT1ooot+DDbZOREqEKgz2j/lHs3RvHAdDffvs j5CHSG40bvW5uj14PN4k9M49yAhHwrzNPBaLjgeBiD5+14WZLOs25joI X-Gm-Gg: ASbGncvwj52DI1ONS9eRWkFqdSud8ASx0q75wUlsTuG78LESOuCXHy1m9YJvgyaHfdt H/y1F9x6DCm/bmkbPaVtGSskZVSZxnvpUzM+IR36mVzxKhFwW/VWn5lEv5gVxGT2SfES5wTVtH7 6mQqjpih6ZqsTLxouhPa4xyrsWbwv88bKUPCYQi3PfXEPQjzBdjet88n3FmywbF0Q9caxHejmIx axWKkjgaYV+7QCpAxaZZR3AWzEZNuyiV8GuBRJoPlgb6eooBhHLMyqvKeCd9RKM1qv0vndurv2M oSTpAtUBLzqhug/oIG0t2LQMndcQNGLPMiCHdB5zS2y/Soakw4rv8O54xYCsePS1 X-Google-Smtp-Source: AGHT+IGxYXG/SuapgXvdgueyn0PUoyYCKu9UE6yrqyyrqY+UM08cN7TL9mVC4MtQyEfeOVk3Ug7Spw== X-Received: by 2002:a17:907:9689:b0:add:ed0d:a583 with SMTP id a640c23a62f3a-addf8cd14a6mr642809566b.19.1749119898645; Thu, 05 Jun 2025 03:38:18 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::22f? ([2620:10d:c092:600::1:d66f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adb390f09c8sm986936566b.45.2025.06.05.03.38.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 03:38:17 -0700 (PDT) Message-ID: <78cc50c9-052b-446f-bd27-9eea73386e60@gmail.com> Date: Thu, 5 Jun 2025 11:39:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v4 09/18] page_pool: rename __page_pool_put_page() to __page_pool_put_netmem() From: Pavel Begunkov To: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250604025246.61616-1-byungchul@sk.com> <20250604025246.61616-10-byungchul@sk.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 9tu68f4bnfgtyhy6gz87mxy3w7n8eibh X-Rspamd-Queue-Id: 8790540007 X-Rspamd-Server: rspam11 X-HE-Tag: 1749119900-269741 X-HE-Meta: U2FsdGVkX1+jG1VjFJ/hKLdq7olAiKvkxgVJECMA8V4MeDqPY5X8zXLA1F6GSd8lxOWOSZd8TKvRJtFftPUlVrpn4pULZhyhrr8im/p/Y+6YsnHjJ4YMfuZRW1M/WLNa2wuwb3ERVT/uB/imtulycSCDzCTZBMxZ4tGnYORy/EFRi/Oc8PwlwJq8ob8/vLpQ7HrJFCn8zgEjgCE2EAQgX0dIVaFix7PKc5z2NSdV7nuYimtuH9+Ip98DNxRAlTZ0jdXCDI3tK/ksIFLShMAuRInjQPBNSswAoqbWikjpggvmW65fkt6ldpN1BYtlbGz5Vmlb2WYYwSlDZuvzt3S9lmF152IhHyzllqSWm/OAei6lFfGNP0sxRxkL5AVdc3ihV5HwVdBlwHcXgpuhh6lUYA6z2XKEGMjUdP2deTP54yGUQAxYOHRsXH1l82OUA+rZgprz/9JVSBbZKoGiizMCD4id0YTCkfZt2uB1CPu5wt1+gxVMHEwbwnyml9OM3GqmW2kPsnTKCLD5Oexitx9V0OPbSmKTp0PZ1Lmg21WuduZ49ysKw3I89K4WZaQhKhVEGxR+nEwgekxu63nUqeu9SloXyz5IfbA55Vo8Kqd7OLQ6lww+h8Rhh05dBfjVy3ms+AM/XG+wooNEcJvH/67k0hGTZFqjH5jdbhl91DbGRtu0+eF8E4CGIL5rSIU+Hnc+l3v3djStlmUC3CmTe6+i+ergEb72l8DncxI0jvp7jRRtZoQ+JOArz8vfTPTjmHHvWheXAj+uPpsC0wnw3GX7TEYULBbV6xJt0TwZ4Ihsi5yyPHpiqKJwxo60W4eTMtDJw7N739DVfVBIqZ8oRb4Mpyp4v77u66QPiuc0ZlEn9EU6uRes7nAr7+0d2UEwG9UFwlZ3mG1WY2iAkyrCszvMF7WA995f/xuEKHYU1n1tVlxTm14Uj9SvOPCDLfZE8utTsafVYVjTGti68u++9iS Mb73ryAb ax5v7ALPCz1VlWyF8EbBMTTd/HBfCxV5Ql/65CoMglXd+EPuJsE2PC9VDvUzItj1TOjlF/eVDA6rXi89Gjt+E7cMve1V2kKwecdWfzY20ynHmqByAlIdo7og6H8TrlwY8HcXbUBieY41uIFMo0n2p3RjSjdSXVEt4E/+V239u624ug0RhRL/VuqL3nT5il11FiWoq1cRC1SfMBctaVxxYBuxSktD6D6jmmrreyQUwzJmkjPceYgvVS0Nkkae1WLv+v1OQOAZvcpxyQqpjF7yzWhCJGYtZ4yDcHTxzMgGGTKzS8bX06D8fsinck39fCgBLYPqbd6oht2FpkEUQO6I6svt3Opm+acTTcV+aVHbKLeljri1ijJYr5m8b5VAy2PLDmcRqGKkeBBhxzJqCMIyYBU2s6E2e67IBuR2Q9ylC5aiNPZFsvCLTMthdOrpSaX1bdd1FJYOlmmOl9wXZHlE5FtwBsc5Vx4sbqZqN+q92Tln4i0bFopNdwE1trhh7a1sLw8ryExWC7Q6QBqcJhNrO+GDm/AZtjYEFc+mYzwX4GYyKFeJdTpBo3Tm/khPuGxh+iS4wA9XY8cmONhfYsJyxjGE9dA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/5/25 11:35, Pavel Begunkov wrote: > On 6/4/25 03:52, Byungchul Park wrote: >> Now that __page_pool_put_page() puts netmem, not struct page, rename it >> to __page_pool_put_netmem() to reflect what it does. > > Reviewed-by: Pavel Begunkov Actually, the function is for non-mp struct pages only, would make sense to use struct page instead. I'd even argue that it's better to change the argument to struct page *. -- Pavel Begunkov