From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79018C83F01 for ; Thu, 31 Aug 2023 14:49:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF7008D0010; Thu, 31 Aug 2023 10:49:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA74F8D0001; Thu, 31 Aug 2023 10:49:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B96398D0010; Thu, 31 Aug 2023 10:49:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AA8F88D0001 for ; Thu, 31 Aug 2023 10:49:18 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7C3EE80332 for ; Thu, 31 Aug 2023 14:49:18 +0000 (UTC) X-FDA: 81184682796.15.5560DD7 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 92E5A14001E for ; Thu, 31 Aug 2023 14:49:15 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf23.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693493355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JCNU/s727G5IM1dObg96DOswKvi5jGIZWybrRUpB8TM=; b=lj4D9aRDZ6XhFkIIk00NucWA0qwf2ocbLdT7PN+LeFJh9O/9N+goV/pw6UKT6HNuERZ039 nEt+5dFzAXIaicmiZaTgC35/Ae3xUEA3gIBilmyyBY2Jj0kOWv8Mco/xYWD77yX+beGhLt cAL6w/cT/I4/bN3BptdMganJrzlDcVs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf23.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693493355; a=rsa-sha256; cv=none; b=hotinPkhMJryyuO6WEpQVYdFlNht3PfFDgbBTwrKZwht5hDYDJfKnBbGNUljIoJ+cvrE// POzw2v+XmchJRZK0z5nUZGNV0YU1dkQPwyRtX7sVzd32J3Crt7/jVPzpLc2co7UsCat4IB sG97OQ99H0/cWduoXl7zWLZqcR2XO7g= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 168B1C15; Thu, 31 Aug 2023 07:49:54 -0700 (PDT) Received: from [10.1.32.135] (XHFQ2J9959.cambridge.arm.com [10.1.32.135]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F68B3F64C; Thu, 31 Aug 2023 07:49:14 -0700 (PDT) Message-ID: <795eadd2-57db-442d-bf40-cdef40f96fe8@arm.com> Date: Thu, 31 Aug 2023 15:49:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 05/14] memcg: Add mem_cgroup_uncharge_folios() Content-Language: en-GB To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org References: <20230825135918.4164671-1-willy@infradead.org> <20230825135918.4164671-6-willy@infradead.org> From: Ryan Roberts In-Reply-To: <20230825135918.4164671-6-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: zha1n5f8qpro37sdf5cf5mhc5zq7pp4c X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 92E5A14001E X-HE-Tag: 1693493355-211516 X-HE-Meta: U2FsdGVkX18KT0GZWjxI5Q+DSieWwt9sNF31xiU277aPC0nN0B6XkWSL1eTp9+POkK7czfFt58I8Raj8CreVvfMzGYynfTjmu4vUKEYtPtcjHiQ3l/ZAkXpZmFBLx4+3P/7uhiglqZM1K0l+fmwqU3qnjT9UlbgWc3PotqYRphK22fsnhQSV2LhIofhftUKb32UH8sBrXKgpkl3vx6tPn6XR5pAXqy6/FGPr4OSYtldJv0ZaaljVfEHtQEWaR8K7LJL2JbRXcymb9ZEZiNlRjkZlXwGlyOM6P03NeyCcr/cf4c2iqr/6KQ6DYems7dvAQUu8JV9xWDmq+HGuloCFMoncwOKNiVHRYnHJHlFqvEJhxc9vKjWnlPFJDkIS4leeDpI9EIIDhEki0dKqhUYkvVcGKlf0vh09mc0AbyxtrQ2/PSksWX1W35vUeScbJU7HuLYMgWyDZAtU2YWwZw763GI3A64GnaQ/BMrp1xwBQOd6uGBXcUdJ1iMrhIL/Dq0SO9DnTKsf4903Vup49CK8JkQ5RfUbX3TiJEhCZ2REMgX2C4sM/Zdht3VeRdy7mimKrYQQPiK4KPrJBDujMqwk2XLyqyvnTmwjasBKnj87fZ1w1RBVlfyCFfytjalLJ2Oq9aEoiArQFvjqBAE6f0LyfGob44duzBgMD7DkPPsAuJQXclH6S2OKKpyGZ01O+DcHXbJBFdp7IwEF6ctG68tooBCGU/lgJheRvkSShpHVCSFmbSfjRmSpQ682MTDAA4rs70XiLfI5YSk76UEUlR8Ov8DQQ/s1Hqt5JoILL+Xlgj8dIIVaWFgSr3Lo1y+Rx7Qcug4Ejql++OVjb+rpuhYhlARShzUK4yq2rEC39WuKCWXD4WKtqW6qYADfmNLZfxYUOWvoDCyWUV5SlOdF+3YSsbhbZt0rSSGynihgIQJqgCme9dgd38lp7ckbkvqKm1bKMoOEPaQvq6fvcGWR0Jx R8zkKP8L tr+0o2rSSoqgj4uLuSr6FpF9lvBGOlVxPEnZ0FDLAdltz5wQY+NnG5rJwQXTCGUTWzX85ZDPQ07GifhKWsyxP9EButMW4tysw0mFwhVxNRj2TTT++XTiqZw9MJGeV4j5Deq6jCRb06D5gATYTJzUB1XufYb6I2Bsh7QW8huvfLbd55C5X2me7I4KPEqOe/FffIjHBFP281kgF+Fe0F4DjKC2Pvi0f2NawkFXVUhScdK5jm7QfS2b4r23hQxUKNv6DQDS3qRPtgTVC+mFX4WYCL7BHqY5O7nBa+c8GP6tXtB9pBsMv4xrr1fz0WA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25/08/2023 14:59, Matthew Wilcox (Oracle) wrote: > Almost identical to mem_cgroup_uncharge_list(), except it takes a > folio_batch instead of a list_head. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Ryan Roberts > --- > include/linux/memcontrol.h | 12 ++++++++++++ > mm/memcontrol.c | 13 +++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index ab94ad4597d0..d0caeb1c1136 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -713,6 +713,14 @@ static inline void mem_cgroup_uncharge_list(struct list_head *page_list) > __mem_cgroup_uncharge_list(page_list); > } > > +void __mem_cgroup_uncharge_folios(struct folio_batch *folios); > +static inline void mem_cgroup_uncharge_folios(struct folio_batch *folios) > +{ > + if (mem_cgroup_disabled()) > + return; > + __mem_cgroup_uncharge_folios(folios); > +} > + > void mem_cgroup_migrate(struct folio *old, struct folio *new); > > /** > @@ -1273,6 +1281,10 @@ static inline void mem_cgroup_uncharge_list(struct list_head *page_list) > { > } > > +static inline void mem_cgroup_uncharge_folios(struct folio_batch *folios) > +{ > +} > + > static inline void mem_cgroup_migrate(struct folio *old, struct folio *new) > { > } > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 26ba9d1a66d1..a0fb008afa23 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -7190,6 +7191,18 @@ void __mem_cgroup_uncharge_list(struct list_head *page_list) > uncharge_batch(&ug); > } > > +void __mem_cgroup_uncharge_folios(struct folio_batch *folios) > +{ > + struct uncharge_gather ug; > + unsigned int i; > + > + uncharge_gather_clear(&ug); > + for (i = 0; i < folios->nr; i++) > + uncharge_folio(folios->folios[i], &ug); > + if (ug.memcg) > + uncharge_batch(&ug); > +} > + > /** > * mem_cgroup_migrate - Charge a folio's replacement. > * @old: Currently circulating folio.