From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D97C433EF for ; Fri, 17 Jun 2022 07:39:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 883A66B0071; Fri, 17 Jun 2022 03:39:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80B886B0073; Fri, 17 Jun 2022 03:39:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 685026B0074; Fri, 17 Jun 2022 03:39:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 521636B0071 for ; Fri, 17 Jun 2022 03:39:33 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 224FA209B6 for ; Fri, 17 Jun 2022 07:39:33 +0000 (UTC) X-FDA: 79586927826.21.9F7EF95 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id B631B100074 for ; Fri, 17 Jun 2022 07:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655451572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3+5SsZD18lshkaJTIGXbLP4b4u9kGlHi/piJMfKgDzY=; b=ET6ibx+2rM/9AJf+Kq59as8D+Dmb0StqL9cdf4iZKCj8q7vKqJWxZ31k+ejVWy5xl+d50W Fx8aGK62GxrxfksLy2zPrIgZbm/ZY5BYKEyjzcEKZT/N6l3lMikQCsH9rINu4RT7OADLIQ upo1b7oQLghz0q902QS6hjL2Xf8cN9Y= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-utDyqXmIMmG46HDFcJi5Eg-1; Fri, 17 Jun 2022 03:39:30 -0400 X-MC-Unique: utDyqXmIMmG46HDFcJi5Eg-1 Received: by mail-wm1-f71.google.com with SMTP id p24-20020a05600c1d9800b0039c51c2da19so3527711wms.0 for ; Fri, 17 Jun 2022 00:39:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=3+5SsZD18lshkaJTIGXbLP4b4u9kGlHi/piJMfKgDzY=; b=YolZ+IWjaR0m80tmgvfjDdOTP2I8jC3LdxpkN2piBkdoK7VDjJXARASHtbXcClzW/9 40iBkGm1YMzzogAYztLdznsmjCmTmjXxDO/MrI1oKqlg7V+UJNB6jJmwhQEvqI0GcwSl eKKbr/j7QaqybtVzgwdiih2zS1KNM1CN6KWSArN65q6lHaTJBrPgJNL6XsgXYzkmI4dx sEVIv1iq3yqiwn/S0ZS1FbXJ5LNfDPydaiAwzOubQNThDALwbk/Jw4qWfv4F6/ZQgvwU uUOG9wNcfIwMcTmiqyFj/yZbPyOXSKKHgdU8NFsB4EU7lXghH7jcLHdo36ZIlkeVAN16 quzw== X-Gm-Message-State: AJIora+nH9Mudsio6CiXRYfst4cIdvxQDlrTXrQ0hm4ROPxW+1QsSx7/ xvBu5fwKh5NCFTec1q35+UDyGpUOBS90kXIqYabqbAS64kzKj90F6XYf/t2R8L6NZdvPrJvLUyX YflsPZboSc4Q= X-Received: by 2002:a05:6000:1446:b0:218:5a5d:6cb5 with SMTP id v6-20020a056000144600b002185a5d6cb5mr7894934wrx.629.1655451569409; Fri, 17 Jun 2022 00:39:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tOXholaP7tYyWm5CZMrTvW0X9DDD/xBPQEaFSdwM9qdJGWAdTNqg6dY1Q7JtEhufau2RKJsw== X-Received: by 2002:a05:6000:1446:b0:218:5a5d:6cb5 with SMTP id v6-20020a056000144600b002185a5d6cb5mr7894909wrx.629.1655451569140; Fri, 17 Jun 2022 00:39:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:7e00:bb5b:b526:5b76:5824? (p200300cbc70a7e00bb5bb5265b765824.dip0.t-ipconnect.de. [2003:cb:c70a:7e00:bb5b:b526:5b76:5824]) by smtp.gmail.com with ESMTPSA id bi19-20020a05600c3d9300b0039c4506bd25sm5300383wmb.14.2022.06.17.00.39.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 00:39:28 -0700 (PDT) Message-ID: <79a1ca29-de8e-6456-460b-a9099340fec4@redhat.com> Date: Fri, 17 Jun 2022 09:39:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 2/2] mm: memory_hotplug: introduce SECTION_CANNOT_OPTIMIZE_VMEMMAP To: Muchun Song , Oscar Salvador Cc: corbet@lwn.net, akpm@linux-foundation.org, paulmck@kernel.org, mike.kravetz@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com References: <20220520025538.21144-1-songmuchun@bytedance.com> <20220520025538.21144-3-songmuchun@bytedance.com> <53024884-0182-df5f-9ca2-00652c64ce36@redhat.com> <24d5ec20-9c9e-93aa-11f4-c4619f51f7d1@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655451572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3+5SsZD18lshkaJTIGXbLP4b4u9kGlHi/piJMfKgDzY=; b=ASCfuOXyDSIu2B75NXnfLwXYYMlR4KdA1AENzafMGGhJcDgmhuzElYwacZxnILP0UPIxb3 WgtGjpl8QXGc14u1vFsjxFIzNqrM5TR9lkqt5EpANVK7gV86tpyj+cu2dbMVzmqJG6RTga vSQm9GJ3E+qTPStknkgYAW0mbLtF2Ek= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655451572; a=rsa-sha256; cv=none; b=M6t/Me9pNyhthEQLot2a4Dtf7QpIVtOyY01vizSAuv9w6PLJQRlQT66cJvO6G54MNsXMkz oIXvMypGwih5o4r6L3xYiBa2ARS/HbijJulMtWly/31ZluMthvHPh5+eRdFGD4UlL4VVuE w+4FP+xrUNJUGLyl0YTJ/qwktLkx8kM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ET6ibx+2; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf14.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ET6ibx+2; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf14.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B631B100074 X-Stat-Signature: 69b3a5yxogtxhfxp3jx7ook3uooc4cy5 X-HE-Tag: 1655451572-226752 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.06.22 09:28, Muchun Song wrote: > On Fri, Jun 17, 2022 at 07:46:53AM +0200, Oscar Salvador wrote: >> On Thu, Jun 16, 2022 at 09:30:33AM +0200, David Hildenbrand wrote: >>> IIRC, that was used to skip these patches on the offlining path before >>> we provided the ranges to offline_pages(). >> >> Yeah, it was designed for that purpose back then. >> >>> I'd not mess with PG_reserved, and give them a clearer name, to not >>> confuse them with other, ordinary, vmemmap pages that are not >>> self-hosted (maybe in the future we might want to flag all vmemmap pages >>> with a new type?). >> >> Not sure whether a new type is really needed, or to put it another way, I >> cannot see the benefit. >> >>> >>> I'd just try reusing the flag PG_owner_priv_1. And eventually, flag all >>> (v)memmap pages with a type PG_memmap. However, the latter would be >>> optional and might not be strictly required >>> >>> >>> So what think could make sense is >>> >>> /* vmemmap pages that are self-hosted and cannot be optimized/freed. */ >>> PG_vmemmap_self_hosted = PG_owner_priv_1, >> >> Sure, I just lightly tested the below, and seems to work, but not sure >> whether that is what you are referring to. >> @Munchun: thoughts? >> > > I think it works and fits my requirement. > >> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >> index e66f7aa3191d..a4556afd7bda 100644 >> --- a/include/linux/page-flags.h >> +++ b/include/linux/page-flags.h >> @@ -193,6 +193,11 @@ enum pageflags { >> >> /* Only valid for buddy pages. Used to track pages that are reported */ >> PG_reported = PG_uptodate, >> + >> +#ifdef CONFIG_MEMORY_HOTPLUG >> + /* For self-hosted memmap pages */ >> + PG_vmemmap_self_hosted = PG_owner_priv_1, >> +#endif >> }; >> >> #define PAGEFLAGS_MASK ((1UL << NR_PAGEFLAGS) - 1) >> @@ -628,6 +633,10 @@ PAGEFLAG_FALSE(SkipKASanPoison, skip_kasan_poison) >> */ >> __PAGEFLAG(Reported, reported, PF_NO_COMPOUND) >> >> +#ifdef CONFIG_MEMORY_HOTPLUG >> +PAGEFLAG(Vmemmap_self_hosted, vmemmap_self_hosted, PF_ANY) >> +#endif >> + >> /* >> * On an anonymous page mapped into a user virtual memory area, >> * page->mapping points to its anon_vma, not to a struct address_space; >> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c >> index 1089ea8a9c98..e2de7ed27e9e 100644 >> --- a/mm/hugetlb_vmemmap.c >> +++ b/mm/hugetlb_vmemmap.c >> @@ -101,6 +101,14 @@ void hugetlb_vmemmap_free(struct hstate *h, struct page *head) >> { >> unsigned long vmemmap_addr = (unsigned long)head; >> unsigned long vmemmap_end, vmemmap_reuse, vmemmap_pages; >> + struct mem_section *ms = __pfn_to_section(page_to_pfn(head)); >> + struct page *memmap; >> + >> + memmap = sparse_decode_mem_map(ms->section_mem_map, >> + pfn_to_section_nr(page_to_pfn(head))); >> + >> + if (PageVmemmap_self_hosted(memmap)) >> + return; > > I think here needs a loop if it is a 1GB page (spans multiple sections). > Right? Here is an implementation based on another approach. But I think > your implementation is more simpler and efficient. Would you mind me > squash your diff into my patch and with your "Co-developed-by"? Due to hugtlb alignment requirements, and the vmemmap pages being at the start of the hotplugged memory region, I think that cannot currently happen. Checking the first vmemmap page might be good enough for now, and probably for the future. -- Thanks, David / dhildenb