From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08150EB64DA for ; Thu, 22 Jun 2023 13:15:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C8868D0002; Thu, 22 Jun 2023 09:15:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 478A68D0001; Thu, 22 Jun 2023 09:15:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3401D8D0002; Thu, 22 Jun 2023 09:15:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 257BD8D0001 for ; Thu, 22 Jun 2023 09:15:10 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B7FB6160B01 for ; Thu, 22 Jun 2023 13:15:09 +0000 (UTC) X-FDA: 80930429538.29.7094090 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 04B0C100021 for ; Thu, 22 Jun 2023 13:15:06 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=evb6L7fq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687439707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CwNoD4npTXJHndQ39H5OyokG0A2tJC7uKm6DdKDHg0U=; b=4BRF7KezkfW4cNCCAYS9W4koyVCapqCNhPYRVM8V57CXyV3uxzRbDWtwqvNaUdFeVM0e/d yLJP7tZ/Tj+nIL0wWdccygGptpQaLQMcttHvu66oBn0eurA0jvHidv4TCKiKq5cKUGzZ58 UhDtNsasW8cRJJHYpFqWpyWghL/qpKc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=evb6L7fq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687439707; a=rsa-sha256; cv=none; b=gmb0frT3+BpGEHpx7lhHndGyRE1dQWhdzOWr21yPWv60xCTvzLDn3GzeemZStkfjdj8DPX 7R5YqA43ZvyNMVeVrQVjK1Iv3Ss6Wb7ND8kOsuZtcyqtFE+WsjC6brgAyd6q4ImQkUd4pO BL9vuo5CzWZkw4n/pb8nmqo0WaH9lAE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687439706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CwNoD4npTXJHndQ39H5OyokG0A2tJC7uKm6DdKDHg0U=; b=evb6L7fqXXI1JFwxJeksKZmnQRliHHIUCssVoEFYKsXdgq/t3QwHL+Ix4dLZqVmbgr6K/B xGNSj8isN3Nf+2LnVA/S1P6IROLtY00YZNMBow7KAv2FbiLV3OynRpcICiVrBLOq2MmSr8 RwnE44g6TSEeaELmM93C+OIR0esh+lM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-9d9CmcV2MFCyOxcjmTbnVA-1; Thu, 22 Jun 2023 09:15:04 -0400 X-MC-Unique: 9d9CmcV2MFCyOxcjmTbnVA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-30e4943ca7fso2813492f8f.3 for ; Thu, 22 Jun 2023 06:15:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687439703; x=1690031703; h=content-transfer-encoding:mime-version:references:in-reply-to:date :to:from:subject:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CwNoD4npTXJHndQ39H5OyokG0A2tJC7uKm6DdKDHg0U=; b=WhXvo1MJGfSDCgSfJhXWsbKF7Rb3eBcptiq/aI53nJgeXx3Dsr7l4Kh8ZiMUEeWrMz k9fb1urQRYcJh6+hgGzhd5HODz2lJuHwL41yQGr8U8OJRCXB4by7aLnKOiRT5pjV8Sre IkmqKW1UtUCuL3WIIG1e9weVxY/7Gj9pwb12mMvH8dIAweNU+3mnOYqWuypdwoQpGfv4 i/cHKEU6EQWx0i0H1z/NGpFTHhXsAPvt4AJXx5ch/xnIEjpmosq57cqpAZ+Jhtai54sy 2bPvhrtNk+WOPg/b1sifMtol3Ltht2s6y6H4g1QTvToGOz+xUULv5ZeFHHBZCMVKhrr9 m1Sw== X-Gm-Message-State: AC+VfDzZOq8O94NI4rM4M+5Zd/gnHn5Cy8vvWs20ZA19+SPr3h0I9j9C GpnxbS9o5jJasSBy2ftbt7GiJQFYml+TAgN0gaMMbUu4qS7E2DBIH/5Bmim36kmw6S76Mc7WrVp mW4BozI7RF60= X-Received: by 2002:adf:fa83:0:b0:30e:56ae:ccb7 with SMTP id h3-20020adffa83000000b0030e56aeccb7mr13129215wrr.52.1687439702993; Thu, 22 Jun 2023 06:15:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7wzrlESkKHfrkXueFgu575m1EZWaFeye+ZamuL5DG2JBkgkpwqxiajJqPMAdS7wlgFKQpT2g== X-Received: by 2002:adf:fa83:0:b0:30e:56ae:ccb7 with SMTP id h3-20020adffa83000000b0030e56aeccb7mr13129176wrr.52.1687439702720; Thu, 22 Jun 2023 06:15:02 -0700 (PDT) Received: from ypodemsk.tlv.csb (IGLD-84-229-250-192.inter.net.il. [84.229.250.192]) by smtp.gmail.com with ESMTPSA id u6-20020adff886000000b0031130b9b173sm7014116wrp.34.2023.06.22.06.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 06:15:02 -0700 (PDT) Message-ID: <79f29f99fa07c46dbaee7b802cdd7b477b2d8dd1.camel@redhat.com> Subject: Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs From: ypodemsk@redhat.com To: Dave Hansen , mtosatti@redhat.com, ppandit@redhat.com, david@redhat.com, linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, keescook@chromium.org, paulmck@kernel.org, frederic@kernel.org, will@kernel.org, peterz@infradead.org, ardb@kernel.org, samitolvanen@google.com, juerg.haefliger@canonical.com, arnd@arndb.de, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, linus.walleij@linaro.org, akpm@linux-foundation.org, sebastian.reichel@collabora.com, rppt@kernel.org, aneesh.kumar@linux.ibm.com, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Thu, 22 Jun 2023 16:14:58 +0300 In-Reply-To: <680fadba-9104-3914-5175-e207fd3d9246@intel.com> References: <20230620144618.125703-1-ypodemsk@redhat.com> <20230620144618.125703-3-ypodemsk@redhat.com> <680fadba-9104-3914-5175-e207fd3d9246@intel.com> X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) Mime-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 04B0C100021 X-Stat-Signature: 6a74giu5rcduswkxc1n18q7dkqjh49ci X-HE-Tag: 1687439706-316759 X-HE-Meta: U2FsdGVkX1+iG2lWByohch/vTM5NMqmJjGafNbcPqxE4zhg4sIB4H/6f+BZX9rZ/EOrX/rvz7gVchG3YztS6WzBbkWXPo4iixsn8ZMUckBP7XseDcB46pP5a+T1iHHtzwgJOM7xUkwRlrfwMqQh291Q2AZFttl/iBvgF1m1CZoPXHdaaToJUcEHmD6vGOo+jtGjlMpcBuyp7N1JFnuMJPdvAVQBnChf8PKKHyBJADhyE6s0IHvXLqGD8KNjfdJG3tTMnnIEIPq9xN3E7Hv4M+gjUUliL0+FEUYECDf4ymV5MK6iS2OvxLzB4RkDY7Jpl6PYPw0IxrZS252cSu/CR0vISGXuAjkwuejkwgCyNRaV6aF5DnVDFJYtywlHZ1WuC5k5JgFDjv3Bysqbdter5zIwK//+KCOjat83cFvFPdKEq9BHA5mMz5wVhG47GdcblQnZOra4h3ItFFVqvTQLVoufwIhLvszwczdDB90XleT35P0pZt5wH3C9jxtA4NXZl2t8Ffbr5NiyRI7ssCBh+c5vvBA5H6isl9cuZcBvEViHq8rcR7KWMvHMMV/1kSVIKwnF+5hroJVcc5tCKeDaJZbOqnIlx8+ol3d+vpAb8Jc4r/kHZF17byRN51UAQSibh4oVsWH5XOAGEfuvgZk8poBrUnQX903cga2+w9uRceTzRfM5xNWcYI4FU6MUDignObLDk6Qs48svYbMw/uKVb1eY3g9Tw8aYm3bAxlZv8vbzCu0ceWwpQCciO6GA9hkf7drQ4yVLcvsQJ3Y6h3hgfd68SYcV31gW0p+1pskjrRx+NQ5oIN1h8j2zWfJI7P3yIevhqiiW9/4J3ijwZAnuuiLtgEFvF2JPg0nTIzR36LRWyxJ4RQQhXLStIPoA3zEnxty6k8ZETBVnPbLQR4H7jREEYpxssU8V6/JFZL7HAj198Hu8oyLT8WWGXQNJyTJfxPzi6cxQBysqUhi69gFR ABjYrLXM qK3JHBLbwAY9tkzGSmC0hMMbr4tSt+87/c5SHSql/9dX1tNXny1PHAfI1w14jvCuFbTvN+v1iU24/0j6Sb/81VV9bzDFMHrKjM3/FW70rbrvlBWqb25d5//jvncb0J0gUtio6kXXsuYB4MTgtExsLHdFvHd7eIvH6G+uf0TPR8Sj/mqqbDWm7ZEVpr0qztsCHhI0tX8U/wCCeRHvNsZa6Yg35UBBQGj336W/mXcy2OTGhHbet6qia0X+eGCwTMiYDnGhSQ3LlwTiL1mVLis9DmoXctcNRgIc9hvEtKUQKOFdTIfZCwbTLHiJDmeijiGb4dv2h48qTWphiesRL14+FCamqoc/YWeycSvs6IaIkrTxBsYsCKgaJeMREUVOM93rHxGUATqQrAZmJsVrdcyplY/emzWcGLvaZTwldIJhi/KbU/GoQympnQUtBD4KpWimEXL7v+BdDquG7xhy4Fm9FT5St/jOJoWKVapjWUtOagCtJVjJfOyRwX4ESL8d+sqw4H8l/1qbU2b9h41mwfSDhRaLDRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2023-06-21 at 10:42 -0700, Dave Hansen wrote: > On 6/20/23 07:46, Yair Podemsky wrote: > > -void tlb_remove_table_sync_one(void) > > +#ifdef CONFIG_ARCH_HAS_CPUMASK_BITS > > +#define REMOVE_TABLE_IPI_MASK mm_cpumask(mm) > > +#else > > +#define REMOVE_TABLE_IPI_MASK cpu_online_mask > > +#endif /* CONFIG_ARCH_HAS_CPUMASK_BITS */ > > + > > +void tlb_remove_table_sync_one(struct mm_struct *mm) > > { > > /* > > * This isn't an RCU grace period and hence the page-tables > > cannot be > > @@ -200,7 +206,8 @@ void tlb_remove_table_sync_one(void) > > * It is however sufficient for software page-table walkers > > that rely on > > * IRQ disabling. > > */ > > - smp_call_function(tlb_remove_table_smp_sync, NULL, 1); > > + on_each_cpu_mask(REMOVE_TABLE_IPI_MASK, > > tlb_remove_table_smp_sync, > > + NULL, true); > > } > > That "REMOVE_TABLE_IPI_MASK" thing is pretty confusing. It *looks* > like > a constant. It does *NOT* look at all like it consumes 'mm'. Worst > case, just create a local variable: > > if (IS_ENABLED(CONFIG_ARCH_HAS_CPUMASK_BITS)) > ipi_mask = mm_cpumask(mm); > else > ipi_mask = cpu_online_mask; > > on_each_cpu_mask(ipi_mask, ...); > > That's a billion times more clear and it'll compile down to the same > thing. > > I do think the CONFIG_ARCH_HAS_CPUMASK_BITS naming is also pretty > confusing, but I don't have any better suggestions. Maybe something > with "MM_CPUMASK" in it? > Hi Dave, Thanks for your suggestions! I will send a new version with the local variable as you suggested soon. As for the config name, what about CONFIG_ARCH_HAS_MM_CPUMASK? Thanks, Yair