From: "Garg, Shivank" <shivankg@amd.com>
To: Ackerley Tng <ackerleytng@google.com>,
willy@infradead.org, akpm@linux-foundation.org, david@redhat.com,
pbonzini@redhat.com, shuah@kernel.org, seanjc@google.com,
vbabka@suse.cz
Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, dsterba@suse.com,
xiang@kernel.org, chao@kernel.org, jaegeuk@kernel.org,
clm@fb.com, josef@toxicpanda.com, kent.overstreet@linux.dev,
zbestahu@gmail.com, jefflexu@linux.alibaba.com,
dhavale@google.com, lihongbo22@huawei.com,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
rppt@kernel.org, surenb@google.com, mhocko@suse.com,
ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com,
rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net,
ying.huang@linux.alibaba.com, apopple@nvidia.com,
tabba@google.com, paul@paul-moore.com, jmorris@namei.org,
serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com,
vannapurve@google.com, chao.gao@intel.com, bharata@amd.com,
nikunj@amd.com, shdhiman@amd.com, yan.y.zhao@intel.com,
Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com,
michael.roth@amd.com, aik@amd.com, jgg@nvidia.com,
kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz,
hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com,
rientjes@google.com, roypat@amazon.co.uk, chao.p.peng@intel.com,
amit@infradead.org, ddutile@redhat.com, dan.j.williams@intel.com,
ashish.kalra@amd.com, gshan@redhat.com, jgowans@amazon.com,
pankaj.gupta@amd.com, papaluri@amd.com, yuzhao@google.com,
suzuki.poulose@arm.com, linux-bcachefs@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev
Subject: Re: [PATCH kvm-next V11 4/7] KVM: guest_memfd: Use guest mem inodes instead of anonymous inodes
Date: Thu, 28 Aug 2025 11:19:42 +0530 [thread overview]
Message-ID: <79fae787-7160-4245-886f-671860b5708a@amd.com> (raw)
In-Reply-To: <diqztt1sbd2v.fsf@google.com>
On 8/28/2025 4:13 AM, Ackerley Tng wrote:
> Shivank Garg <shivankg@amd.com> writes:
>
>>
>> [...snip...]
>>
>
> I meant to send this to you before this version went out but you were
> too quick!
I wanted to get it merged quickly ;)
>
> Here's a new version, Fuad and I reviewed this again internally. The
> changes are:
>
> + Sort linux/pseudo_fs.h after linux/pagemap.h (alphabetical)
> + Don't set MNT_NOEXEC on the mount, since SB_I_NOEXEC was already set
> on the superblock
> + Rename kvm_gmem_inode_make_secure_inode() to kvm_gmem_inode_create()
> + Emphasizes that there is a creation in this function
> + Remove "secure" from the function name to remove confusion that
> there may be a "non-secure" version
> + In kvm_gmem_inode_create_getfile()'s error path, return ERR_PTR(err)
> directly instead of having a goto
>
Thanks for the quick update! The changes look good. I'll incorporate them
in the next version.
Best Regards,
Shivank
next prev parent reply other threads:[~2025-08-28 5:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 17:52 [PATCH kvm-next V11 0/7] Add NUMA mempolicy support for KVM guest-memfd Shivank Garg
2025-08-27 17:52 ` [PATCH kvm-next V11 1/7] mm/filemap: Add NUMA mempolicy support to filemap_alloc_folio() Shivank Garg
2025-08-27 17:52 ` [PATCH kvm-next V11 2/7] mm/filemap: Extend __filemap_get_folio() to support NUMA memory policies Shivank Garg
2025-08-27 17:52 ` [PATCH kvm-next V11 3/7] mm/mempolicy: Export memory policy symbols Shivank Garg
2025-08-27 17:52 ` [PATCH kvm-next V11 4/7] KVM: guest_memfd: Use guest mem inodes instead of anonymous inodes Shivank Garg
2025-08-27 22:43 ` Ackerley Tng
2025-08-28 5:49 ` Garg, Shivank [this message]
2025-08-28 10:06 ` David Hildenbrand
2025-08-27 17:52 ` [PATCH kvm-next V11 5/7] KVM: guest_memfd: Add slab-allocated inode cache Shivank Garg
2025-08-27 17:52 ` [PATCH kvm-next V11 6/7] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy Shivank Garg
2025-08-27 17:52 ` [PATCH kvm-next V11 7/7] KVM: guest_memfd: selftests: Add tests for mmap and NUMA policy support Shivank Garg
2025-08-28 12:44 ` [PATCH kvm-next V11 0/7] Add NUMA mempolicy support for KVM guest-memfd David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79fae787-7160-4245-886f-671860b5708a@amd.com \
--to=shivankg@amd.com \
--cc=Liam.Howlett@oracle.com \
--cc=Neeraj.Upadhyay@amd.com \
--cc=ackerleytng@google.com \
--cc=aik@amd.com \
--cc=akpm@linux-foundation.org \
--cc=amit@infradead.org \
--cc=apopple@nvidia.com \
--cc=ashish.kalra@amd.com \
--cc=bfoster@redhat.com \
--cc=bharata@amd.com \
--cc=brauner@kernel.org \
--cc=byungchul@sk.com \
--cc=cgzones@googlemail.com \
--cc=chao.gao@intel.com \
--cc=chao.p.peng@intel.com \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=ddutile@redhat.com \
--cc=dhavale@google.com \
--cc=dsterba@suse.com \
--cc=gourry@gourry.net \
--cc=gshan@redhat.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jefflexu@linux.alibaba.com \
--cc=jgg@nvidia.com \
--cc=jgowans@amazon.com \
--cc=jmorris@namei.org \
--cc=josef@toxicpanda.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kalyazin@amazon.com \
--cc=kent.overstreet@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=lihongbo22@huawei.com \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=matthew.brost@intel.com \
--cc=mhocko@suse.com \
--cc=michael.roth@amd.com \
--cc=nikunj@amd.com \
--cc=pankaj.gupta@amd.com \
--cc=papaluri@amd.com \
--cc=paul@paul-moore.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=pvorel@suse.cz \
--cc=rakie.kim@sk.com \
--cc=rientjes@google.com \
--cc=roypat@amazon.co.uk \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=serge@hallyn.com \
--cc=shdhiman@amd.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vannapurve@google.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
--cc=yan.y.zhao@intel.com \
--cc=ying.huang@linux.alibaba.com \
--cc=yuzhao@google.com \
--cc=zbestahu@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).