From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36283C43334 for ; Sun, 12 Jun 2022 23:00:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60BCA8D013B; Sun, 12 Jun 2022 19:00:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BB326B014D; Sun, 12 Jun 2022 19:00:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45BBC8D013B; Sun, 12 Jun 2022 19:00:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 35E006B014A for ; Sun, 12 Jun 2022 19:00:14 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 0B8DB1209EC for ; Sun, 12 Jun 2022 23:00:14 +0000 (UTC) X-FDA: 79571103948.21.46C6955 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf18.hostedemail.com (Postfix) with ESMTP id 88C621C007B for ; Sun, 12 Jun 2022 23:00:13 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id x138so4258375pfc.12 for ; Sun, 12 Jun 2022 16:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=BhZn/YLFjWinGYE1K2OdXmxZD2HyQtebUnbRlvHaipU=; b=XQOLh4+5+zhk/9/MVE0hLR0CVKMMlJnhmGFB4iF9a7Ts+6PJ1RuGMXMh3quuBWdtTA /kfkAIu/0FNCipUjpi/sBkdUbbMGF68n/2NvBiyEfkRgfH3xKgMm2JkTrg5G9z6dWjec sQQ8yQ7EjzRdLeMsrSGINKasA2RSjC4mf/ZmPwA5n1w10+R44nmkZgRI9iZh0vf/UX+u B1BTPD+9Dfj1pqeKt8pO6dI+BJeRBynD/9Luk5WqGxOYMHNAoNX8f1q+N6zdq5AXHitN BRgeB6blgia/AqqKqGbAsKXG1XOqA1/bVL1RQZaLaEJaBrtKCPVkJCS3voZlu6umMWrx 31HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=BhZn/YLFjWinGYE1K2OdXmxZD2HyQtebUnbRlvHaipU=; b=Nj1YLeQG/IOgnSfpDcvN2mS75uLEGbdlFsJWiDZDuxSPZbsn+sDRl+SkWqevYKO7CL 9iSDc6dU1NwrDBFC570khd9MsBfaZzwN/Ngl4Z9oJD343FkOmP35yVQHtsno7sg97Q+3 sdOrQ7q/hU6UEOUgONO5u+lCRzNd0vgyMBgzO5zPEgrRD7mpwVwKpfB8Y7oa4wQGdMlq oMvfph2tWpc7c9mauCl6mO1nfPfgB+7jFBnQdrohgFHk80OmsNSb+jCu5McY2sXHezwJ wwGgA5/vWZ+yd0I0KuBr/JUykBDifoUXylMsJ5GIBFCm7J5t9ESAxMKhNjoA2BkQs2Lp qFXA== X-Gm-Message-State: AOAM531rYqPXDfCsECUyxVj5pRIL7CCrIeALEEygeLQN90x3UGmv3NOX zPcJ8qcJpwVHsjTt/vi24xfxFlVGJlmLRg== X-Google-Smtp-Source: ABdhPJzpinCR6bQlEKm2X/IvwQ/rLqYYh2mcFdKHwTBVhXMpZRq60C9GAK/pHt07LiGbo9ydZ5OG5Q== X-Received: by 2002:a63:210e:0:b0:3fd:9c07:7670 with SMTP id h14-20020a63210e000000b003fd9c077670mr34791757pgh.222.1655074812274; Sun, 12 Jun 2022 16:00:12 -0700 (PDT) Received: from [2620:15c:29:204:c274:b6da:d4b1:cf53] ([2620:15c:29:204:c274:b6da:d4b1:cf53]) by smtp.gmail.com with ESMTPSA id x21-20020a170902821500b001641244d051sm3531337pln.257.2022.06.12.16.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jun 2022 16:00:11 -0700 (PDT) Date: Sun, 12 Jun 2022 16:00:11 -0700 (PDT) From: David Rientjes To: Daniel Vetter cc: LKML , DRI Development , Daniel Vetter , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm/slab: delete cache_alloc_debugcheck_before() In-Reply-To: <20220605152539.3196045-2-daniel.vetter@ffwll.ch> Message-ID: <79fc4112-bc2f-c5f5-2e4-975324b69316@google.com> References: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> <20220605152539.3196045-2-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655074813; a=rsa-sha256; cv=none; b=egfySF3WuSkUh6Rx9/w3/PbXUGl/FQoVjZfq3MMp8o+Ouw9Uyxu87rU8jJyJf6ONmKJXR3 g9cDkzYIvlPq8EeEQhxwhwsWZIHZXTxiSgKEIs43KE8sjZ5rRaSYOgP2J6hrwEwYgQ43qx v8sZw1xWK298jVtdUDw+G77sqznx5R0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=XQOLh4+5; spf=pass (imf18.hostedemail.com: domain of rientjes@google.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655074813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BhZn/YLFjWinGYE1K2OdXmxZD2HyQtebUnbRlvHaipU=; b=f+yYtXSkgLwztsvwN/RKXr9/L0iSZiQWuSkWPkAEwciZdkg7fTB5orh7BKlqIKko1EZhS9 MrPSQ9abQ7QTFU/R5y9zeXeK3+Qi/90qaGVnczvlhkoG5YK5bIlpeXTRZ7ulLSi4LQOUSX YVy2jo9cBkPIEu9zT1gV30gUgFI69p4= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 88C621C007B X-Stat-Signature: tehpknfrmu5crmrdwd14drrnjk1o6eir X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=XQOLh4+5; spf=pass (imf18.hostedemail.com: domain of rientjes@google.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1655074813-498064 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 5 Jun 2022, Daniel Vetter wrote: > It only does a might_sleep_if(GFP_RECLAIM) check, which is already > covered by the might_alloc() in slab_pre_alloc_hook(). And all callers > of cache_alloc_debugcheck_before() call that beforehand already. > > Signed-off-by: Daniel Vetter > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Roman Gushchin > Cc: linux-mm@kvack.org Acked-by: David Rientjes