Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bradley Morgan <bradley.morgan@linux.dev>
To: david@kernel.org
Cc: akpm@linux-foundation.org, alexander.shishkin@linux.intel.com,
	ast@kernel.org, bpf@vger.kernel.org, bsegall@google.com,
	dietmar.eggemann@arm.com, juri.lelli@redhat.com, kees@kernel.org,
	kprateek.nayak@amd.com, liam@infradead.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org,
	mason@kernel.org, mathieu.poirier@linaro.org, mgorman@suse.de,
	mhocko@suse.com, mingo@kernel.org, mingo@redhat.com,
	peterz@infradead.org, rostedt@goodmis.org, rppt@kernel.org,
	sashiko-bot@kernel.org, songliubraving@fb.com,
	stable@vger.kernel.org, surenb@google.com, vbabka@kernel.org,
	vincent.guittot@linaro.org, vschneid@redhat.com, yhs@fb.com
Subject: Re: [PATCH] fork: clear p->mm when copy_process() fails
Date: Thu, 19 Nov 2026 16:00:23 +0000	[thread overview]
Message-ID: <7F08BE59-B6F6-4884-AD56-8178335F2C15@linux.dev> (raw)
In-Reply-To: <20261119-mm_failed_fork-v1-1-b3019f43d197@kernel.org>

On 19 November 2026 08:04:58 GMT, "David Hildenbrand (Arm)"
<david@kernel.org> wrote:
>From: Chris Mason <mason@kernel.org>
>
>When copy_process() fails after copy_mm(), the error path drops the mm
>reference but leaves p->mm set. Perf and BPF can still reach the
>task, and take a reference on the already freed mm through get_task_mm()
>or bpf_find_vma(), resulting in a use-after-free:
>
>    copy_process()               PERF_EVENT_IOC_SET_FILTER
>    ==============               =========================
>    perf_event_init_task(p)
>    copy_mm(p)
>    a later step fails
>    mmput(p->mm)
>      /* frees the mm */
>                                 perf_event_addr_filters_apply()
>                                   get_task_mm(p)
>                                     /* use-after-free */
>
>Similarly, a BPF program on the task_free LSM hook can call
>bpf_find_vma(p)
>before the task is freed.
>
>Fix it by clearing p->mm under task_lock() before dropping the reference,
>just like exit_mm() does.
>
>Further, if copy_process() fails before copy_mm(), p->mm is still the
>parent's mm pointer copied by dup_task_struct(), without having taken a
>reference. While nobody can access it concurrently, there is the
>chance that it might get accessed later when a BPF program is attached
>to free_task().
>
>With CONFIG_MEMCG the task is freed after an RCU grace period, so the
>parent might already be gone and p->mm in the child points at something
>that was already freed. So let's just clear p->mm before freeing the
>task. No lock is required as there cannot be concurrent access (and we
>might not even have the lock initialized yet).
>
>This has medium urgency.
>
>Fixes: 375637bc5249 ("perf/core: Introduce address range filtering")
>Fixes: 7c7e3d31e785 ("bpf: Introduce helper bpf_find_vma")
>Reported-by: Sashiko <sashiko-bot@kernel.org>
>Closes: https://lore.kernel.org/sashiko-outbox-180866@kernel.org/
>Cc: stable@vger.kernel.org
>Signed-off-by: Chris Mason <mason@kernel.org>
>[ david: simplify description and comments ]

Reviewed-by: Bradley Morgan <bradley.morgan@linux.dev>


>Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
>---
>I can take this through my tree (rather soonish) unless someone else
>wants to pick this up.
>---
> kernel/fork.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
>diff --git a/kernel/fork.c b/kernel/fork.c
>index 5efceb8d58a78..77d6c8fc38c66 100644
>--- a/kernel/fork.c
>+++ b/kernel/fork.c
>@@ -2628,8 +2628,14 @@ __latent_entropy struct task_struct *copy_process(
> bad_fork_cleanup_mm:
> 	sched_cache_fork_cleanup(p);
> 	if (p->mm) {
>-		mm_clear_owner(p->mm, p);
>-		mmput(p->mm);
>+		struct mm_struct *mm = p->mm;
>+
>+		/* Perf events and BPF programs can still reach p. */
>+		task_lock(p);
>+		p->mm = NULL;
>+		task_unlock(p);
>+		mm_clear_owner(mm, p);
>+		mmput(mm);
> 	}
> bad_fork_cleanup_signal:
> 	if (!(clone_flags & CLONE_THREAD))
>@@ -2663,6 +2669,11 @@ __latent_entropy struct task_struct *copy_process(
> 	exit_cred_namespaces(p);
> 	exit_creds(p);
> bad_fork_free:
>+	/*
>+	 * If set, p->mm points at the parent's mm without a reference. Nobody
>+	 * can access it concurrently anymore, but prevent later access.
>+	 */
>+	p->mm = NULL;
> 	WRITE_ONCE(p->__state, TASK_DEAD);
> 	exit_task_stack_account(p);
> 	put_task_stack(p);
>
>---
>base-commit: 4405c18c95d2d0f99f6c581ef0ee8591a1aa6ccd
>change-id: 20261119-mm_failed_fork-a46141b503d0
>
>Best regards,
>--  
>David Hildenbrand (Arm) <david@kernel.org>
>
>
>


--- Thanks!


      parent reply	other threads:[~2026-11-19 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:04 [PATCH] fork: clear p->mm when copy_process() fails David Hildenbrand (Arm)
2026-11-19  8:29 ` Michal Hocko
2026-11-19 11:33 ` Lorenzo Stoakes (ARM)
2026-11-19 16:00 ` Bradley Morgan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7F08BE59-B6F6-4884-AD56-8178335F2C15@linux.dev \
    --to=bradley.morgan@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=bsegall@google.com \
    --cc=david@kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kees@kernel.org \
    --cc=kprateek.nayak@amd.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mason@kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox