From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_NONE,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1AC1C433E0 for ; Fri, 3 Jul 2020 15:46:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5FD6720C56 for ; Fri, 3 Jul 2020 15:46:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F2LHPoy/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FD6720C56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D08378D0089; Fri, 3 Jul 2020 11:46:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C922A8D0074; Fri, 3 Jul 2020 11:46:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5B378D0089; Fri, 3 Jul 2020 11:46:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 9C4818D0074 for ; Fri, 3 Jul 2020 11:46:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 54A0E181AC9BF for ; Fri, 3 Jul 2020 15:46:36 +0000 (UTC) X-FDA: 76997191992.09.pipe03_5a1271826e93 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 2A114180AD807 for ; Fri, 3 Jul 2020 15:46:36 +0000 (UTC) X-HE-Tag: pipe03_5a1271826e93 X-Filterd-Recvd-Size: 4307 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 15:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593791195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kZamksu9q4RTlXzhEF7oeFMOgoJ1Qb6qWkOIgdiQa7I=; b=F2LHPoy/ikCLvo0s1d72nWd28RN64dszEs7ihUpMT/FcwiSvjN3iGuwsoIq0MHsTmYJavi wQrl0nyPHGQaEAFAfg0Ok3LTsZ4V66QXRWa1VOkhn1fiS9Oyt7/h/AKrDBLoC87U3TYVH7 F14PHyOj8vJSfWZAnEdX3uTXlCNg5W4= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162--STQJNMZOuyo1HMbrBSlcA-1; Fri, 03 Jul 2020 11:46:33 -0400 X-MC-Unique: -STQJNMZOuyo1HMbrBSlcA-1 Received: by mail-qv1-f69.google.com with SMTP id em19so15105448qvb.14 for ; Fri, 03 Jul 2020 08:46:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=kZamksu9q4RTlXzhEF7oeFMOgoJ1Qb6qWkOIgdiQa7I=; b=YxvSv2/JurtkKyz4A11yIQCLZb34XGoZEDPuOwROWZw5VfPM0XBIRRA1rPh5IsIk6b AvglT3RwXd3BLMrII4X6zjvLnF3qXTpyBhPkj/SJfXGOwbb5AvQCyB8KSKCj1D3qsL88 b1pVUgmYcSeSdH/ok2IyJVo3WDZsiebonalpgk9Mbgw1GlK75blGlaApUgeL/mXq6JsW EFI3Lwa/XEJ5KfXSiD8K9+lBN/hmZbJRyUzpN16AhbVByEuWhUPx1J3yHTaFRD44fOAG t6gDvJximDpVoG3ruCf1WI+ZWdrkioHaePihmSTj0OabUsvHQ6cpK8enu07WTZ5psNvV qEYg== X-Gm-Message-State: AOAM5327g7VSisFYGl3JNxZ+upsHmiaKj0cWS1rNoKC9tNS/2KLtdKvl fY01httTr2AOBm4FDJ7LnAAywuo0R6brknI2+StA4UM3w4ZkV1imDmo4Pf3v2XggT66eH/Kz0cY JhzAPFidLU5Y= X-Received: by 2002:a05:6214:884:: with SMTP id cz4mr21705040qvb.3.1593791193270; Fri, 03 Jul 2020 08:46:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPFteIG/zDmV9OhkFZB+1yp9sGcAuhAQc+YY9Q88SZ8CcE37BbpMKtTkvgBPVirzToeV7QFw== X-Received: by 2002:a05:6214:884:: with SMTP id cz4mr21705023qvb.3.1593791193050; Fri, 03 Jul 2020 08:46:33 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id k45sm13334427qtc.62.2020.07.03.08.46.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2020 08:46:32 -0700 (PDT) Subject: Re: [PATCH] mm: initialize return of vm_insert_pages To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20200703145202.10629-1-trix@redhat.com> <20200703145454.GH25523@casper.infradead.org> From: Tom Rix Message-ID: <7b6eb14b-bbdc-dedb-c989-5e705cb9a453@redhat.com> Date: Fri, 3 Jul 2020 08:46:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200703145454.GH25523@casper.infradead.org> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2A114180AD807 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/3/20 7:54 AM, Matthew Wilcox wrote: > On Fri, Jul 03, 2020 at 07:52:02AM -0700, trix@redhat.com wrote: >> From: Tom Rix >> >> clang static analysis reports a garbage return >> >> In file included from mm/memory.c:84: >> mm/memory.c:1612:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] >> return err; >> ^~~~~~~~~~ >> >> The setting of err depends on a loop executing. >> So initialize err. > I'd argue that returning zero is wrong. If someone's asked to insert > zero pages, that's a nonsense thing to do so it should return -EINVAL.. > good point, i'll respin.