From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A02C433EF for ; Thu, 12 May 2022 20:03:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 840468D0003; Thu, 12 May 2022 16:03:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F0076B007B; Thu, 12 May 2022 16:03:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 647EC8D0003; Thu, 12 May 2022 16:03:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5699D6B0078 for ; Thu, 12 May 2022 16:03:02 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 24C5912082B for ; Thu, 12 May 2022 20:03:02 +0000 (UTC) X-FDA: 79458164604.29.2083651 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 09FD4400B5 for ; Thu, 12 May 2022 20:02:41 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id l20-20020a17090a409400b001dd2a9d555bso5886279pjg.0 for ; Thu, 12 May 2022 13:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=sgzUXe6rR4WSRaM+rRtq97MJQETnHYm+qxECQJ7rpDg=; b=s7kYJ7/I3nJPSDnYXtTsy8SNN2nbYnIDmWuHPyiEuuVxqMJuS+w2i7RTwzR0V/Zb/J CwcdS8Gsdmagq6dMHwuDYuGkGvdiqeTdT99iiCigpX8BnP/Lz5TsGHJ58p7x77dAVqqA vPNEjCV0gjddINHJfl9X+Z6KMKWrlnynAlRnX+KoLpNOV2iJxFrzFFAbeO92D/WywLh8 9jOuB/aO5hQxwNoDjh4L8SgLEYT1kJ55lVOrukwyl/au8cDLCPONPvP488cZiOJvB4A4 bTqkQLnAQT1YA05Pb+nWdryMNVlvfXtbCp06ALprTxz0oXHKuDdMxFPoVONb9IvFBsG+ D3cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=sgzUXe6rR4WSRaM+rRtq97MJQETnHYm+qxECQJ7rpDg=; b=c2R7K8btZSGEOcwZGJbbMfaSBLZWCztgxzeyMK34RfFDKQncOenFgMzMcX+WpWQGp+ 44ETzMq0Of6wckd2LBD//2YBIfZ+NZ6c5GnyI5i4htNImpBAQVpL6rdy5kfxwxHoOItn ZZcJLglowyayeI5q+n/yDkOnjIWtBIqQj/v5GEirrJ45nRUIKOFX0oFbgi4EqE8rHIC+ bqn2GEE8zx/HG4o/IhvDyptfUnBs9GMwXdoroQHSbN2sVdchwnNAeZzQwhoh2gwDuFXa 5vGZx+B0SUePGbXMsEBOXqa0+Pd6KXrlJUNBky8V7i2PrViFoHSTXUI7YTAmju3sUbLB FdmQ== X-Gm-Message-State: AOAM530tckqU7ukIBnr5C7JpFb0nscYp42Gm/zmssLg3pn+eMEE2PlHy 36xVIYHvOh8Zb78XyIcDguiP9Q== X-Google-Smtp-Source: ABdhPJw0sdoJibCRqGFM3xdEdaAcoLf+CrRsaAe1WdznrZqQSRUfoH2s9uxp0QKCxjuqPJ7zC7Yx+w== X-Received: by 2002:a17:903:1212:b0:15e:7d94:e21d with SMTP id l18-20020a170903121200b0015e7d94e21dmr1135236plh.92.1652385780589; Thu, 12 May 2022 13:03:00 -0700 (PDT) Received: from [2620:15c:29:204:8122:ccb0:c783:c757] ([2620:15c:29:204:8122:ccb0:c783:c757]) by smtp.gmail.com with ESMTPSA id t11-20020a170902e84b00b0015e8d4eb1dfsm335724plg.41.2022.05.12.13.02.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 13:03:00 -0700 (PDT) Date: Thu, 12 May 2022 13:02:59 -0700 (PDT) From: David Rientjes To: Zach O'Keefe cc: Alex Shi , David Hildenbrand , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer Subject: Re: [PATCH v5 05/13] mm/khugepaged: pipe enum scan_result codes back to callers In-Reply-To: <20220504214437.2850685-6-zokeefe@google.com> Message-ID: <7ca7c4-26ef-c533-a096-bcd2768cde4@google.com> References: <20220504214437.2850685-1-zokeefe@google.com> <20220504214437.2850685-6-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: 55nzowx1mw47c9tsa1bcut98whajbpdw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 09FD4400B5 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="s7kYJ7/I"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of rientjes@google.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=rientjes@google.com X-HE-Tag: 1652385761-698942 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 4 May 2022, Zach O'Keefe wrote: > Pipe enum scan_result codes back through return values of functions > downstream of khugepaged_scan_file() and khugepaged_scan_pmd() to > inform callers if the operation was successful, and if not, why. > > Since khugepaged_scan_pmd()'s return value already has a specific > meaning (whether mmap_lock was unlocked or not), add a bool* argument > to khugepaged_scan_pmd() to retrieve this information. > > Change khugepaged to take action based on the return values of > khugepaged_scan_file() and khugepaged_scan_pmd() instead of acting > deep within the collapsing functions themselves. > > Signed-off-by: Zach O'Keefe Acked-by: David Rientjes