From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F33C4708E for ; Tue, 6 Dec 2022 09:43:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 688748E0003; Tue, 6 Dec 2022 04:43:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 669068E0001; Tue, 6 Dec 2022 04:43:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 528918E0003; Tue, 6 Dec 2022 04:43:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4600E8E0001 for ; Tue, 6 Dec 2022 04:43:11 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 008571A07DE for ; Tue, 6 Dec 2022 09:43:10 +0000 (UTC) X-FDA: 80211392940.16.D061A5C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 59DA810000F for ; Tue, 6 Dec 2022 09:43:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W3fiXALK; spf=pass (imf05.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670319790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eGk91IPw6rbq/lI/vrTCbPQIiPbKWWsypyMlB5hlmTM=; b=II9ZzD9XVf4hXmdV8/0JAVvUOWuwPx6ks1emwDlpWaxKAN6eAyrGHWCgpRl052qcST8Orj Ag2gbfaRq+NMGNmFDgEoz7zkWvtXDywJoB99izloWPwDcN7n6n7nUhtFbruhZr0jQCH5/V zL05CIR3QbyIodltsLPrSDPew3Wp8mE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W3fiXALK; spf=pass (imf05.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670319790; a=rsa-sha256; cv=none; b=Wx6fQMRjQ2q0D5PyvQ6sQPxwJRDg2EGJ50q1BGtTpzWMiizbIuVjkCWSfBffttlKB+s68l HGe6eb+Fg3iWgIdy2ze17SNnhbrSSE6G2B+dfQdbBFQOOVvSDeNOCkWxDMkki7Bhr4U54P Bpj6EEQ12UbYf7Wj0ctBMKsbWvYC+BY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670319789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eGk91IPw6rbq/lI/vrTCbPQIiPbKWWsypyMlB5hlmTM=; b=W3fiXALKHBRfD1MyPEFJ6TLp3CAru5APKx0HHWb5ddRMLbg7wWI5q3v8TowQpBjZKvoaP9 wm8lfNKNoEuS3XQ1hwr+rKWANTKpMxm6XR1sn/XfWHQKd6lEmD6n1GNaW5HZG8mNgWlhpG r1cyv3GuUwxWLVp+WntrgJZbNBEPL30= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-68-rIiPhWiiN6ylZMXEGaGnZA-1; Tue, 06 Dec 2022 04:43:08 -0500 X-MC-Unique: rIiPhWiiN6ylZMXEGaGnZA-1 Received: by mail-ej1-f70.google.com with SMTP id gb8-20020a170907960800b007bef177dddeso1219587ejc.10 for ; Tue, 06 Dec 2022 01:43:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eGk91IPw6rbq/lI/vrTCbPQIiPbKWWsypyMlB5hlmTM=; b=UekO76S2uNTi2sRt+JgjCSnnDRoICjmdDU78KyFMYHb8mHi4bk+ut46PYLbfvm67UN 9mxeIEj2dwwqR/Ft8lNlbziFWBTUyqyg7x0fjFNa54tnISeKkohoJi4kAZSamZ1+1Otf Yb3NBxWGDrylGUyTQOCkvCU+sRpFJ8TMtaI9fpiXAPrLrW3XafJGfVXnK1dpkbVeTOv/ f8peUVrGReOK8m5LCsywJT3jrF4FEFwhZQs8lOSbTU/m5Rvjw16T2kd470ULqWWjDrv9 Sh+/3JjfD40d+sSvf9oIFQfjbFYQOkYlh8FE35j8+RGK1mKt2PpMydWsO9J9NG1nUOYI 0njg== X-Gm-Message-State: ANoB5pnSg/YEd3vUOq1SvrFsLvIW2IoKpXAdaZy4GjDO9JDm2w3FMeky EMF85Na/AUInheT45yK6NTiWMQFYJWFVJHryXX7fQc6q7LcIu9BEZkyzGgWL9O+9hM7bLkl38Te PuY876MMAems= X-Received: by 2002:a17:906:c250:b0:7c0:9bc2:a7f0 with SMTP id bl16-20020a170906c25000b007c09bc2a7f0mr23342992ejb.59.1670319787370; Tue, 06 Dec 2022 01:43:07 -0800 (PST) X-Google-Smtp-Source: AA0mqf5x6dYtNeE9lF9+PVXBxLxdQwb29ESPvaO0wDftxcCEfVz2CMlpyhLRkpA66Tnw8lus39qxVQ== X-Received: by 2002:a17:906:c250:b0:7c0:9bc2:a7f0 with SMTP id bl16-20020a170906c25000b007c09bc2a7f0mr23342978ejb.59.1670319787127; Tue, 06 Dec 2022 01:43:07 -0800 (PST) Received: from [192.168.41.200] (83-90-141-187-cable.dk.customer.tdc.net. [83.90.141.187]) by smtp.gmail.com with ESMTPSA id u14-20020a056402110e00b0046af63521a2sm776580edv.29.2022.12.06.01.43.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 01:43:06 -0800 (PST) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <7cfbcde0-9d17-0a89-49ae-942a80c63feb@redhat.com> Date: Tue, 6 Dec 2022 10:43:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Cc: brouer@redhat.com, Jesper Dangaard Brouer , Ilias Apalodimas , netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 00/24] Split page pools from struct page To: Matthew Wilcox , Jesper Dangaard Brouer References: <20221130220803.3657490-1-willy@infradead.org> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 59DA810000F X-Rspam-User: X-Stat-Signature: e7mo16okchgb5jxoztkbwmmxg8tkcw6w X-Spamd-Result: default: False [1.52 / 9.00]; SORBS_IRL_BL(3.00)[209.85.218.70:received]; BAYES_HAM(-1.58)[84.63%]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; BAD_REP_POLICIES(0.10)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; DMARC_POLICY_ALLOW(0.00)[redhat.com,none]; DKIM_TRACE(0.00)[redhat.com:+]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:170.10.133.0/24]; RCVD_COUNT_THREE(0.00)[4]; R_DKIM_ALLOW(0.00)[redhat.com:s=mimecast20190719]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; RCVD_VIA_SMTP_AUTH(0.00)[] X-HE-Tag: 1670319790-851852 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/12/2022 17.31, Matthew Wilcox wrote: > On Mon, Dec 05, 2022 at 04:34:10PM +0100, Jesper Dangaard Brouer wrote: >> I have a micro-benchmark [1][2], that I want to run on this patchset. >> Reducing the asm code 'text' size is less likely to improve a >> microbenchmark. The 100Gbit mlx5 driver uses page_pool, so perhaps I can >> run a packet benchmark that can show the (expected) performance improvement. >> >> [1] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_simple.c >> [2] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_cross_cpu.c > > Appreciate it! I'm not expecting any performance change outside noise, > but things do surprise me. I'd appreciate it if you'd test with a > "distro" config, ie enabling CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP so > we show the most expensive case. > I have CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP=y BUT it isn't default runtime enabled. Should I also choose CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON or enable it via sysctl ? $ grep -H . /proc/sys/vm/hugetlb_optimize_vmemmap /proc/sys/vm/hugetlb_optimize_vmemmap:0 --Jesper