From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"ardb@kernel.org" <ardb@kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"Szabolcs.Nagy@arm.com" <Szabolcs.Nagy@arm.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"maz@kernel.org" <maz@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
"debug@rivosinc.com" <debug@rivosinc.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"hjl.tools@gmail.com" <hjl.tools@gmail.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"oleg@redhat.com" <oleg@redhat.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"will@kernel.org" <will@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
"kvmarm@lists.linux.dev" <kvmarm@lists.linux.dev>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"oliver.upton@linux.dev" <oliver.upton@linux.dev>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v3 21/36] arm64/mm: Implement map_shadow_stack()
Date: Tue, 1 Aug 2023 20:57:59 +0000 [thread overview]
Message-ID: <7d03be1277a5f4be23df35ca96f4d6cd77735e2b.camel@intel.com> (raw)
In-Reply-To: <55c629cc-0545-460b-91cb-2ebdb8ae9051@sirena.org.uk>
On Tue, 2023-08-01 at 18:57 +0100, Mark Brown wrote:
> > You don't have to support all the flags actually, you could just
> > support the one mode you already have and reject all other
> > combinations... Then it matches between arch's, and you still have
> > the
> > guaranteed-ish end marker.
>
> Sure, though if we're going to the trouble of checking for the flag
> we
> probably may as well implement it. I guess x86 is locked in at this
> point by existing userspace. I guess I'll implement it assuming
> nobody
> from userspace complains, it's trivial for a kernel.
To make sure we are on the same page: What I'm saying is say we do
something like add another flag SHADOW_STACK_SET_MARKER that means add
a marker at the end (making the token off by one frame). Then you can
just reject any flags != (SHADOW_STACK_SET_MARKER |
SHADOW_STACK_SET_TOKEN) value, and leave the rest of the code as is. So
not really implementing anything new.
Then x86 could use the same flag meanings if/when it implements end
markers. If it doesn't seem worth it, it's not a big deal on my end.
Just seemed that they were needlessly diverging.
next prev parent reply other threads:[~2023-08-01 20:58 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 13:43 [PATCH v3 00/36] arm64/gcs: Provide support for GCS in userspace Mark Brown
2023-07-31 13:43 ` [PATCH v3 01/36] prctl: arch-agnostic prctl for shadow stack Mark Brown
2023-07-31 13:43 ` [PATCH v3 02/36] arm64: Document boot requirements for Guarded Control Stacks Mark Brown
2023-07-31 13:43 ` [PATCH v3 03/36] arm64/gcs: Document the ABI " Mark Brown
2023-07-31 13:43 ` [PATCH v3 04/36] arm64/sysreg: Add new system registers for GCS Mark Brown
2023-07-31 13:43 ` [PATCH v3 05/36] arm64/sysreg: Add definitions for architected GCS caps Mark Brown
2023-07-31 13:43 ` [PATCH v3 06/36] arm64/gcs: Add manual encodings of GCS instructions Mark Brown
2023-07-31 13:43 ` [PATCH v3 07/36] arm64/gcs: Provide copy_to_user_gcs() Mark Brown
2023-07-31 13:43 ` [PATCH v3 08/36] arm64/cpufeature: Runtime detection of Guarded Control Stack (GCS) Mark Brown
2023-07-31 13:43 ` [PATCH v3 09/36] arm64/mm: Allocate PIE slots for EL0 guarded control stack Mark Brown
2023-07-31 13:43 ` [PATCH v3 10/36] mm: Define VM_SHADOW_STACK for arm64 when we support GCS Mark Brown
2023-08-01 16:53 ` Mike Rapoport
2023-07-31 13:43 ` [PATCH v3 11/36] arm64/mm: Map pages for guarded control stack Mark Brown
2023-08-01 17:02 ` Mike Rapoport
2023-08-01 19:05 ` Mark Brown
2023-07-31 13:43 ` [PATCH v3 12/36] KVM: arm64: Manage GCS registers for guests Mark Brown
2023-07-31 13:43 ` [PATCH v3 13/36] arm64/gcs: Allow GCS usage at EL0 and EL1 Mark Brown
2023-07-31 13:43 ` [PATCH v3 14/36] arm64/idreg: Add overrride for GCS Mark Brown
2023-07-31 13:43 ` [PATCH v3 15/36] arm64/hwcap: Add hwcap " Mark Brown
2023-07-31 13:43 ` [PATCH v3 16/36] arm64/traps: Handle GCS exceptions Mark Brown
2023-07-31 13:43 ` [PATCH v3 17/36] arm64/mm: Handle GCS data aborts Mark Brown
2023-07-31 13:43 ` [PATCH v3 18/36] arm64/gcs: Context switch GCS state for EL0 Mark Brown
2023-07-31 13:43 ` [PATCH v3 19/36] arm64/gcs: Allocate a new GCS for threads with GCS enabled Mark Brown
2023-07-31 13:43 ` [PATCH v3 20/36] arm64/gcs: Implement shadow stack prctl() interface Mark Brown
2023-07-31 13:43 ` [PATCH v3 21/36] arm64/mm: Implement map_shadow_stack() Mark Brown
2023-07-31 15:56 ` Edgecombe, Rick P
2023-07-31 17:06 ` Mark Brown
2023-07-31 23:19 ` Edgecombe, Rick P
2023-08-01 14:01 ` Mark Brown
2023-08-01 17:07 ` Edgecombe, Rick P
2023-08-01 17:28 ` Mike Rapoport
2023-08-01 18:03 ` Mark Brown
2023-08-01 17:57 ` Mark Brown
2023-08-01 20:57 ` Edgecombe, Rick P [this message]
2023-08-02 16:27 ` Mark Brown
2023-08-04 13:38 ` Mark Brown
2023-08-04 16:43 ` Edgecombe, Rick P
2023-08-04 17:10 ` Mark Brown
2023-08-07 10:20 ` Szabolcs Nagy
2023-08-07 13:00 ` Mark Brown
2023-08-08 8:21 ` Szabolcs Nagy
2023-08-08 20:42 ` Mark Brown
2023-07-31 13:43 ` [PATCH v3 22/36] arm64/signal: Set up and restore the GCS context for signal handlers Mark Brown
2023-07-31 13:43 ` [PATCH v3 23/36] arm64/signal: Expose GCS state in signal frames Mark Brown
2023-07-31 13:43 ` [PATCH v3 24/36] arm64/ptrace: Expose GCS via ptrace and core files Mark Brown
2023-07-31 13:43 ` [PATCH v3 25/36] arm64: Add Kconfig for Guarded Control Stack (GCS) Mark Brown
2023-07-31 13:43 ` [PATCH v3 26/36] kselftest/arm64: Verify the GCS hwcap Mark Brown
2023-07-31 13:43 ` [PATCH v3 27/36] kselftest/arm64: Add GCS as a detected feature in the signal tests Mark Brown
2023-07-31 13:43 ` [PATCH v3 28/36] kselftest/arm64: Add framework support for GCS to signal handling tests Mark Brown
2023-07-31 13:43 ` [PATCH v3 29/36] kselftest/arm64: Allow signals tests to specify an expected si_code Mark Brown
2023-07-31 13:43 ` [PATCH v3 30/36] kselftest/arm64: Always run signals tests with GCS enabled Mark Brown
2023-07-31 13:43 ` [PATCH v3 31/36] kselftest/arm64: Add very basic GCS test program Mark Brown
2023-07-31 13:43 ` [PATCH v3 32/36] kselftest/arm64: Add a GCS test program built with the system libc Mark Brown
2023-07-31 13:43 ` [PATCH v3 33/36] kselftest/arm64: Add test coverage for GCS mode locking Mark Brown
2023-07-31 13:43 ` [PATCH v3 34/36] selftests/arm64: Add GCS signal tests Mark Brown
2023-07-31 13:43 ` [PATCH v3 35/36] kselftest/arm64: Add a GCS stress test Mark Brown
2023-07-31 13:43 ` [PATCH v3 36/36] kselftest/arm64: Enable GCS for the FP stress tests Mark Brown
2023-08-01 14:13 ` [PATCH v3 00/36] arm64/gcs: Provide support for GCS in userspace Will Deacon
2023-08-01 15:09 ` Mark Brown
2023-08-08 10:27 ` Szabolcs Nagy
2023-08-08 13:38 ` Will Deacon
2023-08-08 20:25 ` Mark Brown
2023-08-10 9:40 ` Will Deacon
2023-08-10 16:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d03be1277a5f4be23df35ca96f4d6cd77735e2b.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=debug@rivosinc.com \
--cc=ebiederm@xmission.com \
--cc=hjl.tools@gmail.com \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oleg@redhat.com \
--cc=oliver.upton@linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).