From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12250C7115C for ; Wed, 25 Jun 2025 10:29:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FBA56B00C6; Wed, 25 Jun 2025 06:29:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AA8F6B00C7; Wed, 25 Jun 2025 06:29:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 572A76B00C8; Wed, 25 Jun 2025 06:29:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 443B86B00C6 for ; Wed, 25 Jun 2025 06:29:14 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EF18F123B45 for ; Wed, 25 Jun 2025 10:29:13 +0000 (UTC) X-FDA: 83593550586.04.93CFAE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 8FFA54000D for ; Wed, 25 Jun 2025 10:29:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O84Slc61; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750847351; a=rsa-sha256; cv=none; b=jk6+Y0sLSOQ7Pg0xtB8ikpuzMUialUxvghJRJd3YAS9nhrq7DirhTV4Pb/ZZmYnGUVVUvR Qr3RDtF+nxuhqKrmgScvtAdF1O/Mbz4+fLLg9zMiBYz1+ZrLaN/H+hrNjbEctoUs1Z9XqQ oPjSONULbnLT7TJoh4XCS7EvcO587Tc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O84Slc61; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750847351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bOtjedNb3agliExh91aNdyGIpCUXRPaSeetVuHew1xQ=; b=THAqRDQT2gni6O7OXtMh4VADoSPvwUd5zJ4MPlD0UTl2ocx5LqUXmMWeK/kj5YOIug1ipq vS2XZxIR6RnCMc2h6W3DdwQK8ySwHgdcSs8k3595upQpmNYZvvj58up7ZV7OSgr+qgZjVX LMpZIXjlpIUuJPiezZVPaBKkqnEDvS0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750847351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bOtjedNb3agliExh91aNdyGIpCUXRPaSeetVuHew1xQ=; b=O84Slc61GakeXmJ7snbuh9eiqb1rVaRa9MeeVNve7ywsI2A41aOsK1x27o2TpetGd5oEeK 6jvJkRka1v57Vq00w/ayUcivX3V5E4mt0Xe4qQ/jI/ynQk2Fs42F6qsvJgvEmgprXwtooi EoP4jNNRNUzscO5j2ECP//l1xjPbXT0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-dzzL9qtZOEeFvKlA1VsgyA-1; Wed, 25 Jun 2025 06:29:07 -0400 X-MC-Unique: dzzL9qtZOEeFvKlA1VsgyA-1 X-Mimecast-MFC-AGG-ID: dzzL9qtZOEeFvKlA1VsgyA_1750847346 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a56b3dee17so384501f8f.0 for ; Wed, 25 Jun 2025 03:29:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750847346; x=1751452146; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bOtjedNb3agliExh91aNdyGIpCUXRPaSeetVuHew1xQ=; b=OK+ZVEiAoRqPHpf3viMhT0Tv57gH+nvQUKzE6IaMefe4ADqtmzpdTGrXfTY9mRS1qG xanMRYFmc0IFjNjGHR43p3nc/L3vwqbpBDBaTcSQjZIbXoB6ITflI+Mmk93fxic8cOXf u6O7nbQpAAZGddVPsgkj9NyK5cJ5dnnNtTaTznc1B5Ear4Bg0kNgPkw7a1RBnkMawD2t ht6qV5DBsuaos8DsWMtS8eNHVElY31lN/UqCe5NQqZmLPGoCDPdVBtaJ0LL8WZ7YnReb 9cGAsNvVTxVvcFHLsWnaeXEY2UllXECn1MN9AzOaEMcuFgZQi2QOLtfZXth9BsW+/Eg3 h1ew== X-Forwarded-Encrypted: i=1; AJvYcCW8aGKBgX6lL8gorgY3nYUuhUCQcmZWSF/R+ir6wb9+qwjrItv/sMTOe+SiLuIK+b2X3zytViQ+yg==@kvack.org X-Gm-Message-State: AOJu0Ywm4WoWTWUPAp7LD/3XNsDZIL6CquHZjYomTdIp+0ifXkL8gz2+ kmNbD60cKh92tAEEd9Sp2fQL1TpDKYjQYTh08RJwrRT2dn13HgcfUz5U1SvVXQ+U5TVT/WMbequ wTlswOwFU3ntWFGugoMfJPRlV3nV5d8TBdL84mrKuPE9NKwr4w0Lg X-Gm-Gg: ASbGncvjH97frgVKwPm1/QUR6pS0anjtMT0wwf9uAnBbWJt9dGVTsVhOm5I+/cWdaeT VHQDXLJDyP2chJBGDFt93K1bWD6Zs+8rGmybpRiZmNE2LmYkMPCczEoTOLXfLCPxMc3qu06S492 rvRhIyxu+G933e0Tby5T4ZNSlaUyS4JIx/dByOpJ5dTV3ThlgYRPuZBD83VBo5L+01pqkN7jsed InfPxUZS4yEtcKubxDSARnb9E1JP7h9Pq0VZj3gptwY4cLJqnuhXyj9S+VMNmF8D5oqQOHyPBTh GBNQWFOSK4a0Y4tbU/uiacymC+Fu+cxzm77ier0xChEg/8Mwz2YMIg== X-Received: by 2002:a05:6000:4024:b0:3a6:d7e6:f281 with SMTP id ffacd0b85a97d-3a6e7206d4fmr6018941f8f.22.1750847346440; Wed, 25 Jun 2025 03:29:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZgXBZLpTCm0txZS3WEHRru9TINqUL4GsR7SzFKebNlcNGIa5fR4Zr/Ulyod36CLaPBpQ1zw== X-Received: by 2002:a05:6000:4024:b0:3a6:d7e6:f281 with SMTP id ffacd0b85a97d-3a6e7206d4fmr6018912f8f.22.1750847345991; Wed, 25 Jun 2025 03:29:05 -0700 (PDT) Received: from [192.168.3.141] (p57a1abde.dip0.t-ipconnect.de. [87.161.171.222]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538237ac2csm15292705e9.38.2025.06.25.03.29.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 03:29:05 -0700 (PDT) Message-ID: <7d1c8c0a-1eb3-4919-9834-9b705c2ae7c8@redhat.com> Date: Wed, 25 Jun 2025 12:29:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/2] fix MADV_COLLAPSE issue if THP settings are disabled To: Lorenzo Stoakes Cc: Baolin Wang , Hugh Dickins , akpm@linux-foundation.org, ziy@nvidia.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, zokeefe@google.com, shy828301@gmail.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <008ec97f-3b33-4b47-a112-9cef8c1d7f58@redhat.com> <01d679f2-fd64-472c-b9dc-ebe87268ce82@lucifer.local> <23b8ad10-cd1f-45df-a25c-78d01c8af44f@redhat.com> <37fc3553-0d5a-4bdc-b473-cd740d47598e@linux.alibaba.com> <5de8ca8e-f293-4bfc-b49d-6e2a2e049f2b@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KYW65iL0OCUZclPvFDpemf6Gm8JeoY5TO0qqRBCAs_c_1750847346 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: suwrm8rtb6g8tj39uo7681q6az6doj87 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8FFA54000D X-HE-Tag: 1750847351-700643 X-HE-Meta: U2FsdGVkX1+QVo+1CwscDaF99wuOTssttd3JHoTppLI6rWN2uT+zdEPqW3anezxYiwpT1WE3zL2I2JTXZ77mlZU1QG6fyObHLRl6HuGWvOoTACH+cmG3sal85ef7Qva4LMSh1tkynGx/RB4brxvvBggwWg2mjuoh1zie5lVbQGm0s6awGHVbZygxOyoEaM8sgapbJDNIjwcgo9lQdXlc1/S6jIowOjxm9l6cIKJW0NVJ3siO1bi7WO/k9xX4pYubaHmVWLS/5xgosadK3V4A7p8rO0AbM454j5PiNWME/RYvQ/8+5maL7g2VbLZYZv84XtJ/JILEkQ7/MmeMW9Zs/IWl1JgHwIl3twQbMIKcqKx3XFSJ7ofG6+MN6xqhCYoIOI75G4VF9GDSBL+LuV1UJ4GpcilrWLwlplMlbifXltlOVJuhlzU9qqOgTlfogEqhUJtJBrJ3vx3cL69oT3g8zBPwVoujUxe08d6p/Farwy8KSbgqGdINTeM6ZZ/haRzyi0+ykZJTeZjKHHp3M99yQflG+SvHSbWaafxVOUdsEOAlP7Kn0UWv4WKEZ6BPTHKhPJCLlNBjrX4v8wVgctFWpbv4BU74UIZsJ/ugeHQLOIByZQLL8xBwBjwYMN0fwCjjBc/KNMc9lsDGNfQcnjwl/5WSStfKCQmYR6dgZC8cy/2yeZFeXPCMbnXZbZyZhmRqZuJ86eo3z3aPYWAoo7FiOwAekcaK717uewd5wMjdUC1IYrpNal5xV74G6tXqnuCvTE7QT4sJt51FQIT1fOnml8ui7iIDRRyYMgyNneF9SlPEGyku7hk2FfDsmwNOBvHvta3Qpy11rWa/SNyjR+cV305dEOZS8QUsSFT7zoxdrYjfwQk18eYBB6mkgOINg17pExoOnVDdyPYbA982O9uUQUfsiBTzrdiT0giTGPUndMDQ5Ex1fAweRjOYofIiwGDMb/CzFBBlqOeGJE4Al+C 0UNLZPrE 1sqIjl7pqikBpCVGv74o+YBu+0wQfDocXxetA50vV3kbqABPuqy31EjOvRribyIaHk4EqLSweqcoLgp0yOjanzEiJLhnJK3RPZYfsnkCTKjKvJI/Mn7ajHbuSWigmvd9/7OSQkVWr844szGc0qvQj1sEBZFV1YVeDgJLS/rSTmhm8XBdIPF1wJoGuh4Y/bzMWzAxRo+26U2g/Gqt5d22ap/pqoOcvJQC3N+ZO9xN+a5Gv+6YUCCz1nN5u4k8TKWTCnLibPdoI7fNEI15BeZyVrRo+PoaXcgO7nkfx73bPn9P+nP+sv8b6R/UUjX8oZCOjh7hrneLewWl7+GRkEvhGg2L+2aPvjT8B3+Pzx2UANt7yc3F7cjQcqYBiMPr2PtUXMUvmZ63PGVJlEgcmGQrxn39EkGSLEar6QK6EGfFLkWsceCkP+m6G9RqM3nAYlU7yCqvI0vPvCHevSoTl/Jbi8j5UDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.06.25 12:15, Lorenzo Stoakes wrote: > On Wed, Jun 25, 2025 at 12:07:12PM +0200, David Hildenbrand wrote: >>> Yes, I don't mean it will prevent madvise_collapse(), just as you said >>> that it could be problematic (it's horrible to try to collapse 512MB). >> >> Well, assume you have a VM at that is 2 GiB and could use 4 THPs. It's >> stupid, but there might be some selected use cases where it's not completely >> stupid. > > I guess we limit the stupidity by MADV_COLLAPSE working on a PMD-aligned range > so it'll be a no-op for an attempt to collapse 2 MiB (unless I'm misreading the > code). At least the doc says: "MADV_COLLAPSE will automatically clamp the provided range to be hugepage-aligned.", and skimming over the code that seems to be the case. Which makes sense to me: never collapse outside the provided range. So if someone would ever specify something smaller (e.g., 2MiB aligned range with 512MiB PMD size) we could decide to collapse a 2MiB THP there instead. Right now, it would be ignored. Guess the rule is simply to not collapse outside of the requested range. Maybe that rule can be used to support collapsing of smaller THPs in the future as well. Maybe (can of worms) :) -- Cheers, David / dhildenb