From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18332C4829E for ; Thu, 15 Feb 2024 16:07:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 407BA8D0006; Thu, 15 Feb 2024 11:07:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B7718D0001; Thu, 15 Feb 2024 11:07:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25B1C8D0006; Thu, 15 Feb 2024 11:07:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0DA258D0001 for ; Thu, 15 Feb 2024 11:07:43 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D76BB1A1196 for ; Thu, 15 Feb 2024 16:07:41 +0000 (UTC) X-FDA: 81794518722.09.8F14755 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id 8F2E6100028 for ; Thu, 15 Feb 2024 16:07:38 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sAaTsuOo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="iqKsAvd/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sAaTsuOo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="iqKsAvd/"; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708013259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L3aB1O/XufYYPRfT2DCizHtazLUMIEGEshtMYMYqQ3Y=; b=X4t+xao67LLm84ZDC54sZmlu/7So1vt+v8UY7u/5FbEpDTDlFwv5P1h87Nbe7qGtQTBypM WW+07XL2FhuPMHWA2nj4TDOHzOzW/EaHOElu4PMagCX4pBiBkIFGov08nm5j781WreautI dFZ7slwYAZFFP2nQ0hPmgiqIObHI+EM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708013259; a=rsa-sha256; cv=none; b=sVlNmArA053e3AUyMK6qz3RUm/pcEFbnV7tiEqE4OGmsguzQXBNpCZSJ/N3rWyNe/vy1mR aN2Y0hDNBfTrOu3RwVKVuAKqi6gxVxHbCICpBVy8ZiiOP9h8YaJVUrTszBRvn3ZtatLDjY qz/fgm24JuuQWx9s5xw3so4fK593URw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sAaTsuOo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="iqKsAvd/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sAaTsuOo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="iqKsAvd/"; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BC6CD1F8BD; Thu, 15 Feb 2024 16:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708013256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L3aB1O/XufYYPRfT2DCizHtazLUMIEGEshtMYMYqQ3Y=; b=sAaTsuOolJA7WH22a80PJT82B1Q2K1Bv9f6lSI8om+Ges4rttWumugW2DwUBcg/X6QaFMt GBNCkwhNQGCsH6K3ZBAGX3YywGGwtp5CT5lJWBMwqzHFe6uxd7XWgq0ANKZL8JbtOBdILD ARc8fdYscDtSvR3YZLx9RKzuPcTWBjk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708013256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L3aB1O/XufYYPRfT2DCizHtazLUMIEGEshtMYMYqQ3Y=; b=iqKsAvd/rVBbS4oTm+QGapY4qfLETqvB1Bb+E/cp2PXXY3momkbYlVRYfteePXfUmVlMeO Yqp6+YleRvmhMhCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708013256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L3aB1O/XufYYPRfT2DCizHtazLUMIEGEshtMYMYqQ3Y=; b=sAaTsuOolJA7WH22a80PJT82B1Q2K1Bv9f6lSI8om+Ges4rttWumugW2DwUBcg/X6QaFMt GBNCkwhNQGCsH6K3ZBAGX3YywGGwtp5CT5lJWBMwqzHFe6uxd7XWgq0ANKZL8JbtOBdILD ARc8fdYscDtSvR3YZLx9RKzuPcTWBjk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708013256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L3aB1O/XufYYPRfT2DCizHtazLUMIEGEshtMYMYqQ3Y=; b=iqKsAvd/rVBbS4oTm+QGapY4qfLETqvB1Bb+E/cp2PXXY3momkbYlVRYfteePXfUmVlMeO Yqp6+YleRvmhMhCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 969BC13A82; Thu, 15 Feb 2024 16:07:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QONoJMg2zmVIfwAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 16:07:36 +0000 Message-ID: <7d2b44bb-e3b0-435d-98ff-670b5029bd93@suse.cz> Date: Thu, 15 Feb 2024 17:07:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] mm/compaction: add support for >0 order folio memory compaction. To: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" References: <20240214220420.1229173-1-zi.yan@sent.com> <20240214220420.1229173-3-zi.yan@sent.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20240214220420.1229173-3-zi.yan@sent.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8F2E6100028 X-Rspam-User: X-Stat-Signature: aegmqf5qd9fiiuqpsiupcir8egeqr376 X-Rspamd-Server: rspam03 X-HE-Tag: 1708013258-860537 X-HE-Meta: U2FsdGVkX1/juCQ7JAidWo7xZxTG4XMhJepB253o6/ZyjRZEQg9rAwSxwk1zvJ2B487hndkwIATpmCr5fRNTDnvJLfZ7U2oVeMi8W2HIXEXpaKB9qeeYX1tL368yXIpXhkcGaHcggnTU4hdO5VqPv2UqOIq8rHQkJJBIG7xka5gr+U1UKBvS0IAr8YS+PPv/4qRwWgH+E/3XfMUONwibgXuAaO0hfRwLPL0BabMAVSD7xVm2VRUS5UHEumgs/6VkNGu/DMrHYR7KxHoc/gM14Fzj1HUgO98bXokxfa9oHQTyZx+1aeezkkP29yiKy3hb2zKx2ASlA3/u/cMkIwMdlp9+9w5nwmAiE/p/C7RRsoWdX5gxWmRdJ0lpVqFFDwilS6H34XGPoVO8AYAQU/6CG5QOonwtRHWdmHpPfCmilT3rzzfWK35HaaDTZndD4wVaZyCTRh7Zzr0HR9Irz1mCNaj/LTxM9v7+7Re5WReAZQvMDHOKwGo5b3kv78Sw20QbsMGMJXCaezrY2K+OzqFjZuetlrhFTI6a2oN7F8eBhm1wMNcAglHxxFmdx5hiBq/949lBUdAjsvmJQvB7sJ8UdgcGKvuvd3bskQsIcPHcDch4J18JzimHIzQVm4G3tVxii9LIx+HEgl5M+3GvBiqt/vpWLolRsWzyAcm0Ij6mu5ZRqCtb2NS1ySxAAR8pnIhmcIvuNA1sYerIBau8Xc7HKChcfntEpoAIldBN6rcW6TBRRuiXNTrd/XdfSHx7CmDVMsytG3Tgkd+EW+nM4yQQ5bfmRKmls6axhXSDHBDkQv+WzhJR6zq9UJX5Gpp9+mczhvf9KyvC4YBjlDDrfVSbnQqQlDRytrxbYvEm+vqAQMD2fA2uroceXeC1yAN03fGFG695pg9BhO8DNdE8CDa5xgQuEzqXHkH6vjKjrDpalkDVDfbDp0ew+Pl4qlJUY3jJl0MF+ef1neTwwRqzjI+ 7lUK/lXc +S6Y0D6bD1pD5LA3bGKVJhQnbfvF5CtvI5K00 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/14/24 23:04, Zi Yan wrote: > From: Zi Yan > > Before last commit, memory compaction only migrates order-0 folios and > skips >0 order folios. Last commit splits all >0 order folios during > compaction. This commit migrates >0 order folios during compaction by > keeping isolated free pages at their original size without splitting them > into order-0 pages and using them directly during migration process. > > What is different from the prior implementation: > 1. All isolated free pages are kept in a NR_PAGE_ORDERS array of page > lists, where each page list stores free pages in the same order. > 2. All free pages are not post_alloc_hook() processed nor buddy pages, > although their orders are stored in first page's private like buddy > pages. > 3. During migration, in new page allocation time (i.e., in > compaction_alloc()), free pages are then processed by post_alloc_hook(). > When migration fails and a new page is returned (i.e., in > compaction_free()), free pages are restored by reversing the > post_alloc_hook() operations using newly added > free_pages_prepare_fpi_none(). > > Step 3 is done for a latter optimization that splitting and/or merging > free pages during compaction becomes easier. > > Note: without splitting free pages, compaction can end prematurely due to > migration will return -ENOMEM even if there is free pages. This happens > when no order-0 free page exist and compaction_alloc() return NULL. > > Signed-off-by: Zi Yan > Reviewed-by: Baolin Wang > Tested-by: Baolin Wang > Tested-by: Yu Zhao Reviewed-by: Vlastimil Babka Noticed a possible simplification: > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -447,6 +447,8 @@ extern void prep_compound_page(struct page *page, unsigned int order); > > extern void post_alloc_hook(struct page *page, unsigned int order, > gfp_t gfp_flags); > +extern bool free_pages_prepare_fpi_none(struct page *page, unsigned int order); > + > extern int user_min_free_kbytes; > > extern void free_unref_page(struct page *page, unsigned int order); > @@ -481,7 +483,7 @@ int split_free_page(struct page *free_page, > * completes when free_pfn <= migrate_pfn > */ > struct compact_control { > - struct list_head freepages; /* List of free pages to migrate to */ > + struct list_head freepages[NR_PAGE_ORDERS]; /* List of free pages to migrate to */ > struct list_head migratepages; /* List of pages being migrated */ > unsigned int nr_freepages; /* Number of isolated free pages */ > unsigned int nr_migratepages; /* Number of pages to migrate */ > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 7ae4b74c9e5c..e6e2ac722a82 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1179,6 +1179,12 @@ static __always_inline bool free_pages_prepare(struct page *page, > return true; > } > > +__always_inline bool free_pages_prepare_fpi_none(struct page *page, > + unsigned int order) > +{ > + return free_pages_prepare(page, order, FPI_NONE); Seems like free_pages_prepare() currently only passes fpi_flags to should_skip_kasan_poison() and that ignores them. You could remove the parameter from both and declare and use free_pages_prepare(page, order) directly. > +} > + > /* > * Frees a number of pages from the PCP lists > * Assumes all pages on list are in same zone.