From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7835EC433EF for ; Fri, 25 Mar 2022 20:20:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5C086B0071; Fri, 25 Mar 2022 16:19:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0C256B0073; Fri, 25 Mar 2022 16:19:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C850B6B0074; Fri, 25 Mar 2022 16:19:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id B4D806B0071 for ; Fri, 25 Mar 2022 16:19:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 563721828AE43 for ; Fri, 25 Mar 2022 20:19:59 +0000 (UTC) X-FDA: 79284024918.23.BF3D859 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 34BAEC0038 for ; Fri, 25 Mar 2022 20:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648239597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BaVEjwXsaEy7cL7JZ+Za+DImYZdSvwVcJnKXWnRGcmo=; b=b4SQEd2+Qrca/w17Qn/c/n13Zd4w2tEb03cNEXCQRKnbIfS4EHpmNzyMjMeCbv20pFCCIj gjCzzwMaf77c/G2RjRgaQdK/kFCfRw9QhS1Ytx9/K828L6H5KmOdzkNrGv5aAcnS7VkEaE xZyv2wyjR3Y20rl6SYi3E+/Lqex2Y3g= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-671-uVRmZT0QM0a87ry3UutwnQ-1; Fri, 25 Mar 2022 16:19:54 -0400 X-MC-Unique: uVRmZT0QM0a87ry3UutwnQ-1 Received: by mail-wm1-f71.google.com with SMTP id c126-20020a1c3584000000b00380dee8a62cso2993372wma.8 for ; Fri, 25 Mar 2022 13:19:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=BaVEjwXsaEy7cL7JZ+Za+DImYZdSvwVcJnKXWnRGcmo=; b=3w1muQD/TXU87GjN7wc5U7CPRK7TXAxRLugWK3qfD5TOabDKXcZjaAKOj02x8po2T3 t73Pksl0JhDzrmg3NvdItXHD75z6rFQte9qq7S03HKfRNMLFZ4CNyYqThhUGGjhuPGBi AzWlGXWbhuL4DnQLAk2lrh26lnzWsLOx39xF0c2MQEGtWuJrG4Bye1bJ2NbxasuFXfrf VMfNRvon5aYdjAut80PVf4/iTG7mHpblTUYBBKjgOfv6nlZTyX8ij6JMAxeoQmUbq43U p2CavGobQ9ekra2V2BYX/0XcX9kle6IRRVj/+9k+z2+XniRu/h+Rl6z79p7wlT4nJNsa yUdw== X-Gm-Message-State: AOAM530thcMl+ckWiF7tEx8fNHVb15/1IBZotSpxZfxF86O3Pn8EaQmr e8I0No31JWVm2iUxWOCIyQr3wpexDiqUZi5OKzUueyxFnF+p/L71zBu2Is54uZbVcoiJBW0Zaqp HJfnRWxO0WIc= X-Received: by 2002:a5d:588b:0:b0:204:1c1a:965d with SMTP id n11-20020a5d588b000000b002041c1a965dmr10653934wrf.669.1648239593311; Fri, 25 Mar 2022 13:19:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyklR57T5x3dRn1ErKGUmoiztN0RoMK7oC4+/r9nKYD6tFd8xCH69JAOhXQJEPU1GHkeTEKQ== X-Received: by 2002:a5d:588b:0:b0:204:1c1a:965d with SMTP id n11-20020a5d588b000000b002041c1a965dmr10653911wrf.669.1648239593051; Fri, 25 Mar 2022 13:19:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:4200:6374:a71a:a88:a4b? (p200300cbc70542006374a71a0a880a4b.dip0.t-ipconnect.de. [2003:cb:c705:4200:6374:a71a:a88:a4b]) by smtp.gmail.com with ESMTPSA id k40-20020a05600c1ca800b0038c6c8b7fa8sm9619012wms.25.2022.03.25.13.19.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Mar 2022 13:19:52 -0700 (PDT) Message-ID: <7f3a973f-1f0c-4e50-2528-b0e9dc3e4cac@redhat.com> Date: Fri, 25 Mar 2022 21:19:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v3] mm/vmstat: add events for ksm cow To: Andrew Morton , cgel.zte@gmail.com Cc: yang.yang29@zte.com.cn, ran.xiaokai@zte.com.cn, yang.shi@linux.alibaba.com, dave.hansen@linux.intel.com, minchan@kernel.org, saravanand@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xu xin References: <20220324104332.2350482-1-yang.yang29@zte.com.cn> <20220325130957.171a68dee88118082ab841c5@linux-foundation.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220325130957.171a68dee88118082ab841c5@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ox1dipsjmibokguoph1nddgeuacdwrw5 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b4SQEd2+; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf28.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 34BAEC0038 X-HE-Tag: 1648239598-895319 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.03.22 21:09, Andrew Morton wrote: > On Thu, 24 Mar 2022 10:43:33 +0000 cgel.zte@gmail.com wrote: > >> From: Yang Yang >> >> Users may use ksm by calling madvise(, , MADV_MERGEABLE) when they want >> to save memory, it's a tradeoff by suffering delay on ksm cow. Users can >> get to know how much memory ksm saved by reading >> /sys/kernel/mm/ksm/pages_sharing, but they don't know what's the costs >> of ksm cow, and this is important of some delay sensitive tasks. >> >> So add ksm cow events to help users evaluate whether or how to use ksm. > > It's unclear (to me) how anyone will actually use this, how they will > interpret the output. > > Some tutorial words added to Documentation/vm/ksm.rst would be helpful. > While in there, please check for any other /proc/vmstat fields which > we forgot to document. > >> --- a/include/linux/vm_event_item.h >> +++ b/include/linux/vm_event_item.h >> @@ -131,6 +131,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, >> SWAP_RA_HIT, >> #ifdef CONFIG_KSM >> KSM_SWPIN_COPY, >> + COW_KSM, > > I agree that this name looks unpleasingly backwards. Do we have an > expectation that we actually will be adding more COW_* fields? As raised previously (also when proposing this), I'd like to have COW_ANON, COW_ZERO, COW_OTHER. Ideally, we'd have added all via a single patch for them. They would at least be of value to me. -- Thanks, David / dhildenb