From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE3EC52D71 for ; Tue, 6 Aug 2024 16:54:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 394236B008C; Tue, 6 Aug 2024 12:54:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 344BC6B0092; Tue, 6 Aug 2024 12:54:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20BB86B0093; Tue, 6 Aug 2024 12:54:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 032866B008C for ; Tue, 6 Aug 2024 12:54:20 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AFFDDC0396 for ; Tue, 6 Aug 2024 16:54:20 +0000 (UTC) X-FDA: 82422418680.09.9BE862B Received: from mail-40133.protonmail.ch (mail-40133.protonmail.ch [185.70.40.133]) by imf28.hostedemail.com (Postfix) with ESMTP id DF5DFC0020 for ; Tue, 6 Aug 2024 16:54:18 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=PRxwg9+P; spf=pass (imf28.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.133 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722963196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JyaLofqIf3cc8LFmc/BZCxfEIWaUzKwUqRl9VTHoZS0=; b=CTsLAhBCdlKjNCtSc8Ei9E7ENj7gKg6OWT4vLAh7lMR1ibO8LGDnwt1fy3FhD4cjU8vl56 M4/sq6HwDJr2Tg4HN7EYrCpb/qZLw/kqIW1/7lESZ2UBQjbA188pRh9dr6NDOqaOz5tLl2 7lcTvl61cpr5CuZn8XdtJnlp/sHaBK4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722963196; a=rsa-sha256; cv=none; b=7AWcdxhXc6C6LMXrtJjhZGbsqiVBKJpRj/tfF+Nu0TCOOBNFZjFm9DC+Y+Z9PQFYmL8XaH kWavy3gJ836ejzri+vn4tdFOE/aZYKVXEuVaUrE8jTBDEyWGMIcOiPu9ecag1ArrYuv4OZ XOZ0573g8Ck886TTwVVZjjNrekbV3w0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=PRxwg9+P; spf=pass (imf28.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.133 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1722963256; x=1723222456; bh=JyaLofqIf3cc8LFmc/BZCxfEIWaUzKwUqRl9VTHoZS0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=PRxwg9+PqydYPaCBNDPXBzrb10m+Ioy4IB01yG48JRYf6yMf9fVB9vrLwIyOiBXLy tFLWjU8n3LiDeVkltb/54eOGF7gTJVMtsLM8T8Z1M6hOQPTaCHJ78dFZgFJMybXnMt l+P4V9MfgZRVFlxrt3GHc8bvVkhQJbobcS/e7Go3bHPMOXv8PxIA0XZ0Q48EJu+usa WR9x16UA9n01pbX4uXunSwitaOLTJO+MhGJpJQi2UbEoLvdT6Q6Ou5lIsIBQiy5vPh r0aNPN4BHiAhT95e/lvGylyhfgsMJ+ORdJmUcl8W3TdDGbaAU49XiMzc8zTfmc2Eog aoTU/vnNuGAcQ== Date: Tue, 06 Aug 2024 16:54:10 +0000 To: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org From: Benno Lossin Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, acurrid@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 05/28] rust: alloc: add module `allocator_test` Message-ID: <7f4b91e6-aae8-4e17-9fcd-4b1d0b2de9a0@proton.me> In-Reply-To: <20240805152004.5039-6-dakr@kernel.org> References: <20240805152004.5039-1-dakr@kernel.org> <20240805152004.5039-6-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 2ee00e2816ba67eeed385eac8e0a32473e2a9116 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: fojdhpg38ig393itpxec874cdf5od15f X-Rspamd-Queue-Id: DF5DFC0020 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722963258-80969 X-HE-Meta: U2FsdGVkX18W04zbTQcKmjMZmmV30zf9tUpn5MErFSzAySEk2hS2dCUfZkdpPUhMe+ucNnH7+jI+F1wExr+/M47Hzs/pYN57h2WwRcBuYe99cFcyYSuSvc+Ponbz8x0369qPRXvDYr6MPrI33oBMrmi0mojCSzjpqrFSmNNDnBbNn0cNwFExwxGrEJlB1dY32eAfPa3EZe870iMyR6BxvosX9CI8rBdS9YHKbEamaJ6tsydz194G/YX7xQ0OHMkUVJcT14wBrwUK342JtVyoU4JIJi5KBJzNWs4FhqhwVFzDe/s32pqdqgW3DBUeFukd+I+OPKSO9Bbc+D0enGZ4cr9KgyVNoNtgwamAi/S7UdfJgiYvhrHr7lbjU4Ay/WlpalBo1IGzx2ORZtWYUII0MxyrZfA1fs5F4LKTHg4EP3FTHxsYoZuboTmZezrSF7275jaBzx+cLD6smaGfRg23ZH86+cibak1aMb/MGRCFMnFfQgZsKy9bLG9vzLnhReJmww1dVlTc63bLt7IJ9N4qAmwWE3+hdkz2dgWorZOmCCf+4DsjE9geL6JxkS208oLkeQ7c80NMen2YpgRd1/cBzHY5prKAFZADJWYV11rBsCC6J3+GRFSynRl1KAFLfKXPEG0gSXZORp8ugx5rqIRC/TsYNq8XMUG7OJtzZ770pyTSnfXL9iSTbVb0UKaqYFIJhMHEoTSXkxTuo934/tragzeW2nLub2W4TB+EyDlfaV0zq1PTFCCBC7VKYY/iJI9zCxd9krzlOWMIHJQDCHHVl3CY0mXfAttjnAdE+yTY3Lz3FaHQgE4KHciVOYuNLGFXudTkT4tcBRlLyCJGxVaXfzjwp60lRkWOq9b24Yw0yVESVV72Q4ImJbSHbVLm3CvahCYWbp5mv9QWxjAEvQOqU2MX2tb+W36GPT3IdiyFqVCpFoApnMvEIuZAglOJoTJGRZSO4HmNQQVXMN1TF6I 3K3z9dnV 6OQDw64/cNGmdj9DPCUFp5gdId1Nss9Jfu6h7vJ4Xv4tOpLxG3cOK07Htsx03KBQszQNctqCuX9rzcpB+fZX47jC7THILB0WyP4cCV5DcjBmyClFwWyD8X5m1NJX7Al8pGfvBQE81KB3sBZ0n2BCYhoCFRiyHlc2h9opv5IlJul1+TOF56ddqm7yU9/pMNYJp6/zJWj0Q6KoMaaE1rLOcOzU3UejojPcfzh1kXfFhBDxvChOPa3RzJR/SnLVkA3gl5iyz3vitVcCCqJKtPUPf/1tO6DFJmvi0sAyx47s47lKuMI+WVQRV+To73lOl7cMdObjB3ds6csH2Ve9EhX3ZESm7Xo+iZCMbrpw5so9aaL+8/+Dk/inyfGPpiLlWy4iMUb24iNjp7qbTzmSoJ3YyFrw9JXUJSpFI+lEsbcvGjPd1WA140y9BszobmbNby4ivK93Q/VYjyErRcJwvwQ+gHClFh3qY9dvwCmNTbQgTmlS5ZmY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000176, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.08.24 17:19, Danilo Krummrich wrote: > `Allocator`s, such as `Kmalloc`, will be used by e.g. `Box` and `Vec` in > subsequent patches, and hence this dependency propagates throughout the > whole kernel. >=20 > Add the `allocator_test` module that provides an empty implementation > for all `Allocator`s in the kernel, such that we don't break the > `rusttest` make target in subsequent patches. This is confusing, since you are talking about both our new `Allocator` trait, allocators and the `alloc` crate `Allocator`. > Reviewed-by: Alice Ryhl > Signed-off-by: Danilo Krummrich > --- > rust/kernel/alloc.rs | 9 +++++++-- > rust/kernel/alloc/allocator_test.rs | 19 +++++++++++++++++++ > 2 files changed, 26 insertions(+), 2 deletions(-) > create mode 100644 rust/kernel/alloc/allocator_test.rs >=20 > diff --git a/rust/kernel/alloc.rs b/rust/kernel/alloc.rs > index bc01a17df5e0..942e2755f217 100644 > --- a/rust/kernel/alloc.rs > +++ b/rust/kernel/alloc.rs > @@ -2,12 +2,17 @@ >=20 > //! Extensions to the [`alloc`] crate. >=20 > -#[cfg(not(test))] > -#[cfg(not(testlib))] > +#[cfg(not(any(test, testlib)))] > pub mod allocator; > pub mod box_ext; > pub mod vec_ext; >=20 > +#[cfg(any(test, testlib))] > +pub mod allocator_test; > + > +#[cfg(any(test, testlib))] > +pub use self::allocator_test as allocator; > + > /// Indicates an allocation error. > #[derive(Copy, Clone, PartialEq, Eq, Debug)] > pub struct AllocError; > diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allo= cator_test.rs > new file mode 100644 > index 000000000000..4785efc474a7 > --- /dev/null > +++ b/rust/kernel/alloc/allocator_test.rs > @@ -0,0 +1,19 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#![allow(missing_docs)] > + > +use super::{AllocError, Allocator, Flags}; > +use core::alloc::Layout; > +use core::ptr::NonNull; > + > +pub struct Kmalloc; > + > +unsafe impl Allocator for Kmalloc { > + unsafe fn realloc( > + _ptr: Option>, > + _layout: Layout, > + _flags: Flags, > + ) -> Result, AllocError> { > + panic!(); Does `build_error!()` also work? If yes, then I would prefer that. --- Cheers, Benno > + } > +} > -- > 2.45.2 >=20