From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36185C8303C for ; Thu, 3 Jul 2025 02:44:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8D5F6B00E6; Wed, 2 Jul 2025 22:44:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C655A6B00E8; Wed, 2 Jul 2025 22:44:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7C4E6B00EB; Wed, 2 Jul 2025 22:44:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A644C6B00E6 for ; Wed, 2 Jul 2025 22:44:25 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 49E181244FA for ; Thu, 3 Jul 2025 02:44:25 +0000 (UTC) X-FDA: 83621409690.18.D0F4813 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf08.hostedemail.com (Postfix) with ESMTP id 4A1B1160009 for ; Thu, 3 Jul 2025 02:44:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bfD+7ccX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of jiahao.kernel@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=jiahao.kernel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751510663; a=rsa-sha256; cv=none; b=sZPDSkxL2moa4TdgN5HzDNZpZ2EF90G6wflykf7BLagrALtvitLReB9dlH7J0Cx4To/c9e AsRzH+8cHrN11OgT4/t9c8D1A9RkVDNthD/sXh3+Ef4+VJTGjH9f0q8DpDVPpFOLdOkq4A N9AKXYYPUKeU/a/m+RP9AZkYw9/nmUc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bfD+7ccX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of jiahao.kernel@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=jiahao.kernel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751510663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MvJyRoQEN6Ftk0YCKQRhf1ab+R7+Q09BKNu92aBVMR8=; b=YK+9MvYNWPSTMPZU0lULh1XDkCim1U8ciH4GXXH5kPa8Xvc0GUC/LNTh7kMmIr2NpsrHK2 t+yxIXmQnCzLHSquuxMhcO6vQeWj0LnFFfQQRx4dPamLJz1Cz2vVpaXO4Hz5yCv/7FjHoH gOL2l9v/qGTIss0dJbVC5+Ig334OrbA= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7426c44e014so7527145b3a.3 for ; Wed, 02 Jul 2025 19:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751510662; x=1752115462; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=MvJyRoQEN6Ftk0YCKQRhf1ab+R7+Q09BKNu92aBVMR8=; b=bfD+7ccX1mW3AFeQa6O8vNRXSrJs4cwBb8r+83ObxR4ZDQNA5Ghz+wSKXjTUp4kdhp 6PMr3qiUIlhTd4zeEMIa+/fFDDz3OLuh1PVMKTSO2yGwB7vqakH0REMBoKmWlAT0j7Cb 7CygJfbfWb0Zsotu2Nd7qM9nsSs9F4KNhtHsZ2Ou3uRDOCmSe/s0PqkKxIiyCqYZFsYo ZlE9s0tf9W0Bta2TQ54+DSod1vt6ZVFT2koL6DTKovFfrYFtabPK82Fy56VY+ID8yoQv oYIMjrO8r9FqsHWQX30JH9qb5t4chE0mw6t5nckieafOHte4WBGl0YdLiF+0d3F7+VWP oy7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751510662; x=1752115462; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MvJyRoQEN6Ftk0YCKQRhf1ab+R7+Q09BKNu92aBVMR8=; b=DtYWXr4kAJScvb04TrMQ86muV4FoS03LCIV26+r8W7HP/WsLJciZZYlKID4yQVyafd FGOZa3m3f0LcJzzFnljkG7wnqUBrzbWYMDbMXfB5ksV5yUw53Vn5BocpX2Xz3N+LFhlR ETYHeli4AjmizP+I3mrrkEh3K/gUF3ilsSRQ19fOWcezEw8HNDuisjbLl8fP4xr4lllu o1AuTV/zm7VBCAtjsrmFhyVNzsiiRcfnFEzb26r715ATPNQPyB76z3o/QpVN1x2r5rjN tVrU5adJo0GdaC/YfZQcDF24xpG1X+/Mul95+brEAq3FUH3/8EIULs8aCq8hjtrpMB8y 81aw== X-Forwarded-Encrypted: i=1; AJvYcCWkyARkpjJi2+3fROw1ermmbbn2eoRra9Cl5hF/uNh90TOJkWqxSOEbGVosVG/huBRJi4uIULH7aA==@kvack.org X-Gm-Message-State: AOJu0YyOMmPn6iLYeKFmaIfCfuyqz5L3HYsqahrpiLsZr0EksJ/nincJ XWWxK154aCyb2ue/LIBm5NaAKN/Ah9uoT/jpVbdKDOvwjbyyi5Gc0RCZ X-Gm-Gg: ASbGncvbWDsalz8l4wlK6N0cFViDgmmJUTHEGz+Ak8dTLBKr7QmS3cs0b4uH2mRbwAF P1Dke4JxCONavl5p2/Oo3e+nteOjthC6fEfg9k3+W/OTwmo/kwgP5L85/dBb9FHjHt27moMbjzL lZsCtfm3slR4H2pA2Le859T6V1VJPBEw1Dt/9wU7WuANK2IiXzAae6T6OApaPGGyERhdb+h38F4 5i7VOn2GMs8ewRqBYuBvAzbAHtLt7HHBao1C3WGnlQHKw6a30cDO6snoFmQ3rv2KCkfPaY1ZBDj bNiqyBmiGfAjH5XVVlND0Y7zdnJkCro7ppj/1MzXL4e7l4VxX9MGb1FQ49MBh6gQEX0W/IGUw+K GyWRe1yg= X-Google-Smtp-Source: AGHT+IFAcHjCAzuSHfjfMenx11NpIMUngIbtzf7Gscr7OriDsIk8QJUe1x5yNHBF++2MKAybKM5K9Q== X-Received: by 2002:a05:6a21:490:b0:215:de5f:febc with SMTP id adf61e73a8af0-2243e5b2ef2mr1862892637.27.1751510662077; Wed, 02 Jul 2025 19:44:22 -0700 (PDT) Received: from [10.125.192.71] ([210.184.73.204]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74af56cd84csm16154263b3a.132.2025.07.02.19.44.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 19:44:21 -0700 (PDT) Message-ID: <7f747869-dc37-64f3-127a-0b61a9d069dc@gmail.com> Date: Thu, 3 Jul 2025 10:44:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] mm/mglru: Stop try_to_inc_min_seq() if the oldest generation LRU lists are not empty To: Yuanchu Xie Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, yuzhao@google.com, kinseyho@google.com, david@redhat.com, mhocko@kernel.org, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hao Jia References: <20250630080603.36171-1-jiahao.kernel@gmail.com> From: Hao Jia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4A1B1160009 X-Stat-Signature: o6j46iyd14pi7en7u9fhe1ro7mw9usxw X-HE-Tag: 1751510663-604357 X-HE-Meta: U2FsdGVkX1/6q4fp+0Zx21f2Jkgz4EWI7UfjA2o+IbGlkm8WAU9vRY40A7x5cEggnkYvVFn0+wGXe2tV0iYMsMc/B2SDABhEbkZfQgotC1nDLuiHvya22278VnLmBUG3TUOeKIp+u8FF9uspkZPaqh7MGUcW/V/Y2QSHKClna2R0+g3v+RhVpTi0Hc9t52er6ugfVcO2PIS+iI6a/d6dSt5/cDvxG3ejKNsowqgSjvBv4mO1NnZdOHY95m0S38TYm5KIukHEWDcjdGfuHQcIqnXscFr4Of6vv7+5v1K1FJT6Nodz07INgNfdgKUPXOzb7hTlOPT7/rEjFW6KlGRjeENCYPpAd87XmX2Jts3WVHSxeKreo4g/q/BTCDpKmwTEY1fSPD6U7Kw7oqbmyxsnU0vGWsOtr8oUoHOx659JuRcdscpRWohGDwuTZW4NJIsbE48vZxWPqtxHUfZQY2JPXR7QcrDvSdrHlywv5vptoYG7go22gezd1E7YswIW3Jal+hHKHRPeug6KkN5JbKVl/1BxZxrTzF/ZabRl7KwfeTuL6pHPzpnbS7lMoRPv0T+45cZ4fXAnDgD6oSKME1knJYLBs1x2UMpOBOA2SOdYueE8y6N26mvVpKHw+7K3t8GCbvDvfQovuQQbJxNQ8e620yC1XeQYAzmWF2hBLr4fd6H2g/D/VwvpcSbbrX1pkWAzEuK20W/LFENnaoVC0CIhsSLpdXwI4qgHRrK0MfBaMoaO6qNQmz7U5CEjoa4Zo55sW9XJU8QXM5bwV2hHbPtKVthUZYfq6LPAB9tXqesjL7PFVJEIWfUPJkHOO7JpTMxy3S7Ey3XKMaUDVDewvzTADReT4yESNg1ukxSNYE/AaYptUtd4bSp39/wvYC4KjrIeeJI+1qmU2gFX5CfMNs0sU8RtlAJ3zRZmbTmd+Ky94gaRAweAVW+/p6MqUgzyaJp7bAukqOd1VCnszIRTCWj 0i25s5Xe MmXoXf60TWodjlrNMI5VNGJ8UTNzX0572XwGZVqPmwUBnMhzy3DhOWIzHEkXTd/svEN6TwkUPy0gEZEswtdkRvCYOWiOd2e0B9O7tVEzRCTHDox3Nfi8W0ru+xsri6aIzi8E2JOveoF21mccsslUdqEpZTTznaBPZq+9VmtVK1C68cEdtdJGe9D5DyJem0GMWjYh99edymDLQEjgMAXSqqxccwoBfLFomHtHXw1RIhJhOAwq+BtDNuc7dqwrTgZq5Xy0+elSGS2cAgazn0VYkNsT7uXCo6Vo5sgevKlj0eu4eEp5uvFymcq/VkeqhGIiJ+CgDSq//E0u4HCNJ+eyvIVNSrfMFMMwhJf8CYmnEfx2rzvVoz4F+nCZK70Db831kbZerxhW+p2QafiGx2pEfCpdrVvpog0FzLg/DTAreSo4vyeh/Q2sFOrnUTSwOb93c3YvvxN33dq7Yk5zotHq3W/NIJhSnNhSIeHtgDbqMFWdOUNW9OtmZKKEJsnzYE4DHug7UTj/kBnHXAC+V5j1hDrmRU65w4Lt/nMTDpIjhUWLKY9A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/7/3 03:22, Yuanchu Xie wrote: > On Tue, Jul 1, 2025 at 10:45 PM Hao Jia wrote: >> >> Perhaps another way to explain it is clearer. >> >> It is known that min_seq[type] has not increased, that is, min_seq[type] >> is equal to lrugen->min_seq[type], then the following: >> >> case 1: min_seq[type] has not been reassigned and changed before >> judgment min_seq[type] <= lrugen->min_seq[type]. >> >> Then the subsequent min_seq[type] <= lrugen->min_seq[type] judgment will >> always be true. >> >> >> case 2: min_seq[type] is reassigned to seq, before judgment >> min_seq[type] <= lrugen->min_seq[type]. >> >> Then at least the condition of min_seq[type] > seq must be met before >> min_seq[type] will be reassigned to seq. >> That is to say, before the reassignment, lrugen->min_seq[type] > seq is >> met, and then min_seq[type] = seq. >> >> Then the following min_seq[type]（seq） <= lrugen->min_seq[type] judgment >> is always true. > > This sounds good to me. Can you change the code to use one bool to > detect any increments in `min_seq[type]`? You don't need `int > seq_inc_flags[ANON_AND_FILE] = {0};` > > Also update the commit message with what you have here. IMO much more clear. > Thanks for your review, I have done it in patch v2. Link to v2: https://lore.kernel.org/all/20250703023946.65315-1-jiahao.kernel@gmail.com/ Thanks, Hao